Re: [QGIS-Developer] Preview job and slow datasources

2017-11-15 Thread Patrick Dunford
In my current project using Qgis 2.99, turning off the rasters uses 16 GB, turning them on uses 52 GB I do not believe it is independent from the number of layers that are being displayed. Previous versions of the software did not cache every single raster (the number of rasters actually

Re: [QGIS-Developer] Preview job and slow datasources

2017-11-15 Thread Matthias Kuhn
Hi Patrick, This uses some memory (~ canvas width pixels * canvas height pixels * 8 preview images * 32 bit RGBA), so let's assume 50 MB to 100 MB. This consumption is independent from the number or type of layers. Matthias On 11/16/2017 08:02 AM, Patrick Dunford wrote: > > So to put it

Re: [QGIS-Developer] Preview job and slow datasources

2017-11-15 Thread Patrick Dunford
So to put it another way this is the reason why Qgis wants to use a huge amount of memory (40 GB) when I have a lot of raster images loaded in the background. On 16/11/17 18:56, Tim Sutton wrote: Hi On 16 Nov 2017, at 04:35, Patrick Dunford

Re: [QGIS-Developer] On the danger of static C++ objects

2017-11-15 Thread Tim Sutton
Hi Even > On 16 Nov 2017, at 00:58, Even Rouault wrote: > > Hi, > > There was a frequent crash in PyQgsServerWMS on Travis that I've hopefully > fixed per > https://github.com/qgis/QGIS/commit/581d0d30ca89a213b1ba1a56a3fe2af5c896eacd >

Re: [QGIS-Developer] Preview job and slow datasources

2017-11-15 Thread Tim Sutton
Hi > On 16 Nov 2017, at 04:35, Patrick Dunford wrote: > > What is this "preview job" function? > > Its application logic to prefetch / pre-render offscreen content in anticipation of user panning the map. Regards Tim > >

Re: [QGIS-Developer] Preview job and slow datasources

2017-11-15 Thread Patrick Dunford
What is this "preview job" function? On 16/11/17 03:56, Even Rouault wrote: Hi, I'm working currently on improving raster performance per https://github.com/qgis/QGIS/pull/5632 , and while testing with a variety of GDAL datasources, I found that the "preview job" (*) mechanism that is

[QGIS-Developer] On the danger of static C++ objects

2017-11-15 Thread Even Rouault
Hi, There was a frequent crash in PyQgsServerWMS on Travis that I've hopefully fixed per https://github.com/qgis/QGIS/commit/581d0d30ca89a213b1ba1a56a3fe2af5c896eacd This is the opportunity to raise attention on the danger of using this pattern: static SomeClass singletonInstance; where

Re: [QGIS-Developer] Preview job and slow datasources

2017-11-15 Thread Nyall Dawson
On 16 November 2017 at 00:56, Even Rouault wrote: > Wouldn't it make sense to offer an option to disable preview jobs on the > main canvas for such use case ? I agree with Matthias here, in that we want to avoid adding a user-configurable option for this. Either we

Re: [QGIS-Developer] Preview job and slow datasources

2017-11-15 Thread Nyall Dawson
On 16 November 2017 at 04:58, Richard Duivenvoorde wrote: > > Is it possible that these preview-jobs are responsible for the WMTS > crashes which are reported in master (and I have myself pretty often)? > Not responsible for them, but they may make an existing issue more

Re: [QGIS-Developer] Preview job and slow datasources

2017-11-15 Thread Even Rouault
> Is it possible that these preview-jobs are responsible for the WMTS > crashes which are reported in master (and I have myself pretty often)? > > https://issues.qgis.org/issues/16966#change-84394 > > At least for WMST I would find retrieving 8 times the number of > images/requests too much? I

Re: [QGIS-Developer] Preview job and slow datasources

2017-11-15 Thread Richard Duivenvoorde
On 15-11-17 17:11, Matthias Kuhn wrote: > Other factors that could be considered are things like how long it takes > to cancel an ongoing rendering job or how many free connections we have > in the pool. > E.g. in the case of a WMST, the time to build the image might be high > (as long as it's

[QGIS-Developer] Is the map preview in CRS selector dialog broken?

2017-11-15 Thread DelazJ
Hi devs, In QGIS 3, in the CRS Selector dialog of a layer (or global setting), there's a map preview (thanks Nathan) [0]. Whatever CRS I select, in the first or the second table of CRSs, the map preview always shows the whole world with a cross at the "center"[1]. I'm on windows 10. I'd expect it

Re: [QGIS-Developer] Preview job and slow datasources

2017-11-15 Thread Matthias Kuhn
On 11/15/2017 04:55 PM, Even Rouault wrote: > On mercredi 15 novembre 2017 16:18:29 CET Matthias Kuhn wrote: > > > So if the provider of one layer returns false in renderInPreview() that > would disable the rendering of those layers in the preview images ? Disabling only certain layers

Re: [QGIS-Developer] Preview job and slow datasources

2017-11-15 Thread Even Rouault
On mercredi 15 novembre 2017 16:18:29 CET Matthias Kuhn wrote: > Hi Even, > > we have shortly discussed this topic in the past and the general > consensus was, not to offer such an option (which is easy to forget and > hard to set right without deep knowledge). > > Should we consider a `virtual

Re: [QGIS-Developer] Preview job and slow datasources

2017-11-15 Thread Matthias Kuhn
Hi Even, we have shortly discussed this topic in the past and the general consensus was, not to offer such an option (which is easy to forget and hard to set right without deep knowledge). Should we consider a `virtual QgsDataProvider::renderInPreview()` method, that can be finetuned by each

[QGIS-Developer] Preview job and slow datasources

2017-11-15 Thread Even Rouault
Hi, I'm working currently on improving raster performance per https://github.com/qgis/QGIS/pull/5632 , and while testing with a variety of GDAL datasources, I found that the "preview job" (*) mechanism that is currently enabled on the main canvas (pre-rendering the 8 zones around the canvas

Re: [QGIS-Developer] Minimum SpatiaLite version 4.2

2017-11-15 Thread Mark Johnson
For compiling, that should be no problem. Since 4.3 has been out for 2 years and contains many new features, I would even say 4.3. But for the reading of Databases from older versions and running with older versions is problematic. The present QgsSpatiaLiteProvider does not deal with this well,

Re: [QGIS-Developer] Processing Split with lines algorithm broken

2017-11-15 Thread G. Allegri
I also agree to step back to single-part output. giovanni 2017-11-15 11:13 GMT+01:00 Alexandre Neto : > +1 > > Nathan Woodrow escreveu no dia quarta, 15/11/2017 > às 05:10: > >> IMO go with the principle of least astonishment. I think the expected

Re: [QGIS-Developer] Processing Split with lines algorithm broken

2017-11-15 Thread Alexandre Neto
+1 Nathan Woodrow escreveu no dia quarta, 15/11/2017 às 05:10: > IMO go with the principle of least astonishment. I think the expected > outcome is single part features as it's not clear that you need to run > another step. > > - Nathan > > On Wed, Nov 15, 2017 at 2:48 PM,

Re: [QGIS-Developer] Merging raster-save dialog change and Windows workflow

2017-11-15 Thread Jürgen E . Fischer
Hi, On Wed, 15. Nov 2017 at 01:02:48 +, Tisham Dhar wrote: > 1) Checkout as standard on windows with git-bash (line endings are an > issue). Will have to try a fresh clone in WLS to see what difference > it makes Why not cygwin? That's what I use and recommend. WLS

[QGIS-Developer] Minimum SpatiaLite version 4.2

2017-11-15 Thread Matthias Kuhn
Hi devs, I just proposed an upgrade to SpatiaLite>=4.2 requirement on QGIS 3 (https://github.com/qgis/QGIS/pull/5636) Is there anyone requiring support for older versions? If yes, we can also keep compatibility with 4.0/4.1 and just drop code for <4.0 (I guess that's really outdated nowadays)

Re: [QGIS-Developer] Processing Split with lines algorithm broken

2017-11-15 Thread matteo
Hi Nyall, > I suspect it's working OK, but you're hitting a change in 3.0 where > the output of this algorithm is a multi-line, with the individual > split parts still forming a single feature. You need to run multiparts > to singleparts on it afterward. uh... sorry I missed that the multipart