Re: [QGIS-Developer] PSA: Travis CI / Docker / Failing Tests

2017-10-02 Thread Even Rouault
On lundi 2 octobre 2017 15:56:00 CEST Matthias Kuhn wrote:
> Dear all,
> 
> we have recently been working on bringing travis ci to the next level
> and moving all the testing that is done into a docker image.
> 
> This has the advantage that
> 
> - we can use newer dependencies for testing (currently Ubuntu 16.04
>   repos compared to 14.04 repos before)
> 
> - tests can be run locally the same way that they are run in CI (to
>   debug)
> 
> - we can upload docker images (nightlies and released versions) that can
>   be used for plugin testing (only partially implemented so far)
> 
> 
> During this process, some issues have been discovered, mostly concerning
> compatibility with newer gdal versions and most of them fixed (kudos to
> Even for his reactive and valuable help with this).
> 
> At the moment, we are left with 3 tests that are still failing:
> 
> - qgis_rastersublayertest
> - PyQgsShapefileProvider
> - PyQgsWFSProvider
> 
> The reasons that these tests fail are either because the tests
> themselves are unstable and rely on very particular behavior of the
> environment or because they actually point out real issues related to
> newer dependencies.
> 
> It would be very welcome if the original authors of these tests or the
> underlying functionality could have a look and either
> 
> - fix the tests
> - fix the underlying issues that caused the tests to fail
> - or disable the tests if they are no longer meaningful.
> 
> A patch has been prepared that disables parts of the tests that trigger
> the failures which can be used as reference to find where things go wrong:
> 
> https://github.com/qgis/QGIS/pull/5256/commits/988aa78feded78634d8600c7baeb7
> 01558b23546
> 
> If there are no fixes in sight, this patch will be merged as part of PR
> 5256.

The PyQgsWFSProvider was added by me, but I won't have time to look at that in 
the next 
days, so go ahead.

Even

-- 
Spatialys - Geospatial professional services
http://www.spatialys.com
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] PSA: Travis CI / Docker / Failing Tests

2017-10-02 Thread Sandro Santilli
On Mon, Oct 02, 2017 at 05:23:14PM +0200, Sandro Santilli wrote:

> I think I might be the author of qgis_rastersublayertest but could

For the record: I was not (phew!)

--strk;
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] PSA: Travis CI / Docker / Failing Tests

2017-10-02 Thread Sandro Santilli
On Mon, Oct 02, 2017 at 03:56:00PM +0200, Matthias Kuhn wrote:

> At the moment, we are left with 3 tests that are still failing:
> 
> - qgis_rastersublayertest
> - PyQgsShapefileProvider
> - PyQgsWFSProvider

[...]

> It would be very welcome if the original authors of these tests or the

I think I might be the author of qgis_rastersublayertest but could
not verify as all of these failed:

  $ find . -name qgis_rastersublayertest.c
  $ find . -name rastersublayertest.c
  $ find . -name '*rastersublayertest*'
  $ git grep qgis_rastersublayertest
  $ git grep rastersublayertest

Frustration took over and I gave up.
Does anyone have an hint about improving this situation ?
It keeps striking me everytime I'm looking for the source code
of a test...

PS: after writing this I went with `git grep rastersublayer` and
saw the light (but the issue remain, I would not want to
try my luck again with the other two...)

--strk;
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

[QGIS-Developer] PSA: Travis CI / Docker / Failing Tests

2017-10-02 Thread Matthias Kuhn
Dear all,

we have recently been working on bringing travis ci to the next level
and moving all the testing that is done into a docker image.

This has the advantage that

- we can use newer dependencies for testing (currently Ubuntu 16.04
  repos compared to 14.04 repos before)

- tests can be run locally the same way that they are run in CI (to
  debug)

- we can upload docker images (nightlies and released versions) that can
  be used for plugin testing (only partially implemented so far)


During this process, some issues have been discovered, mostly concerning
compatibility with newer gdal versions and most of them fixed (kudos to
Even for his reactive and valuable help with this).

At the moment, we are left with 3 tests that are still failing:

- qgis_rastersublayertest
- PyQgsShapefileProvider
- PyQgsWFSProvider

The reasons that these tests fail are either because the tests
themselves are unstable and rely on very particular behavior of the
environment or because they actually point out real issues related to
newer dependencies.

It would be very welcome if the original authors of these tests or the
underlying functionality could have a look and either

- fix the tests
- fix the underlying issues that caused the tests to fail
- or disable the tests if they are no longer meaningful.

A patch has been prepared that disables parts of the tests that trigger
the failures which can be used as reference to find where things go wrong:

https://github.com/qgis/QGIS/pull/5256/commits/988aa78feded78634d8600c7baeb701558b23546

If there are no fixes in sight, this patch will be merged as part of PR
5256.

Thanks
Matthias
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer