Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-23 Thread Richard Duivenvoorde
On 23-12-14 08:06, Paolo Cavallini wrote: Hi Nyall, Il 22/12/2014 23:47, Nyall Dawson ha scritto: I disagree - while there may be an issue with the difficulty of getting wide testing of pull requests, the solution isn't to allow broken code into master. You're right, we're big boys

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-23 Thread Nathan Woodrow
I agree with Paolo, and also see the value of Sandro's argument that developing such functionality in a branch get's much less testing/viewing and is very hard to merge back. Myself I only had a serious look at it when it was in master... Sometimes it's not about other people testing, sometimes

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-23 Thread Mathieu Pellerin
To be fair to all, there should probably be an agreed upon understanding on what would need fixing/implementing for the rotation feature to sticik prior to 2.8, and if it can't be achieved by then revert the commits until next dev cycle? I can't be the judge of that, senior devs needed :) On 23

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-23 Thread Matthias Kuhn
Hi all, I think we need to distinguish a bit more in several categories of bugs and features. *Regression bugs* These are the bugs that affect previously working functionality. Like the ugly jumping maps while zooming. If something like this happens it's normally tagged as blocker and a good

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-23 Thread Sandro Santilli
On Tue, Dec 23, 2014 at 02:12:48PM +0100, Matthias Kuhn wrote: I think we need to distinguish a bit more in several categories of bugs and features. *Regression bugs* These are the bugs that affect previously working functionality. Like the ugly jumping maps while zooming. If something

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread 'Sandro Santilli'
On Mon, Dec 22, 2014 at 09:07:32AM +, Ziegler Stefan wrote: The jumping is gone when there is no rotation. Thanks for testing. Martin merged the fix into master. But it has some strange behaviour when drawing the zooming rectangle with a rotated map (see attached image). Known (by me)

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread Nathan Woodrow
Sandro, Am I reading this as you are not doing any more rotation work? Are you planning on fixing the bugs opened against the feature? On Mon, 22 Dec 2014 9:02 pm Sandro Santilli s...@keybit.net wrote: On Mon, Dec 22, 2014 at 09:07:32AM +, Ziegler Stefan wrote: The jumping is gone when

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread Sandro Santilli
On Mon, Dec 22, 2014 at 11:09:06AM +, Nathan Woodrow wrote: Am I reading this as you are not doing any more rotation work? Right now I'm doing work on contextual WMS legend, which is funded. Will get back to rotation later. Probably first or second week of January. Are you planning on

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread Mathieu Pellerin
Thanks for fixing the jumping issue for non-rotated canvas. That said, I'm wondering whether the rotation feature should be exposed in the status bar unless all of the basic canvas interactions are taught how to deal with rotation (which inc. flawless zoom / pan experience and probably north

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread Richard Duivenvoorde
On 22-12-14 12:37, Sandro Santilli wrote: On Mon, Dec 22, 2014 at 11:09:06AM +, Nathan Woodrow wrote: Am I reading this as you are not doing any more rotation work? Right now I'm doing work on contextual WMS legend, which is funded. Will get back to rotation later. Probably first or

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread Sandro Santilli
On Mon, Dec 22, 2014 at 02:18:05PM +0100, Richard Duivenvoorde wrote: On 22-12-14 12:37, Sandro Santilli wrote: I plan to make a call for funding to work on those bugs, but need to find the time for that too. Maybe during christmas holidays. If the feature is not ready for feature

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread Paolo Cavallini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all. Il 22/12/2014 15:04, Sandro Santilli ha scritto: The rotation functionality might be reported as not being complete in the GUI allowing for enabling it. Of course I'd prefer having all things working, but I just could not raise enough

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread Nyall Dawson
On 23 Dec 2014 5:11 am, Paolo Cavallini cavall...@faunalia.it wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all. Il 22/12/2014 15:04, Sandro Santilli ha scritto: The rotation functionality might be reported as not being complete in the GUI allowing for enabling it. Of

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread Nyall Dawson
Sorry, gmail messed up my original reply: On 23 Dec 2014 5:11 am, Paolo Cavallini cavall...@faunalia.it wrote: IMHO removing the function will make much more difficult to attract interest and funding to complete the necessary features. My proposal: add an option to add the rotation spinbox,

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread G. Allegri
I agree with Nyall. I think putting hidden proof of concepts within an official release doesn't put QGIS in a good light. It could be ok some time ago, when QGIS was a niche, but not today. If a sponsorship campagin is required to complete the development we should pursue different marketing

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread Nathan Woodrow
On Tue Dec 23 2014 at 8:57:26 AM G. Allegri gioha...@gmail.com wrote: I agree with Nyall. I think putting hidden proof of concepts within an official release doesn't put QGIS in a good light. It could be ok some time ago, when QGIS was a niche, but not today. If a sponsorship campagin is

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread Nathan Woodrow
Sorry about that blank email. Hit ctrl enter really early. On Tue Dec 23 2014 at 9:31:30 AM Nathan Woodrow madman...@gmail.com wrote: On Tue Dec 23 2014 at 8:57:26 AM G. Allegri gioha...@gmail.com wrote: I agree with Nyall. I think putting hidden proof of concepts within an official

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread Andreas Neumann
Hi, I agree with Nyall. We need to be more strict with new features - if they break other functionality. That's why we added the testing integration. I value the work Sandro has done - but if it can't be finished we need to roll it back and develop in a separate branch. There are too many

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-22 Thread Paolo Cavallini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Nyall, Il 22/12/2014 23:47, Nyall Dawson ha scritto: I disagree - while there may be an issue with the difficulty of getting wide testing of pull requests, the solution isn't to allow broken code into master. You're right, we're big boys now,

[Qgis-developer] Ugly jumping maps while zooming

2014-12-15 Thread Ziegler Stefan
Hi When I zoom in/out, the map contents is jumping to the upper left corner and then jumps back to the right place. I'm on Ubuntu 14.04. Does anybody sees the same effect? Regards Stefan Freundliche Grüsse Stefan Ziegler Kantonsgeometer Amt für Geoinformation Amtliche Vermessung

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-15 Thread Matthias Kuhn
Hi Stefan, Please see this issue: http://hub.qgis.org/issues/11811 And there's a pull request to fix this: https://github.com/qgis/QGIS/pull/1734 Best Matthias On 15.12.2014 15:04, Ziegler Stefan wrote: Hi When I zoom in/out, the map contents is jumping to the upper left corner and then

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-15 Thread Sandro Santilli
On Mon, Dec 15, 2014 at 03:13:56PM +0100, Matthias Kuhn wrote: Hi Stefan, Please see this issue: http://hub.qgis.org/issues/11811 And there's a pull request to fix this: https://github.com/qgis/QGIS/pull/1734 Stefan, if you like the fix you see in the pull request 1734 please report so.

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-15 Thread Ziegler Stefan
. Dezember 2014 15:58 An: Matthias Kuhn Cc: qgis-developer@lists.osgeo.org Betreff: Re: [Qgis-developer] Ugly jumping maps while zooming On Mon, Dec 15, 2014 at 03:13:56PM +0100, Matthias Kuhn wrote: Hi Stefan, Please see this issue: http://hub.qgis.org/issues/11811 And there's a pull

Re: [Qgis-developer] Ugly jumping maps while zooming

2014-12-15 Thread 'Sandro Santilli'
On Mon, Dec 15, 2014 at 03:02:29PM +, Ziegler Stefan wrote: Hi Sandro I just know git clone, push and pull :-) Is there a simple command to use this PR? git pull git://github.com/strk/QGIS.git zoom-by-wheel-glitch2 --strk; ___ Qgis-developer