Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-09-06 Thread Martin Dobias
Hi Marco On Thu, Aug 28, 2014 at 2:33 PM, Marco Hugentobler marco.hugentob...@sourcepole.ch wrote: That leaves doxygen. Why not document API breakages where the API is documented? Sounds like the best fit ;) It's fine to put it into doxygen. Can it also be available as a summarized list

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-28 Thread Marco Hugentobler
Something to be addressed - these features are not supported out of the box by QgsLegendRenderer. Btw. are these custom options documented / used anywhere? The additional wms legend parameters are documented here:

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-28 Thread Jürgen E . Fischer
Hi Marco, On Thu, 28. Aug 2014 at 09:03:49 +0200, Marco Hugentobler wrote: On 27.08.2014 09:27, Paolo Cavallini wrote: Il 27/08/2014 05:40, Martin Dobias ha scritto: Do you have any preferences where to put it - doxygen page / wiki page / qgis-documentation repo / somewhere else? -1 for

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-28 Thread Nyall Dawson
On 28/08/2014 5:29 pm, Jürgen E. j...@norbit.de wrote: That leaves doxygen. Why not document API breakages where the API is documented? Sounds like the best fit ;) That's fine, until those deprecated methods are removed. Then the api break documentation will be removed as well... Nyall

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-28 Thread Martin Dobias
Hi Nyall On Thu, Aug 28, 2014 at 5:33 PM, Nyall Dawson nyall.daw...@gmail.com wrote: On 28/08/2014 5:29 pm, Jürgen E. j...@norbit.de wrote: That leaves doxygen. Why not document API breakages where the API is documented? Sounds like the best fit ;) That's fine, until those deprecated

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-27 Thread Paolo Cavallini
Il 27/08/2014 05:40, Martin Dobias ha scritto: Do you have any preferences where to put it - doxygen page / wiki page / qgis-documentation repo / somewhere else? -1 for wiki thanks -- Paolo Cavallini - www.faunalia.eu Corsi QGIS e PostGIS: http://www.faunalia.eu/training.html

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-26 Thread Martin Dobias
Hi Tim! On Sun, Aug 24, 2014 at 2:51 PM, Tim Sutton t...@kartoza.com wrote: Ah wow - I've been playing with it here and it is so much nicer from the UI point of view. Two things I picked up though. * I don't know how to reproduce it exactly but it seems that when I change the text for a

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-26 Thread Martin Dobias
Hi Denis thanks for testing! On Tue, Aug 26, 2014 at 12:32 PM, Denis Rouzaud denis.rouz...@gmail.com wrote: * In the case of a rule based renderer has a single top level rule, I would suggest that this top rule is not shown as a symbol but directly at the layer level (similarly to a single

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-26 Thread Marco Hugentobler
Hi Martin Thanks for your efforts to unify the legends. Few comments from my side: - API break: is there a list of breaks inside the 2.x series? I recently came accross one in the provider API, and it would be good to provide some guidance for people porting code to newer versions. Regarding

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-26 Thread Martin Dobias
Hi Marco thanks for you comments. On Tue, Aug 26, 2014 at 3:38 PM, Marco Hugentobler marco.hugentob...@sourcepole.ch wrote: Hi Martin Thanks for your efforts to unify the legends. Few comments from my side: - API break: is there a list of breaks inside the 2.x series? I recently came

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-25 Thread Luigi Pirelli
Hi martin, I'll try to have a check of your modification on wms legend next days (or week) regards, Luigi Pirelli (luigi.pire...@faunalia.it - lui...@gmail.com) On 22 August 2014 13:02, Martin Dobias wonder...@gmail.com wrote: Hi all In recent weeks I have been busy with the second part of

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-25 Thread Denis Rouzaud
Hi Martin, This sounds quite exciting! Thanks a lot for this large refactoring! I can't tell much for the code part. However, I have a few remarks from testing: * Removing a symbol in the rule based symbology that was used as a group without any symbol does not removie it from the legend.

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-24 Thread Tim Sutton
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Martin On 22/08/2014 13:02, Martin Dobias wrote: Hi all In recent weeks I have been busy with the second part of legend refactoring. The main goals were: - clean up the mess with legend - there are three different ways of legend

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-24 Thread Tim Sutton
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi On 24/08/2014 09:51, Tim Sutton wrote: Hi Martin On 22/08/2014 13:02, Martin Dobias wrote: Hi all In recent weeks I have been busy with the second part of legend refactoring. The main goals were: - clean up the mess with legend - there

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-24 Thread Leyan
On 08/24/2014 03:51 PM, Tim Sutton wrote: * Do you have any strategy for dealing with symbols larger than the thumbnail in the legend? e.g. if you set the size of a circle to 8 it basically draws a square. This is not a regression as the old legend implementation suffered the same thing, but I

[Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-22 Thread Martin Dobias
Hi all In recent weeks I have been busy with the second part of legend refactoring. The main goals were: - clean up the mess with legend - there are three different ways of legend presentation/rendering: 1. in legend widget (now layer tree view), 2. composer legend, 3. WMS legend - make legend

Re: [Qgis-developer] Legend refactoring - part II - ready for merge

2014-08-22 Thread Marco Hugentobler
Hi Martin If there are no objections I will merge it during the next week. You should give people at least a full week to look at the new code. Regards, Marco On 22.08.2014 13:02, Martin Dobias wrote: Hi all In recent weeks I have been busy with the second part of legend refactoring.