Re: [Qgis-developer] Possible memory leak in rendering code

2013-05-14 Thread Nyall Dawson
On 23 April 2013 19:05, Andreas Neumann a.neum...@carto.net wrote: Hi, How comes that the same feature works fine for some but is broken for others? When I have it on (using a combination of Postgis, WMS and GeoTiff) I often have redraw issues and the layer toggeling often fails. Layers are

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-23 Thread Matthias Kuhn
Backbuffering solves a lot of issues with the rendering cache. It was only introduced on Linux so far (to avoid flickering of the canvas) but maybe it should be enabled automatically if rendering cache is enabled. Explanation: Most crashes I had, happened due to recursively starting another

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-23 Thread Matthias Kuhn
The pull request got accepted. Thank you Minoru. Alex, could you test if this helps anything for your problem? Matthias On 22.04.2013 12:03, Minoru Akagi wrote: Hi, I found some memory leaks and attached a patch to ticket #6795. Regards, Minoru Akagi 2013/4/22 Matthias Kuhn

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-23 Thread Anita Graser
Hi, On Tue, Apr 23, 2013 at 8:22 AM, Matthias Kuhn matthias.k...@gmx.ch wrote: This has some limitations like you are not able to incrementally draw features and you are not able to cancel rendering (Escape). I would be very sorry to see this feature go. I use it regularly since I often

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-23 Thread Matthias Kuhn
Hi Anita, Please don't get me wrong. I don't want this to be the default. But it should be the default with rendering cache enabled (if the decision is to keep rendering cache at all). Regards Matthias On Die 23 Apr 2013 10:09:24 CEST, Anita Graser wrote: Hi, On Tue, Apr 23, 2013 at 8:22

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-23 Thread Andreas Neumann
I am surprised that people really used the render caching. I had all sorts of issues so I did not use it. To me it was really broken. I think we should remove it and reintroduce it when multithreading is implemented and the feature works as expected. Better not ship it than ship in a broken

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-23 Thread Nathan Woodrow
I'm the opposite. I have it enabled all the time and don't really have any issues with it. It's not doing any harm leaving it in IMO so -1 to remove it. - Nathan On Tue, Apr 23, 2013 at 6:38 PM, Andreas Neumann a.neum...@carto.netwrote: I am surprised that people really used the render

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-23 Thread Andreas Neumann
Hi, How comes that the same feature works fine for some but is broken for others? When I have it on (using a combination of Postgis, WMS and GeoTiff) I often have redraw issues and the layer toggeling often fails. Layers are not drawn, but appear to be on with the checkbox in the layer tree or

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-23 Thread Alexander Bruy
Hi, this changes doesn't solve issue for me. Crash happens even if only vector layers with or without labels used. Just finished testing with disabled caching and enabled backbuffer (only vector layers with Single symbol style, one layer labeled using PAL and scale-dependent labeling is

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-23 Thread Ivan Mincik
On 04/23/2013 10:38 AM, Andreas Neumann wrote: I am surprised that people really used the render caching. I had all sorts of issues so I did not use it. To me it was really broken. I think we should remove it and reintroduce it when multithreading is implemented and the feature works as

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-23 Thread Ivan Mincik
Obviously an ideal solution would be to cache the PostGIS layer locally, but until that's possible render caching helps a lot... Also you can use 'materialized views' [1] in Your database. 1 - http://tech.jonathangardner.net/wiki/PostgreSQL/Materialized_Views -- Ivan Mincik

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-23 Thread Ivan Mincik
On 04/23/2013 11:05 AM, Andreas Neumann wrote: Hi, How comes that the same feature works fine for some but is broken for others? When I have it on (using a combination of Postgis, WMS and GeoTiff) I often have redraw issues and the layer toggeling often fails. Layers are not drawn, but

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-22 Thread Minoru Akagi
Hi, I found some memory leaks and attached a patch to ticket #6795. Regards, Minoru Akagi 2013/4/22 Matthias Kuhn matthias.k...@gmx.ch: Hi Alex, I found in the past particularly two things making the rendering more stable: * Disable Render Cache * Enable Backbuffer (only availale in

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-22 Thread Alexander Bruy
Hi Matthias, thanks for hints. Just tested with disabled Renderer Cache and again get crash. Here is last console messages: Warning: QPainter::end: Painter ended with 2 saved states Debug: src/core/qgsmessagelog.cpp: 45: (logMessage) 2013-04-22T15:19:22 Qt[1] QPainter::end: Painter ended with 2

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-22 Thread Martin Dobias
On Mon, Apr 22, 2013 at 10:54 AM, Matthias Kuhn matthias.k...@gmx.ch wrote: Hi Alex, I found in the past particularly two things making the rendering more stable: * Disable Render Cache * Enable Backbuffer (only availale in X11/Linux) By the way, it would be a good thing to remove render

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-22 Thread Paolo Cavallini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 22/04/2013 13:42, Martin Dobias ha scritto: By the way, it would be a good thing to remove render caching completely before 2.0. In any case it will need to be reworked when Hi Martin, it makes sense. Any objections in removing it? All the

Re: [Qgis-developer] Possible memory leak in rendering code

2013-04-22 Thread John C. Tull
On Apr 22, 2013, at 2:12 PM, Nyall Dawson nyall.daw...@gmail.com wrote: By the way, it would be a good thing to remove render caching completely before 2.0. In any case it will need to be reworked when moving to multi-threaded rendering... it has only a limited functionality of storing