Re: [Ql-Users] Possible bug in smsqmulator.

[Norman Dunbar via Ql-Users]

Ok, thanks Wolf.

Cheers,
Norm.

On 12 October 2017 04:41:36 BST, Wolf via Ql-Users  
wrote:
>Hi,
>
>thanks for your warning but no bug. The comment mentions what the
>SMSQ/E 
>format routine gets, not the java side.
>
>Cheers
>
>Wolfgang
>
>On 11/10/2017 23:24, Norman Dunbar via Ql-Users wrote:
>> Evening All,
>> 
>> I was nosing around in the latest source for Smsqmulator and I might
>have found a bug in the floppy driver code. Mind you, it's Java, so all
>bets are off!
>> 
>> In formatDrive() it has a comment that d0 is the format type, 0=sd,
>1=dd, 2=hd or 3=ed etc. However the code looks to be getting the format
>type from register d2 and not d0. As in:
>> 
>> Int type = (this.cpu.data_regs[2]&0x)-1;
>> 
>> I might be wrong of course, it does happen, but it looks odd given
>the comments.
>> 
>> 
>> Cheers,
>> Norm.
>> 
>___
>QL-Users Mailing List

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
___
QL-Users Mailing List

Re: [Ql-Users] Possible bug in smsqmulator.

[Wolf via Ql-Users]

Hi,

thanks for your warning but no bug. The comment mentions what the SMSQ/E 
format routine gets, not the java side.


Cheers

Wolfgang

On 11/10/2017 23:24, Norman Dunbar via Ql-Users wrote:

Evening All,

I was nosing around in the latest source for Smsqmulator and I might have found 
a bug in the floppy driver code. Mind you, it's Java, so all bets are off!

In formatDrive() it has a comment that d0 is the format type, 0=sd, 1=dd, 2=hd 
or 3=ed etc. However the code looks to be getting the format type from register 
d2 and not d0. As in:

Int type = (this.cpu.data_regs[2]&0x)-1;

I might be wrong of course, it does happen, but it looks odd given the comments.


Cheers,
Norm.


___
QL-Users Mailing List