Re: [qooxdoo-devel] Label: setAppearance resets wrap property

2007-04-05 Thread Ralf Sternberg
Hi Alex, thanks a lot for your detailed explanations! Alex Back schrieb: >> First, there is also an appearance "label" in our appearance theme, that >> sets "wrap" to false in the "initial" part. This does not explain why >> wrap is set to true - or am I again missing something? > The defaultValu

Re: [qooxdoo-devel] Label: setAppearance resets wrap property

2007-04-05 Thread Alex Back
Hi Ralf, > First, there is also an appearance "label" in our appearance theme, that > sets "wrap" to false in the "initial" part. This does not explain why > wrap is set to true - or am I again missing something? The defaultValue of the property wrap is true (-> defined in qx.ui.basic.Label). So

Re: [qooxdoo-devel] Label: setAppearance resets wrap property

2007-04-04 Thread Ralf Sternberg
Hi Alex, Alex Back schrieb: > calling setAppearance() resets those properties to its defaultValue which are > defined in the original appearance but not in the new appearance. > Let me explain this mechanism with your label example. > > The original "label"-appearance in the Classic appearance

Re: [qooxdoo-devel] Label: setAppearance resets wrap property

2007-04-04 Thread Alex Back
That's why the property system got reimplemented. With the 0.6.x codebase there was no possibility to get back to the user value. The property system nows brings in multi-value support for properties. cheers, Alex On Wednesday 04 April 2007 Jim Hunter wrote: > To me, keeping the user value i

Re: [qooxdoo-devel] Label: setAppearance resets wrap property

2007-04-04 Thread Alex Back
Hi Jim, I think the problem is not that the value falls back to its default. The current behaviour of qooxdoo is that the property should fall back to its defaultvalue rather than using the property value of the original appearance. I think the main problem here is that the value defined by th

Re: [qooxdoo-devel] Label: setAppearance resets wrap property

2007-04-04 Thread Jim Hunter
Why step #3? This looks like an unnecessary thing to do. Is there a reason for it? I would expect that only the items in the new appearance would get change, especially if you make the change after some time and the widget may be completely changed or moves to a new location or ??? There are lots

Re: [qooxdoo-devel] Label: setAppearance resets wrap property

2007-04-04 Thread Alex Back
Hi Ralf, calling setAppearance() resets those properties to its defaultValue which are defined in the original appearance but not in the new appearance. Let me explain this mechanism with your label example. The original "label"-appearance in the Classic appearance-theme defines wrap as "fals