[quagga-dev 15575] Comments on Tools and Maintainer Doc please! (Was Re: Call for Agenda)

I would appreciate if everyone takes some time to read through the documents and adds their comment. I’ve added a table at the bottom of the tools document for everyone to list their preferences. There are many choices and I think it would be great for everyone to list what they prefer so we

[quagga-dev 15574] Re: Bug Fixes Fast Lane

Thanks for pointing that out. --Jafar On 6/14/2016 2:26 PM, Donald Sharp wrote: Jafar - I would point out that the new process as outlined, is that once a bug get's Acked is immediately placed in master by a maintainer. donald On Tue, Jun 14, 2016 at 3:03 PM, Jafar Al-Gharaibeh

[quagga-dev 15573] CI Testresult: FAILED (Re: [quagga-dev, 15567, 16/16] vtysh: fix a memory leak in vtysh_client_execute)

Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 1985: http://patchwork.quagga.net/patch/1985

[quagga-dev 15572] CI Testresult: FAILED (Re: [quagga-dev, 15551, 6/6] build: split off libquaggasnmp)

Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 1981: http://patchwork.quagga.net/patch/1981

[quagga-dev 15571] Re: Regarding multiple fpm connectivity

On Tue, 14 Jun 2016, Udaya Shankara KS wrote: Hi Paul, Both are different. Previous patch - 1815, queued for round-8, is to facilitate configuring the fpm server ip and port to other than default ( localhost:2620). This new change is to have multiple fpm connection to support application

[quagga-dev 15570] Re: Bug Fixes Fast Lane

Jafar - I would point out that the new process as outlined, is that once a bug get's Acked is immediately placed in master by a maintainer. donald On Tue, Jun 14, 2016 at 3:03 PM, Jafar Al-Gharaibeh wrote: > Greetings, > > I know the Quagga community is in the process

[quagga-dev 15568] Re: [PATCH 01/16] zebra: fix null pointer dereference in zsend_ipv4_nexthop_lookup_mrib

This is already addressed and included in round 8 branch. --Jafar On 6/14/2016 1:06 PM, Christian Franke wrote: From: Christian Franke zsend_ipv4_nexthop_lookup_mrib is called with rib == NULL if the lookup does not yield any result. Therefore, rib->vrf_id cannot be used

[quagga-dev 15564] [PATCH 13/16] pimd: don't leak original_s_route on error

From: Christian Franke original_s_route is allocated on the heap and was not freed during the error case. Signed-off-by: Christian Franke --- pimd/pim_static.c | 4 1 file changed, 4 insertions(+) diff --git a/pimd/pim_static.c

[quagga-dev 15561] [PATCH 07/16] bgpd: fix memory leaks in show commands

From: Christian Franke sockunion_str2su allocates a struct sockunion that used to be leaked in the show commands. Use str2sockunion and keep the information on the stack instead. Signed-off-by: Christian Franke --- bgpd/bgp_encap.c | 38

[quagga-dev 15558] [PATCH 08/16] ospfd: fix double assignment in ospf_vl_set_timers

From: Christian Franke Signed-off-by: Christian Franke --- ospfd/ospf_vty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ospfd/ospf_vty.c b/ospfd/ospf_vty.c index fb17dff..a118794 100644 --- a/ospfd/ospf_vty.c +++

[quagga-dev 15563] [PATCH 12/16] isisd: Fix size of malloc

From: Christian Franke Signed-off-by: Christian Franke --- isisd/isis_routemap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/isisd/isis_routemap.c b/isisd/isis_routemap.c index 3e0ab04..3443a0a 100644 ---

[quagga-dev 15562] [PATCH 11/16] isisd: fix an error that was probably a result of copypasting

From: Christian Franke The code should check for the existance of the correct list prior to accessing it. Signed-off-by: Christian Franke --- isisd/isis_circuit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[quagga-dev 15566] [PATCH 15/16] vtysh: handle case if there is no match in "write terminal $daemon"

From: Christian Franke While the DEFUN should match the list of clients registered in vtysh, it seems better to handle the case explicitly instead of relying on the client list and the DEFUN signature being in sync. Signed-off-by: Christian Franke

[quagga-dev 15567] [PATCH 16/16] vtysh: fix a memory leak in vtysh_client_execute

From: Christian Franke buf is dynamically allocated and needs to be freed in the error handling path too. Signed-off-by: Christian Franke --- vtysh/vtysh.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vtysh/vtysh.c b/vtysh/vtysh.c index

[quagga-dev 15554] [PATCH 03/16] bgpd: check return value of zebra_interface_state_read

From: Christian Franke zebra_interface_state_read can return NULL in cornercases. The other daemons check for this, so should bgpd. Signed-off-by: Christian Franke --- bgpd/bgp_zebra.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[quagga-dev 15560] [PATCH 10/16] ospf6d: fix off-by-one on display of spf reasons

From: Christian Franke The loop should only iterate to array_size - 1. Signed-off-by: Christian Franke --- ospf6d/ospf6_spf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ospf6d/ospf6_spf.c b/ospf6d/ospf6_spf.c index

[quagga-dev 15559] [PATCH 09/16] ospf6d: don't access nexthops out of bounds

From: Christian Franke Given that the && is evaluated lazily from left to right, i < OSPF6_MULTI_PATH_LIMIT should be checked prior to calling ospf6_nexthop_is_set on the array element, not the other way around. Signed-off-by: Christian Franke

[quagga-dev 15556] [PATCH 05/16] bgpd: don't leak memory in community_regexp_include

From: Christian Franke Signed-off-by: Christian Franke --- bgpd/bgp_clist.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/bgpd/bgp_clist.c b/bgpd/bgp_clist.c index 1f1a4e7..800bd01 100644 --- a/bgpd/bgp_clist.c

[quagga-dev 15555] [PATCH 04/16] bgpd: fix bgp_table_stats for mpls vpn

From: Christian Franke bgpd uses an internal value SAFI_MPLS_VPN == 4 to index the information related to mpls vpn, while the IANA safi value is SAFI_MPLS_LABELED_VPN == 128. To access the bgp_table_stats, the internal value has to be used, not the wire-format value.

[quagga-dev 15557] [PATCH 06/16] bgpd: fix off-by-one in attribute flags handling

From: Christian Franke bgp_attr_flag_invalid can access beyond the last element of attr_flags_values. Fix this by initializing attr_flags_values_max to the correct value. Signed-off-by: Christian Franke --- bgpd/bgp_attr.c | 3 +-- 1 file

[quagga-dev 15552] [PATCH 01/16] zebra: fix null pointer dereference in zsend_ipv4_nexthop_lookup_mrib

From: Christian Franke zsend_ipv4_nexthop_lookup_mrib is called with rib == NULL if the lookup does not yield any result. Therefore, rib->vrf_id cannot be used to construct the response and vrf has to be passed explicitly. Signed-off-by: Christian Franke

[quagga-dev 15549] [PATCH 4/6] bgpd: snmp: use hooks for sending traps

--- bgpd/bgp_fsm.c | 14 +- bgpd/bgp_fsm.h | 4 bgpd/bgp_snmp.c | 11 +++ bgpd/bgp_snmp.h | 3 +++ 4 files changed, 19 insertions(+), 13 deletions(-) diff --git a/bgpd/bgp_fsm.c b/bgpd/bgp_fsm.c index c4cfd58..8b3bb8c 100644 --- a/bgpd/bgp_fsm.c +++ b/bgpd/bgp_fsm.c

[quagga-dev 15551] [PATCH 6/6] build: split off libquaggasnmp

--- bgpd/Makefile.am | 1 + configure.ac | 6 -- lib/Makefile.am| 13 +++-- ospf6d/Makefile.am | 2 +- ospfd/Makefile.am | 2 +- ripd/Makefile.am | 2 +- zebra/Makefile.am | 2 +- 7 files changed, 20 insertions(+), 8 deletions(-) diff --git a/bgpd/Makefile.am

[quagga-dev 15548] [PATCH 3/6] lib: add hook infrastructure

--- lib/Makefile.am | 2 + lib/hook.c | 40 ++ lib/hook.h | 126 3 files changed, 168 insertions(+) create mode 100644 lib/hook.c create mode 100644 lib/hook.h diff --git a/lib/Makefile.am b/lib/Makefile.am

[quagga-dev 15550] [PATCH 5/6] bgpd: snmp: convert into plugin

--- bgpd/Makefile.am | 9 +++-- bgpd/bgp_snmp.c | 24 ++-- bgpd/bgp_snmp.h | 31 --- bgpd/bgpd.c | 9 +++-- bgpd/bgpd.h | 3 +++ 5 files changed, 31 insertions(+), 45 deletions(-) delete mode 100644 bgpd/bgp_snmp.h diff

[quagga-dev 15546] [PATCH 1/6] lib: plugin loading

--- lib/Makefile.am | 10 +++- lib/plugin.c| 177 lib/plugin.h| 117 + 3 files changed, 301 insertions(+), 3 deletions(-) create mode 100644 lib/plugin.c create mode 100644 lib/plugin.h diff

[quagga-dev 15545] RFC: plugin (DSO) + hook support

Hi all, this series contains support for loading dynamic modules (DSOs) that contain additional functionality. bgpd's SNMP support is the test target. THIS IS AN UNFINISHED VERSION TO INVITE FEEDBACK. In the "big picture", there are some very broad topics that are non-trivial, first and

[quagga-dev 15547] [PATCH 2/6] zebra/bgpd: cmdline-load modules

--- bgpd/bgp_main.c | 17 - zebra/main.c| 17 +++-- 2 files changed, 31 insertions(+), 3 deletions(-) diff --git a/bgpd/bgp_main.c b/bgpd/bgp_main.c index 25669a0..0ca2b99 100644 --- a/bgpd/bgp_main.c +++ b/bgpd/bgp_main.c @@ -39,6 +39,7 @@ Software Foundation,

[quagga-dev 15542] Re: [PATCH] vtysh: auto-generated vtysh_cmd.c file should depend on its creator

Acked-by: Donald Sharp On Tue, Jun 14, 2016 at 10:06 AM, Paul Jakma wrote: > --- > vtysh/Makefile.am | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/vtysh/Makefile.am b/vtysh/Makefile.am > index d347735..e44cd49

[quagga-dev 15541] CI Testresult: PASSED (Re: [quagga-dev, 15535] zebra: *addattr should use size_t len args, quell signed v unsigned warning)

Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied :

[quagga-dev 15540] Re: Round 8

I would recommend reverting: ceecc7e *: Consolidate all double VIEW_NODE and ENABLE_NODE's 0dbe0d2 lib: Consolidate VIEW_NODE to be ENABLE_NODE as well They are the cause of this breakage. Shall I do this? thanks! donald On Tue, Jun 14, 2016 at 10:45 AM, Donald Sharp

[quagga-dev 15539] CI Testresult: PASSED (Re: [quagga-dev, 15534] vtysh: auto-generated vtysh_cmd.c file should depend on its creator)

Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied :

[quagga-dev 15538] Re: Round 8

I'm getting this crash in zebra: root@robot:/etc/quagga# /usr/lib/quagga/zebra --daemon -A 127.0.0.1 Aborted (core dumped) root@robot:/etc/quagga# (gdb) r -A 127.0.0.1 Starting program: /usr/lib/quagga/zebra -A 127.0.0.1 [Thread debugging using libthread_db enabled] Using host libthread_db

[quagga-dev 15537] Re: Round 8

Paul, On 6/14/2016 9:02 AM, Paul Jakma wrote: > Note: I've had a good few conflicts on 'install_element' lines, due to > various patches adding/removing commands with the restricted node and > 'auto-install view commands into enable' patches. I didn't look too > closely as to whether I

[quagga-dev 15534] [PATCH] vtysh: auto-generated vtysh_cmd.c file should depend on its creator

--- vtysh/Makefile.am | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/vtysh/Makefile.am b/vtysh/Makefile.am index d347735..e44cd49 100644 --- a/vtysh/Makefile.am +++ b/vtysh/Makefile.am @@ -36,6 +36,5 @@ vtysh_cmd_FILES = $(top_srcdir)/bgpd/*.c $(top_srcdir)/isisd/*.c \

[quagga-dev 15536] Re: Round 8

Hi Paul, Thanks a lot producing this round8. BTW, I have two small patches for my TE branch. Can you have a look at github here: https://github.com/Orange-OpenSource/Quagga-TE/commit/b2d48d2838ef4813f4c7c7d0ce1d55dc25e3acf1 That just fix some comment as draft-ietf-isis-te-metric-extensions-11

[quagga-dev 15533] Re: Round 8

Eak -- the branch doesn't compile with -std=c99 . I think these changes need to be reworked with standard modern c declarations. Lou On 6/14/2016 9:47 AM, Lou Berger wrote: > Paul, > > Great to see this published. Is there a quagga convention WRT C99? > > I see the following when compiling

[quagga-dev 15532] Re: Round 8

Paul, Great to see this published. Is there a quagga convention WRT C99? I see the following when compiling proposed/8 if.c:1151: error: ?for? loop initial declarations are only allowed in C99 mode if.c:1151: note: use option -std=c99 or -std=gnu99 to compile your code zclient.c:903: error:

[quagga-dev 15530] Re: Round 8

Oh, and I've created a bundle in pw to track the patchwork IDs: http://patchwork.quagga.net/bundle/paul/round-8 regards, Paul On Tue, 14 Jun 2016, Paul Jakma wrote: Hi, Took a bit longer, but the proposed patches are up in: http:

[quagga-dev 15529] Re: Regarding multiple fpm connectivity

Hi Udaya, Does this update the previous patch you posted, which I have queued up for round-8? Or is it the same? http://git.savannah.gnu.org/cgit/quagga.git/commit/?h=volatile/patch-tracking/8/proposed/patchwork=b2fb29654b9655c04921421bb3fc403ae49f7f05 regards, Paul On Tue, 14 Jun 2016,

[quagga-dev 15528] Re: Round 8

Hi, Took a bit longer, but the proposed patches are up in: http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/patch-tracking/8/proposed/patchwork http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/patch-tracking/8/proposed/donald-take-3 I've done some initial prioritising, so

[quagga-dev 15527] Re: [PATCH 3/4] lib: AgentX: use threads instead of eventloop hack

On Mon, 13 Jun 2016, David Lamparter wrote: AgentX fd/timeout handling is rather hackishly monkeyed into thread.c. Replace with code that uses plain thread_* functions. Oh yes. That's been annoying my eyes every time I've scrolled past it. regards, -- Paul Jakma | p...@jakma.org | @pjakma |

[quagga-dev 15526] Re: [PATCH 2/8] isisd: API: basic area config

On Tue, 24 May 2016, David Lamparter wrote: Whoops, the "add" part of this got mixed up in the 1/8 patch... (Thanks Donald for pointing that out!) Should've noticed that myself looking at the diffstat... I'll go fix & resend. Patchwork seems only to have the version from this thread - which