[quagga-dev 15667] Re: Call for Agenda

2016-06-20 Thread Martin Winter
A little bit late, but I had a long call with Vincent today (his late monday evening). He has some different suggestion which I wrote down in a new document as an alternative choice. (Unfortunately, he can’t attend the call) Description is here:

[quagga-dev 15666] Re: ospfd crashes after updating to 1.0.20160315

2016-06-20 Thread Jafar Al-Gharaibeh
On 6/20/2016 5:05 PM, Sergey Popov wrote: Well, silly me. I look on quagga's cgit and found commit bb01bdd740339b0c07d8ed0786811801b2a79192, which, i hope, fixes my problem. Yep, that is the one I had in mind :) At least 1 hour run for test router with flapping ppp interfaces does not crash

[quagga-dev 15665] Re: ospfd crashes after updating to 1.0.20160315

2016-06-20 Thread Sergey Popov
Well, silly me. I look on quagga's cgit and found commit bb01bdd740339b0c07d8ed0786811801b2a79192, which, i hope, fixes my problem. At least 1 hour run for test router with flapping ppp interfaces does not crash ospfd. I have just backported this into Gentoo package, which i maintain, thanks a

[quagga-dev 15664] Re: ospfd crashes after updating to 1.0.20160315

2016-06-20 Thread Jafar Al-Gharaibeh
Sergey, Can you also post zebra.conf? In any case, this might be related to a bug that have been fixed recently, but not 100% sure. Can you build Quagga from the latest sources? just checkout master, build, and see if that fixes the issue, and let us know how it goes. --Jafar On

[quagga-dev 15663] Re: ospfd crashes after updating to 1.0.20160315

2016-06-20 Thread Sergey Popov
Able to reproduce this on smaller setup My ospfd conf: https://bpaste.net/show/171b3a5dadd1 ospfd.log with debug options enabled(warning - >600Kb of text): https://bpaste.net/show/dd70ace5f819 It happens almost every time(but not exactly every time and that's strange) when i remove one of the

[quagga-dev 15662] CI Testresult: PASSED (Re: [quagga-dev, 15660] zebra: Change bitwise operations to purpose-built macros)

2016-06-20 Thread cisystem
Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied :

[quagga-dev 15661] Re: [PATCH] zebra: Change bitwise operations to purpose-built macros

2016-06-20 Thread Jafar Al-Gharaibeh
Acked-by: Jafar Al-Gharaibeh On 6/20/2016 12:58 PM, Quentin Young wrote: Some bitfields for zebra_debug_* flags were being modified with bitwise operators instead of the purpose-built macros in lib/zebra.h. Changed such instances to use the macros. Signed-off-by: Quentin

[quagga-dev 15660] [PATCH] zebra: Change bitwise operations to purpose-built macros

2016-06-20 Thread Quentin Young
Some bitfields for zebra_debug_* flags were being modified with bitwise operators instead of the purpose-built macros in lib/zebra.h. Changed such instances to use the macros. Signed-off-by: Quentin Young --- zebra/debug.c | 20 ++-- 1 file changed,

[quagga-dev 15659] Re: [PATCH ] bgpd: use default index table for vpnv4 when called from vty

2016-06-20 Thread Jafar Al-Gharaibeh
Submitted by Christian Franke a few days ago. See patch 1988. What is the action taken for duplicate/identical patches. Nack, so that they can be easily identified and dropped? --Jafar On 6/20/2016 3:35 AM, Philippe Guibert wrote: For vpnv4, RIB is reachable through safi index set to

[quagga-dev 15658] CI Testresult: PASSED (Re: [quagga-dev, 15657] bgpd: use default index table for vpnv4 when called from vty)

2016-06-20 Thread cisystem
Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied :

[quagga-dev 15655] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

2016-06-20 Thread Philippe Guibert
On Fri, Jun 17, 2016 at 4:10 PM, Lou Berger wrote: Hello Lou, >> #if ENABLE_BGP_VNC >> if (v != RD_TYPE_VNC_ETH) >>v |= (u_int16_t) *pnt; >> #else >> v |= (u_int16_t) *pnt; >> #endif >> >> IMHO, I think this brings more clarity about the algorithm in place. > I considered

[quagga-dev 15656] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

2016-06-20 Thread Philippe Guibert
On Fri, Jun 17, 2016 at 7:31 PM, Lou Berger wrote: Lou, > BTW V3 has the references you asked for in the log. > > * > https://github.com/LabNConsulting/quagga-vnc/tree/patches/R1.0.20160315%2Bvnc/v3 > Just read the changes. Thanks a lot. Acked-by: Philippe Guibert