[quagga-dev 15492] Re: [PATCH] bgpd: Squash spurious "unknown afi" log messages

_____ > Quagga-dev mailing list > Quagga-dev@lists.quagga.net > https://lists.quagga.net/mailman/listinfo/quagga-dev Acked-by: Philippe Guibert <philippe.guib...@6wind.com> ___ Quagga-dev mailing list Quagga-dev@lists.quagga.net https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15491] Re: [PATCH] bgpd: bgp_update_receive ignores non present NLRI

acket really, just the code non-sensically giving a > warning about AFIs/SAFIs that weren't sent. ;) > > On Wed, 8 Jun 2016, Philippe Guibert wrote: > >> Fixes 518a4b7eadcb "bgpd: Regularise bgp_update_receive, >> add missing notifies and checks" >> Error mes

[quagga-dev 15499] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

On Wed, Jun 8, 2016 at 9:22 PM, Lou Berger wrote: Hi Lou, > >> >> * It seems the RD_TYPE_EOI type surfaced again (see >> http://patchwork.quagga.net/patch/1728/ ), whereas I don't see where it >> is used. Is there a need to keep this flag ? > This is used by the ethernet

[quagga-dev 15483] Re: [PATCH 00/10] VNC: L3 & L2 VPN application support

I will continue the review the patch code, and get back to you quickly, Best Regards, Philippe On Mon, Jun 6, 2016 at 6:00 PM, Philippe Guibert <philippe.guib...@6wind.com> wrote: > Hi Lou, > > I am looking deeper at EVPN implementation, with patch "VNC; L3 & L2 > VPN ap

[quagga-dev 15482] [PATCH] bgpd: bgp_update_receive ignores non present NLRI

message. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_packet.c | 8 1 file changed, 8 insertions(+) diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c index 740b0f1ce603..601d39d1c1ad 100644 --- a/bgpd/bgp_packet.c +++ b/bgpd/bgp_packet.c @@ -1781,6 +178

[quagga-dev 15431] Re: [PATCH 00/10] VNC: L3 & L2 VPN application support

Hi Lou, I am looking deeper at EVPN implementation, with patch "VNC; L3 & L2 VPN application support". To get more familiar with this, I tried to mount a setup based on Mesh NVA configuration example that can be found on doc/vnc.texi file, and make a BGP exchange between the two BGP speakers. At

[quagga-dev 15596] Re: [PATCH 07/16] bgpd: fix memory leaks in show commands

munity_free(com); > The usage of the new API is safer. If the quagga testing were not using sockunion_str2su(), this command could have been removed. It is possible to mention in the commit log the memory leak related to community structure ? Thanks, Regards, Philippe Signed-off-by: Philippe Guib

[quagga-dev 15590] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

thread ? > We have an openflow RFP implementation in the works and once it is > sufficiently mature / stable, we'll submit it too. > > Cheers, > Lou Best Regards, Acked-by: Philippe Guibert <philippe.guib...@6wind.com> ___ Quagga-dev m

[quagga-dev 15675] Re: [PATCH ] bgpd: use default index table for vpnv4 when called from vty

> can be easily identified and dropped? As far as i know, i self nack that patch, and ack the original one. nacked-by: Philippe Guibert <philippe.guib...@6wind.com> ___ Quagga-dev mailing list Quagga-dev@lists.quagga.net https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15674] Re: [PATCH 04/16] bgpd: fix bgp_table_stats for mpls vpn

PN; Problem Confirmed, and fix approved. acked-by: Philippe Guibert <philippe.guib...@6wind.com> ___ Quagga-dev mailing list Quagga-dev@lists.quagga.net https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15673] Re: [PATCH] bgpd: Squash spurious "unknown afi" log messages

Hi all, On Wed, Jun 8, 2016 at 5:17 PM, Philippe Guibert <philippe.guib...@6wind.com> wrote: > >> bgpd/bgp_packet.c | 5 - >> + if (!nlris[i].nlri) continue; > Acked-by: Philippe Guibert <philippe.guib...@6wind.com> Is this patch that I did ack'

[quagga-dev 15671] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

hi all, On Mon, Jun 20, 2016 at 8:32 AM, Philippe Guibert <philippe.guib...@6wind.com> wrote: > > https://github.com/LabNConsulting/quagga-vnc/tree/patches/R1.0.20160315%2Bvnc/v3 > > > Just read the changes. Thanks a lot. > > Acked-by: Philippe Guibert <philippe.gui

[quagga-dev 15670] Re: [PATCH 07/16] bgpd: fix memory leaks in show commands

On Wed, Jun 15, 2016 at 5:50 PM, Philippe Guibert < philippe.guib...@6wind.com> wrote: Hello, Is this patch that I did ack't applied? Regards, Philippe ___ Quagga-dev mailing list Quagga-dev@lists.quagga.net https://lists.quagga.net/mailman/li

[quagga-dev 15676] Re: [PATCH ] bgpd: Add new configuration cli for graceful restart.

On Tue, May 24, 2016 at 4:52 PM, Philippe Guibert <philippe.guib...@6wind.com> wrote: Hi all, > There is support to configure graceful restart timer. This is the > time to wait to delete stale routes before a BGP open message is > received. Could someone make a review of this p

[quagga-dev 15644] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

On Thu, Jun 16, 2016 at 8:52 PM, Lou Berger wrote: Hello Lou, > Philippe, > > I've posted a fix to this (patch on patch) in > > https://github.com/LabNConsulting/quagga-vnc/commit/cd54370cb94d598aa95bd7561cc012200920d97a > I posted 2 minor comments: 1) The code has been

[quagga-dev 15634] Re: [PATCH] bgpd: eliminate RD related duplicate code in bgp_encap.c

t > decode_rd_type (u_char *pnt) Please, can you please add a commit log like the following ? bgpd: decode_rd() apis are declared global in bgpd() This fix avoids duplicated function utilities in differents files of bgpd. Thanks, Acked-by: Philippe Guibe

[quagga-dev 15655] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

On Fri, Jun 17, 2016 at 4:10 PM, Lou Berger wrote: Hello Lou, >> #if ENABLE_BGP_VNC >> if (v != RD_TYPE_VNC_ETH) >>v |= (u_int16_t) *pnt; >> #else >> v |= (u_int16_t) *pnt; >> #endif >> >> IMHO, I think this brings more clarity about the algorithm in place. > I considered

[quagga-dev 15656] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

On Fri, Jun 17, 2016 at 7:31 PM, Lou Berger <lber...@labn.net> wrote: Lou, > BTW V3 has the references you asked for in the log. > > * > https://github.com/LabNConsulting/quagga-vnc/tree/patches/R1.0.20160315%2Bvnc/v3 > Just read the changes. Thanks a lot. Acked

[quagga-dev 15625] Re: [PATCH 1/6] lib: plugin loading

On Tue, Jun 14, 2016 at 7:59 PM, David Lamparter wrote: Hello David, > > +DEFINE_MTYPE_STATIC(LIB, PLUGIN_LOADNAME, "Plugin loading name") * I got compilation problems. Some elements are not yet in the master. I will retry later. branch of quagga. error: patch

[quagga-dev 15622] Re: [PATCH 06/16] bgpd: fix off-by-one in attribute flags handling

On Tue, Jun 14, 2016 at 8:07 PM, Christian Franke <ch...@opensourcerouting.org> wrote: Hello Christian, > +static const size_t attr_flags_values_max = array_size(attr_flags_values) - > 1; This macro is very useful. Acked-by : Philippe Guibert <philippe.gu

[quagga-dev 15744] Re: [PATCH ] bgpd: Add new configuration cli for graceful restart.

On Tue, Jun 21, 2016 at 12:13 PM, Philippe Guibert <philippe.guib...@6wind.com> wrote: Hello, > Could someone make a review of this patch ? I see on patchwork it is queued: where is it queued? http://patchwork.quagga.net/patch/1943/ Regards,

[quagga-dev 15745] Re: [PATCH] bgpd: Squash spurious "unknown afi" log messages

On Fri, Jun 24, 2016 at 11:50 AM, Paul Jakma wrote: Hi Paul, > Maybe not yet, but it will be. Thanks, I see it is queued (http://patchwork.quagga.net/patch/1921/), but it is not applied. Where is it? regards, ___ Quagga-dev mailing

[quagga-dev 15746] bgp addpath feature

Hello Donald, I saw that on the public branch of quagga from cumulus ( https://github.com/CumulusNetworks/quagga.git, branch mpls), there is a feature named addpath. This feature is very interesting for multipath, since it permits sending multiple path entries for the same prefix in BGP updates.

[quagga-dev 15358] [PATCH ] bgpd: Add new configuration cli for graceful restart.

bgpd/bgpd.c * bgp_config_write(): Output graceful restart-time configuration Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_vty.c | 50 ++ bgpd/bgpd.c| 3 +++ 2 files changed, 53 insertions(+) diff --git a/bgp

[quagga-dev 15761] Re: [PATCH 01/10] *: get rid of "MTYPE 0"

On Fri, Feb 26, 2016 at 8:00 AM, David Lamparter wrote: Hi David, > Signed-off-by: David Lamparter > Acked-by: Vincent JARDIN > Acked-by: Donald Sharp About

[quagga-dev 15762] quagga / quagga-capnproto / push to upstream

Hi David, Christian, About the quagga work done on https://git.netdef.org/scm/osr/quagga-capnproto.git, branch capnproto. It contains interesting commits related to L3VPN and Capnproto. FYI, I am still reviewing and rebasing your series; within few days I should be able to propose a serie that

[quagga-dev 15771] Re: [PATCH 01/10] *: get rid of "MTYPE 0"

On Tue, Jun 28, 2016 at 5:11 PM, Paul Jakma wrote: Hello Paul, > That's already in the r8 queue. Seems it was resent. The previous one, set to > queued already: FYI, there are 2 series of patches related to memtypes, - 1822 till 1831, all except 1829 is acked by Donald. -

[quagga-dev 15758] Re: [PATCH ] bgpd: Add new configuration cli for graceful restart.

On Tue, Jun 28, 2016 at 12:37 PM, Paul Jakma wrote: > In > http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/patch-tracking/8/proposed/ff > You can see the refs for what I have so far for round-8: > http://git.savannah.gnu.org/cgit/quagga.git/refs/ Great and thanks

[quagga-dev 15801] Re: quagga / quagga-capnproto / push to upstream

On Thu, Jun 30, 2016 at 9:57 AM, David Lamparter wrote: Hello David, > I have a rebased/somewhat-cleaned version around, might be more useful > to look at that. It's not fully cleaned up yet, but better than what's > currently up there. I'll push it out some time

[quagga-dev 16053] Re: [PATCH] bgp: bgp_nexthop init/free AFI_ETHER related NH tables

and reset those tables with AFI_ETHERNET. I think it is better than locking the NHT entry point with some defense code. So, I would ack it. Acked-by: Philippe Guibert <philippe.guib...@6wind.com> Best Regards, Philippe -- Forwarded message -- From: Paul Jakma <p...@

[quagga-dev 16059] [PATCH 01/10] *: get rid of "MTYPE 0"

From: David Lamparter <equi...@opensourcerouting.org> A few places are using 0 in place of the MTYPE_* argument. The following rewrite of the alloc tracking won't deal with that, so let's use MTYPE_TMP instead. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Reviewed-

[quagga-dev 16064] [PATCH 08/10] lib: clean/restore memory debugging functions

qui...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.guib...@6wind.com> --- lib/memory.c | 35 ++ lib/memory.h | 1 + lib/memory_vty.c | 89 +--- lib/memory_vty.h | 1 - 4 files changed, 3

[quagga-dev 16063] [PATCH 06/10] *: stop (re|ab)using lib/ MTYPEs

<equi...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_nexthop.c | 8 +--- isisd/isis_memory.c | 2 ++ isisd/isis_memory.h | 2 ++ isisd/isis_redist.c | 14 +++--- ospf6d/ospf6_interface.c | 10 ++ tests/heavy

[quagga-dev 16062] [PATCH 04/10] lib: migrate to new memory-type handling

From: David Lamparter <equi...@opensourcerouting.org> Move over to the new allocation counting added in the previous commit. (This is mostly mechanical.) Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.guib...@6wind

[quagga-dev 16068] [PATCH 10/10] build: goodbye, gawk

From: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.guib...@6wind.com> --- INSTALL.quagga.txt | 1 - configure.ac | 6 -- 2 files changed, 7 deleti

[quagga-dev 16060] [PATCH 02/10] lib: move memory.[ch] out of the way

From: David Lamparter <equi...@opensourcerouting.org> The following commit will recreate memory.[ch]. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.guib...@6wind.com> --- lib/Makefile.am | 8 +- lib/

[quagga-dev 16065] [PATCH 07/10] lib: distribute mtypes into files

From: David Lamparter <equi...@opensourcerouting.org> This places MTYPE definitions into the files where they're actually used, making most of them static in the process. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.gu

[quagga-dev 16061] [PATCH 03/10] lib: add new extensible memory-type handling

tartup. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.guib...@6wind.com> --- lib/Makefile.am | 1 + lib/log.c| 8 +++ lib/memory.c | 102 + lib/

[quagga-dev 16084] [PATCH 07/10] lib: distribute mtypes into files

From: David Lamparter <equi...@opensourcerouting.org> This places MTYPE definitions into the files where they're actually used, making most of them static in the process. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.gu

[quagga-dev 16078] [PATCH 02/10] lib: move memory.[ch] out of the way

From: David Lamparter <equi...@opensourcerouting.org> The following commit will recreate memory.[ch]. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.guib...@6wind.com> --- lib/Makefile.am | 8 +- lib/

[quagga-dev 16082] [PATCH 09/10] build: goodbye, memtypes.c

From: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.guib...@6wind.com> --- lib/.gitignore | 1 - lib/Makefile.am | 10 +++--- lib/memtypes.c | 16

[quagga-dev 16075] scrap & rewrite memtypes handling

Hi all, This series of patches has already been sent a few months ago by David Lamparter. I updated the patch to the latest quagga upstream, resent it. I also fixed some last issues related to previous post containing ( CI Testresult: FAILED (Re: [quagga-dev,16068,10/10] build: goodbye,

[quagga-dev 16080] [PATCH 04/10] lib: migrate to new memory-type handling

From: David Lamparter <equi...@opensourcerouting.org> Move over to the new allocation counting added in the previous commit. (This is mostly mechanical.) Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.guib...@6wind

[quagga-dev 16085] [PATCH 05/10] *: split & distribute memtypes

place to put the #include "zebra_memory.h" statement. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/Makefile.am | 2 + bgpd/bgp_community.c | 1 + bg

[quagga-dev 16083] [PATCH 10/10] build: goodbye, gawk

From: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.guib...@6wind.com> --- INSTALL.quagga.txt | 1 - configure.ac | 6 -- 2 files changed, 7 deleti

[quagga-dev 16079] [PATCH 06/10] *: stop (re|ab)using lib/ MTYPEs

<equi...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_nexthop.c | 8 +--- isisd/isis_memory.c | 2 ++ isisd/isis_memory.h | 2 ++ isisd/isis_redist.c | 14 +++--- ospf6d/ospf6_interface.c | 10 ++ tests/heavy

[quagga-dev 16081] [PATCH 08/10] lib: clean/restore memory debugging functions

qui...@opensourcerouting.org> Reviewed-by: Philippe Guibert <philippe.guib...@6wind.com> --- lib/memory.c | 35 ++ lib/memory.h | 1 + lib/memory_vty.c | 89 +--- lib/memory_vty.h | 1 - 4 files changed, 3

[quagga-dev 16130] BGP VRF Route Distinguisher configuration

Hi Quagga-dev, This series of patches introduces the ability for a BGP router, to configure a route distinguisher and associate import and export route targets. This permits for a BGP update to be sent with BGP extended communities associated to the exported route targets of the RD. This permits

[quagga-dev 16131] [PATCH 2/2] bgpd: vpnv4 af exports extended communities

If the user preconfigures a vrf with import and export rules, before creating a new network on vpnv4 address, then BGP update emitted will contain the exported rts mentioned by the vrf export rule. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_route.

[quagga-dev 16143] [PATCH v2 1/3] lib: 3byte stream foo

From: David Lamparter <equi...@opensourcerouting.org> API enhancement to be able to write and read 3 byte series in stream structures. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> ---

[quagga-dev 16142] BGP multiple label support

Hi Quagga-dev, This work is enhancing RFC3107 encoding format for label in BGP NLRI messages. This applies for instance to VPNv4 address family. It is to be noted that this commit does not bring any API enhancement regarding VTY configuration. However, the mecanic is ready to receive BGP updates

[quagga-dev 16186] [PATCH v3 2/3] bgpd: multiple label stack support

<equi...@opensourcerouting.org> Signed-off-by: Christian Franke <ch...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_attr.c| 29 --- bgpd/bgp_attr.h| 6 +-- bgpd/bgp_encap.c | 4 +-

[quagga-dev 16187] [PATCH v3 3/3] tests: enhance bgpd testing with label value

bgp NLRI has a specific format for label, terminating with bottom of stack bit. This value is updated in all BGP attribute tests. A specific test has been added to check for a list of labels contained in a single NLRI. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> ---

[quagga-dev 16185] [PATCH v3 1/3] lib: 3byte stream foo

From: David Lamparter <equi...@opensourcerouting.org> API enhancement to be able to write and read 3 byte series in stream structures. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> ---

[quagga-dev 16172] Re: scrap & rewrite memtypes handling

Hello quagga-dev, Paul, The patch has not been reviewed yet. Please, do not hesitate to push me any remarks so that I can adapt, or simply ack the modification. Best regards, Philippe On Thu, Sep 29, 2016 at 2:37 PM, Philippe Guibert < philippe.guib...@6wind.com> wrote: > Hi q

[quagga-dev 16173] Re: BGP VRF Route Distinguisher configuration

Hello quagga-dev, David, The patch has not been reviewed yet. Please, do not hesitate to push me any remarks so that I can adapt, or simply ack the patch. Thanks, Best regards, Philippe On Thu, Sep 29, 2016 at 4:30 PM, Philippe Guibert < philippe.guib...@6wind.com> wrote: > Hi Q

[quagga-dev 16176] [PATCH v2 2/3] bgpd: multiple label stack support

<equi...@opensourcerouting.org> Signed-off-by: Christian Franke <ch...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_attr.c| 27 +++--- bgpd/bgp_attr.h| 6 +-- bgpd/bgp_encap.c | 4 +-

[quagga-dev 16174] BGP multiple label support

Hi Quagga-dev, This work is enhancing RFC3107 encoding format for label in BGP NLRI messages. This applies for instance to VPNv4 address family. It is to be noted that this commit does not bring any API enhancement regarding VTY configuration. However, the mecanic is ready to receive BGP updates

[quagga-dev 16175] [PATCH v2 1/3] lib: 3byte stream foo

From: David Lamparter <equi...@opensourcerouting.org> API enhancement to be able to write and read 3 byte series in stream structures. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> ---

[quagga-dev 16177] [PATCH v2 3/3] tests: enhance bgpd testing with label value

bgp NLRI has a specific format for label, terminating with bottom of stack bit. This value is updated in all BGP attribute tests. A specific test has been added to check for a list of labels contained in a single NLRI. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> ---

[quagga-dev 16162] Re: [PATCH] Extend BGP_SEND_ASPATH_CHECK to cover confederations

On Thu, Sep 29, 2016 at 7:25 PM, Thorvald Natvig wrote: Hello Thorvald, > Extend the check for BGP_SEND_ASPATH_CHECK to also cover confederations. .. > -#endif /* BGP_SEND_ASPATH_CHECK */ > >/* If we're a CONFED we need to loop check the CONFED ID too */ >if

[quagga-dev 16118] [PATCH v2 04/11] lib: remove constructor reference

because some compilers do not use this feature, it is provided an API that forces the user to call its mem group and memtypes init. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- lib/memory.h | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-)

[quagga-dev 16119] [PATCH v2 03/11] lib: add new extensible memory-type handling

tartup. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- lib/Makefile.am | 1 + lib/log.c| 8 +++ lib/memory.c | 102 +++ lib/

[quagga-dev 16120] [PATCH v2 02/11] lib: move memory.[ch] out of the way

From: David Lamparter <equi...@opensourcerouting.org> The following commit will recreate memory.[ch]. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- lib/Makefile.am | 8 +- lib/

[quagga-dev 16124] [PATCH v2 11/11] lib: clean/restore memory debugging functions

qui...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- lib/memory.c | 35 ++ lib/memory.h | 1 + lib/memory_vty.c | 89 +--- lib/memory_vty.h | 1 - 4 files changed, 3

[quagga-dev 16122] [PATCH v2 05/11] lib: migrate to new memory-type handling

From: David Lamparter <equi...@opensourcerouting.org> Move over to the new allocation counting added in the previous commit. (This is mostly mechanical.) Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind

[quagga-dev 16125] [PATCH v2 08/11] *: declare and init mgroup and mtype for all lib/daemons

their own memory types and groups. In addition to this, as all daemons require usage of lib library, then the daemons also initialise the lib memory types and group entries. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_main.c | 2 + bgpd/bgp_memory.c

[quagga-dev 16121] [PATCH v2 07/11] *: stop (re|ab)using lib/ MTYPEs

<equi...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_nexthop.c | 8 +--- isisd/isis_memory.c | 2 ++ isisd/isis_memory.h | 2 ++ isisd/isis_redist.c | 14 +++--- ospf6d/ospf6_interface.c | 10 ++

[quagga-dev 16127] [PATCH v2 10/11] *: enhance memtype and memgroup generation across lib and daemons

within lib/and or daemons and describing the memory group and memory types. Note that this generator tool takes into account global memory declarations, but not static memory group and types defined inside specific .c files. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- .git

[quagga-dev 16126] [PATCH v2 06/11] *: split & distribute memtypes

place to put the #include "zebra_memory.h" statement. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/Makefile.am | 2 + bgpd/bgp_community.c | 1 + bg

[quagga-dev 16115] [PATCH 2/2] bgpd: multiple label stack support

<equi...@opensourcerouting.org> Signed-off-by: Christian Franke <ch...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_attr.c| 27 +++--- bgpd/bgp_attr.h| 6 +-- bgpd/bgp_encap.c | 4 +-

[quagga-dev 16114] BGP multiple label support

Hi Quagga-dev, This work is enhancing RFC3107 encoding format for label in BGP NLRI messages. This applies for instance to VPNv4 address family. It is to be noted that this commit does not bring any API enhancement regarding VTY configuration. However, the mecanic is ready to receive BGP updates

[quagga-dev 16113] [PATCH 1/2] lib: 3byte stream foo

From: David Lamparter <equi...@opensourcerouting.org> API enhancement to be able to write and read 3 byte series in stream structures. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> ---

[quagga-dev 16168] Re: [PATCH] Extend BGP_SEND_ASPATH_CHECK to cover confederations

3.0/24 does contain > the confed-id, so this route gets suppressed. > > All this patch does is make sure this second check, which is enabled > only for confederations, is covered by the same #define as the > non-confederation case. > > - Thorvald > > > On Mon, Oct 3, 20

[quagga-dev 16309] Re: [PATCH v2 1/2] bgpd: VRF vty configuration, RIB table creation

It would be possible to change configuration: instead of "vrf rd", one could have "rd <>". > PS I think an update to bgpd.texi is needed for this patch of course, this is something that can be done. Best Regards, Philippe > On 10/11/2016 4:17 AM, Philippe Guibert

[quagga-dev 16329] Re: [PATCH v2 1/2] bgpd: VRF vty configuration, RIB table creation

ets of RTs). BTW RRs only care about > this part. > > So keying a VPN/VRF off an RD just seems wrong, particularly for the > import case where RD is ignored. > > Lou > > On 10/19/2016 3:59 AM, Philippe Guibert wrote: >> On Tue, Oct 18, 2016 at 3:56 PM, Lou Berger <lb

[quagga-dev 16332] EVPN RFC Patch

Hi all, This thread is a starting point to discuss about Ethernet VPN implementation in Quagga BGP daemon. Currently, the RFC7432 is not supported in quagga 1.1.0. This email is a preparatory work to open discussion. It is also a preparatory work to propose the following EVPN implementation.

[quagga-dev 16331] Re: [PATCH v2 1/2] bgpd: VRF vty configuration, RIB table creation

On Fri, Oct 21, 2016 at 8:21 PM, Lou Berger wrote: Hello Lou, Thanks for your detailed response, I agree to configure the RD , and the RT set per VRF. However, I tried to make a counter proposal about the way to configure it. You will find it below. Your comments are welcome.

[quagga-dev 16337] [PATCH 02/57] bgpd: vpnv4 af exports extended communities

If the user preconfigures a vrf with import and export rules, before creating a new network on vpnv4 address, then BGP update emitted will contain the exported rts mentioned by the vrf export rule. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_route.

[quagga-dev 16349] [PATCH 19/57] vtysh: add support of address-family evpn

From: Julien Courtat Update extract.pl ignore list to prevent from installing address_family_evpn_cmd twice and have "Ambiguous command" return by vtysh when trying to configure address-family evpn. Signed-off-by: Julien Courtat ---

[quagga-dev 16336] [PATCH 03/57] tests: enhance bgpd testing with label value

bgp NLRI has a specific format for label, terminating with bottom of stack bit. This value is updated in all BGP attribute tests. A specific test has been added to check for a list of labels contained in a single NLRI. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> ---

[quagga-dev 16351] [PATCH 17/57] bgpd: basic support for EVPN

To handle BGP NLRI EVPN messages, bgp is modified to handle AFI_L2VPN and SAFI_EVPN values. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_attr.c | 25 ++- bgpd/bgp_open.c | 29 ++- bgpd/bgp_packet.

[quagga-dev 16342] [PATCH 11/57] bgpd: vty command for vrf maximum path configuration

From: Julien Courtat Enhancement of new vty command to configure the maximum number of multipath entries that are possible within a VRF RIB table. The following command is available: - vrf rd maximum-path <1-64> - no vrf rd maximum-path <1-64> Vrfs with a

[quagga-dev 16346] [PATCH 14/57] bgpd: sanity check against accessing invalid table pointer.

This sanity check has been discovered when running bgp mpath_tests that are available in tests folder. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_mpath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bgpd/bgp_mpath.c b/bgpd/bgp_mpath.c

[quagga-dev 16339] [PATCH 05/57] bgpd: multiple label stack support

<equi...@opensourcerouting.org> Signed-off-by: Christian Franke <ch...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_attr.c| 28 +++--- bgpd/bgp_attr.h| 6 +-- bgpd/bgp_encap.c | 4 +-

[quagga-dev 16353] [PATCH 20/57] bgpd: basic vty support for EVPN

for setting NLRI entries for EVPN. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_vty.c | 54 ++ lib/command.c | 3 +++ lib/command.h | 1 + lib/vty.c | 1 + vtysh/vtysh.c | 28 +++- 5

[quagga-dev 16341] [PATCH 10/57] bgpd: VRF RIB log updates enhancement

On adding/removing/updating NLRI entries into VRF RIB tables, a BGP event is fired. Note that only selected entries, and entries that are part of multipath entries, and where one of the multipath entry is selected. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_r

[quagga-dev 16347] [PATCH 15/57] bgpd: avoid looping when unselecting a list of mpath entries

sometimes, when electing best route algorithm, a static route may be injected, thus causing all old multipath entries to be removed from multipath list. As a loop is removing each mpath entry from mpath list, it is necessary to update the pointer. Signed-off-by: Philippe Guibert <philippe.g

[quagga-dev 16334] [PATCH 01/57] bgpd: VRF vty configuration, RIB table creation

it. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_route.c | 192 +++-- bgpd/bgp_route.h | 4 ++ bgpd/bgp_table.h | 3 + bgpd/bgp_v

[quagga-dev 16335] [PATCH 04/57] lib: 3byte stream foo

From: David Lamparter <equi...@opensourcerouting.org> API enhancement to be able to write and read 3 byte series in stream structures. Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> ---

[quagga-dev 16354] [PATCH 18/57] bgpd: bgp open graceful restart capability fix with mpls

If vpnv4 capability has to be sent, then the correct safi parameter is sent instead of internal value. In case BGP open graceful restart capability is applied to EVPN, then the flags to be set are modified to be official afi and safi parameters, and not internal value. Signed-off-by: Philippe

[quagga-dev 16338] [PATCH 07/57] bgpd: BGP VRF processing handling

NLRI entries received from MP-BGP peer exchange are exported in VRF RIB tables. This commit introduces the BGP VRF processing handler that can be used for further processing into VRF RIB tables: best selection algorithm, multipath. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.

[quagga-dev 16340] [PATCH 06/57] tests: fix BGP VRF interactions

From: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: David Lamparter <equi...@opensourcerouting.org> Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- tests/Makefile.am | 2 +- tests/bgp_mpath_test.c | 15 +++ 2 files changed, 1

[quagga-dev 16352] [PATCH 21/57] bgpd: safi_valid_indices ability to return internal afi identifier

Because afi numbers can reach high values, a conversion is necessary to return associate afi internal identifier. The safi_valid_indices API has been changed for that. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_open.c | 22 +++--- bgpd/bgp_

[quagga-dev 16343] [PATCH 08/57] bgpd: detect if bgp_info is multipath entry

Enhance a function that permits knowing if two entries belong to the same multipath group. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_mpath.c | 15 +++ bgpd/bgp_mpath.h | 1 + 2 files changed, 16 insertions(+) diff --git a/bgpd/bgp_mpath.c

[quagga-dev 16377] [PATCH 44/57] bgpd: MAC/IP advertisements have next hop attribute

When sending an EVPN MAC/IP attribute, the nexthop attribute is also appended. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_attr.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c index 2b57d6

[quagga-dev 16388] [PATCH 55/57] bgpd: show ip bgp vrf enhancements.

add vty command : show ipv6 bgp vrf [route] This command permits to dump IPv6 entries in VRF RIB filled by export RT facility. Type 1 route distinguishers are now supported by command show ip bgp vrf Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_route.

[quagga-dev 16389] [PATCH 57/57] bgpd: VRF adj rib in update

This commit appends or withdraw entries in ADJ-RIB-IN entries of VRF RIB tables. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_route.c | 45 + 1 file changed, 33 insertions(+), 12 deletions(-) diff --git a/bgpd/bgp_r

[quagga-dev 16384] [PATCH 52/57] bgpd: add VRF field layer type

From: Julien Courtat On VRF creation, an additionnal parameter layer type can be provided to distinguish between layer 2 and layer 3 vrf. layer 2 is used by EVPN when dealing with MAC/IP route advertisement. layer 3 is used by any other route L3VPN or EVPN route

[quagga-dev 16382] [PATCH 51/57] bgpd: avoid sending duplicated nlri attributed in bgp

When configuring MPLS or EVPN entries, the NLRI is duplicated. Which is not wished. Signed-off-by: Philippe Guibert <philippe.guib...@6wind.com> --- bgpd/bgp_attr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c index eb13e1

  1   2   >