Re: [qubes-devel] Why code review is hard

2022-02-13 Thread Holger Levsen
On Sun, Feb 13, 2022 at 11:52:53AM +0100, David Hobach wrote: > I never stated it is. It was just a general comment on code review and > bash in specific - especially since I'm aware that Qubes has a lot of > bash in sometimes security relevant places (qubes-dom0-update, qubes-rpc, > ...). ah,

Re: [qubes-devel] Why code review is hard

2022-02-13 Thread David Hobach
On 2/13/22 10:05, Holger Levsen wrote: On Sat, Feb 12, 2022 at 01:03:35PM +0100, David Hobach wrote: just stumbled across it and was wondering what a reviewer would expect from this code to do: [...] At least on my amchine it executes "badCode" in both domU and dom0. I might miss where you

Re: [qubes-devel] Why code review is hard

2022-02-13 Thread Frédéric Pierret
Hi, Le 2/13/22 à 10:05, Holger Levsen a écrit : On Sat, Feb 12, 2022 at 01:03:35PM +0100, David Hobach wrote: just stumbled across it and was wondering what a reviewer would expect from this code to do: [...] At least on my amchine it executes "badCode" in both domU and dom0. I might miss

Re: [qubes-devel] Why code review is hard

2022-02-13 Thread Holger Levsen
On Sat, Feb 12, 2022 at 01:03:35PM +0100, David Hobach wrote: > just stumbled across it and was wondering what a reviewer would expect from > this code to do: [...] > At least on my amchine it executes "badCode" in both domU and dom0. I might miss where you stumbled upon this, but how is this