Re: [Radiant] Odd behavior with copy_move and default_page_parts
On Tue, Feb 24, 2009 at 5:32 PM, Chaim Kirby wrote: > It is actually not a bug with copy_move I don't think. Rather it is a > byproduct of how default_page_parts is implemented. > I don't know the exact terminology, but the dpp extension modifies the > add_child template for and pages it is defined in. Unfortunately it is > naive so even if the tabs already exist in the child they get created > again. I assume the function gets triggered because copy_move just > automagically fires add_child calls. You are right, it's the default_page_parts extension, and it's the right behavior, but it's not what you need. Maybe we can add some options to make them work correctly together. > Chaim Kirby > chaim.ki...@childrens.harvard.edu > > Andrea Franz wrote: >> I'll try to fixit asap, maybe rewriting tests with rspec to be up to >> date with radiant. >> >> -- >> Andrea Franz >> http://gravityblast.com >> >> On 23/feb/09, at 21:42, "Chaim Kirby" >> wrote: >> >>> 1.9.1, Git rev. 79ee39addf4adabcf28fe77a8cb9cbf2338feda8 (The one that >>> works correctly with 0.6.9) >>> >>> Chaim >>> >>> chaim.ki...@childrens.harvard.edu >>> >>> >>> Andrea Franz wrote: Hi Chaim, which version of copy_move are you using? On Mon, Feb 23, 2009 at 8:23 PM, Chaim Kirby wrote: > Has anyone else run into this issue? I copied a tree of pages > using the > copy_move extension. Some of the pages use the default_page_parts > extension to define page parts of children. Some of the children > ended > up with duplicate page parts, where only one had content. > > example: > page_part_config > --- > - name: main > - name: highlight > > Expected child page in copied hierarchy: > Main(with content), Highlight(with content) > > > Actual child page in copied hierarchy: > Main, Highlight, Main(with content), Highlight(with content) > > Thanks, > Chaim > > chaim.ki...@childrens.harvard.edu > > ___ > Radiant mailing list > Post: Radiant@radiantcms.org > Search: http://radiantcms.org/mailing-list/search/ > Site: http://lists.radiantcms.org/mailman/listinfo/radiant > >>> >>> ___ >>> Radiant mailing list >>> Post: Radiant@radiantcms.org >>> Search: http://radiantcms.org/mailing-list/search/ >>> Site: http://lists.radiantcms.org/mailman/listinfo/radiant >> ___ >> Radiant mailing list >> Post: Radiant@radiantcms.org >> Search: http://radiantcms.org/mailing-list/search/ >> Site: http://lists.radiantcms.org/mailman/listinfo/radiant >> > > > ___ > Radiant mailing list > Post: Radiant@radiantcms.org > Search: http://radiantcms.org/mailing-list/search/ > Site: http://lists.radiantcms.org/mailman/listinfo/radiant > -- Andrea Franz http://gravityblast.com http://blog.mikamai.com ___ Radiant mailing list Post: Radiant@radiantcms.org Search: http://radiantcms.org/mailing-list/search/ Site: http://lists.radiantcms.org/mailman/listinfo/radiant
Re: [Radiant] Odd behavior with copy_move and default_page_parts
It is actually not a bug with copy_move I don't think. Rather it is a byproduct of how default_page_parts is implemented. I don't know the exact terminology, but the dpp extension modifies the add_child template for and pages it is defined in. Unfortunately it is naive so even if the tabs already exist in the child they get created again. I assume the function gets triggered because copy_move just automagically fires add_child calls. Chaim Kirby chaim.ki...@childrens.harvard.edu Andrea Franz wrote: > I'll try to fixit asap, maybe rewriting tests with rspec to be up to > date with radiant. > > -- > Andrea Franz > http://gravityblast.com > > On 23/feb/09, at 21:42, "Chaim Kirby" > wrote: > >> 1.9.1, Git rev. 79ee39addf4adabcf28fe77a8cb9cbf2338feda8 (The one that >> works correctly with 0.6.9) >> >> Chaim >> >> chaim.ki...@childrens.harvard.edu >> >> >> Andrea Franz wrote: >>> Hi Chaim, which version of copy_move are you using? >>> >>> On Mon, Feb 23, 2009 at 8:23 PM, Chaim Kirby >>> wrote: Has anyone else run into this issue? I copied a tree of pages using the copy_move extension. Some of the pages use the default_page_parts extension to define page parts of children. Some of the children ended up with duplicate page parts, where only one had content. example: page_part_config --- - name: main - name: highlight Expected child page in copied hierarchy: Main(with content), Highlight(with content) Actual child page in copied hierarchy: Main, Highlight, Main(with content), Highlight(with content) Thanks, Chaim chaim.ki...@childrens.harvard.edu ___ Radiant mailing list Post: Radiant@radiantcms.org Search: http://radiantcms.org/mailing-list/search/ Site: http://lists.radiantcms.org/mailman/listinfo/radiant >>> >>> >> >> ___ >> Radiant mailing list >> Post: Radiant@radiantcms.org >> Search: http://radiantcms.org/mailing-list/search/ >> Site: http://lists.radiantcms.org/mailman/listinfo/radiant > ___ > Radiant mailing list > Post: Radiant@radiantcms.org > Search: http://radiantcms.org/mailing-list/search/ > Site: http://lists.radiantcms.org/mailman/listinfo/radiant > ___ Radiant mailing list Post: Radiant@radiantcms.org Search: http://radiantcms.org/mailing-list/search/ Site: http://lists.radiantcms.org/mailman/listinfo/radiant
Re: [Radiant] Odd behavior with copy_move and default_page_parts
I'll try to fixit asap, maybe rewriting tests with rspec to be up to date with radiant. -- Andrea Franz http://gravityblast.com On 23/feb/09, at 21:42, "Chaim Kirby" wrote: 1.9.1, Git rev. 79ee39addf4adabcf28fe77a8cb9cbf2338feda8 (The one that works correctly with 0.6.9) Chaim chaim.ki...@childrens.harvard.edu Andrea Franz wrote: Hi Chaim, which version of copy_move are you using? On Mon, Feb 23, 2009 at 8:23 PM, Chaim Kirby wrote: Has anyone else run into this issue? I copied a tree of pages using the copy_move extension. Some of the pages use the default_page_parts extension to define page parts of children. Some of the children ended up with duplicate page parts, where only one had content. example: page_part_config --- - name: main - name: highlight Expected child page in copied hierarchy: Main(with content), Highlight(with content) Actual child page in copied hierarchy: Main, Highlight, Main(with content), Highlight(with content) Thanks, Chaim chaim.ki...@childrens.harvard.edu ___ Radiant mailing list Post: Radiant@radiantcms.org Search: http://radiantcms.org/mailing-list/search/ Site: http://lists.radiantcms.org/mailman/listinfo/radiant ___ Radiant mailing list Post: Radiant@radiantcms.org Search: http://radiantcms.org/mailing-list/search/ Site: http://lists.radiantcms.org/mailman/listinfo/radiant ___ Radiant mailing list Post: Radiant@radiantcms.org Search: http://radiantcms.org/mailing-list/search/ Site: http://lists.radiantcms.org/mailman/listinfo/radiant
Re: [Radiant] Odd behavior with copy_move and default_page_parts
1.9.1, Git rev. 79ee39addf4adabcf28fe77a8cb9cbf2338feda8 (The one that works correctly with 0.6.9) Chaim chaim.ki...@childrens.harvard.edu Andrea Franz wrote: > Hi Chaim, which version of copy_move are you using? > > On Mon, Feb 23, 2009 at 8:23 PM, Chaim Kirby > wrote: >> Has anyone else run into this issue? I copied a tree of pages using the >> copy_move extension. Some of the pages use the default_page_parts >> extension to define page parts of children. Some of the children ended >> up with duplicate page parts, where only one had content. >> >> example: >> page_part_config >> --- >> - name: main >> - name: highlight >> >> Expected child page in copied hierarchy: >> Main(with content), Highlight(with content) >> >> >> Actual child page in copied hierarchy: >> Main, Highlight, Main(with content), Highlight(with content) >> >> Thanks, >> Chaim >> >> chaim.ki...@childrens.harvard.edu >> >> ___ >> Radiant mailing list >> Post: Radiant@radiantcms.org >> Search: http://radiantcms.org/mailing-list/search/ >> Site: http://lists.radiantcms.org/mailman/listinfo/radiant >> > > > ___ Radiant mailing list Post: Radiant@radiantcms.org Search: http://radiantcms.org/mailing-list/search/ Site: http://lists.radiantcms.org/mailman/listinfo/radiant
Re: [Radiant] Odd behavior with copy_move and default_page_parts
Hi Chaim, which version of copy_move are you using? On Mon, Feb 23, 2009 at 8:23 PM, Chaim Kirby wrote: > Has anyone else run into this issue? I copied a tree of pages using the > copy_move extension. Some of the pages use the default_page_parts > extension to define page parts of children. Some of the children ended > up with duplicate page parts, where only one had content. > > example: > page_part_config > --- > - name: main > - name: highlight > > Expected child page in copied hierarchy: > Main(with content), Highlight(with content) > > > Actual child page in copied hierarchy: > Main, Highlight, Main(with content), Highlight(with content) > > Thanks, > Chaim > > chaim.ki...@childrens.harvard.edu > > ___ > Radiant mailing list > Post: Radiant@radiantcms.org > Search: http://radiantcms.org/mailing-list/search/ > Site: http://lists.radiantcms.org/mailman/listinfo/radiant > -- Andrea Franz http://gravityblast.com http://blog.mikamai.com ___ Radiant mailing list Post: Radiant@radiantcms.org Search: http://radiantcms.org/mailing-list/search/ Site: http://lists.radiantcms.org/mailman/listinfo/radiant
Re: [Radiant] Odd behavior with copy_move and default_page_parts
Using radiant 0.6.9 Chaim Kirby wrote: > Has anyone else run into this issue? I copied a tree of pages using the > copy_move extension. Some of the pages use the default_page_parts > extension to define page parts of children. Some of the children ended > up with duplicate page parts, where only one had content. > > example: > page_part_config > --- > - name: main > - name: highlight > > Expected child page in copied hierarchy: > Main(with content), Highlight(with content) > > > Actual child page in copied hierarchy: > Main, Highlight, Main(with content), Highlight(with content) > > Thanks, > Chaim > > chaim.ki...@childrens.harvard.edu > > ___ > Radiant mailing list > Post: Radiant@radiantcms.org > Search: http://radiantcms.org/mailing-list/search/ > Site: http://lists.radiantcms.org/mailman/listinfo/radiant > ___ Radiant mailing list Post: Radiant@radiantcms.org Search: http://radiantcms.org/mailing-list/search/ Site: http://lists.radiantcms.org/mailman/listinfo/radiant
[Radiant] Odd behavior with copy_move and default_page_parts
Has anyone else run into this issue? I copied a tree of pages using the copy_move extension. Some of the pages use the default_page_parts extension to define page parts of children. Some of the children ended up with duplicate page parts, where only one had content. example: page_part_config --- - name: main - name: highlight Expected child page in copied hierarchy: Main(with content), Highlight(with content) Actual child page in copied hierarchy: Main, Highlight, Main(with content), Highlight(with content) Thanks, Chaim chaim.ki...@childrens.harvard.edu ___ Radiant mailing list Post: Radiant@radiantcms.org Search: http://radiantcms.org/mailing-list/search/ Site: http://lists.radiantcms.org/mailman/listinfo/radiant
