Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-07-01 Thread Hartmaier Alexander
Hi Heikki, On 2016-06-29 12:41, Heikki Vatiainen wrote: > On 28.6.2016 11.24, Hartmaier Alexander wrote: > >> Tue Jun 28 08:18:50 2016: DEBUG: ServerTACACSPLUS: New connection from >> 1.2.3.4:11422 >> Tue Jun 28 08:18:50 2016: ERR: Could not get peer name on >> TacacsplusConnection socket:

Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-06-29 Thread Heikki Vatiainen
On 28.6.2016 11.24, Hartmaier Alexander wrote: > Tue Jun 28 08:18:50 2016: DEBUG: ServerTACACSPLUS: New connection from > 1.2.3.4:11422 > Tue Jun 28 08:18:50 2016: ERR: Could not get peer name on > TacacsplusConnection socket: Transport endpoint is not connected > Tue Jun 28 08:18:50 2016: DEBUG:

Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-06-28 Thread Hartmaier Alexander
On 2016-06-24 13:57, Heikki Vatiainen wrote: > On 24.06.2016 14:08, Hartmaier Alexander wrote: > >>> We also thought about further improvements for unexpectedly closed >>> connections so that they can be logged and handled more easily. However, >>> this is the first step before doing further

Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-06-24 Thread Heikki Vatiainen
On 24.06.2016 14:08, Hartmaier Alexander wrote: >> We also thought about further improvements for unexpectedly closed >> connections so that they can be logged and handled more easily. However, >> this is the first step before doing further changes. > We still get the 'Could not get peer name on

Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-06-24 Thread Hartmaier Alexander
Hi Heikki, On 2016-06-21 12:58, Heikki Vatiainen wrote: > On 13.06.2016 10:27, Hartmaier Alexander wrote: > >>> I also noticed that we can get the peer IP and port from accept directly >>> instead of calling getpeername(). What is done now is to check accept >>> return value for success and call

Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-06-21 Thread Heikki Vatiainen
On 13.06.2016 10:27, Hartmaier Alexander wrote: >> I also noticed that we can get the peer IP and port from accept directly >> instead of calling getpeername(). What is done now is to check accept >> return value for success and call getpeername() immediately after that. > I haven't seen that

Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-06-13 Thread Hartmaier Alexander
Hi Heikki, On 2016-06-10 09:39, Heikki Vatiainen wrote: > On 8.6.2016 11.28, Hartmaier Alexander wrote: > >>> Hmm, do you get these often? Also, does your configuration have FarmSize >>> enabled? This error occurs very early after the new connection has been >>> accepted. The code tries to figure

Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-06-10 Thread Heikki Vatiainen
On 8.6.2016 11.28, Hartmaier Alexander wrote: >> Hmm, do you get these often? Also, does your configuration have FarmSize >> enabled? This error occurs very early after the new connection has been >> accepted. The code tries to figure out the address and port of the >> client, but getpeername

Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-06-08 Thread Hartmaier Alexander
On 2016-05-31 15:24, Heikki Vatiainen wrote: > On 31.5.2016 12.57, Hartmaier Alexander wrote: > - Could not get peer name on TacacsplusConnection socket: Transport endpoint is not connected >>> Hmm, that's happening very early withing server tacacsplus, so there's >>> no request, client,

Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-05-31 Thread Heikki Vatiainen
On 31.5.2016 12.57, Hartmaier Alexander wrote: >>> - Could not get peer name on TacacsplusConnection socket: Transport >>> endpoint is not connected >> Hmm, that's happening very early withing server tacacsplus, so there's >> no request, client, etc is available yet. Improvements here may be >>

Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-05-31 Thread Hartmaier Alexander
On 2016-05-30 11:31, Heikki Vatiainen wrote: > On 27.5.2016 16.04, Hartmaier Alexander wrote: > >> The log messages emitted by ServerTACACSPLUS sadly lack all the standard >> Radius attributes like Handler:Identifier, User-Name, Client-Identifier etc. >> Is there a way to improve this situation?

Re: [RADIATOR] ServerTACACSPLUS logging improvements

2016-05-30 Thread Heikki Vatiainen
On 27.5.2016 16.04, Hartmaier Alexander wrote: > The log messages emitted by ServerTACACSPLUS sadly lack all the standard > Radius attributes like Handler:Identifier, User-Name, Client-Identifier etc. > Is there a way to improve this situation? We can, and have already thought about, adding $p