[Rails-core] Re: Auto-generated find queries adding bogus WHERE clauses

2006-02-10 Thread Matthew Palmer
[Please respect MFT to rails-core; I think most of the discussion of this, if any, will be more topical there] On Fri, Feb 10, 2006 at 01:33:32PM +1100, Matthew Palmer wrote: > class Collection << ActiveRecord::Base > def findpkg > self.repositories.each do |r| > p = r.packages.find(:a

RE: [Rails-core] [3795] render_component doesn't work with modules?

2006-02-10 Thread Nathaniel S. H. Brown
I originally tried the render_component 'admin/blog', when viewing a page within the 'admin/someothercontroller', and had the same issue. When I did further tests, I found that both 'admin/blog' and '/admin/blog' replicated the same error abut the inflector. I haven't tried with edge, but was plan

Re: [Rails-core] Quoting table and column names inside AR

2006-02-10 Thread Michael Koziarski
> While you're giving thought to that, what are your thoughts on renaming the > quote method inside of AR:B? Quite a few tickets come through for that as > well. Unfortunately we have a lot of people calling the quote method from plugins, custom code etc. We can't rename it without breaking backw

Re: [Rails-core] Date Helper Mega Patch

2006-02-10 Thread Michael Koziarski
> They all have to do with the Date Helper. > > * Support index and/or @auto_index > * Enable discard year > * time_select (alias to datetime_select with previous patch applied) > * Unique id's as per w3c spec > * :order for datetime_select to mimic date_select :order option > * add :include_second

[Rails-core] Date Helper Mega Patch

2006-02-10 Thread Bob Silva
Hi guys, I'm going to start work on a mega-patch to close the following tickets: 1260 1050 847 1427 2089 2655 2998 2833 1382 363 1782 and a new one that's only 6 hours old: 3800 They all have to do with the Date Helper. * Support index and/or @auto_index * Enable discard year * time_select (al

Re: [Rails-core] Be a hero: Convert Active Record fixtures to schema.rb

2006-02-10 Thread Michael Schoen
Is there a way to make the schema dumper aware of synonyms? Should be, I'll take a look at that. ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core

RE: [Rails-core] Quoting table and column names inside AR

2006-02-10 Thread Bob Silva
I've learned to just not use reserved names in my models, but since the databases allow quoting of names to get around this limitation, I don't see why Rails shouldn't allow for it as well. The question is in implementation. I would think an AR configuration variable would be best since there is a

Re: [Rails-core] Quoting table and column names inside AR

2006-02-10 Thread Wilson Bilkovich
On 2/10/06, Bob Silva <[EMAIL PROTECTED]> wrote: > > There are quite a few tickets asking for quoted table names and field names > to enable reserved words as table or column names. > > What is the general consensus regarding this issue? > Is there a downside, other than the effort of making the c

[Rails-core] Quoting table and column names inside AR

2006-02-10 Thread Bob Silva
There are quite a few tickets asking for quoted table names and field names to enable reserved words as table or column names. What is the general consensus regarding this issue?     Bob Silva http://www.railtie.net/   ___ Rails-core

Re: [Rails-core] AR Unit Tests

2006-02-10 Thread Michael Koziarski
On 2/11/06, Bob Silva <[EMAIL PROTECTED]> wrote: > Whew! Gotta find those debugging switches a little faster next time. > > Wasn't able to track down why, but aaa_create_tables.rb tests weren't being > run first. In my case, instead of the file name determining the order of > things, the class name

Re: [Rails-core] anyone in a committing mood?

2006-02-10 Thread David Heinemeier Hansson
> Would a similar approach be helpful for the new OpenBase adapter (ticket > #3538)? I'm guessing it hasn't even been looked at because of the overhead > in getting your system ready to test it...install new bindings...install > openbase... That'd be a great idea. It definitely helps us with conf

Re: [Rails-core] Be a hero: Convert Active Record fixtures to schema.rb

2006-02-10 Thread Wilson Bilkovich
On 2/10/06, Michael Schoen <[EMAIL PROTECTED]> wrote: > > Is this possible for systems (like Oracle) that don't have schema dump > > support yet? > > ..or did I miss some breaking news somewhere? > > I believe Oracle supports all the migrations methods now. If I've missed > something please let me

Re: [Rails-core] anyone in a committing mood?

2006-02-10 Thread Derrick Spell
On Feb 10, 2006, at 2:49 PM, David Heinemeier Hansson wrote:If it would help I can bundle them all up into a single patch, just letme know. It would. Please do roll them all up into 1 patch and get a fewOracle'ers to try that out. If you could get them to comment on thisnew ticket with "+1 works fo

Re: [Rails-core] anyone in a committing mood?

2006-02-10 Thread David Heinemeier Hansson
> If it would help I can bundle them all up into a single patch, just let > me know. It would. Please do roll them all up into 1 patch and get a few Oracle'ers to try that out. If you could get them to comment on this new ticket with "+1 works for me", then that'd be great. Thanks! -- David Heinem

Re: [Rails-core] anyone in a committing mood?

2006-02-10 Thread Michael Schoen
I punted on the oracle patches. But 3611 is in now. Sorry for the delay in getting back to you. Thanks for that. Can somebody handle the Oracle patches? They're all fairly trivial. #3210 will likely get another pass, as the current patch works for some folks, doesn't help for others. If it

Re: [Rails-core] Be a hero: Convert Active Record fixtures to schema.rb

2006-02-10 Thread Michael Schoen
Is this possible for systems (like Oracle) that don't have schema dump support yet? ..or did I miss some breaking news somewhere? I believe Oracle supports all the migrations methods now. If I've missed something please let me know. ___ Rails-core m

Re: [Rails-core] XSS prevention with Rails

2006-02-10 Thread Dave Teare
Has there been any progress on this? I have an OWASP compliance review @ my day job and would like something like this to point to. Thanks! On Monday, January 09, 2006, at 8:56 PM, Florian Weber wrote: >> Have a look at TextHelper#sanitize and go from there. >> http://ha.ckers.org/xss.html has a

[Rails-core] Sybase adapter association dates

2006-02-10 Thread John Sheets
I'm trying to clean up my Sybase adapter patch (http://dev.rubyonrails.org/ticket/3765) and I keep tripping over a puzzling hurdle. I can get all the unit tests to pass in stable and (with a few minor tweaks) in trunk, but in both cases I have to special-case the date assert in associations_test.r

RE: [Rails-core] AR Unit Tests

2006-02-10 Thread Bob Silva
Whew! Gotta find those debugging switches a little faster next time. Wasn't able to track down why, but aaa_create_tables.rb tests weren't being run first. In my case, instead of the file name determining the order of things, the class name would determine the order. So I renamed the class to AAAC

RE: [Rails-core] AR Unit Tests

2006-02-10 Thread Bob Silva
The problem with the taggings table is that aaa_create_tables isn't the first test that is run (on linux at least). On that note, is it the best design to have a test dependent on another test? associations_join_model_test is dependent on aaa_create_tables running before it. Still working on reso

Re: [Rails-core] [3795] render_component doesn't work with modules?

2006-02-10 Thread Trevor Squires
Rick, I'm not sure that changeset is the issue. As I said before, a *leading* slash will give you problems. If you look at the stack trace (assuming I'm recreating Nathaniel's problem correctly) it says the error is thrown in Inflector#constantize. That bit of code expressly *forbids* le

Re: [Rails-core] [3795] render_component doesn't work with modules?

2006-02-10 Thread Rick Olson
On 2/10/06, Trevor Squires <[EMAIL PROTECTED]> wrote: > Hi Nathaniel, > > I'm using a version of edge (not the most recent, but after module > namespace support was improved) and I use render_component into a > module namespace quite extensively with no problems. > > I know you said you "nailed it

Re: [Rails-core] [3795] render_component doesn't work with modules?

2006-02-10 Thread Trevor Squires
Hi Nathaniel, I'm using a version of edge (not the most recent, but after module namespace support was improved) and I use render_component into a module namespace quite extensively with no problems. I know you said you "nailed it down to having a '/' in the controller" but are you sure i

RE: [Rails-core] AR Unit Tests

2006-02-10 Thread Bob Silva
Hi Lars, Glad to see those errors, it's EXACTLY the same output I receive. If you run tests again, all the taggings errors disappear though. Bob Silva http://www.railtie.net/ > -Original Message- > From: [EMAIL PROTECTED] [mailto:rails-core- > [EMAIL PROTECTED] On Behalf Of Lars Pind > S

Re: [Rails-core] AR Unit Tests

2006-02-10 Thread Lars Pind
I'm seeing the same on OS X. I just upgraded from MySQL 4.1 to 5.0 (mysql-standard-5.0.18-osx10.4-powerpc), and ruby from 1.8.2 to 1.8.4 (ruby 1.8.4 (2005-12-24) [powerpc-darwin8.4.0]) just to make sure that wasn't the cause. It wasn't. This is the status: 701 tests, 2210 assertions, 3 fai

Re: [Rails-core] AR Unit Tests

2006-02-10 Thread Jakob Skjerning
Wilson Bilkovich wrote: This is a test I wrote. I don't use MySQL, unfortunately, so I can only hope that I got the definition syntax right. This is what is in the mysql.sql file.. is this correct? Sure is: mysql> CREATE TABLE `legacy_things` ( -> `id` int(11) NOT NULL auto_increment,

Re: [Rails-core] AR Unit Tests

2006-02-10 Thread Wilson Bilkovich
On 2/10/06, Bob Silva <[EMAIL PROTECTED]> wrote: > > test_lock_column_name_existing(LockingTest): > > ActiveRecord::StatementInvalid: Mysql::Error: #42S02Table > 'activerecord_unittest.legacy_things' doesn't exist: DELETE > FROM legacy_things This is a test I wrote. I don't use MySQL, unfortunate

RE: [Rails-core] [3795] render_component doesn't work with modules?

2006-02-10 Thread Nathaniel S. H. Brown
Just nailed it down to having a "/" in the controller. If you even trying: render_component :controller => "/blog", :action => "list" It will produce an error saying it cant find ::Blog -Nb ~ Nathaniel S. H. Brown

Re: [Rails-core] Be a hero: Convert Active Record fixtures to schema.rb

2006-02-10 Thread Wilson Bilkovich
On 2/10/06, David Heinemeier Hansson <[EMAIL PROTECTED]> wrote: > I've started for a few new tests to use schema.rb instead of creating > a gazillion changes to all the db-specific .sql files. Great stuff. > But it would be even greater if ALL of the db-specific fixtures were > replaced by entries

[Rails-core] [3795] render_component doesn't work with modules?

2006-02-10 Thread Nathaniel S. H. Brown
I just submitted a bug report for the render_component not being able to properly find the modules. I did a pretty detailed search, and wasn't able to find anything in the tracker. Is this something you guys are already aware of ? http://dev.rubyonrails.org/ticket/3795 -Nb ~

Re: [Rails-core] Multithreaded script/runner

2006-02-10 Thread Tom Ward
I've been using the pooled adapter on some installations without any obvious problems, but not running against rails 1.0. I know that some changes were made in #428 that may affect the pool. I'll take a look at the code I wrote over the weekend, and see how it looks against 1.0 and trunk. I'll co

Re: [Rails-core] Still trying to get pagination fixed.. STILLhavethis ActiveRecord connection helper thingy pending

2006-02-10 Thread Tom Ward
On 2/9/06, Michael Koziarski <[EMAIL PROTECTED]> wrote: > * notests - For patches submitted without unittests > > These should also be marked XPATCH, because barring exceptional > circumstances (or trivial fixes) we don't apply patches which don't > include tests. Going through and marking untest