[Rails-core] MySQL doesnt close connections

2006-03-01 Thread Bob Silva
Trying to track it down now, but I svn up’d right after running successful tests, and running the tests again runs until mysql reaches its connection limit and all further tests fail with too many connections errors. I’ve verified that the connections aren’t getting closed with mysqladmin p

Re: [Rails-core] reloadable classes for other base classes than the built-ins

2006-03-01 Thread Jon Tirsen
On 3/2/06, Michael Koziarski <[EMAIL PROTECTED]> wrote: > On 3/2/06, Jon Tirsen <[EMAIL PROTECTED]> wrote: > > I'm working on the plugin for RBatis and a new little thing I'm toying > > around with called ActiveMessaging (sorry, David I stole the name from > > you from the TW AwayDay ;-)). Anyway,

Re: [Rails-core] Rails 1.1 is coming

2006-03-01 Thread John Sheets
On Mar 1, 2006, at 7:17 PM, David Heinemeier Hansson wrote: If at all possible, please do setup some form of automated testing for this adapter. Say a script that checks out Active Record once a day/week, runs the tests, and emails you if something is b0rked. That'd give us the confidence that th

Re: [Rails-core] reloadable classes for other base classes than the built-ins

2006-03-01 Thread Trevor Squires
Jon, do the new Reloadable and Reloadable::Subclasses modules in edge rails (and I assume to be included in 1.1) help you? Regards, Trevor -- Trevor Squires http://somethinglearned.com On 1-Mar-06, at 8:00 PM, Jon Tirsen wrote: I'm working on the plugin for RBatis and a new little thing

Re: [Rails-core] reloadable classes for other base classes than the built-ins

2006-03-01 Thread Michael Koziarski
On 3/2/06, Jon Tirsen <[EMAIL PROTECTED]> wrote: > I'm working on the plugin for RBatis and a new little thing I'm toying > around with called ActiveMessaging (sorry, David I stole the name from > you from the TW AwayDay ;-)). Anyway, in both these applications I > want to be able to have reloadabl

[Rails-core] reloadable classes for other base classes than the built-ins

2006-03-01 Thread Jon Tirsen
I'm working on the plugin for RBatis and a new little thing I'm toying around with called ActiveMessaging (sorry, David I stole the name from you from the TW AwayDay ;-)). Anyway, in both these applications I want to be able to have reloadable classes that don't extend any of the standard built in

RE: [Rails-core] Converting AR Test Suite to use AR::Schema -Feedback needed

2006-03-01 Thread Bob Silva
> create_table :subscribers, :primary_key => :nick do |t| > ... > end Unless I'm being a total idiot in reading the code, this creates an integer based primary key column and doesn't allow an arbitrary primary key column like in the example I provided. Bob Silva http://www.railtie.net/ > -

Re: [Rails-core] Should child callbacks call their parents

2006-03-01 Thread Adam Ballai
Rick Olson wrote: On 3/1/06, Adam Ballai <[EMAIL PROTECTED]> wrote: Rick Olson wrote: Perhaps plugins shouldn't be defining those methods, and instead use the callback class methods: class Foo < AR::Base before_save :do_this_one_last_thing protected def do_this_one_last_thing

Re: [Rails-core] Converting AR Test Suite to use AR::Schema - Feedback needed

2006-03-01 Thread Corey Donohoe
On 3/1/06, Bob Silva <[EMAIL PROTECTED]> wrote: > Hi, > > I'm working on converting the test suite over to AR::Schema. > I'm finding there are a lot of barriers to doing this due to somewhat > limited customization support in AR::Schema. > > Here are some ideas (some implemented already) to extend

Re: [Rails-core] New version of AWS aggregated patch

2006-03-01 Thread David Heinemeier Hansson
> I've create a new ticket #4038 and uploaded a new patch with test cases. Smashing work, Kent. As a last thing, could I get you to write a summary of all the fixes that have been made? Preferably even as a patch to the CHANGELOG file for AWS if you want to make it real easy to apply ;) -- David H

Re: [Rails-core] Rails 1.1 is coming

2006-03-01 Thread David Heinemeier Hansson
> Okay, finally got it cleaned up and working against recent trunk. The patch Great work, John! It has been applied. If at all possible, please do setup some form of automated testing for this adapter. Say a script that checks out Active Record once a day/week, runs the tests, and emails you if s

Re: [Rails-core] Converting AR Test Suite to use AR::Schema - Feedback needed

2006-03-01 Thread Benjamin Curtis
+1 for also paying attention to primary_key_prefix_type when creating primary keys. :) On Mar 1, 2006, at 4:08 PM, Bob Silva wrote: Hi, I'm working on converting the test suite over to AR::Schema. I'm finding there are a lot of barriers to doing this due to somewhat limited customization sup

Re: [Rails-core] Rails 1.1 is coming

2006-03-01 Thread John Sheets
On Feb 26, 2006, at 2:08 PM, David Heinemeier Hansson wrote:How about the Sybase connection adapter?  Any chance of getting thatinto 1.1?  I can update the patch against the latest trunk andresubmit if that'll help.  The patch only touches test code and addsa single new application source file, syb

[Rails-core] Converting AR Test Suite to use AR::Schema - Feedback needed

2006-03-01 Thread Bob Silva
Hi, I'm working on converting the test suite over to AR::Schema. I'm finding there are a lot of barriers to doing this due to somewhat limited customization support in AR::Schema. Here are some ideas (some implemented already) to extend AR::Schema, but still keep it (relatively) true to its origi

Re: [Rails-core] Make a daemon and have him behave!

2006-03-01 Thread David Heinemeier Hansson
> Cant we just reset RAILS_ROOT to be an absolute path? This way paths will > be still valid after chdir(). Bit late for me here for such experiments > but will try it tomorrow. Please do give it a shot. It'd be great to have a no-brain easy way of getting daemons running with Rails. -- David Hein

Re: [Rails-core] Should child callbacks call their parents

2006-03-01 Thread Rick Olson
On 3/1/06, Adam Ballai <[EMAIL PROTECTED]> wrote: > Rick Olson wrote: > > Perhaps plugins shouldn't be defining those methods, and instead use > > the callback class methods: > > > > class Foo < AR::Base > > before_save :do_this_one_last_thing > > > > protected > > def do_this_one_last_thing

Re: [Rails-core] Edge + Webrick + Helloworld now fails

2006-03-01 Thread Michael Schoen
Stefan Kaes wrote: Stefan Kaes wrote: Please try http://dev.rubyonrails.org/attachment/ticket/3979/connection_cache_bug.patch This should fix all problems. Please use http://dev.rubyonrails.org/attachment/ticket/3979/connection_cache_bug2.patch Patch works for me, thanks. And it turns o

Re: [Rails-core] Make a daemon and have him behave!

2006-03-01 Thread Dee Zsombor
David Heinemeier Hansson wrote: >> True these where all hackish in a certain way: I've loaded the classes >> before forking, by setting a in a central model class before any db calls >> are made. Also the RAILS_ROOT will be useless after you've chdir()-ed to >> root. > > Verdammt. Is there no way

Re: [Rails-core] Should child callbacks call their parents

2006-03-01 Thread Adam Ballai
Rick Olson wrote: Perhaps plugins shouldn't be defining those methods, and instead use the callback class methods: class Foo < AR::Base before_save :do_this_one_last_thing protected def do_this_one_last_thing end end Otherwise, this could cause issues for someone overwriting a parent's

Re: [Rails-core] Make a daemon and have him behave!

2006-03-01 Thread David Heinemeier Hansson
> True these where all hackish in a certain way: I've loaded the classes > before forking, by setting a in a central model class before any db calls > are made. Also the RAILS_ROOT will be useless after you've chdir()-ed to > root. Verdammt. Is there no way to make a daemon without doing all this

Re: [Rails-core] New version of AWS aggregated patch

2006-03-01 Thread Kent Sibilev
David, I've create a new ticket #4038 and uploaded a new patch with test cases. -- Kent On 3/1/06, David Heinemeier Hansson <[EMAIL PROTECTED]> wrote: > > It sounds like a good plan. Do you want me to do that? > > Please, that'd be great. ___ Rails-c

Re: [Rails-core] assigns() method disappeared from test_process.rb

2006-03-01 Thread Kevin Clark
Fixed in changeset 3725 (http://dev.rubyonrails.org/changeset/3725) On 3/1/06, James Adam <[EMAIL PROTECTED]> wrote: > I just noticed that the assigns() method has been dropped from > action_controller/test_process.rb > (http://dev.rubyonrails.org/changeset/3724). Was this an oversight or > is the

Re: [Rails-core] Should child callbacks call their parents

2006-03-01 Thread Rick Olson
On 3/1/06, Adam Ballai <[EMAIL PROTECTED]> wrote: > The subject asks the question. > > Should child callbacks call their parents in STI design models? > Right now they don't and it was causing a headache as we needed to audit > in the parent(ie: acts_as_auditable) and another plugin the child, > sp

[Rails-core] Should child callbacks call their parents

2006-03-01 Thread Adam Ballai
The subject asks the question. Should child callbacks call their parents in STI design models? Right now they don't and it was causing a headache as we needed to audit in the parent(ie: acts_as_auditable) and another plugin the child, specific to the scope of only that class(ie: acts_as_ldapabl

Re: [Rails-core] AWS issue > r3630

2006-03-01 Thread Michael Schoen
I ran in exactly the same problem and found the cause: The SOAP request was redirected because of a configuration problem and some HTML was returned. That HTML did not get through the response parser, what is no surprise. Yep, in my case it was a result of some routing issue, that got caught in

Re: [Rails-core] Make a daemon and have him behave!

2006-03-01 Thread Dee Zsombor
David Heinemeier Hansson wrote: > So I added Kernel#daemonize yesterday thinking that I was going to > summon one for a book store application I've been getting real with, > but it did not go too well. Basically, as soon as I daemonize, I loose > the right to rely on auto-class instantiation and th

[Rails-core] assigns() method disappeared from test_process.rb

2006-03-01 Thread James Adam
I just noticed that the assigns() method has been dropped from action_controller/test_process.rb (http://dev.rubyonrails.org/changeset/3724). Was this an oversight or is there a new process for working with controller instance variables? -- * J * ~ ___

Re: [Rails-core] Edge + Webrick + Helloworld now fails

2006-03-01 Thread Stefan Kaes
Stefan Kaes wrote: Please try http://dev.rubyonrails.org/attachment/ticket/3979/connection_cache_bug.patch This should fix all problems. Please use http://dev.rubyonrails.org/attachment/ticket/3979/connection_cache_bug2.patch some private methods had to be changed to public to satisfy AR t

[Rails-core] Make a daemon and have him behave!

2006-03-01 Thread David Heinemeier Hansson
So I added Kernel#daemonize yesterday thinking that I was going to summon one for a book store application I've been getting real with, but it did not go too well. Basically, as soon as I daemonize, I loose the right to rely on auto-class instantiation and the database connection is fuxored. Could

Re: [Rails-core] New version of AWS aggregated patch

2006-03-01 Thread David Heinemeier Hansson
> It sounds like a good plan. Do you want me to do that? Please, that'd be great. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrai

Re: [Rails-core] New version of AWS aggregated patch

2006-03-01 Thread David Heinemeier Hansson
> That is exaclty want I'm working on right now :). I'll send a new > patch when all tests are done. Excellent, thanks. Let's make sure the new patch goes on a ticket so we have the public record. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.c

Re: [Rails-core] New version of AWS aggregated patch

2006-03-01 Thread Kent Sibilev
On 3/1/06, David Heinemeier Hansson <[EMAIL PROTECTED]> wrote: > > Can somebody from the core team take a look at this patch and comment or > > apply? > > Also, let's open a new ticket for this mega patch and close down the others. > -- It sounds like a good plan. Do you want me to do that? --

Re: [Rails-core] New version of AWS aggregated patch

2006-03-01 Thread Kent Sibilev
That is exaclty want I'm working on right now :). I'll send a new patch when all tests are done. -- Kent On 3/1/06, David Heinemeier Hansson <[EMAIL PROTECTED]> wrote: > > Can somebody from the core team take a look at this patch and comment or > > apply? > > One thing that immediately strikes

Re: [Rails-core] rake clear_logs backwards-compatibility problem

2006-03-01 Thread David Heinemeier Hansson
> Works against rev 3706. Looks like it was broken in 3713. Thanks, fixed. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com

Re: [Rails-core] New version of AWS aggregated patch

2006-03-01 Thread David Heinemeier Hansson
> Can somebody from the core team take a look at this patch and comment or > apply? Also, let's open a new ticket for this mega patch and close down the others. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management h

Re: [Rails-core] New version of AWS aggregated patch

2006-03-01 Thread David Heinemeier Hansson
> Can somebody from the core team take a look at this patch and comment or > apply? One thing that immediately strikes me is: Where are all the tests? It's hard to have strong confidence in patches fixing this many things without test coverage. Could you have a look at adding some tests to ensure

Re: [Rails-core] Rails 1.1 is coming

2006-03-01 Thread David Heinemeier Hansson
> Supports use as either "oci" or "oracle". Applied. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application fra

[Rails-core] rake clear_logs backwards-compatibility problem

2006-03-01 Thread Wilson Bilkovich
This works: C:\rails\spending_plan>rake log:clear (in C:/rails/spending_plan) ..but this doesn't: C:\rails\spending_plan>rake clear_logs (in C:/rails/spending_plan) rake aborted! Don't know how to build task 'logs:clear' (See full trace by running task with --trace) Works against rev 3706. Looks

Re: [Rails-core] AWS issue > r3630

2006-03-01 Thread Norman Timmler
Am Montag, den 27.02.2006, 11:35 -0800 schrieb Michael Schoen: > In some rev after 3630, starting to run into an ActionWebService issue. > I remember some recent thread (I think on rails-core) that mentioned > something about an issue with a #parent method, but I can't find that > thread. > > I

Re: [Rails-core] issue with unit tests for AR calculations

2006-03-01 Thread John Sheets
> Hi everyone, thanks for the heads-up. Try this patch: > > http://dev.rubyonrails.org/attachment/ticket/4016/calc.2.diff Hey Rick, I tried that patch against the Sybase adapter and it fixes things perfectly. Thumbs up on my side for a commit. Thanks for the quick turnaround! John _

Re: [Rails-core] 3707 breaks my unit tests

2006-03-01 Thread Wilson Bilkovich
On 3/1/06, Michael Schoen <[EMAIL PROTECTED]> wrote: > Michael Schoen wrote: > > Wilson Bilkovich wrote: > >> 3706 is good, 3707 kills them. > > > > I'm also getting something odd after 3707, don't know exactly what it is > > yet. > > Ok, found my problem, not sure if it's the same as yours -- lock

Re: [Rails-core] Database Adapter Plugin

2006-03-01 Thread John Sheets
On Feb 28, 2006, at 8:04 PM, Derrick Spell wrote: * LIMIT and OFFSET are broken in OpenBase. And actually, the tests expecting 0 results when using LIMIT 0 will always fail. The guys at OpenBase feel that LIMIT 0 should be equivalent to not having a limit at all. That way you can be a l

Re: [Rails-core] Edge + Webrick + Helloworld now fails

2006-03-01 Thread Stefan Kaes
Tom Ward wrote: On 2/28/06, Jeremy Kemper <[EMAIL PROTECTED]> wrote: For now, I'm removing the setting from the webrick server so folks can continue working with trunk. That's great, certainly the pragmatic solution. Please try http://dev.rubyonrails.org/attachment/ticket/3979/con

Re: [Rails-core] Edge + Webrick + Helloworld now fails

2006-03-01 Thread Tom Ward
On 2/28/06, Jeremy Kemper <[EMAIL PROTECTED]> wrote: > For now, I'm removing the setting from the webrick server so folks > can continue working with trunk. That's great, certainly the pragmatic solution. > I'd like to see allow_concurrency wiped out. Perhaps that's best left until after 1.1, a