[Rails-core] Strip Owner Name From Table Aliases On Eager Loading

2006-03-19 Thread Rick Olson
Can someone tell me why this patch is important? http://dev.rubyonrails.org/ticket/4251 """ I think the name says it all. Basically we are taking LEFT OUTER JOIN dbo.Users AS dbo.Users and making it LEFT OUTER JOIN dbo.Users AS Users. """ Do the aliases cause issues if they have periods in them

Re: [Rails-core] RJS Collection Proxies

2006-03-19 Thread David Heinemeier Hansson
> > "my_name".camelize(:lower) #=> myName This now works. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-applicatio

Re: [Rails-core] Two issues with through associations

2006-03-19 Thread Mark James
Rick Olson wrote: 2. Through associations do not currently support the :include option, either in their declarations or through an :include on the source belongs_to declaration. As of [3974] they do. That's service! It works fine in 3974, though I get a load stack overflow error in 398

Re: [Rails-core] RJS Collection Proxies

2006-03-19 Thread Cody Fauser
Thanks Rick! On 3/19/06, Rick Olson <[EMAIL PROTECTED]> wrote: > On 3/19/06, Cody Fauser <[EMAIL PROTECTED]> wrote: > > RJS collection proxies are currently broken for mixed case methods > > like findAll or sortBy. I've added a patch in > > http://dev.rubyonrails.org/ticket/4314. > > > > In looki

Re: [Rails-core] RJS Collection Proxies

2006-03-19 Thread Rick Olson
On 3/19/06, Cody Fauser <[EMAIL PROTECTED]> wrote: > RJS collection proxies are currently broken for mixed case methods > like findAll or sortBy. I've added a patch in > http://dev.rubyonrails.org/ticket/4314. > > In looking into the patch I was led to wonder if it might be useful to > add an opti

[Rails-core] RJS Collection Proxies

2006-03-19 Thread Cody Fauser
RJS collection proxies are currently broken for mixed case methods like findAll or sortBy. I've added a patch in http://dev.rubyonrails.org/ticket/4314. In looking into the patch I was led to wonder if it might be useful to add an option :lower to camelize to generate lower camel case names? "my

Re: [Rails-core] Two issues with through associations

2006-03-19 Thread Rick Olson
> 2. Through associations do not currently support the :include > option, either in their declarations or through an :include > on the source belongs_to declaration. > author.books.find(:all, :include => :chapters) does however work, > so it should be easy to get a default include w

[Rails-core] Two issues with through associations

2006-03-19 Thread Mark James
Extending DHH's example of a through association somewhat: class Author has_many :authorships has_many :books, :class_name => 'Textbook', # <-- do not include :through => :authorships, :include => :chapters # <-- inoperative end class Textbook has_many

Re: [Rails-core] Eager loading for both find_by_sql and associations using custom finder_sql

2006-03-19 Thread Mark James
Tom Ward wrote: Is there any way you can implement your changes as a plugin, or are they too deeply imbedded into ActiveRecord? In either case, it's worth releasing your code one way or another, as someone will surely find it useful, even if it never makes into the main core. Tom, a plugin's