Re: [Rails-core] Ticket 4440 seems mostly completed

2006-06-27 Thread Nick Sieger
On 6/27/06, Nick Sieger <[EMAIL PROTECTED]> wrote: Already done -- new patch applied. Whoops! s/applied/attached/ :) ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core

Re: [Rails-core] Ticket 4440 seems mostly completed

2006-06-27 Thread Nick Sieger
On 6/27/06, Charles O Nutter <[EMAIL PROTECTED]> wrote: I was worried about that, I had some bad patches creep into my system a while back. I'll take the patch I have, use the same crappy program to apply it, and then get a clean one out that I know works on trunk. Already done -- new patch app

Re: [Rails-core] Ticket 4440 seems mostly completed

2006-06-27 Thread Charles O Nutter
I was worried about that, I had some bad patches creep into my system a while back. I'll take the patch I have, use the same crappy program to apply it, and then get a clean one out that I know works on trunk.FYI, the 1.1.2 patch in trac should be clean, applied directly to railties dir.On 6/27/06

[Rails-core] Ticket #4888: [PATCH] EventObserver's initialize should take third parameter, trigger.

2006-06-27 Thread Scott Raymond
FYI: http://dev.rubyonrails.org/ticket/4888 This patch fixes a (presumably mistaken) rollback a while ago, in Prototype's Abstract.EventObserver.prototype.initialize method. In rev 3378, DHH changed it to allow an optional third parameter [1]. But in rev 3795, sam changed it back [2]. As a resul

Re: [Rails-core] Ticket 4440 seems mostly completed

2006-06-27 Thread Nick Sieger
On 6/27/06, Charles O Nutter <[EMAIL PROTECTED]> wrote: What's the next steps for this ticket? Are the patches satisfactory? I just tried to apply the patch in the ticket to railties svn head and several hunks failed. Perhaps we should update the patch one more time and wave our hands really

Re: [Rails-core] Patching process (Was: Ticket 4440 seems mostly completed)

2006-06-27 Thread Brad Ediger
Well, one more reason to kick myself for not going to RailsConf! :-) Thanks, --be Zack Chandler wrote: Brad, This exact question was posed to the Rails Core team at the Q and A session at RailsConf. Basically the anwser was: 1) Include documentation and describe WHY this needs to be done. 2)

Re: [Rails-core] Patching process (Was: Ticket 4440 seems mostly completed)

2006-06-27 Thread Zack Chandler
Brad, This exact question was posed to the Rails Core team at the Q and A session at RailsConf. Basically the anwser was: 1) Include documentation and describe WHY this needs to be done. 2) Include tests 3) Make the patch small if possible. I think there were a few more things mentioned but th

[Rails-core] Patching process (Was: Ticket 4440 seems mostly completed)

2006-06-27 Thread Brad Ediger
I think quite a few of us have been lurking on rails-core waiting for our pet patches to come through. The actual commit process seems rather opaque after a ticket is put into Trac. Would one of the core team members care to take a few minutes and explain how the process of getting a patch acc

[Rails-core] Ticket 4440 seems mostly completed

2006-06-27 Thread Charles O Nutter
I've posted a couple different patches to ticket 4440, and as far as I can tell they resolve all nonstandard block syntax throughout the rails/railties module. I would be very interested in helping to move this forward, since JRuby currently requires this patch for Rails to work. What's the next st

[Rails-core] ticket 5336

2006-06-27 Thread Ian White
Hi List, Could someone in the core team let me know if there's something impeding the patch in http://dev.rubyonrails.org/ticket/5336 being applied? I've checked in on it a few times to see if there's something I need to do, but it seems pretty inactive. Cheers, Ian White __

Re: [Rails-core] Patch 4720

2006-06-27 Thread Marcel Molina Jr.
On Tue, Jun 27, 2006 at 03:26:22PM -0400, Kent Sibilev wrote: > Can anyone from the rails core team apply a small patch from ticket > 4720? Done: http://dev.rubyonrails.org/changeset/4497 Thanks, marcel -- Marcel Molina Jr. <[EMAIL PROTECTED]> ___ Rai

[Rails-core] Patch 4720

2006-06-27 Thread Kent Sibilev
Can anyone from the rails core team apply a small patch from ticket 4720? Thank you. -- Kent --- http://www.datanoise.com ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core

[Rails-core] [PATCH] allow standalone use of ActionView::Base

2006-06-27 Thread Solomon White
Here's an annoyance I've run into before, and a simple patch to fix it. Say I want to export some data as xml. I should be able to fire up a script or rake task with my environment, grab some data, then render an rxml template. However, ActionView::Base makes the assumption that I have a c

[Rails-core] [PATCH] wrong template rendering

2006-06-27 Thread Surendra Singhi
Hello, I have discovered some issues with Action Mailer. To reproduce them: Create multiple mailers with the same action say, (FirstMailer and SecondMailer) with action `share'. Now, the way the action mailer code is currently written, 'compile_and_render_template' function will assign the same