Re: [Rails-core] Can't create new ticket on Trac

2006-07-24 Thread Tom Ward
I believe trac is semi-broken at the moment, and that no-one can submit tickets. If you check out the timeline (http://dev.rubyonrails.org/timeline) you'll see no new issues have been created for a couple of weeks. I'm sure there are people working hard getting it back up and running. Last week

Re: [Rails-core] Unit Tests for active record fail with mysql

2006-07-23 Thread Tom Ward
On 23/07/06, Daniel N <[EMAIL PROTECTED]> wrote: Tom, Thanx for the effort to get this going. Unfortunately the diff file attached has nothing it it. Cheers Well spotted ;) Try this one. Tom fix_mysql_schema_to_work_in_strict_mode.diff Description: Binary data ___

Re: [Rails-core] Unit Tests for active record fail with mysql

2006-07-22 Thread Tom Ward
Tom Ward wrote: I'll look into changing the mysql test schema to see if it can be fixed to work in strict mode, unless anyone vehemently objects. As promised, here's a patch against the schema allowing the activerecord test suite to be run in strict mode on mysql 5.0. I'll

Re: [Rails-core] Unit Tests for active record fail with mysql

2006-07-22 Thread Tom Ward
On 22/07/06, Daniel N <[EMAIL PROTECTED]> wrote: On 7/22/06, Chris Mear <[EMAIL PROTECTED]> wrote: > On 22 Jul 2006, at 7:58 am, Daniel N wrote: > > > ActiveRecord::StatementInvalid: Mysql::Error: #HY000Field 'type' > > doesn't have a default value: INSERT INTO projects (`name`, `id`) > > VALUES

Re: [Rails-core] test:plugins task dependency on :environment is pointless, surely?

2006-07-22 Thread Tom Ward
On 22/07/06, Caio Chassot <[EMAIL PROTECTED]> wrote: On 2006-07-22, at 13:02 , James Adam wrote: > However, because of the way that Rake::TestTask works (loading a new > Ruby interpreter which churns through the test cases), the Rails > environment is never actually made available to any plugin

Re: [Rails-core] Showing SQL Server some love...

2006-07-10 Thread Tom Ward
On 7/6/06, David Heinemeier Hansson <[EMAIL PROTECTED]> wrote: Create one new aggregated patch and mark the others as duplicate. We can then apply the aggregate. We've done that in the past for both SQL Server and Oracle too. I've created a patch against #5670 which fixes many minor problems.

Re: [Rails-core] Showing SQL Server some love...

2006-07-08 Thread Tom Ward
On 7/8/06, Ryan Tomayko <[EMAIL PROTECTED]> wrote: Tom has arguably contributed every bit as much if not more to the apapter as myself so I'd like to nominate him. He was probably the right guy for the job months ago. That's very gracious of you Ryan, but don't underestimate your own contribut

Re: [Rails-core] Showing SQL Server some love...

2006-07-08 Thread Tom Ward
On 7/8/06, Jeremy Kemper <[EMAIL PROTECTED]> wrote: On Jul 7, 2006, at 6:51 PM, Ryan Tomayko wrote: > On 7/6/06, Tom Ward <[EMAIL PROTECTED]> wrote: >> There are a fair few issues against the SQL Server db adapter that >> I'd >> like to see fixed. There are

Re: [Rails-core] Showing SQL Server some love...

2006-07-08 Thread Tom Ward
On 7/8/06, Michael A. Schoen <[EMAIL PROTECTED]> wrote: Jeremy Kemper wrote: > So, Tom, you looking to be a bug magnet? ;) Tom: let me know if you'd like a copy of the script I use to test against the Oracle adapter after every checkin. It's not very fancy, but it does a good job spamming rails-

[Rails-core] Showing SQL Server some love...

2006-07-06 Thread Tom Ward
There are a fair few issues against the SQL Server db adapter that I'd like to see fixed. There are also a couple of features I'd like to add, but don't really want to until these bugs have been fixed. It's time to show SQL Server some love! Many of these outstanding issues have patches against

Re: [Rails-core] [PROPOSAL] Partial commit access

2006-06-13 Thread Tom Ward
On 6/13/06, David Heinemeier Hansson <[EMAIL PROTECTED]> wrote: > It would be nice if the people like Michael Schoen who have shown a commitment > to the Oracle bindings could work on that portion without the overhead of a full > time committer reviewing each commit, as long as only that file or

[Rails-core] :limit option in schemas/migrations

2006-05-30 Thread Tom Ward
There's some confusion as to what the :limit option should mean when used against integer columns in migrations. Patch #2900 added support for limits in PostgreSQL mapping mapping limit < 4 to smallint, > 4 to bigint, and anything else to integer (so the limit is the number of bytes) However, th

Re: [Rails-core] Filtering with ActiveRecord

2006-05-24 Thread Tom Ward
On 5/24/06, Rick Olson <[EMAIL PROTECTED]> wrote: On 5/23/06, Hampton <[EMAIL PROTECTED]> wrote: > Is there anything I can do to help this patch get vetted quickly and > efficiently? > > -hampton. Make a plugin and get folks to use it. I'm not sold on this idea at all, personally. Here are th

Re: [Rails-core] Filtering with ActiveRecord

2006-05-14 Thread Tom Ward
On 5/13/06, Hampton <[EMAIL PROTECTED]> wrote: Let's say you have params[:student] = { :last_name = "Catlin" }. And, anything could have been passed in. Maybe a bunch of different attributes, and we'd like to filter based on that. Student.find_with (params[:student]) ...which really works as..

Re: [Rails-core] Eager loading for both find_by_sql and associations using custom finder_sql

2006-03-18 Thread Tom Ward
On 3/18/06, Mark James <[EMAIL PROTECTED]> wrote: > Hi, > > Only a couple of lines of code needed to be changed in order to get > eager loading (:include option) working with a has_many association > that uses a custom finder_sql. A similarly small change would be > needed to also make eager loadi

Re: [Rails-core] Rails 1.1 is coming

2006-03-06 Thread Tom Ward
On 3/6/06, Greg Lappen <[EMAIL PROTECTED]> wrote: > I had the same thought after I requested this to be in Rails 1.1, but > its not clear how plugins would work if we were using ActiveRecord > outside of a Rails application. You can create rails applications that don't use certain components (such

Re: [Rails-core] Rails 1.1 is coming

2006-03-06 Thread Tom Ward
On 3/3/06, Greg Lappen <[EMAIL PROTECTED]> wrote: > This may have gotten lost at the bottom of my email re: another topic > so I'm repeating it again. > > How about that connection pooling adaptor for Rails 1.1? > > There is a patch attached to http://dev.rubyonrails.org/ticket/2162 > that's be

Re: [Rails-core] Edge + Webrick + Helloworld now fails

2006-03-01 Thread Tom Ward
On 2/28/06, Jeremy Kemper <[EMAIL PROTECTED]> wrote: > For now, I'm removing the setting from the webrick server so folks > can continue working with trunk. That's great, certainly the pragmatic solution. > I'd like to see allow_concurrency wiped out. Perhaps that's best left until after 1.1, a

Re: [Rails-core] Edge + Webrick + Helloworld now fails

2006-02-28 Thread Tom Ward
On 2/28/06, Stefan Kaes <[EMAIL PROTECTED]> wrote: > Tom Ward wrote: > > A second line of attack is the allows_concurrency flag itself. I > > can't think when you'd ever want it to be false. > FCGI is single threaded. By having the flag, we can optimize AR

Re: [Rails-core] Edge + Webrick + Helloworld now fails

2006-02-28 Thread Tom Ward
ltiple threads, but as provided, this wouldn't be thread-safe in any case. Assuming allow_concurrency is always true fixes this issue, but there may be applications I haven't thought of that will be adversely affected. Thoughts? Tom Ward ___

Re: [Rails-core] Edge + Webrick + Helloworld now fails

2006-02-28 Thread Tom Ward
on't run my application under webrick and didn't test it with > ticket 3979. However, after doing so, I can't reproduce this problem > with current trunk. I can reproduce this problem with my (very) basic toy application. Running Windows XP/Webrick/SQL Server. I'll see if I can locate the cause.. Tom Ward ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core

Re: [Rails-core] Default <%= to use the h (html safe) method.

2006-02-15 Thread Tom Ward
On 15 Feb 2006 15:39:25 -, Kevin Olbrich <[EMAIL PROTECTED]> wrote: > > On Wednesday, February 15, 2006, at 2:50 PM, Tom Ward wrote: > >This is a bad idea. It assumes data from ActiveRecord models only > >ever displayed on the web. This ignores email templates, log

Re: [Rails-core] Default <%= to use the h (html safe) method.

2006-02-15 Thread Tom Ward
On 2/15/06, Nathaniel S. H. Brown <[EMAIL PROTECTED]> wrote: > I really like the idea of acts_as_secure/unescaped, especially with the > method missing catch as you have mentioned. This is a bad idea. It assumes data from ActiveRecord models only ever displayed on the web. This ignores email tem

Re: [Rails-core] Multithreaded script/runner

2006-02-10 Thread Tom Ward
unk. I'll comment against #2162 with anything I find. Tom On 2/9/06, Greg Lappen <[EMAIL PROTECTED]> wrote: > Your guess is as good as mine. Tom Ward did some work based on my > original patch to implement a pooled adaptor which I thought was on > track to be integrated into t

Re: [Rails-core] Still trying to get pagination fixed.. STILLhavethis ActiveRecord connection helper thingy pending

2006-02-10 Thread Tom Ward
On 2/9/06, Michael Koziarski <[EMAIL PROTECTED]> wrote: > * notests - For patches submitted without unittests > > These should also be marked XPATCH, because barring exceptional > circumstances (or trivial fixes) we don't apply patches which don't > include tests. Going through and marking untest

Re: [Rails-core] Still trying to get pagination fixed.. STILLhavethis ActiveRecord connection helper thingy pending

2006-02-09 Thread Tom Ward
On 2/9/06, Tom Ward <[EMAIL PROTECTED]> wrote: > Any suggestions for a better keyword are welcome! Talking to yourself, first sign of madness and all that, but instead of hastests I propose 'tested', to indicate that the patch has unit tests, and that those tests have be

Re: [Rails-core] Still trying to get pagination fixed.. STILLhavethis ActiveRecord connection helper thingy pending

2006-02-09 Thread Tom Ward
7;hastests'. The core team would then be able to concentrate on applying tested patches, while the rest of the community writes tests for those without. Any suggestions for a better keyword are welcome! Tom Ward ___ Rails-core mailing list

Re: [Rails-core] Proposal: Deprecate ADO support in the SQL Server adapter

2006-01-29 Thread Tom Ward
> Why not have something like this: > > server: &server > driver: /opt/local/whatever-driver.so # or whatever > user: my_login > password: M$_wh0r3 > server: 192.168.2.666 > tds_version: 8.0 # if anyone needs this > > development: > database: rails_

Re: [Rails-core] Proposal: Deprecate ADO support in the SQL Server adapter

2006-01-29 Thread Tom Ward
> > Unless people have significant objections, I'll create a ticket and > > patch to deprecate ADO, and update the wiki instruction pages > > accordingly. > > I don't really know enough about SQLServer to object. I know that I > had to install the ADO driver to connect to one of my client's > serve

Re: [Rails-core] Is :primary on Column meant to indicate if the column is the primary key?

2006-01-23 Thread Tom Ward
> Agreed. My intention was to update the columns method on the connection > adapter to set the primary attribute to true for the primary key. The one > thing which we ran into while doing some work on this is that for tables > with a primary key that is made up of more then one field we probably

[Rails-core] Proposal: Deprecate ADO support in the SQL Server adapter

2006-01-23 Thread Tom Ward
The SQL Server adapter can currently operate in two modes, ADO and ODBC, each of which uses a different interface to access the db. The ADO interface is currently the default, while ODBC can be specified as an option. I propose this situation is reversed, and that use of the ADO interface is depr

Re: [Rails-core] Is :primary on Column meant to indicate if the column is the primary key?

2006-01-23 Thread Tom Ward
> What I'm looking to do is make it so > connection.columns sets the primary flag so that when I do a db_schema_dump > I can have the create_table have the correct :primary_key value (assuming > the default "id" isn't being used). > > So if I have: > > CREATE TABLE Users ( > UserID int NOT NULL I

[Rails-core] Why does Object.subclasses_of ignore subclasses within modules?

2006-01-19 Thread Tom Ward
o have been in the repository since the first revision, so I can't divine anything looking through changesets. Ideally I'd like to use the method myself, but can't unless it works as I'd expect. I'd be grateful for any explanation anyone can give. Tom Ward P.S. Here'

Re: [Rails-core] activerecord rake test_mysql

2005-11-29 Thread Tom Ward
> Is there an archive of this list I could check > such things? Try http://wrath.rubyonrails.org/pipermail/rails-core/ Tom ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core