Re: [Rails-core] Routing rewrite, checked in

2006-06-03 Thread Julian 'Julik' Tarkhanov
On 3-jun-2006, at 5:00, Julian 'Julik' Tarkhanov wrote: On 2-jun-2006, at 7:57, Jamis Buck wrote: Hampton, Thanks for your testing on this. It does appear that :id, at least, is extra sticky now. We'll see what can be done with this, since it should definitely not be acting so zealous.

Re: [Rails-core] Routing rewrite, checked in

2006-06-02 Thread Julian 'Julik' Tarkhanov
On 2-jun-2006, at 7:57, Jamis Buck wrote: Hampton, Thanks for your testing on this. It does appear that :id, at least, is extra sticky now. We'll see what can be done with this, since it should definitely not be acting so zealous. Jamis, can something be done to disambiguiate where a lea

Re: [Rails-core] Routing rewrite, checked in

2006-06-01 Thread Jamis Buck
Hampton, Thanks for your testing on this. It does appear that :id, at least, is extra sticky now. We'll see what can be done with this, since it should definitely not be acting so zealous. - Jamis On Jun 1, 2006, at 12:58 PM, Hampton wrote: Further: I was trying to fix my code to use th

Re: [Rails-core] Routing rewrite, checked in

2006-06-01 Thread Rick Olson
On 6/1/06, Jamis Buck <[EMAIL PROTECTED]> wrote: Just a quick update--the routing rewrite has been checked in. We've already noticed a few things broken and have patching them this morning, but we'd love to hear from those of you willing to test their apps with the bleeding edge. Thanks! - Jami

Re: [Rails-core] Routing rewrite, checked in

2006-06-01 Thread Rodney Ramdas
that works, tnx :-) On 6/1/06, Jeremy Kemper <[EMAIL PROTECTED]> wrote: On Jun 1, 2006, at 12:04 PM, Rodney Ramdas wrote: > hi > > this seems to give issues: > > simply doing, > > def helper_routes > with_routing do |set| > set.draw { set.connect ':controller/:action/:id' } > [..] > en

Re: [Rails-core] Routing rewrite, checked in

2006-06-01 Thread Jeremy Kemper
On Jun 1, 2006, at 12:04 PM, Rodney Ramdas wrote: hi this seems to give issues: simply doing, def helper_routes with_routing do |set| set.draw { set.connect ':controller/:action/:id' } [..] end end throws NoMethodError: undefined method `connect' for # i don't quite get why since R

Re: [Rails-core] Routing rewrite, checked in

2006-06-01 Thread Rodney Ramdas
hi this seems to give issues: simply doing, def helper_routes with_routing do |set| set.draw { set.connect ':controller/:action/:id' } [..] end end throws NoMethodError: undefined method `connect' for # i don't quite get why since RouteSet#draw simply yields to Mapper which does con

Re: [Rails-core] Routing rewrite, checked in

2006-06-01 Thread Hampton
Further:I was trying to fix my code to use the nil method, and here was the result:url_for(:page_number => 3, :id => nil)"/video/2?id="That's definitely not the desired behaviour. -hampton.On 6/1/06, Hampton <[EMAIL PROTECTED]> wrote: Let me give you a more full example of what changes after the up

Re: [Rails-core] Routing rewrite, checked in

2006-06-01 Thread Hampton
Let me give you a more full example of what changes after the upgrade.  I fully acknowledge this is a hackish way to keep a pretty URL. Whether this is the Best Way doesn't really matter. What should matter is that this breaks applications. Routing in question:map.connect ':controller/:page_number'

Re: [Rails-core] Routing rewrite, checked in

2006-06-01 Thread Abdur-Rahman Advany
Oops... common way of doing it would be redirect_to(:id => nil) Abdur-Rahman Advany wrote: btw, the default way of doing this would be redirect_to(:action => 'index') Abdur-Rahman Advany wrote: You need to set the id or action to nil, unless you change the controller to something else than vi

Re: [Rails-core] Routing rewrite, checked in

2006-06-01 Thread Abdur-Rahman Advany
btw, the default way of doing this would be redirect_to(:action => 'index') Abdur-Rahman Advany wrote: You need to set the id or action to nil, unless you change the controller to something else than video it will include all the params... try redirect_to(:controller => "video", :action => nil

Re: [Rails-core] Routing rewrite, checked in

2006-06-01 Thread Abdur-Rahman Advany
You need to set the id or action to nil, unless you change the controller to something else than video it will include all the params... try redirect_to(:controller => "video", :action => nil) -- Abdul Hampton wrote: I have an application that broke. This may be an unwanted behaviour, or not

Re: [Rails-core] Routing rewrite, checked in

2006-06-01 Thread Hampton
I have an application that broke.This may be an unwanted behaviour, or not, but I was working with this as a feature for using some crazy-routing for pretty urls.url = "" => {"action"=>"index", "id"=>"21", "controller"=>"video"} then, I would do this.redirect_to(:controller => "video")The url it re

Re: [Rails-core] Routing rewrite, checked in

2006-06-01 Thread Charlie Bowman
I just updated, and noticed no problems.  I can't run full tests right now, but nothing seems broken.  I was able to test out my broomstick plugin which uses url for and it still works fine.  On Thu, 2006-06-01 at 10:25 -0600, Jamis Buck wrote: Just a quick update--the routing rewrite has b

Re: [Rails-core] Routing rewrite

2006-05-31 Thread Charlie Bowman
Really what is required is to produce all the urls for a given resource. The two main problems with page caching are: - A cached page may be located at several paths. The big issue here is that only the first route matched will be swept on changes. Yes, this is how I deleted my entir

Re: [Rails-core] Routing rewrite

2006-05-31 Thread Nicholas Seckar
On May 31, 2006, at 7:49 AM, Charlie Bowman wrote: Sorry, for the slow reply. I'm only registered for this list at my work address and there's no way I'm going to set my home computer to check that email! You're right I could definitely use a redirect statement to make caching work, but

Re: [Rails-core] Routing rewrite

2006-05-31 Thread Charlie Bowman
Sorry, for the slow reply. I'm only registered for this list at my work address and there's no way I'm going to set my home computer to check that email!  You're right I could definitely use a redirect statement to make caching work, but it seems like a hackish maneuver.  As soon as this rewr

Re: [Rails-core] Routing rewrite

2006-05-30 Thread Nicholas Seckar
On May 30, 2006, at 6:35 PM, Nicholas Seckar wrote: It would not be hard to make a plugin to do this... Actually Nicholas, putting this into core would be a good idea, as we could 'fix' caching -- we could save page caches to all the paths for a parameter set, and sweepers would be able t

Re: [Rails-core] Routing rewrite

2006-05-30 Thread Jamis Buck
On May 30, 2006, at 4:04 PM, Charlie Bowman wrote: Charlie, I'm afraid I don't understand. How would it know to build /pragmatic/ index from {:controller => "pragmatic", :action => "index"}, when you've connected it to ''? You can't have one route that maps to two paths, I'm afraid. - Jamis

Re: [Rails-core] Routing rewrite

2006-05-30 Thread Nicholas Seckar
On May 30, 2006, at 3:11 PM, Charlie Bowman wrote: Will there now be a way to get the long url back? Here's an example. map.connect '', :controller => "pragmatic", :action => 'index' Can we now map this back to /pragmatic/index by using url_for? I don't know if anyone else uses this, but

Re: [Rails-core] Routing rewrite

2006-05-30 Thread Charlie Bowman
Charlie, I'm afraid I don't understand. How would it know to build /pragmatic/ index from {:controller => "pragmatic", :action ="" "index"}, when you've connected it to ''? You can't have one route that maps to two paths, I'm afraid. - Jamis That's what I thought.  I spent quite a l

Re: [Rails-core] Routing rewrite

2006-05-30 Thread Rodney Ramdas
ah but a documentation patch is being worked on: http://dev.rubyonrails.org/ticket/5165 Please, write a decent documentation, since the current one is kinda missing. :) ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyo

Re: [Rails-core] Routing rewrite

2006-05-30 Thread Jamis Buck
On May 30, 2006, at 1:11 PM, Charlie Bowman wrote: Will there now be a way to get the long url back? Here's an example. map.connect '', :controller => "pragmatic", :action => 'index' Can we now map this back to /pragmatic/index by using url_for? I don't know if anyone else uses this, but

Re: [Rails-core] Routing rewrite

2006-05-30 Thread Rodrigo Kochenburger
It would be nice if route parameters could be dinamicly accessible by default values. Something like this: map.dashboard ':module', :controller => '#{module}/dashboard' So http://thedomain.com/organizer would actually call :controller => "organizer/dashboard', :action ="" 'index' But there's a p

Re: [Rails-core] Routing rewrite

2006-05-30 Thread Dan Webb
Hi Jamis, Thanks for the notice. I'll keep an eye on it and make adjustments to the Request Routing plugin as necessary. I'm looking forward to a rewrite of the routing code, it's the most difficult to extend of part of Rails. Cheers, Dan On 5/30/06, Jamis Buck <[EMAIL PROTECTED]> wrote: Ni

Re: [Rails-core] Routing rewrite

2006-05-30 Thread Charlie Bowman
Will there now be a way to get the long url back?  Here's an example. map.connect '', :controller => "pragmatic", :action ="" 'index' Can we now map this back to /pragmatic/index by using url_for?   I don't know if anyone else uses this, but it would really help me out on the page expiration