[Rails-core] Rails 1.1 is coming

2006-02-26 Thread Michael Koziarski
Hey guys, We're now beginning to finalise rails 1.1, and we need to make sure that we don't miss any heinous bugs. While we'll all be giving the list a once over, we're only human and we're likely to miss things. So, if you have any tickets which you think need to be addressed, please bring them

Re: [Rails-core] Rails 1.1 is coming

2006-02-26 Thread John Sheets
On Feb 26, 2006, at 1:13 PM, Michael Koziarski wrote: Hey guys, We're now beginning to finalise rails 1.1, and we need to make sure that we don't miss any heinous bugs. While we'll all be giving the list a once over, we're only human and we're likely to miss things. So, if you have any tickets

Re: [Rails-core] Rails 1.1 is coming

2006-02-26 Thread David Heinemeier Hansson
> How about the Sybase connection adapter? Any chance of getting that > into 1.1? I can update the patch against the latest trunk and > resubmit if that'll help. The patch only touches test code and adds > a single new application source file, sybase_adapter.rb. > >http://dev.rubyonrails.org

[Rails-core] Re: Rails 1.1 is coming

2006-02-26 Thread Andreas Schwarz
Michael Koziarski schrieb: > Hey guys, > > We're now beginning to finalise rails 1.1, and we need to make sure > that we don't miss any heinous bugs. While we'll all be giving the > list a once over, we're only human and we're likely to miss things. This is neither a bug nor very important, but

Re: [Rails-core] Re: Rails 1.1 is coming

2006-02-26 Thread David Heinemeier Hansson
> This is neither a bug nor very important, but > http://dev.rubyonrails.org/ticket/3461 is trivial, useful and 100% > backwards compatible, so I don't think there is any reason for not > including it in 1.1. Applied. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain ht

Re: [Rails-core] Re: Rails 1.1 is coming

2006-02-26 Thread Abdur-Rahman Advany
Hi, This patch: http://dev.rubyonrails.org/ticket/3530 would be nice to include... greets, Abdur-Rahman Andreas Schwarz wrote: Michael Koziarski schrieb: Hey guys, We're now beginning to finalise rails 1.1, and we need to make sure that we don't miss any heinous bugs. While we'll all

Re: [Rails-core] Rails 1.1 is coming

2006-02-26 Thread Anatol Pomozov
I am voting for tickets #3811To be precise I am voting for fixing problem with :index in datetime select.In http://dev.rubyonrails.org/ticket/3811 Bob made great job by consolidation all ticket related to date helper. I am using patch from this ticket on stage server and it works as expected (:in

Re: [Rails-core] Rails 1.1 is coming

2006-02-26 Thread Kent Sibilev
Ruby 1.8.4 comes with soap4r 1.5.5. With this version of soap4r actionwebservice is completely broken. Any soap rpc call which returns a value results with 'can't modify frozen object' exception. There is a ticket open for this problem http://dev.rubyonrails.org/ticket/2553 There are several prop

[Rails-core] Re: Rails 1.1 is coming

2006-02-26 Thread Matthew Palmer
On Mon, Feb 27, 2006 at 08:13:39AM +1300, Michael Koziarski wrote: > So, if you have any tickets which you think need to be addressed, > please bring them up in this thread, or add a keyword of > needs_review. We're pretty keen on pushing out a 1.1 release pretty > soon, but we also want to get

[Rails-core] ActionWebService targeted for unbundling by 1.1

2006-02-26 Thread David Heinemeier Hansson
The creator of ActionWebService, Leon Breedt, seems to be on a long-term vacation from Rails work and no one else in the core group is working with this framework. So its not a good fit to be in core when none of core is deeply familiar with it. On top of that, it's not one of those things that "mo

[Rails-core] Namespaced actions in Rails 1.1?

2006-02-26 Thread David Heinemeier Hansson
So Rake 0.7 allows for namespaces in actions. It's mighty nice. rake db:schema:import and rake db:schema:export whips the llama's ass on db_schema_import/export. It makes it much to organize tasks. Yay, yay. But how does this relate to backwards compatibility? What would happen if the next release

Re: [Rails-core] Namespaced actions in Rails 1.1?

2006-02-26 Thread Jon Tirsen
Include a backwards-compatability task library with the old names that just delegates to the new modularized ones? Might be overkill if it's not going to be a serious problem but it's relatively easy to do. On 2/27/06, David Heinemeier Hansson <[EMAIL PROTECTED]> wrote: > So Rake 0.7 allows for na

Re: [Rails-core] Namespaced actions in Rails 1.1?

2006-02-26 Thread David Heinemeier Hansson
> Include a backwards-compatability task library with the old names that > just delegates to the new modularized ones? Might be overkill if it's > not going to be a serious problem but it's relatively easy to do. The problem is what a mess that'll make of "rake -T". So before making such a mess, I

[Rails-core] Don't use "and" and "or" for boolean tests, instead always use "&&" and "||"

2006-02-26 Thread David Heinemeier Hansson
This is now Tha Law on all new patches. I documented this on the style guide at dev.rubyonrails.org. Reasoning: Everyone always forget the different binding rules of "and" and "or", which has resulted in bugs before. And it looks inconsistent with the rest of the code base. -- David Heinemeier Han

Re: [Rails-core] Namespaced actions in Rails 1.1?

2006-02-26 Thread Peter Donald
Hi, Anyone who has modified the flow of tasks when building rail apps or who have built their own tasks that rely on rails tasks is going to be bitten. For example, almost all of my rails apps have something similar to the example below. Also - almost all of my custom tasks will depend upon rails

Re: [Rails-core] Namespaced actions in Rails 1.1?

2006-02-26 Thread Wilson Bilkovich
On 2/26/06, David Heinemeier Hansson <[EMAIL PROTECTED]> wrote: > So Rake 0.7 allows for namespaces in actions. It's mighty nice. rake > db:schema:import and rake db:schema:export whips the llama's ass on > db_schema_import/export. It makes it much to organize tasks. Yay, yay. > > But how does this

Re: [Rails-core] Namespaced actions in Rails 1.1?

2006-02-26 Thread David Heinemeier Hansson
> Include a backwards-compatability task library with the old names that > just delegates to the new modularized ones? Might be overkill if it's > not going to be a serious problem but it's relatively easy to do. This is the way we'll go since I can make the old tasks not show up in rake -T, but t

Re: [Rails-core] ActionWebService targeted for unbundling by 1.1

2006-02-26 Thread Justin Forder
David Heinemeier Hansson wrote: The creator of ActionWebService, Leon Breedt, seems to be on a long-term vacation from Rails work Is he alive? Does anyone know if he's OK? and no one else in the core group is working with this framework. So its not a good fit to be in core when none of core

Re: [Rails-core] Namespaced actions in Rails 1.1?

2006-02-26 Thread Dave Thomas
On Feb 26, 2006, at 6:29 PM, David Heinemeier Hansson wrote: The problem is what a mess that'll make of "rake -T". So before making such a mess, I want to have some good reasons for doing so ;) I thought the Rails 1 series was supposed to maintain compatibility. Apart from being cool, what

Re: [Rails-core] Namespaced actions in Rails 1.1?

2006-02-26 Thread Jon Tirsen
On 2/27/06, Dave Thomas <[EMAIL PROTECTED]> wrote: > Apart from being cool, what benefits to these changes bring to the > _users_ of Rails? So you're saying "cool" isn't a benefit in itself. ;-) (But of course, I agree, if it's not backwards compatible it shouldn't be done.) ___

Re: [Rails-core] ActionWebService targeted for unbundling by 1.1

2006-02-26 Thread Michael Koziarski
> Is he alive? Does anyone know if he's OK? Leon's fine. He's just overworked at the dayjob. > I agree that for something to be in core it must be maintainable by > known maintainers. I assume Leon fell into that category, without (I > guess) being in the core team. Leon was in the core team, i

Re: [Rails-core] Namespaced actions in Rails 1.1?

2006-02-26 Thread Michael Koziarski
> So you're saying "cool" isn't a benefit in itself. ;-) > > > (But of course, I agree, if it's not backwards compatible it shouldn't be > done.) I agree too, and the change currently being proposed is backwards compatible for exactly this reason. David's rake -T concerns wouldn't be reason enou

Re: [Rails-core] ActionWebService targeted for unbundling by 1.1

2006-02-26 Thread TJ Vanderpoel
On Sun, Feb 26, 2006 at 05:40:51PM -0600, David Heinemeier Hansson wrote: > The creator of ActionWebService, Leon Breedt, seems to be on a > long-term vacation from Rails work and no one else in the core group > is working with this framework. So its not a good fit to be in core > when none of core

Re: [Rails-core] ActionWebService targeted for unbundling by 1.1

2006-02-26 Thread Michael Koziarski
> We'd be happy to take on ActionWebServices, as we use it daily in > much of our business process. I had run into the issues in 1.8.4 > but decided the benefits of AWS made 1.8.2 adequate for now. We > were unaware there was a maintainer vacancy. The 'we' i'm referring > to are myself, trey dem

Re: [Rails-core] ActionWebService targeted for unbundling by 1.1

2006-02-26 Thread TJ Vanderpoel
On Mon, Feb 27, 2006 at 04:27:59PM +1300, Michael Koziarski wrote: > > We'd be happy to take on ActionWebServices, as we use it daily in > > much of our business process. I had run into the issues in 1.8.4 > > but decided the benefits of AWS made 1.8.2 adequate for now. We > > were unaware there

Re: [Rails-core] Namespaced actions in Rails 1.1?

2006-02-26 Thread David Heinemeier Hansson
> I thought the Rails 1 series was supposed to maintain compatibility. See the decision from 1:30 minutes ago. The old tasks will still work, "rake -T" will just only show the new names. > Apart from being cool, what benefits to these changes bring to the > _users_ of Rails? Better coherence in

Re: [Rails-core] Re: Rails 1.1 is coming

2006-02-26 Thread Kevin Clark
Anyone have comments on ticket 3935 (http://dev.rubyonrails.org/ticket/3935) ? I think it should be in 1.1. It allows for a set_fixture_class method in unit tests so table accessor methods still work if your model uses a set_table_name call. So for example (and from the unit tests): model: class

[Rails-core] EdgeRails, rename_table doesn't change the sequence name

2006-02-26 Thread Nathaniel S. H. Brown
With regards to Rails 1.1, this may be a new or old error, I wasn't able to find it in Trac. Patch: http://dev.rubyonrails.org/ticket/3975 Basically, when I try to rename a table, the sequence names are not updated. connection.rename_table('banannas', 'banannas_pies') Table Name: bananna_pies

[Rails-core] #3005 - Prevent duplicate names (needs review for 1.1)

2006-02-26 Thread Francois Beausoleil
Hi ! I was taking another look at http://dev.rubyonrails.org/ticket/3005 I reread the discussion we had here in late December: http://thread.gmane.org/gmane.comp.lang.ruby.rails.core/41 The patch still applies cleanly. After removing the exceptions we had talked about, now I have another proble

[Rails-core] Added tests to #3270 :group is incorrectly reported as being an unknown key

2006-02-26 Thread Francois Beausoleil
http://dev.rubyonrails.org/ticket/3270 I added a bunch of tests. Need someone to review and apply. Bye ! -- François Beausoleil http://blog.teksol.info/ ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/l

Re: [Rails-core] Rails 1.1 is coming

2006-02-26 Thread Michael Schoen
So, if you have any tickets which you think need to be addressed, please bring them up in this thread, or add a keyword of needs_review. We're pretty keen on pushing out a 1.1 release pretty soon, but we also want to get all the nasty bugs. It's always kind of bugged me that the Oracle adapte

Re: [Rails-core] Rails 1.1 is coming

2006-02-26 Thread David Heinemeier Hansson
> It's always kind of bugged me that the Oracle adapter is named "oci", > seems odd relative to all the other adapters. > > Would the core group be open to a patch that renamed this "oracle", w/ > the required stubs to maintain backwards compatibility? > > Or am I being too nit-picky? It's legacy

Re: [Rails-core] ActionWebService targeted for unbundling by 1.1

2006-02-26 Thread Michael Schoen
TJ Vanderpoel wrote: We're on it Not that we're voting, but I'd really like to see AWS remain a core part of Rails. We're also about to roll out some significant production use. I haven't been the dev on that part of our app, but I know we've got a local patch applied to make it work for us