[Rails-core] RawPostDataTest#test_put_with_empty_content_type_ignores_body failure

2006-06-28 Thread Francois Beausoleil
Hi ! I get a failure for RawPostDataTest#test_put_with_empty_content_type_ignores_body at r4498: 2) Error: test_put_with_empty_content_type_ignores_body(RawPostDataTest): NoMethodError: undefined method `downcase' for nil:NilClass ./test/controller/../../lib/action_controller/cgi_ext/raw_po

[Rails-core] Routing failures on r4498

2006-06-28 Thread Francois Beausoleil
Hi all, I seem to have a problem. I attached a test case which I can't make pass. The route was extracted verbatim from an existing application. If I rollback in time to r4393, the tests pass. The route is: map.game_instructions 'game/:game/instructions', :controller => 'games', :action =>

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Michael Genereux
I lost even the most basic automatic routing support for the module/:controller/:action/:id URL format going from 1.1.2 to 1.1.3. I had to lock all my apps back to 1.1.2. Is my issue the same issue as Francois? Actual data but .com names have been changed to protect the innocent: --- route.

Re: [Rails-core] RawPostDataTest#test_put_with_empty_content_type_ignores_body failure

2006-06-28 Thread Mislav Marohnić
This has been like this for quite some time now on Win32. The problem is that, when you save an empty string into an ENV variable, it is later returned as nil. Since the whole core team is on OS X they don't experience this and therefore it was never fixed. 4 weeks ago I submitted a patch for this

Re: [Rails-core] RawPostDataTest#test_put_with_empty_content_type_ignores_body failure

2006-06-28 Thread Marcel Molina Jr.
On Wed, Jun 28, 2006 at 03:37:38PM +0200, Mislav Marohni?? wrote: >This has been like this for quite some time now on Win32. The problem is >that, when you save an empty string into an ENV variable, it is later >returned as nil. Since the whole core team is on OS X they don't >exper

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Jamis Buck
Francois, I suspect the problem is that the :game regex has \A and \Z in it. Because the new routes put that verbatim into the larger route regex, the match will fail. (Ditto for the /^.*$/ regex, with the ^ and $ anchors.) I *think* (Nicholas, correct me if I'm wrong) that you can just t

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Jean-François
2006/6/28, Jamis Buck <[EMAIL PROTECTED]>: Francois, I suspect the problem is that the :game regex has \A and \Z in it. Because the new routes put that verbatim into the larger route regex, the match will fail. (Ditto for the /^.*$/ regex, with the ^ and $ anchors.) I *think* (Nicholas, correct

[Rails-core] simply_restful plugin

2006-06-28 Thread Zack Chandler
I love the simply_restful plugin (beautiful work Jamis) but wonder why the naming convention changed to look for pluralized controllers by default. If you do: map.resource :message then you must have a MessagesController. If you already have a MessageController you need: map.resource :message,

[Rails-core] 1.1.3 kills modularized controllers?

2006-06-28 Thread Coda Hale
Howdy all, I just installed 1.1.3, and all of a sudden my modularized controller doesn't have a valid route. Admin::NewsController used to be mapped by default in 1.1.2, but 1.1.3 doesn't find it. The problem appears to be in ActionController::Routing::ControllerComponent#traverse_to_controller,

Re: [Rails-core] 1.1.3 kills modularized controllers?

2006-06-28 Thread Nicholas Seckar
Thanks for the bug report. This has been fixed in [4501].Sorry for the breakage,Nicholas SeckarOn 6/28/06, Coda Hale < [EMAIL PROTECTED]> wrote:Howdy all,I just installed 1.1.3, and all of a sudden my modularized controller doesn't have a valid route. Admin::NewsController used to be mapped bydefau

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Francois Beausoleil
Ah ha ! 2006/6/28, Jamis Buck <[EMAIL PROTECTED]>: I suspect the problem is that the :game regex has \A and \Z in it. Because the new routes put that verbatim into the larger route regex, the match will fail. (Ditto for the /^.*$/ regex, with the ^ and $ anchors.) I *think* (Nicholas, correct me

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Nicholas Seckar
On 6/28/06, Francois Beausoleil <[EMAIL PROTECTED]> wrote: Hi all,The route is:map.game_instructions 'game/:game/instructions', :controller => 'games',:action ="" 'instructions', :requirements => {:game => /\A[-\w \+%]+\Z/i} Placing ^, \A, \Z, and $ inside regexp captures for requirements is no

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Francois Beausoleil
Hello Jean-François, 2006/6/28, Jean-François <[EMAIL PROTECTED]>: By the way, isn't \A \z better than \A \Z ? Actually, you might be right, except in this case it doesn't matter. From "Programming Ruby" 2nd edition, p. 70, section Anchors: """The sequence \A matches the beginning of a string

Re: [Rails-core] simply_restful plugin

2006-06-28 Thread Jeremy Kemper
On Jun 28, 2006, at 10:18 AM, Zack Chandler wrote: I love the simply_restful plugin (beautiful work Jamis) but wonder why the naming convention changed to look for pluralized controllers by default. If you do: map.resource :message then you must have a MessagesController. If you already have a

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Francois Beausoleil
Hello Nicholas ! 2006/6/28, Nicholas Seckar <[EMAIL PROTECTED]>: Perhaps we should add an informative error message for this case. Feel free to weight in if you think so. (Or better yet, send a diff + unit test.) I will, I only need a pointer on where I should start searching. With that, I'll

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Nicholas Seckar
On 6/28/06, Francois Beausoleil <[EMAIL PROTECTED]> wrote: Hello Nicholas !2006/6/28, Nicholas Seckar <[EMAIL PROTECTED]>:> Perhaps we should add an informative error message for this case. Feel free> to weight in if you think so. (Or better yet, send a diff + unit test.) I will, I only need a poin

Re: [Rails-core] simply_restful plugin

2006-06-28 Thread Jamis Buck
Zack, The pluralization is intentional. This is because of the collection- oriented nature of resources. If you have a "message" resource, you get the collection of all messages at "/messages", and a single message at "/messages/2". The controller itself manages "messages" (serves up eithe

Re: [Rails-core] Ticket 4440 seems mostly completed

2006-06-28 Thread Nicholas Seckar
On 6/27/06, Nick Sieger <[EMAIL PROTECTED]> wrote: On 6/27/06, Nick Sieger <[EMAIL PROTECTED]> wrote:> Already done -- new patch applied.Whoops!  s/applied/attached/ :)s/attached/applied/ :-) ___ Rails-core mailing list Rails-core@lists.rubyonrails.org ht

Re: [Rails-core] Ticket 4440 seems mostly completed

2006-06-28 Thread Nick Sieger
On 6/28/06, Nicholas Seckar <[EMAIL PROTECTED]> wrote: s/attached/applied/ :-) Thanks Nicholas! ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core

Re: [Rails-core] Ticket 4440 seems mostly completed

2006-06-28 Thread Charles O Nutter
Excellent, thank you! Does this automatically mean it will be in 1.1.4?On 6/28/06, Nicholas Seckar <[EMAIL PROTECTED] > wrote: On 6/27/06, Nick Sieger <[EMAIL PROTECTED]> wrote: On 6/27/06, Nick Sieger <[EMAIL PROTECTED]> wrote:> Already done -- new patch applied. Whoops!  s/applied/attached/ :)s/

Re: [Rails-core] simply_restful plugin

2006-06-28 Thread Zack Chandler
Jeremy, Jamis, Thanks for clarifying the intention behind this choice. I had posted a similar question to a recent loudthinking post and the response (see below) leads me to believe there may be a few more changes ahead. http://www.loudthinking.com/arc/000593.html> Challenge by DHH on June 28,

[Rails-core] #5544: [PATCH] Add underscore_table_names option to ActiveRecord::Base

2006-06-28 Thread Obie Fernandez
FYI... whenever someone is in a committing mood, the following is a small no-brainer (IMHO) Cheers, Obie #5544: [PATCH] Add underscore_table_names option to ActiveRecord::Base -+-- Reporter: [EMAIL PROTECTED] | Owner

[Rails-core] Routing patch and test question

2006-06-28 Thread Wilson Bilkovich
I did this during RailsConf, while browsing the routing source: http://dev.rubyonrails.org/ticket/5507 I showed it to Nicholas on IRC, and he wondered why it didn't just use Pathname#cleanpath from the standard library, rather than reinventing it. That seemed like a good question to me, so I rewr

[Rails-core] Re: [Ruby on Rails] #5544: [PATCH] Add underscore_table_names option to ActiveRecord::Base

2006-06-28 Thread Obie Fernandez
wtf? did I miss a previous discussion on this or something? That's an ugly hack if I've ever seen one. - obie Changes (by bitsweat): * resolution: => wontfix * version: => 1.1.1 * status: new => closed Comment: Pass a block wrapping the default table name to {{{set_table_name}}} {{{ class