Re: [Rails-core] AR unit tests

2005-11-23 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Nov 23, 2005, at 12:31 PM, Michael Schoen wrote: The test adding in [3089] passes under Oracle, but spits out some ugly stuff. Is this expected? Yes; it's expected. I will silence the warnings. It's to ensure than we don't generate reader met

Re: [Rails-core] Changeset 3169 causing errors in my model

2005-11-24 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The mutual dependencies error introduced in [3169] is fixed in [3181]. jeremy -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.2 (Darwin) iD8DBQFDhhwpAQHALep9HFYRAjLbAKDGdIo6Mt/lbhYPBQbQwL9vQWcT8wCeP35o Yxalq/jkefkiUm1DKqaZKYI= =Y2fT -END PGP S

Re: [Rails-core] Changeset 3169 causing errors in my model

2005-11-24 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Nov 24, 2005, at 12:00 PM, Francois Beausoleil wrote: 2005/11/24, Michael Koziarski <[EMAIL PROTECTED]>: SystemStackError isn't the user experience we're after though... Was there anything in your logs warning you that you'd overridden transac

Re: [Rails-core] question on enable_warnings

2005-11-24 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Nov 24, 2005, at 12:06 AM, Michael Schoen wrote: In [3169], a change was made to enable warnings on the first load of a file in dev mode. Seems to result in a LOT of warnings from within Rails, particularly ActiveRecord (see below for a sample)

Re: [Rails-core] Changeset 3169 causing errors in my model

2005-11-24 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Nov 24, 2005, at 12:35 PM, Francois Beausoleil wrote: 2005/11/24, Jeremy Kemper <[EMAIL PROTECTED]>: Bummer. The whole point of this warnings stuff is so that you get a message in your logs telling you that you're overriding an exis

Re: [Rails-core] connection specifications borked in changeset 3218?

2005-12-05 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Dec 5, 2005, at 12:55 PM, Trevor Squires wrote: it looks like a recent change (3218) has borked connection specifications in some way. When I run my unit tests it fails because even though it's connection to the test database it's using the u

Re: [Rails-core] #3024 - Reloading aggregation instances

2005-12-07 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Dec 5, 2005, at 4:14 PM, Francois Beausoleil wrote: Another patch that I feel needs more attention: http://dev.rubyonrails.org/ticket/3024 This patch ensures aggregations are reloaded when the parent record is. This bit me during unit testing.

Re: [Rails-core] automatic db retries

2005-12-09 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Dec 9, 2005, at 10:50 AM, Rick Bradley wrote: Not only that, but with 0.14.4 we've turned up a problem on Oracle with transaction isolation in tests. Basically, if we have a test that calls some AR functionality which happens to use a transac

Re: [Rails-core] automatic db retries

2005-12-09 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Dec 9, 2005, at 8:18 AM, Wilson Bilkovich wrote: Sorry to resurrect an old thread, but what about just defining a "no-op" query for each adapter. In Oracle, that would be, say, "select * from dual". Many Java connection pool implementations have

Re: [Rails-core] config.frameworks

2005-12-13 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Dec 12, 2005, at 11:21 PM, Kent Sibilev wrote: Can I ask you guys what is the point of having config.frameworks in environment.rb? According to the comment before this config parameter, it is there so you can specify which frameworks you don't w

Re: [Rails-core] rails breaking with ruby rc 1.8.4

2005-12-13 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Dec 13, 2005, at 9:39 AM, Ara.T.Howard wrote: this kind of thing exists in other places in the code as well. here are summaries of the two stack traces when this code is loaded: [...] yikes. basically what is happening is that Callbacks gets

Re: [Rails-core] bug in has_many count?

2006-01-19 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Jan 19, 2006, at 9:30 AM, Michael Schoen wrote: construct_sql is executed in the initialize method of the association and it handles the substitution of the sql. Ah, thanks. So the bug is that it doesn't do the right thing if the finder_sql ha

Re: [Rails-core] bug in has_many count?

2006-01-19 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Jan 19, 2006, at 12:59 PM, Michael Schoen wrote: construct_sql is executed in the initialize method of the association and it handles the substitution of the sql. Ah, thanks. So the bug is that it doesn't do the right thing if the finder_sql

Re: [Rails-core] How should we do away with the rubysess white page of death?

2006-01-26 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Jan 26, 2006, at 8:40 AM, Duane Johnson wrote: Jamis Buck and I had a few ideas tonight that would each take care of the CgiRequest bug where switching between Rails apps that have different classes (models) stored in the session causes the who

Re: [Rails-core] Edge + Webrick + Helloworld now fails

2006-02-27 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Feb 27, 2006, at 4:04 PM, Kyle Maxwell wrote: This stopped working rather recently. NoMethodError in # undefined method `verify!' for {}:Hash RAILS_ROOT: script/../config/.. Application Trace | Framework Trace | Full Trace ./script/../config

Re: [Rails-core] Rails 1.1 is coming

2006-02-27 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Feb 27, 2006, at 6:24 PM, Bob Silva wrote: I'll also have the date_helper patch updated to trunk tonight. Not sure what's wrong with it yet but bitsweat asked for updated tests against trunk so... Hey, it simply doesn't apply cleanly to trun

Re: [Rails-core] Edge + Webrick + Helloworld now fails

2006-02-28 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Feb 28, 2006, at 9:12 AM, Tom Ward wrote: On 2/28/06, Stefan Kaes <[EMAIL PROTECTED]> wrote: Tom Ward wrote: A second line of attack is the allows_concurrency flag itself. I can't think when you'd ever want it to be false. FCGI is single threa

Re: [Rails-core] Database Adapter Plugin

2006-02-28 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Feb 28, 2006, at 11:40 AM, Derrick Spell wrote: With all the talk of 1.1, and with all the patches being applied, I realized that my laziness (or lack of free time, depending on your perspective) means that my OpenBase database adapter will mos

Re: [Rails-core] Use svnmerge.py for merging trunk to stable branch

2006-04-09 Thread Jeremy Kemper
On Apr 7, 2006, at 12:29 PM, Blair Zajac wrote: Now that Rails has a stable branch, I would like to suggest considering using svnmerge.py to manage the revisions in trunk that you want to pull over into the branch. It'll make life much easier in managing commits to trunk and then merging th

Re: [Rails-core] Issue in ActiveRecord generated reader methods

2006-05-09 Thread Jeremy Kemper
On May 9, 2006, at 6:12 PM, Jonathan Viney wrote: I agree that seems odd. I can't see any reason not to use read_attribute there, as it will type cast if necessary. define_read_method could be simplified and Column#type_cast_code should be unnecesary perhaps. Inline type casting tailored to

Re: [Rails-core] Re: Rails AR/Oracle Unit Test: [4335] failed

2006-05-12 Thread Jeremy Kemper
On May 11, 2006, at 10:19 PM, Michael A. Schoen wrote: This can be fixed by enhancing the test to support Oracle's sql type for integer, which is NUMBER(38), but this test also exposed a difference in how the Oracle adapter is handling sql_type, and I'd like to just fix that. I'll have a p

Re: [Rails-core] real bind variables

2006-05-25 Thread Jeremy Kemper
On May 25, 2006, at 3:07 PM, Michael A. Schoen wrote: So I've finally bitten the bullet and patched the AR Oracle adapter to use real OCI bind variables. This has a measurable impact on the client side, and a huge impact on a high volume Oracle server due to the sql hard parses that it saves

Re: [Rails-core] Routing rewrite, checked in

2006-06-01 Thread Jeremy Kemper
On Jun 1, 2006, at 12:04 PM, Rodney Ramdas wrote: hi this seems to give issues: simply doing, def helper_routes with_routing do |set| set.draw { set.connect ':controller/:action/:id' } [..] end end throws NoMethodError: undefined method `connect' for # i don't quite get why since R

Re: [Rails-core] rubygems support for rails plugins (patch)

2006-06-18 Thread Jeremy Kemper
On Jun 16, 2006, at 1:26 PM, John-Mason P. Shackelford wrote: Rails committers, (feedback from others welcome) Would you accept a patch--in principle, obviously the implementation matters--that would: Yes. Gems are a great fit and the reason we've pushed back on proposals such as dependency

Re: [Rails-core] simply_restful plugin

2006-06-28 Thread Jeremy Kemper
On Jun 28, 2006, at 10:18 AM, Zack Chandler wrote: I love the simply_restful plugin (beautiful work Jamis) but wonder why the naming convention changed to look for pluralized controllers by default. If you do: map.resource :message then you must have a MessagesController. If you already have a

Re: [Rails-core] Re: [Ruby on Rails] #5544: [PATCH] Add underscore_table_names option to ActiveRecord::Base

2006-06-29 Thread Jeremy Kemper
On Jun 29, 2006, at 3:36 PM, Obie Fernandez wrote: I think my patch is merited, but if nobody else thinks so then I'll defer to the wisdom of the group. That said, the workaround provided by bitsweat doesn't make sense to me. I wonder if perhaps I didn't get my point across in the description. O

Re: [Rails-core] help finishing a patch for label helpers? [#362]

2006-07-05 Thread Jeremy Kemper
On Jul 5, 2006, at 5:43 PM, Peter Michaux wrote: Rick, it looks like a little more than hacking. What is stopping your patch from going into the core? (BTW, you quoted his answer just a few lines up.) I use labels too and would like to see them in the standard form builder. jeremy

Re: [Rails-core] Showing SQL Server some love...

2006-07-07 Thread Jeremy Kemper
On Jul 7, 2006, at 6:51 PM, Ryan Tomayko wrote: On 7/6/06, Tom Ward <[EMAIL PROTECTED]> wrote: There are a fair few issues against the SQL Server db adapter that I'd like to see fixed. There are also a couple of features I'd like to add, but don't really want to until these bugs have been fix

Re: [Rails-core] Float -> BigDecimal

2006-07-08 Thread Jeremy Kemper
On Jul 8, 2006, at 11:00 PM, Michael A. Schoen wrote: But just wondering if folks considered the performance impact of the change? From a simple test it seems that BigDecimal math is about twice as slow as using Floats. BigDecimal is slow, but numeric(10,3) ought to be meaningful. Anyone tr

Re: [Rails-core] Testing has_many :dependent => :restrict

2006-07-26 Thread Jeremy Kemper
On Jul 26, 2006, at 6:06 AM, Daniel N wrote: I've had a crack at this one and it is as I feared. If I define the restrict association first, then the destroy chain is halted and all is well. But if I have an association where a :dependent => :destroy is declared before the association wit

Re: [Rails-core] Testing has_many :dependent => :restrict

2006-07-29 Thread Jeremy Kemper
On Jul 28, 2006, at 8:29 PM, Daniel N wrote: Just a thought tho. By raising an exception, this would put destroy into a different category, this should perhaps be destroy! to fit with the other methods that raise errors. Good call. Really, destroy_with_callbacks should rollback the transa

Re: [Rails-core] Re: Why are has_one objects resaved when the parentis saved?

2006-07-29 Thread Jeremy Kemper
On Jul 28, 2006, at 11:22 PM, Josh Susser wrote: The other way to do dirty checking is to do it on an object basis, instead of by columns. I'd love to be able to track what associated objects had been modified so that when I save an order, all the line items that got modified get saved too.

Re: [Rails-core] Re: Why are has_one objects resaved when the parentis saved?

2006-07-29 Thread Jeremy Kemper
sociations in a write heavy environment especially if you have text or blob fields in your tables. Anyone care to PDI this as a plugin? As I remember it, about a year ago Jeremy Kemper implemented dirty column tracking and decided against it for reasons I forget. Something wasn't

Re: [Rails-core] error on ticket submit

2006-08-01 Thread Jeremy Kemper
On Aug 1, 2006, at 1:34 PM, Michael Genereux wrote: Are all new, noncritical patches on hold for right now pending the new ticket page? I've started editing documentation in the core Rails classes to make them more clear, fix typos, and in some cases, fill in undocumented public methods. S

Re: [Rails-core] Adding :having to Active Record

2006-08-05 Thread Jeremy Kemper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Aug 4, 2006, at 11:19 PM, Blake Watters wrote: I have recently needed support for having clauses for some advanced find queries in my application. I've implemented this in a mixin that implements a new set of finders and query constructors that

Re: [Rails-core] documentation

2006-08-08 Thread Jeremy Kemper
On Aug 8, 2006, at 3:47 PM, Michael Koziarski wrote: For example I just submitted a documentation patch (http://dev.rubyonrails.org/ticket/5762) for the :from option for the ActiveRecord find method. I'd think that adding support for this option should have had documentation associated with it w

Re: [Rails-core] Fix for cascading includeded associations

2006-08-14 Thread Jeremy Kemper
On 8/13/06, Rich Collins <[EMAIL PROTECTED]> wrote: I noticed that you can't cascade an include more than twice on thesame association (for has_many at least).  It seems that theassociation name table alias is used as a key to store the number oftimes that the association has been used in the inclu

Re: [Rails-core] More changes to cascading associations

2006-08-15 Thread Jeremy Kemper
Is this a patch against trunk, which includes your previous patch?On 8/15/06, Rich Collins <[EMAIL PROTECTED] > wrote:I added additional fixes to recursively cascading associations.  This patch includes fixes for has_many :through and habtm (with tests) aswell as tests for has_one and belongs_to.  

Re: [Rails-core] test::unit namespace pollution

2006-08-15 Thread Jeremy Kemper
On 8/15/06, court3nay <[EMAIL PROTECTED]> wrote: Background: I've got an app that doesn't use the DB (long story..)and running tests is certainly a chore when you don't have any DBconnection.Also, due to the way rails extends TestCase, running tests in  your suite that aren't tied to AR can have is

Re: [Rails-core] More changes to cascading associations

2006-08-15 Thread Jeremy Kemper
On 8/15/06, Rich Collins <[EMAIL PROTECTED]> wrote: Yes.  I did an update before I did the diff.Ah, appears the attachment is the same diff as the last patch. Could you pass along the new patch?Thanks,jeremy On Aug 15, 2006, at 9:18 PM, Jeremy Kemper wrote: Is this a patch against trunk,

Re: [Rails-core] More changes to cascading associations

2006-08-16 Thread Jeremy Kemper
On 8/16/06, Rich Collins <[EMAIL PROTECTED]> wrote: Ah sorry I grabbed the old diff.  Here is the new one with the proposed changes.Thanks - http://dev.rubyonrails.org/changeset/4776 jeremyOn Aug 15, 2006, at 11:09 PM, Jeremy Kemper wrote: On 8/15/06, Rich Collins <[EMAIL PROTECTED] >