Re: rdiff-backup-fs filesize for large files

2021-03-23 Thread Arrigo Marchiori
Hello All,

On Tue, Mar 23, 2021 at 06:56:23AM +0100, Eric Lavarde wrote:

> Hi,
> 
> I can't help but I created the next issue, for someone to take, and
> document/fix the build process:
> 
> https://github.com/rdiff-backup/rdiff-backup-fs/issues/4
> 
> The MR from Arrigo is also merged, not knowing if it really helps, as nobody
> built the code :-/

Now it should build after this:
https://github.com/rdiff-backup/rdiff-backup-fs/pull/5

As I wrote in the PR message, it may be a better idea to merge
Debian's patches into the code instead of mine. They seem to have been
written by people who know Autotools (I don't) and add support for
kFreeBSD, that could be a Good Thing. So feel free to reject my PR and
do better ;-)

Please understand I am just hacking away this, just because the
"C-only problem" label tempted me. I do not have resources to spend
into this (not for 30 USD ;-), but I will be available to guide anyone
interested, if you think my contribution could be useful.

> On 23/03/2021 00:24, griffin tucker wrote:
> > i forgot, i also ran:
> > 
> > cp README.md README
> > automake --add-missing
> > 
> > before i ran autoreconf --install

This could also be clarified by reading the Debian patches and package
script.

An unrequested comment: there source code files I have seen do not
seem to carry any information about the license. It may be worth
another PR? I am not a lawyer, but I know for sure that the Apache
License requires a note to be inserted into each and every file.

Indicating the license would probably be necessary, before integrating
the Debian patches.

Best regards,
-- 
Arrigo

http://rigo.altervista.org



Re: rdiff-backup-fs filesize for large files

2021-03-22 Thread Eric Lavarde

Hi,

I can't help but I created the next issue, for someone to take, and 
document/fix the build process:


https://github.com/rdiff-backup/rdiff-backup-fs/issues/4

The MR from Arrigo is also merged, not knowing if it really helps, as 
nobody built the code :-/


KR, Eric

On 23/03/2021 00:24, griffin tucker wrote:

i forgot, i also ran:

cp README.md README
automake --add-missing

before i ran autoreconf --install

On Tue, 23 Mar 2021 at 09:55, griffin tucker
 wrote:


i've spent the last few hours trying to install from source, but i
only got as far as:

/urs/bin/ld: rdiff-backup-fs.o: in function `run':
rdiff-backup-fs.c:(.text+0xad): undefined reference to `fuse_main_real' "

(above was after running make)

i think it references an old version of the fuse library

usually i install from "apt install rdiff-backup-fs "

for those interested, i ran:
autoreconf --install
./configure
make

and didn't get as far as:
sudo make install

i don't know what i'm doing wrong to install from source in this case

On Tue, 23 Mar 2021 at 08:22, Arrigo Marchiori  wrote:


Hello Eric, Griffin,

replying below.

On Mon, Mar 22, 2021 at 07:33:21AM +1100, griffin tucker wrote:


yep, thanks eric.

also worth noting there's a $30 bounty on bountysource for whomever
solves this particular bug

https://www.bountysource.com/issues/96838952-files-with-a-byte-size-larger-than-an-int-cause-i-o-errors

On Mon, 22 Mar 2021 at 03:11, EricZolf  wrote:


Hi Arrigo,

It's about https://github.com/rdiff-backup/rdiff-backup-fs/issues/2


Aha, thank you. I did not read the email subject carefully enough.


But to be clear, it's possibly the whole FS code which needs a cleanup,


Yes, it does! ;-)


I only "saved" it under the umbrella of rdiff-backup, no clue in which state it 
exactly is.

You're more than welcome to have a look!


Thank you.. I did and I am proposing a very very simple fix:
https://github.com/rdiff-backup/rdiff-backup-fs/pull/3
...in the hope it is such a low-hanging fruit!

Unfortunately I have no idea about how to test this. Maybe Griffin?

Regards,
--
Arrigo

http://rigo.altervista.org






Re: rdiff-backup-fs filesize for large files

2021-03-22 Thread griffin tucker
i forgot, i also ran:

cp README.md README
automake --add-missing

before i ran autoreconf --install

On Tue, 23 Mar 2021 at 09:55, griffin tucker
 wrote:
>
> i've spent the last few hours trying to install from source, but i
> only got as far as:
>
> /urs/bin/ld: rdiff-backup-fs.o: in function `run':
> rdiff-backup-fs.c:(.text+0xad): undefined reference to `fuse_main_real' "
>
> (above was after running make)
>
> i think it references an old version of the fuse library
>
> usually i install from "apt install rdiff-backup-fs "
>
> for those interested, i ran:
> autoreconf --install
> ./configure
> make
>
> and didn't get as far as:
> sudo make install
>
> i don't know what i'm doing wrong to install from source in this case
>
> On Tue, 23 Mar 2021 at 08:22, Arrigo Marchiori  wrote:
> >
> > Hello Eric, Griffin,
> >
> > replying below.
> >
> > On Mon, Mar 22, 2021 at 07:33:21AM +1100, griffin tucker wrote:
> >
> > > yep, thanks eric.
> > >
> > > also worth noting there's a $30 bounty on bountysource for whomever
> > > solves this particular bug
> > >
> > > https://www.bountysource.com/issues/96838952-files-with-a-byte-size-larger-than-an-int-cause-i-o-errors
> > >
> > > On Mon, 22 Mar 2021 at 03:11, EricZolf  wrote:
> > > >
> > > > Hi Arrigo,
> > > >
> > > > It's about https://github.com/rdiff-backup/rdiff-backup-fs/issues/2
> >
> > Aha, thank you. I did not read the email subject carefully enough.
> >
> > > > But to be clear, it's possibly the whole FS code which needs a cleanup,
> >
> > Yes, it does! ;-)
> >
> > > > I only "saved" it under the umbrella of rdiff-backup, no clue in which 
> > > > state it exactly is.
> > > >
> > > > You're more than welcome to have a look!
> >
> > Thank you.. I did and I am proposing a very very simple fix:
> > https://github.com/rdiff-backup/rdiff-backup-fs/pull/3
> > ...in the hope it is such a low-hanging fruit!
> >
> > Unfortunately I have no idea about how to test this. Maybe Griffin?
> >
> > Regards,
> > --
> > Arrigo
> >
> > http://rigo.altervista.org



Re: rdiff-backup-fs filesize for large files

2021-03-22 Thread griffin tucker
i've spent the last few hours trying to install from source, but i
only got as far as:

/urs/bin/ld: rdiff-backup-fs.o: in function `run':
rdiff-backup-fs.c:(.text+0xad): undefined reference to `fuse_main_real' "

(above was after running make)

i think it references an old version of the fuse library

usually i install from "apt install rdiff-backup-fs "

for those interested, i ran:
autoreconf --install
./configure
make

and didn't get as far as:
sudo make install

i don't know what i'm doing wrong to install from source in this case

On Tue, 23 Mar 2021 at 08:22, Arrigo Marchiori  wrote:
>
> Hello Eric, Griffin,
>
> replying below.
>
> On Mon, Mar 22, 2021 at 07:33:21AM +1100, griffin tucker wrote:
>
> > yep, thanks eric.
> >
> > also worth noting there's a $30 bounty on bountysource for whomever
> > solves this particular bug
> >
> > https://www.bountysource.com/issues/96838952-files-with-a-byte-size-larger-than-an-int-cause-i-o-errors
> >
> > On Mon, 22 Mar 2021 at 03:11, EricZolf  wrote:
> > >
> > > Hi Arrigo,
> > >
> > > It's about https://github.com/rdiff-backup/rdiff-backup-fs/issues/2
>
> Aha, thank you. I did not read the email subject carefully enough.
>
> > > But to be clear, it's possibly the whole FS code which needs a cleanup,
>
> Yes, it does! ;-)
>
> > > I only "saved" it under the umbrella of rdiff-backup, no clue in which 
> > > state it exactly is.
> > >
> > > You're more than welcome to have a look!
>
> Thank you.. I did and I am proposing a very very simple fix:
> https://github.com/rdiff-backup/rdiff-backup-fs/pull/3
> ...in the hope it is such a low-hanging fruit!
>
> Unfortunately I have no idea about how to test this. Maybe Griffin?
>
> Regards,
> --
> Arrigo
>
> http://rigo.altervista.org



Re: rdiff-backup-fs filesize for large files

2021-03-22 Thread Arrigo Marchiori
Hello Eric, Griffin,

replying below.

On Mon, Mar 22, 2021 at 07:33:21AM +1100, griffin tucker wrote:

> yep, thanks eric.
> 
> also worth noting there's a $30 bounty on bountysource for whomever
> solves this particular bug
> 
> https://www.bountysource.com/issues/96838952-files-with-a-byte-size-larger-than-an-int-cause-i-o-errors
> 
> On Mon, 22 Mar 2021 at 03:11, EricZolf  wrote:
> >
> > Hi Arrigo,
> >
> > It's about https://github.com/rdiff-backup/rdiff-backup-fs/issues/2

Aha, thank you. I did not read the email subject carefully enough.

> > But to be clear, it's possibly the whole FS code which needs a cleanup,

Yes, it does! ;-)

> > I only "saved" it under the umbrella of rdiff-backup, no clue in which 
> > state it exactly is.
> >
> > You're more than welcome to have a look!

Thank you.. I did and I am proposing a very very simple fix:
https://github.com/rdiff-backup/rdiff-backup-fs/pull/3
...in the hope it is such a low-hanging fruit!

Unfortunately I have no idea about how to test this. Maybe Griffin?

Regards,
-- 
Arrigo

http://rigo.altervista.org



Re: rdiff-backup-fs filesize for large files

2021-03-21 Thread griffin tucker
yep, thanks eric.

also worth noting there's a $30 bounty on bountysource for whomever
solves this particular bug

https://www.bountysource.com/issues/96838952-files-with-a-byte-size-larger-than-an-int-cause-i-o-errors

On Mon, 22 Mar 2021 at 03:11, EricZolf  wrote:
>
> Hi Arrigo,
>
> It's about https://github.com/rdiff-backup/rdiff-backup-fs/issues/2
>
> But to be clear, it's possibly the whole FS code which needs a cleanup, I 
> only "saved" it under the umbrella of rdiff-backup, no clue in which state it 
> exactly is.
>
> You're more than welcome to have a look!
>
> KR, Eric
>
> On March 21, 2021 2:39:46 PM UTC, Arrigo Marchiori  wrote:
> >Hello All,
> >
> >my reply (actually a question) is at the bottom.
> >
> >On Tue, Mar 02, 2021 at 12:56:31PM +, ewl+rdiffbac...@lavar.de
> >wrote:
> >
> >> Hi Griffin,
> >>
> >> nobody is currently working on the topic and C doesn't belong to my
> >knowledge, so it's waiting for a volunteer to step forward.
> >>
> >> Sorry, Eric
> >>
> >> On March 2, 2021 2:01:33 AM UTC, griffin tucker
> > wrote:
> >> >files with a byte size larger than an int show up with input/output
> >> >errors
> >> >
> >> >i see that someone tried changing the integer to a long long,
> >however
> >> >apparently this didn't work
> >> >
> >> >i have limited programming experience, and since this deals with the
> >> >operating system, i think this is above my head
> >> >
> >> >has any progress been made on this bug?
> >
> >What bug are you talking about?
> >
> >Best regards,
>



Re: rdiff-backup-fs filesize for large files

2021-03-21 Thread EricZolf
Hi Arrigo,

It's about https://github.com/rdiff-backup/rdiff-backup-fs/issues/2

But to be clear, it's possibly the whole FS code which needs a cleanup, I only 
"saved" it under the umbrella of rdiff-backup, no clue in which state it 
exactly is.

You're more than welcome to have a look!

KR, Eric

On March 21, 2021 2:39:46 PM UTC, Arrigo Marchiori  wrote:
>Hello All,
>
>my reply (actually a question) is at the bottom.
>
>On Tue, Mar 02, 2021 at 12:56:31PM +, ewl+rdiffbac...@lavar.de
>wrote:
>
>> Hi Griffin,
>> 
>> nobody is currently working on the topic and C doesn't belong to my
>knowledge, so it's waiting for a volunteer to step forward.
>> 
>> Sorry, Eric
>> 
>> On March 2, 2021 2:01:33 AM UTC, griffin tucker
> wrote:
>> >files with a byte size larger than an int show up with input/output
>> >errors
>> >
>> >i see that someone tried changing the integer to a long long,
>however
>> >apparently this didn't work
>> >
>> >i have limited programming experience, and since this deals with the
>> >operating system, i think this is above my head
>> >
>> >has any progress been made on this bug?
>
>What bug are you talking about?
>
>Best regards,



Re: rdiff-backup-fs filesize for large files

2021-03-21 Thread Arrigo Marchiori
Hello All,

my reply (actually a question) is at the bottom.

On Tue, Mar 02, 2021 at 12:56:31PM +, ewl+rdiffbac...@lavar.de wrote:

> Hi Griffin,
> 
> nobody is currently working on the topic and C doesn't belong to my 
> knowledge, so it's waiting for a volunteer to step forward.
> 
> Sorry, Eric
> 
> On March 2, 2021 2:01:33 AM UTC, griffin tucker 
>  wrote:
> >files with a byte size larger than an int show up with input/output
> >errors
> >
> >i see that someone tried changing the integer to a long long, however
> >apparently this didn't work
> >
> >i have limited programming experience, and since this deals with the
> >operating system, i think this is above my head
> >
> >has any progress been made on this bug?

What bug are you talking about?

Best regards,
-- 
Arrigo

http://rigo.altervista.org



Re: rdiff-backup-fs filesize for large files

2021-03-02 Thread ewl+rdiffbackup
Hi Griffin,

nobody is currently working on the topic and C doesn't belong to my knowledge, 
so it's waiting for a volunteer to step forward.

Sorry, Eric

On March 2, 2021 2:01:33 AM UTC, griffin tucker 
 wrote:
>files with a byte size larger than an int show up with input/output
>errors
>
>i see that someone tried changing the integer to a long long, however
>apparently this didn't work
>
>i have limited programming experience, and since this deals with the
>operating system, i think this is above my head
>
>has any progress been made on this bug?



rdiff-backup-fs filesize for large files

2021-03-01 Thread griffin tucker
files with a byte size larger than an int show up with input/output errors

i see that someone tried changing the integer to a long long, however
apparently this didn't work

i have limited programming experience, and since this deals with the
operating system, i think this is above my head

has any progress been made on this bug?