Re: [PATCH] reiserfs: reiserfs_file_write will lose error code when a 0-length write occurs w/ O_SYNC

2006-03-03 Thread Clemens Eisserer
> I suggest that they sit in -mm or an rc for ~2 weeks before they go in. > If 2.6.16 is coming out before then, then let it ship without them. All > of these things are pretty obscure/rare, so not unsettling the code > matters more than getting them in. I know this sounds quite a bit stupid but

Re: [PATCH 00/11] reiserfs: xattr rework

2006-03-03 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jan Kara wrote: >> The data journaling mode can be set as a flag associated with the inode. >> Currently, i_data_log is set in REISERFS_I(inode)->i_flags. I add >> i_data_ordered in one of my later patches. They can be tested easily >> with reiserfs_f

Re: Coding Standards

2006-03-03 Thread Giovanni A. Orlando
Hello, I was reading an article long ago where Mr Reiser was saying that he was using military grade coding standards. And that it is also the reason why Reiser4 is not integrated by default in the Linux kernel. I think that was a minor issue. The major issues are political. So ...

Re: [PATCH] reiserfs: reiserfs_file_write will lose error code when a 0-length write occurs w/ O_SYNC

2006-03-03 Thread Hans Reiser
Andrew Morton wrote: >Boy, lots of reiserfs things happening lately. > >We presently have: > >reiserfs-do-not-check-if-unsigned-0.patch [ merged today ] >reiserfs-fix-transaction-overflowing.patch >reiserfs-handle-trans_id-overflow.patch >reiserfs-reiserfs_file_write-will-lose-error-code-when

Re: [Fwd: Re: [PATCH] reiserfs: use balance_dirty_pages_ratelimited_nr in reiserfs_file_write]

2006-03-03 Thread Hans Reiser
Andrew Morton wrote: >Hans Reiser <[EMAIL PROTECTED]> wrote: > > >>I suspect that when someone did the search and replace when creating >>balance_dirty_pages_ratelimited_nr they failed to read the code and >>realize this code path was already effectively ratelimited. The result >>is they made i

Re: Coding Standards

2006-03-03 Thread Hans Reiser
Marc-André Laverdière wrote: > Hello, > > I was reading an article long ago where Mr Reiser was saying that he > was using military grade coding standards. And that it is also the > reason why Reiser4 is not integrated by default in the Linux kernel. I think that was a minor issue. The major iss

Re: mount fails

2006-03-03 Thread Vladimir V. Saveliev
Hello On Fri, 2006-03-03 at 08:41 -0500, boricua wrote: > > > > you have to get spare reliable partition of not smaller size and copy > > hda4 to it. > > > > Please make sure that you have to use dd_rescue to copy data. > > (dd requires additional options to properly copy data off when source >

Re: mount fails

2006-03-03 Thread boricua
> > you have to get spare reliable partition of not smaller size and copy > hda4 to it. > > Please make sure that you have to use dd_rescue to copy data. > (dd requires additional options to properly copy data off when source > file has unreadable blocks). > then run reiserfsck on new partition.

Re: mount fails

2006-03-03 Thread Vladimir V. Saveliev
Hello On Fri, 2006-03-03 at 08:13 -0500, boricua wrote: > On Fri, 03 Mar 2006 15:23:05 +0300 > "Vladimir V. Saveliev" <[EMAIL PROTECTED]> wrote: > > > Hello > > > > On Thu, 2006-03-02 at 20:47 -0500, boricua wrote: > > > using suse 10.0 , strange this is like 2nd time suse fails or my hd fails

Re: mount fails

2006-03-03 Thread boricua
On Fri, 03 Mar 2006 15:23:05 +0300 "Vladimir V. Saveliev" <[EMAIL PROTECTED]> wrote: > Hello > > On Thu, 2006-03-02 at 20:47 -0500, boricua wrote: > > using suse 10.0 , strange this is like 2nd time suse fails or my hd fails > > using suse > > > > > > trying to mount /dev/hda4 fails with bad b

Re: mount fails

2006-03-03 Thread Vladimir V. Saveliev
Hello On Thu, 2006-03-02 at 20:47 -0500, boricua wrote: > using suse 10.0 , strange this is like 2nd time suse fails or my hd fails > using suse > > > trying to mount /dev/hda4 fails with bad blocks and both > > reiserfsck --rebuild-tree also fails. > this happend to be my / partition > > an

Re: [PATCH 00/11] reiserfs: xattr rework

2006-03-03 Thread Jan Kara
> -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Jan Kara wrote: > > You are right that the quota code and xattrs need to do the same thing. > > We only need to do slight interface changes (currently functions take a > > superblock and a type and pick appropriate quota inode themselves) and