Re: [PATCH] reiser4: fix readv

2006-09-17 Thread Andrew Morton
On Sun, 17 Sep 2006 22:39:07 +0400 Vladimir V. Saveliev [EMAIL PROTECTED] wrote: Hello On Friday 15 September 2006 06:24, Andrew Morton wrote: On Wed, 13 Sep 2006 22:12:54 +0400 Vladimir V. Saveliev [EMAIL PROTECTED] wrote: Hello, Andrew reiser4 in 2.6.18-rc6-mm2 has a bug

Re: [PATCH] reiser4: fix readv

2006-09-17 Thread Andrew Morton
btw, please be aware that the post-2.6.17 deadlock fixes which went into generic_file_buffered_write() caused a few problems: a) Significant NFS overwrite performance regression (due to running prepare_write/commit_write) against each writev segment. b) Smaller but significant performance

Re: Reiser4 und LZO compression

2006-08-27 Thread Andrew Morton
On Sun, 27 Aug 2006 04:34:26 +0400 Alexey Dobriyan [EMAIL PROTECTED] wrote: The patch below is so-called reiser4 LZO compression plugin as extracted from 2.6.18-rc4-mm3. I think it is an unauditable piece of shit and thus should not enter mainline. Like lib/inflate.c (and this new code

Re: [PATCH] reiserfs: eliminate minimum window size for bitmap searching

2006-08-22 Thread Andrew Morton
I can see that the bigalloc code as-is is pretty sad, but this is a scary patch. It has the potential to cause people significant performance problems way, way ahead in the future. For example, suppose userspace is growing two files concurrently. It could be that the bigalloc code would cause

Re: [PATCH] reiserfs: eliminate minimum window size for bitmap searching

2006-08-22 Thread Andrew Morton
On Tue, 22 Aug 2006 19:46:34 -0700 Clay Barnes [EMAIL PROTECTED] wrote: Perhaps I mis-recall, but shouldn't delayed writes (or something along those lines) cause a case where two files are being incrementally written rare? If we did delayed allocation, yes. But we generally don't.

Re: reiser4: maybe just fix bugs?

2006-08-01 Thread Andrew Morton
On Tue, 01 Aug 2006 15:24:37 +0400 Vladimir V. Saveliev [EMAIL PROTECTED] wrote: The writeout code is ugly, although that's largely due to a mismatch between what reiser4 wants to do and what the VFS/MM expects it to do. Yes. reiser4 writeouts atoms. Most of pages get into atoms via

Re: [PATCH] reiserfs: fix handling of device names with /'s in them

2006-07-12 Thread Andrew Morton
On Wed, 12 Jul 2006 12:42:28 -0400 Jeff Mahoney [EMAIL PROTECTED] wrote: On systems with block devices containing slashes (virtual dasd, cciss, etc), reiserfs will fail to initialize /proc/fs/reiserfs/dev due to it being interpreted as a subdirectory. The generic block device code changes

Re: [PATCH] reiserfs: fix handling of device names with /'s in them

2006-07-12 Thread Andrew Morton
On Wed, 12 Jul 2006 20:51:47 -0700 Hans Reiser [EMAIL PROTECTED] wrote: Andrew Morton wrote: On Wed, 12 Jul 2006 12:42:28 -0400 Jeff Mahoney [EMAIL PROTECTED] wrote: On systems with block devices containing slashes (virtual dasd, cciss, etc), reiserfs will fail to initialize

Re: [PATCH] reiserfs:fix journaling issue regarding fsync()

2006-07-02 Thread Andrew Morton
On Mon, 03 Jul 2006 10:31:49 +0900 Hisashi Hifumi [EMAIL PROTECTED] wrote: When write() extends a file(i_size is increased) and fsync() is called, change of inode must be written to journaling area through fsync(). But,currently the i_trans_id is not correctly updated when i_size is

Re: [PATCH] Fix reiserfs deadlock

2006-04-21 Thread Andrew Morton
Jan Kara [EMAIL PROTECTED] wrote: reiserfs_cache_default_acl() should return whether we successfully found the acl or not. We have to return correct value even if reiserfs_get_acl() returns error code and not just 0. Otherwise callers such as reiserfs_mkdir() can unnecessarily lock the xattrs

Re: [Fwd: Re: [PATCH] reiserfs: use balance_dirty_pages_ratelimited_nr in reiserfs_file_write]

2006-03-02 Thread Andrew Morton
Hans Reiser [EMAIL PROTECTED] wrote: I suspect that when someone did the search and replace when creating balance_dirty_pages_ratelimited_nr they failed to read the code and realize this code path was already effectively ratelimited. The result is they made it excessively infrequent (every

Re: [PATCH] reiserfs: reiserfs_file_write will lose error code when a 0-length write occurs w/ O_SYNC

2006-03-02 Thread Andrew Morton
Boy, lots of reiserfs things happening lately. We presently have: reiserfs-do-not-check-if-unsigned-0.patch [ merged today ] reiserfs-fix-transaction-overflowing.patch reiserfs-handle-trans_id-overflow.patch

Re: latest patches degrade reiser4 performance substantially

2005-09-21 Thread Andrew Morton
Hans Reiser [EMAIL PROTECTED] wrote: At the this time we have no idea which patch is responsible, probably in a day or two we'll have a patch to fix it. OK. I assume this performance change is demonstrable in just 2.6.14-rc2+reiser4? Beware that there are other changes in the -mm lineup

Re: + reiser4-big-update-div64-fix.patch added to -mm tree

2005-09-16 Thread Andrew Morton
Vladimir V. Saveliev [EMAIL PROTECTED] wrote: Hello [EMAIL PROTECTED] wrote: The patch titled reiser4-big-update-div64-fix has been added to the -mm tree. Its filename is reiser4-big-update-div64-fix.patch From: Andrew Morton [EMAIL PROTECTED] There's

Re: List of things requested by lkml for reiser4 inclusion (to review)

2005-09-09 Thread Andrew Morton
Hans Reiser [EMAIL PROTECTED] wrote: ... Do I remember right that the submission deadline is a week from Monday for 2.6.14 inclusion? Next week, supposedly. But something like a brand new filesystem can go in pretty much any time, as long as it compiles. Because it can't break anyone's

Re: reiser4 merge status

2005-09-07 Thread Andrew Morton
Hans Reiser [EMAIL PROTECTED] wrote: Andrew, we have been working on a big patch that resolves the VFS layering issues. This patch should be ready to send in any day now, we are debugging it. We may not have been sending you a lot of emails, but we have been working away at it. That's good

Re: reiser4 merging action list

2005-06-27 Thread Andrew Morton
Hans Reiser [EMAIL PROTECTED] wrote: Andrew asked me to put together a list of things that need to be done before merging: Thanks. As I said to Hans, if we can get a list of bullet-point actions nailed down and agreed to then we have an uncontroversial path to happiness and a merge. Let's

Re: -mm - 2.6.13 merge status

2005-06-23 Thread Andrew Morton
Jeff Mahoney [EMAIL PROTECTED] wrote: + assert(nikita-955, pool != NULL); These assertion codes are meaningless to the rest of us so please drop them. As someone who spends time debugging reiser3 issues, I've grown accustomed to the named assertions. They make discussing a

Re: reiser4 plugins

2005-06-21 Thread Andrew Morton
Hans Reiser [EMAIL PROTECTED] wrote: What is wrong with having an encryption plugin implemented in this manner? What is wrong with being able to have some files implemented using a compression plugin, and others in the same filesystem not. What is wrong with having one file in the FS

Re: reiser4 read performance loss of 17% in latest -mm kernel

2004-12-30 Thread Andrew Morton
Hans Reiser [EMAIL PROTECTED] wrote: Just an FYI, we are still figuring it out. andrew, you might note it in release notes, especially if we don't fix it before your next release. I'd try reverting simplified-readahead*.patch.

Re: [PATCH] Fix of quota deadlock on pagelock

2004-11-22 Thread Andrew Morton
Jan Kara [EMAIL PROTECTED] wrote: What prevents vfs_quota_off() from racing with unmount? If you look at, say, sync_filesystems() you'll see that we take -s_umount and then test -s_root to check that we didn't race with an unmount attempt. I thought that the sync_fs and stuff is

Re: [Fwd: [PATCH] reiser4: fix a use after free bug in reiser4_parse_options]

2004-11-22 Thread Andrew Morton
Laurent Riffard [EMAIL PROTECTED] wrote: This patch fix a use after kfree bug in reiser4_parse_options. I'll add that to -mm. In future, please don't allow your email client to wordwrap patches. Thanks.

Re: [PATCH] Fix of quota deadlock on pagelock

2004-11-19 Thread Andrew Morton
Jan Kara [EMAIL PROTECTED] wrote: +static ssize_t ext2_quota_read(struct super_block *sb, int type, char *data, +size_t len, loff_t off) +{ + struct inode *inode = sb_dqopt(sb)-files[type]; + unsigned long blk = off EXT2_BLOCK_SIZE_BITS(sb); `blk' should

Re: [PATCH] Fix of quota deadlock on pagelock

2004-11-19 Thread Andrew Morton
Jan Kara [EMAIL PROTECTED] wrote: +static ssize_t ext2_quota_write(struct super_block *sb, int type, + const char *data, size_t len, loff_t off) +{ + struct inode *inode = sb_dqopt(sb)-files[type]; + unsigned long blk = off EXT2_BLOCK_SIZE_BITS(sb); +

Re:  2.6.9-mm1

2004-10-23 Thread Andrew Morton
Hilzinger Marcel [EMAIL PROTECTED] wrote: SuSE Linux 9.2 will contain reiser4 hm. Nobody ever tells me anything. Does that mean that SuSE are using 8k stacks?

Re: I oppose Chris and Jeff's patch to add an unnecessary additional namespace to ReiserFS

2004-04-26 Thread Andrew Morton
Hey, I was reading that! Please do *not* go making modifications to Cc: lists. Just do reply-to-all and be happy, thanks.

Re: reiserfs logging patches udpated

2004-03-24 Thread Andrew Morton
Chris Mason [EMAIL PROTECTED] wrote: ftp.suse.com/pub/people/mason/patches/data-logging/experimental/2.6.5-rc2-mm2 Has a new set of reiserfs patches. -ENODOCCO. If people are going to test this stuff we will need setup and usage instructions, links to userspace tool upgrades, etc, etc.

Re: reiserfs logging patches udpated

2004-03-24 Thread Andrew Morton
Chris Mason [EMAIL PROTECTED] wrote: On Wed, 2004-03-24 at 17:18, Andrew Morton wrote: Chris Mason [EMAIL PROTECTED] wrote: ftp.suse.com/pub/people/mason/patches/data-logging/experimental/2.6.5-rc2-mm2 Has a new set of reiserfs patches. -ENODOCCO. If people are going

Re: reiserfs logging patches udpated

2004-03-24 Thread Andrew Morton
Chris Mason [EMAIL PROTECTED] wrote: On Wed, 2004-03-24 at 17:35, Andrew Morton wrote: For data=ordered? The only docs are to mount -o data=writeback if you don't want data=ordered (which is the new default). No tool upgrades are required. OK, thanks. Switching the default

Re: Filesystem Tests

2003-08-14 Thread Andrew Morton
Mike Fedyk [EMAIL PROTECTED] wrote: On Wed, Aug 06, 2003 at 06:34:10PM +0200, Diego Calleja Garc?a wrote: El Wed, 06 Aug 2003 18:06:37 +0400 Hans Reiser [EMAIL PROTECTED] escribi?: I don't think ext2 is a serious option for servers of the sort that Linux specializes in, which is

Re: Filesystem Tests

2003-08-05 Thread Andrew Morton
Grant Miner [EMAIL PROTECTED] wrote: I tested the performace of various filesystems with a mozilla build tree of 295MB, with primarily writing and copying operations. The test system is Linux 2.6.0-test2, 512MB memory, 11531.85MB partition for tests. Sync is run a few times throughout