[Reproducible-builds] Bug#833340: mini-buildd: please make the build reproducible
Control: user reproducible-builds@lists.alioth.debian.org Control: usertags -1 environment X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org 2016-08-03 20:14 GMT+08:00 Chris Lamb : > - default=os.getenv("HOME"), > + default="$HOME", > > Unless I'm missing something, this won't work as $VARS are not expanded > in Python.. > > (What you probably want to do is set the default to ~/.mini-buildd and > patch the callsites to use os.path.expanduser at "real" runtime.) I intended to use "$HOME" string literally since I did not come up with a better solution. :-( The original author used os.getenv() in python argparse, so the output of `mini-buildd --help' really depend on $HOME env var. Unfortunately the man page is generated using help2man (or similar tool) [1] during building process and reproducible build website will alter $HOME env var to test reproducibility. So in my opinion there is no better option except fixed text string. Mini-buildd script won't and shouldn't detect if itself is running for help2man or for end-user. [1] https://tests.reproducible-builds.org/debian/rb-pkg/unstable/armhf/diffoscope-results/mini-buildd.html Thanks, Boyuan ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] Bug#833340: mini-buildd: please make the build reproducible
user Reproducible-builds@lists.alioth.debian.org usertag 833340 + Environment Hi, On Wed, Aug 03, 2016 at 05:20:47PM +0800, Boyuan Yang wrote: > Source: mini-buildd > Version: 1.0.16 > Severity: wishlist > Tags: patch thanks for filing this bug with patch! If you plan to file further such bugs in future, please also usertag them when filing those, as this will make sure they turn up on our radar automatically, also they will be included in our weekly blog posts. https://wiki.debian.org/ReproducibleBuilds/Contribute#How_to_report_bugs explain how to use usertags for reproducible builds. and really: thanks for filing this bug at all! :) -- cheers, Holger signature.asc Description: Digital signature ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
[Reproducible-builds] Bug#833340: mini-buildd: please make the build reproducible
Source: mini-buildd Version: 1.0.16 Severity: wishlist Tags: patch Hi, The current unreproducible status is due to different env HOME value generated by help2man. An example patch is provided to fix make the package reproducible. Thanks. --- a/mini-buildd +++ b/mini-buildd @@ -77,9 +77,9 @@ help="SMTP credentials in format '[USER]:[PASSWORD]@smtp|ssmtp://HOST:PORT'.") group_conf.add_argument("-U", "--dedicated-user", action="store", default="mini-buildd", help="Force a custom dedicated user name (to run as a different user than 'mini-buildd').") -group_conf.add_argument("-H", "--home", action="store", default=os.getenv("HOME"), +group_conf.add_argument("-H", "--home", action="store", default="$HOME", help="Run with this home dir. The only use case to change this for debugging, really.") -group_conf.add_argument("-F", "--pidfile", action="store", default=os.path.join(os.getenv("HOME"), ".mini-buildd.pid"), +group_conf.add_argument("-F", "--pidfile", action="store", default=os.path.join("$HOME", ".mini-buildd.pid"), help="Set pidfile path.") group_conf.add_argument("-f", "--foreground", action="store_true", help="Don't daemonize, log to console.") ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds