Re: [Reproducible-builds] Bug#812428: libgcrypt20: please make the build reproducible (timestamps)
On 2016-01-24 Daniel Kahn Gillmor wrote: > On Sat 2016-01-23 16:52:09 -0500, Jérémy Bobbio wrote: >> While working on the “reproducible builds” effort [1], we have noticed >> that libgcrypt20 could not be built reproducibly. >> The attached patch adds support for SOURCE_DATE_EPOCH to set the value >> of BUILD_TIMESTAMP defined in the configure script. Once applied, >> libgcrypt20 is nearly reproducible in our current experimental >> framework—their might be remaining timestamps in the PDF documentation. > Thanks for fixing this, Lunar. > fwiw, libgcrypt upstream is the same folks as libgpg-error upstream. In > response to concerns about reproducible builds, libgpg-error 1.20 > switched to not embedding the build timestamp at all upstream by > default. > Perhaps they'd be open to the same approach for libgcrypt if it were > proposed. [...] Hello, FYI this had already happened on libgcrypt master branch when this bug was submitted, Werner has already done this. http://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=a785cc3db0c4e8eb8ebbf784b833a40d2c42ec3e cu Andreas -- `What a good friend you are to him, Dr. Maturin. His other friends are so grateful to you.' `I sew his ears on from time to time, sure' ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] Bug#812428: libgcrypt20: please make the build reproducible (timestamps)
On Sun, Jan 24, 2016 at 05:00:55PM +0100, Axel Beckert wrote:
> Hi again,
>
> Axel Beckert wrote:
> > > /usr/share/doc/autotools-dev/README.Debian.gz says:
> > >
> > > >> Do NOT use dh-autoreconf and dh_autotools-dev_* helpers at the same
> > > >> time, dh-autoreconf takes care of updating config.sub and
> > > >> config.guess by itself.
> >
> > It still says that? I thought that got fixed.
>
> Yeah, in dh-autoreconf (#698765), but not in autotools-dev obviously.
> Will file a bug report for that, too.
Please also have a look at https://wiki.debian.org/Autoreconf
Now, the cases where autotools-dev *and* autoreconf are needed are/were
pretty rare.
Furthermore consider that since the last debhelper release
config.{sub,guess} are automatically updated before the build by
dh_update_autotools_config(1), so I believe calling autotools-dev
manually now is more useless than ever.
IOW: it's probably better/cleaner to just remove --with autotools-dev.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] Bug#812428: libgcrypt20: please make the build reproducible (timestamps)
Hi again, Axel Beckert wrote: > > /usr/share/doc/autotools-dev/README.Debian.gz says: > > > > >> Do NOT use dh-autoreconf and dh_autotools-dev_* helpers at the same > > >> time, dh-autoreconf takes care of updating config.sub and > > >> config.guess by itself. > > It still says that? I thought that got fixed. Yeah, in dh-autoreconf (#698765), but not in autotools-dev obviously. Will file a bug report for that, too. Regards, Axel -- ,''`. | Axel Beckert , http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] Bug#812428: libgcrypt20: please make the build reproducible (timestamps)
Hi, Daniel Kahn Gillmor wrote: > > - dh $@ --parallel --with autotools_dev > > + dh $@ --parallel --with autoreconf --with autotools_dev > > /usr/share/doc/autotools-dev/README.Debian.gz says: > > >> Do NOT use dh-autoreconf and dh_autotools-dev_* helpers at the same > >> time, dh-autoreconf takes care of updating config.sub and > >> config.guess by itself. It still says that? I thought that got fixed. See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=734765#17 for an example where it was necessary and see https://bugs.debian.org/698765 for the bug which argues that the text cited above is not entirely correct. Regards, Axel -- ,''`. | Axel Beckert , http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] Bug#812428: libgcrypt20: please make the build reproducible (timestamps)
On Sat 2016-01-23 16:52:09 -0500, Jérémy Bobbio wrote: > While working on the “reproducible builds” effort [1], we have noticed > that libgcrypt20 could not be built reproducibly. > > The attached patch adds support for SOURCE_DATE_EPOCH to set the value > of BUILD_TIMESTAMP defined in the configure script. Once applied, > libgcrypt20 is nearly reproducible in our current experimental > framework—their might be remaining timestamps in the PDF documentation. Thanks for fixing this, Lunar. fwiw, libgcrypt upstream is the same folks as libgpg-error upstream. In response to concerns about reproducible builds, libgpg-error 1.20 switched to not embedding the build timestamp at all upstream by default. Perhaps they'd be open to the same approach for libgcrypt if it were proposed. > --- a/debian/rules > +++ b/debian/rules > @@ -48,4 +48,4 @@ override_dh_gencontrol: > dh_gencontrol --remaining-packages > > %: > - dh $@ --parallel --with autotools_dev > + dh $@ --parallel --with autoreconf --with autotools_dev /usr/share/doc/autotools-dev/README.Debian.gz says: >> Do NOT use dh-autoreconf and dh_autotools-dev_* helpers at the same >> time, dh-autoreconf takes care of updating config.sub and >> config.guess by itself. Regards, --dkg ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
