Re: [Resteasy-users] Why no client.close()?

2014-05-29 Thread Bill Burke
THere is a finalize in ApacheHttpClient4Engine. We actually have a unit test that tests GC for responses and clients. But, you should never rely on finalize. Its really bad practice. The examples are a poor job on my end if they don't do close. On 5/28/2014 5:16 PM, Guy Rouillier wrote: > Th

Re: [Resteasy-users] Why no client.close()?

2014-05-28 Thread Guy Rouillier
Thanks for the reply, Bill. I cloned the RESTEasy repo so I could look at the latest source. I see that ResteasyClient.java has a close() method, but no finalize(). So, I suppose the most conservative course of action would be to specifically invoke ResteasyClient.close() in a finally block

Re: [Resteasy-users] Why no client.close()?

2014-05-28 Thread Bill Burke
Oh, one more thing. ResteasyClient does implement finalize and will close during garbage collection. On 5/28/2014 12:49 AM, Guy Rouillier wrote: > The RESTEasy documentation specifically says (section 48.3): > > "Finally, if your javax.ws.rs.client.Client class has created the engine > automatic

Re: [Resteasy-users] Why no client.close()?

2014-05-28 Thread Bill Burke
The examples are bad examples of clean code. On 5/28/2014 12:49 AM, Guy Rouillier wrote: > The RESTEasy documentation specifically says (section 48.3): > > "Finally, if your javax.ws.rs.client.Client class has created the engine > automatically for you, you should call Client.close() and this will

[Resteasy-users] Why no client.close()?

2014-05-27 Thread Guy Rouillier
The RESTEasy documentation specifically says (section 48.3): "Finally, if your javax.ws.rs.client.Client class has created the engine automatically for you, you should call Client.close() and this will clean up any socket connections." Yet the overwhelming majority of examples I can find, inclu