Re: Does reviewboard support new review notifications other than email?

2010-01-29 Thread Tino Breddin
Thanks for the update. I guess I'll look into the code to see how I can apply the hooks I need. Tino On Jan 28, 10:50 pm, Christian Hammond chip...@chipx86.com wrote: Hi Tino, WebHooks are going to go into the 1.6 release. We're hoping for this to be a quick release after 1.5 (a few months

Re: SHIP IT countre is zero even if reviewer clicks ship it.

2010-01-29 Thread Kunjal
Chris. Here is what happening. Reviewer mark the review Ship It. In the night, I generate the report saying how many reviews are apprved or how many are pending etc. I create the query and get the data of SHIP IT counter: my $query = SELECT r1.id, submitter_id, r2.username, r2.first_name,

Re: SHIP IT countre is zero even if reviewer clicks ship it.

2010-01-29 Thread Christian Hammond
Hi, I'd love to provide a patch, except I don't think Review Board is broken. This works fine from what I can tell, and the code has not changed since we introduced it. I'm not convinced the query is correct, though. That ship_it column is not a counter. It's a boolean flag, meaning that you'll