Here is what happening.
Reviewer mark the review Ship It.
In the night, I generate the report saying how many reviews are
apprved or how many are pending etc.
I create the query and get the data of SHIP IT counter:
my $query = "
SELECT r1.id, submitter_id, r2.username, r2.first_name, r2.last_name,
changenum ,time_added, description, ship_it FROM
reviewboard.reviews_reviewrequest r1 LEFT OUTER JOIN
diffviewer_diffset n1 on r1.diffset_history_id=n1.history_id LEFT
OUTER JOIN diffviewer_filediff n2 on n1.id=n2.diffset_id LEFT OUTER
JOIN reviewboard.reviews_review r ON r1.id=r.review_request_id LEFT
OUTER JOIN reviewboard.auth_user r2 ON submitter_id=r2.id where
description like '$uniqueKey';
>From this query result, I found the value of SHIP IT counter and
report whether reveiew is approved or pending.
So, for few users we are observing that even if they click on Ship It,
the value of ship_it counter is zero.
We are having more of such issue now a days.
Someone report one more issue and issue escalated to director level !!
Can your team provide any patch release?
We are using mySQL database.
On Jan 28, 2:46 pm, Christian Hammond <chip...@chipx86.com> wrote:
> So, they click Ship It, publish the review, and you see the review with the
> Ship It but you don't see that on the dashboard?
> This sounds like the code for bumping up the Ship It counter
> (ReviewRequest.increment_ship_it in reviewboard/reviews/models.py) is not
> working correctly. What database are you using?
> The last login time should be fine. I believe that's just storing when they
> actually performed the login, and the cookie has kept him logged in ever
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
> On Thu, Jan 28, 2010 at 9:38 AM, Kunjal <kunjal.par...@gmail.com> wrote:
> > Hello,
> > For one of our user, he does have active account and when he approves
> > the review, the ship it counter is still zero.
> > Why this is happening?
> > When I debug this, I found that the user did logged in RB today but in
> > the Submitters list, it is showing his last login as 2009-12-17.
> > Is this causing issue? Where should I debug for this?
> > Kunjal
> > --
> > Want to help the Review Board project? Donate today at
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~----------~----~----~----~------~----~------~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> > For more options, visit this group at
> >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text -
> - Show quoted text -
Want to help the Review Board project? Donate today at
Happy user? Let us know at http://www.reviewboard.org/users/
To unsubscribe from this group, send email to
For more options, visit this group at