Re: Marking a review as currently being reviewed

2010-05-28 Thread Thilo-Alexander Ginkel
On Wed, May 26, 2010 at 21:47, David Trowbridge trowb...@gmail.com wrote: There aren't any better ways to do it, since this is kind of contrary to the use cases we had when building RB. I personally like it when more than one person looks at a review--more eyes means more bugs are caught early

Re: Configuring LDAPS

2010-05-28 Thread Martelo
Hi, thanks for your reply... But unfortunately, still with no success... The error is: - WARNING - LDAP error: {'info': 'error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed', 'desc': Can't contact LDAP server} If that's not working, it may be a certificate issue.

Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.

2010-05-28 Thread reviewboard
Comment #2 on issue 1524 by alex.remen: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 Easy enough to fix by using --no-ext-diff, attaching a patch that fixes it for me at least. Attachments:

Re: Issue 1668 in reviewboard: Diffs not applying cleanly circa 1.0.7 with odd line endings

2010-05-28 Thread reviewboard
Comment #3 on issue 1668 by AaronJSherman: Diffs not applying cleanly circa 1.0.7 with odd line endings http://code.google.com/p/reviewboard/issues/detail?id=1668 Ah, OK, here's the easiest way to reproduce. This worked on a file we had checked in: Open an *existing* file (my post above