Pre-Commit Workflow

2014-02-15 Thread Charles Yates
Hi, We're trying to follow a pre-commit workflow with bzr with all patches submitted to the review board prior to checkin to the repo - I was wondering anyone had any experience with this and how best to handle pending patches. Sometimes it's inconvenient to wait for the review process to be

Re: The current directory does not contain a checkout... (problem posting from perforce)

2014-02-15 Thread David Trowbridge
Greg, You're probably getting hit by case mismatches ( https://code.google.com/p/reviewboard/issues/detail?id=3221). We'll be fixing this for 0.5.8. -David On Wed, Feb 12, 2014 at 5:14 PM, Greg Dean g...@familydean.net wrote: Hi there, I've updated to 0.5.7 and I'm running from cygwin and I

Issue 3251 in reviewboard: The supplied diff file is too large for patch file

2014-02-15 Thread reviewboard
Status: New Owner: Labels: Type-Defect Component-Docs New issue 3251 by bentsai0...@gmail.com: The supplied diff file is too large for patch file http://code.google.com/p/reviewboard/issues/detail?id=3251 The supplied diff file is too large error while upload the patch file. The patch

Re: Issue 3251 in reviewboard: The supplied diff file is too large for patch file

2014-02-15 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 3251 by trowb...@gmail.com: The supplied diff file is too large for patch file http://code.google.com/p/reviewboard/issues/detail?id=3251 How are you creating/uploading the diff? In general, patches which are large enough to trigger

Re: Issue 3201 in reviewboard: Put a link next to rich-text fields.

2014-02-15 Thread reviewboard
Updates: Status: Fixed Comment #3 on issue 3201 by trowb...@gmail.com: Put a link next to rich-text fields. http://code.google.com/p/reviewboard/issues/detail?id=3201 Fixed in master (997ad1a). Thanks! -- You received this message because this project is configured to send all

Re: Issue 3248 in reviewboard: rbt: svn client incorrectly detects history scheduled with commit, always requires --svn-show-copies-as-adds=y/n

2014-02-15 Thread reviewboard
Updates: Status: Fixed Comment #3 on issue 3248 by trowb...@gmail.com: rbt: svn client incorrectly detects history scheduled with commit, always requires --svn-show-copies-as-adds=y/n http://code.google.com/p/reviewboard/issues/detail?id=3248 Fixed in rbtools master (2d19868).

Re: Issue 3247 in reviewboard: Mid-review, uploading a screenshot seems to fail. Uploading after review shows 2x of the same screenshot

2014-02-15 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 3247 by trowb...@gmail.com: Mid-review, uploading a screenshot seems to fail. Uploading after review shows 2x of the same screenshot http://code.google.com/p/reviewboard/issues/detail?id=3247 When you upload the screenshot, are you

Re: Issue 2751 in reviewboard: Images with file names longer than 72 characters can not be properly uploaded as screenshots

2014-02-15 Thread reviewboard
Updates: Status: Fixed Comment #9 on issue 2751 by trowb...@gmail.com: Images with file names longer than 72 characters can not be properly uploaded as screenshots http://code.google.com/p/reviewboard/issues/detail?id=2751 This is obsolete. The file attachments backend uses a much

Re: Issue 3221 in reviewboard: get_repository_info in perforce.py fails if norm_cwd and norm_client_root have different cases.

2014-02-15 Thread reviewboard
Updates: Status: Fixed Comment #2 on issue 3221 by trowb...@gmail.com: get_repository_info in perforce.py fails if norm_cwd and norm_client_root have different cases. http://code.google.com/p/reviewboard/issues/detail?id=3221 Fixed in release-0.5.x (446a656). Thanks! -- You received

Re: Issue 2702 in reviewboard: can not post-review iphone retina image named xxx@2x

2014-02-15 Thread reviewboard
Updates: Status: Fixed Comment #4 on issue 2702 by trowb...@gmail.com: can not post-review iphone retina image named xxx@2x http://code.google.com/p/reviewboard/issues/detail?id=2702 Fixed in rbtools master (c4002b9). This will ship in 0.6. -- You received this message because this

Re: Issue 48 in reviewboard: Add number of lines changed to dashboard view

2014-02-15 Thread reviewboard
Updates: Status: Fixed Comment #10 on issue 48 by trowb...@gmail.com: Add number of lines changed to dashboard view http://code.google.com/p/reviewboard/issues/detail?id=48 Fixed in master (7ba68fe). Whoo! -- You received this message because this project is configured to send all