Re: Binary Files handling in RB 1.0.5

2009-12-04 Thread Kunjal
Thanks..This is dummy question but I can not find post-review script any where on my linux distribution. I search all the files and folder and nothing is there. We definately installed RB tools. Kunjal On Dec 2, 12:41 pm, Christian Hammond chip...@chipx86.com wrote: Hi Kunjal,

Re: Binary Files handling in RB 1.0.5

2009-12-02 Thread Kunjal
Chris, I think we have not updated post-review for a while. Where to find it in RB website? Can you point me location? Kunjal On Dec 1, 5:22 pm, Christian Hammond chip...@chipx86.com wrote: Tom is right, they should be filtered so long as Perforce has them listed as binary files. How

Re: Binary Files handling in RB 1.0.5

2009-12-02 Thread Christian Hammond
Hi Kunjal, See: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ And the section on nightlies at: http://www.reviewboard.org/docs/manual/dev/admin/installation/development-releases/ Christian -- Christian Hammond - chip...@chipx86.com Review Board -

Re: Binary Files handling in RB 1.0.5

2009-12-01 Thread Tom Sakkos
Assuming that the files are marked as Binary files in Perforce, Review-Board should ignore them and properly say something along the lines of Binary files differ. -Tom On Tue, Dec 1, 2009 at 6:51 PM, Kunjal kunjal.par...@gmail.com wrote: Hello, In our development environment, we have lot of

Re: Binary Files handling in RB 1.0.5

2009-12-01 Thread Kunjal
The perforce has marked them as binary file. Why I get error message instead of some standard message saying this is binary file or similar? Do I need to install some patch ? On Dec 1, 5:04 pm, Tom Sakkos nasis...@gmail.com wrote: Assuming that the files are marked as Binary files in Perforce,

Re: Binary Files handling in RB 1.0.5

2009-12-01 Thread Christian Hammond
Tom is right, they should be filtered so long as Perforce has them listed as binary files. How recent is your post-review? I'd recommend trying a nightly and seeing if the problem goes away. I seem to recall a corrupt patch issue that was fixed when using binary files, which may trigger this.