Re: Cache collisions with memcached

2010-04-08 Thread Gilles Moris
On Thursday 08 April 2010 01:18:33 am Christian Hammond wrote: The very first part of the key contains the site site's domain, so as long as each reviewboard instance is using a different domain, it should work. Are you running subdir installs? It's possible that could cause problems. Does

Cache collisions with memcached

2010-04-07 Thread Chris Trimble
Have people who have widely deployed reviewboard even seen diffs showing up in the wrong review? I just have. A random other file would be shown in the place of a diff section. It turned out that memcached was having issues, I imagine a key collision? I shut it down and the problem went away,

Re: Cache collisions with memcached

2010-04-07 Thread Christian Hammond
I've never seen that, and we're pretty careful to key off everything with unique data representing a particular diff. It worries me that you're seeing this. The very first part of the key contains the site site's domain, so as long as each reviewboard instance is using a different domain, it

Re: Cache collisions with memcached

2010-04-07 Thread Chris Trimble
On Wed, Apr 7, 2010 at 4:18 PM, Christian Hammond chip...@chipx86.comwrote: Are you running subdir installs? It's possible that could cause problems. Yup, I'm betting that's it. We have a central reviewboard server with subdirs. Should I look at patching that code in djblets? - Chris --

Re: Cache collisions with memcached

2010-04-07 Thread Christian Hammond
That'd be good, yeah. The code would have to look for settings.SITE_ROOT, and it should be optional (as users of Djblets may not use SITE_ROOT). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Apr 7,