Re: ReviewRequestApprovalHook not working (Reviewboard 3.0.x )

2018-10-05 Thread Raja
Thanks Christian. It looks like if I wanted to show some info on the ReviewRequestView page based on those attributes (approved/approvalFailure), I could setup some listeners that will get the model and display them as an alert. They wont block the action but I can show some info based on those

Re: ReviewRequestApprovalHook not working (Reviewboard 3.0.x )

2018-10-05 Thread Christian Hammond
Hi Raja, The hook doesn't influence anything in the UI. It's used for integrations that make use of the API to check if a review request has been approved (through the 'approved' and 'approval_failure' fields). This is intended for use in repository pre-commit hooks or in custom integrations.

ReviewRequestApprovalHook not working (Reviewboard 3.0.x )

2018-10-05 Thread Raja
Hi, Im trying to build a custom extension following the example in https://www.reviewboard.org/docs/manual/3.0/extending/extensions/hooks/review-request-approval-hook/#review-request-approval-hook to check if a user needs to have X number of Ship-Its before its approved. I have installed the