Re: Stripping comments from patches -- not so good

2009-08-04 Thread Dan Savilonis
Hi Joyjit, Are you talking about comments that precede the actual diff in the patch? This is a problem for git patches, and a bug 1229 is open for it. I looked into the issue a bit and I think it can be resolved by maintaining the extra info as part of the diff set. Right now, RB splits the diff

Re: Stripping comments from patches -- not so good

2009-08-04 Thread Joyjit Nath
Yes, I am referring to the comments that preced the actual diff in the patch. Reviewboard throws them away, which makes it a kind of severe limitation for us to use in our workflow (which uses git). Thanks On Tue, Aug 4, 2009 at 4:19 PM, Dan Savilonisd...@n-cube.org wrote: Hi Joyjit, Are

Stripping comments from patches -- not so good

2009-07-29 Thread joyjit
When one submits a patch file (in unified diff format), reviewboard seems to throw away the comments that are embedded in the patch file. This is not good. It would be nice to have reviewboard accept those comments and add it to the Description field. And it would also be nice for reviewboard