Re: ReviewBoard Integration with GIT
I am using 1.0.5.1 On Jan 25, 3:12 pm, Christian Hammond chip...@chipx86.com wrote: What version of Git are you using? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Jan 25, 2010 at 10:13 AM, Kunjal kunjal.par...@gmail.com wrote: I just try to post the review. my git branch -a shows: git branch -a donut * kunjal postreview.py --parent=origin/donut Failed to execute command: ['git', 'diff', '--no-color', '--full- index', 'master'] fatal: ambiguous argument 'master': unknown revision or path not in the working tree. Use '--' to separate paths from revisions On Jan 25, 9:48 am, Kunjal kunjal.par...@gmail.com wrote: Thanks a lot. One question... In the Add repository dialog, I have provided repository path as git://mobcom-git.sj.broadcom.com/git_repos. Is that correct? We have our all repositories stored at /projects/xxx/xxx/git_repos. Also, on the local workspace, user must do -- git config reviewboard.urlhttp://reviewboard.example.com This could be part of .cshrc file so every user does not have to do it all the time. After I do 2 above steps, am I ready to post-review or some more config is needed? I am using nigthlies as of Jan25. Kunjal On Jan 24, 5:20 pm, Christian Hammond chip...@chipx86.com wrote: Hi, Git support in Review Board 1.1 (soon to be renamed 1.5) is much better than in 1.0.x. Git has no concept of checking out individual files from a remote repository, so in 1.0.x, you need to make sure that you have a repository on a filesystem accessible from the Review Board server and it needs to be constantly up-to-date with a master repository. In 1.5, if you have a web-based repository viewer set up for your Git repository (such as cgit, gitweb, GitHub, etc.) then you can specify a path to a raw file URL that provides a raw checkout of the file based on revision and filename. Review Board will use this to grab the files instead of needing a local checkout. It's much easier to maintain, and we're going to recommend this route going forward. As for post-review, it's had Git support for a long time. I imagine your copy is just out of date. The class should be named GitClient. The nightles are preferred for Git, though, as there's a number of important fixes for determining parent branches. I plan to cut a release soon. To run post-review with Git, you can just type `post-review` and it will generate a diff from the origin to HEAD. If you specify --parent=branchname then it will generate from branchname to HEAD. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Jan 24, 2010 at 5:11 PM, Kunjal kunjal.par...@gmail.com wrote: Last question... Does the GIT support available in RB 1.0.5 or I have to move to RB 1.1 Alpha 2? Sorry for all these questions. On Jan 24, 12:04 pm, Kunjal kunjal.par...@gmail.com wrote: One more thing... The post-review script we have has the class called PerforceClient which gets the repository info. and creates diff. I do not see any class for GITClient. Do I need to create such class on my own? Thanks Kunjal On Jan 23, 11:10 am, Kunjal kunjal.par...@gmail.com wrote: Hello Chris, We do have RB-Perforce integration working perfect! We want RB-GIT integration as well. Here are the steps I can think of. Can you evaluate it? 1. Add new repository for GIT in RB. 2. Install RB tools in Linux machines. We do have our own version of post-review. can we just replace it? 3. what are the commands to be used to post review? For perforce, we are using post-review.exe 234545 For GIT, I have to give latest commit number? post-review 0er545455 ? 4. Any other things I need to take care. Thanks for your help. Kunjal- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en-Hidequoted text - - Show quoted text -- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/
RB Security Concern
Hello, We have enabled RB with Active Directory. I can see that ReviewBoard uses http to login, and not https. I am no expert in these matters, but according to my old knowledge this means that the username and password is being sent in clear text on Broadcom intranet. This seems a bit unsafe to me, especially considering that we now use windows passwords. Is this how RB works? Is there a work around? Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB Security Concern
You can put the entire site on HTTPS if you want. Review Board doesn't limit you to HTTP or HTTPS. Set the correct URL in your admin settings, and if necessary set up Apache to redirect automatically to the HTTPS URL. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Jan 26, 2010 at 9:56 AM, Kunjal kunjal.par...@gmail.com wrote: Hello, We have enabled RB with Active Directory. I can see that ReviewBoard uses http to login, and not https. I am no expert in these matters, but according to my old knowledge this means that the username and password is being sent in clear text on Broadcom intranet. This seems a bit unsafe to me, especially considering that we now use windows passwords. Is this how RB works? Is there a work around? Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Integration with GIT
Git, not Review Board. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Jan 26, 2010 at 9:55 AM, Kunjal kunjal.par...@gmail.com wrote: I am using 1.0.5.1 On Jan 25, 3:12 pm, Christian Hammond chip...@chipx86.com wrote: What version of Git are you using? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Jan 25, 2010 at 10:13 AM, Kunjal kunjal.par...@gmail.com wrote: I just try to post the review. my git branch -a shows: git branch -a donut * kunjal postreview.py --parent=origin/donut Failed to execute command: ['git', 'diff', '--no-color', '--full- index', 'master'] fatal: ambiguous argument 'master': unknown revision or path not in the working tree. Use '--' to separate paths from revisions On Jan 25, 9:48 am, Kunjal kunjal.par...@gmail.com wrote: Thanks a lot. One question... In the Add repository dialog, I have provided repository path as git://mobcom-git.sj.broadcom.com/git_repos. Is that correct? We have our all repositories stored at /projects/xxx/xxx/git_repos. Also, on the local workspace, user must do -- git config reviewboard.urlhttp://reviewboard.example.com This could be part of .cshrc file so every user does not have to do it all the time. After I do 2 above steps, am I ready to post-review or some more config is needed? I am using nigthlies as of Jan25. Kunjal On Jan 24, 5:20 pm, Christian Hammond chip...@chipx86.com wrote: Hi, Git support in Review Board 1.1 (soon to be renamed 1.5) is much better than in 1.0.x. Git has no concept of checking out individual files from a remote repository, so in 1.0.x, you need to make sure that you have a repository on a filesystem accessible from the Review Board server and it needs to be constantly up-to-date with a master repository. In 1.5, if you have a web-based repository viewer set up for your Git repository (such as cgit, gitweb, GitHub, etc.) then you can specify a path to a raw file URL that provides a raw checkout of the file based on revision and filename. Review Board will use this to grab the files instead of needing a local checkout. It's much easier to maintain, and we're going to recommend this route going forward. As for post-review, it's had Git support for a long time. I imagine your copy is just out of date. The class should be named GitClient. The nightles are preferred for Git, though, as there's a number of important fixes for determining parent branches. I plan to cut a release soon. To run post-review with Git, you can just type `post-review` and it will generate a diff from the origin to HEAD. If you specify --parent=branchname then it will generate from branchname to HEAD. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Jan 24, 2010 at 5:11 PM, Kunjal kunjal.par...@gmail.com wrote: Last question... Does the GIT support available in RB 1.0.5 or I have to move to RB 1.1 Alpha 2? Sorry for all these questions. On Jan 24, 12:04 pm, Kunjal kunjal.par...@gmail.com wrote: One more thing... The post-review script we have has the class called PerforceClient which gets the repository info. and creates diff. I do not see any class for GITClient. Do I need to create such class on my own? Thanks Kunjal On Jan 23, 11:10 am, Kunjal kunjal.par...@gmail.com wrote: Hello Chris, We do have RB-Perforce integration working perfect! We want RB-GIT integration as well. Here are the steps I can think of. Can you evaluate it? 1. Add new repository for GIT in RB. 2. Install RB tools in Linux machines. We do have our own version of post-review. can we just replace it? 3. what are the commands to be used to post review? For perforce, we are using post-review.exe 234545 For GIT, I have to give latest commit number? post-review 0er545455 ? 4. Any other things I need to take care. Thanks for your help. Kunjal- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
Re: Unable to upload screenshots
No, I'm still stuck with this. -David On Tue, Jan 26, 2010 at 6:33 PM, Thilo-Alexander Ginkel th...@ginkel.comwrote: On Thu, Jan 7, 2010 at 08:34, David Resnick abune...@gmail.com wrote: Well, loading the image in PIL from the command line works. I am facing the same issue. Command line image loading works, but uploading through the RB UI fails: $ python Python 2.6 (r26:66714, Feb 21 2009, 02:16:04) [GCC 4.3.2 [gcc-4_3-branch revision 141291]] on linux2 Type help, copyright, credits or license for more information. from PIL import Image Image.open(screenshot.png) PIL.PngImagePlugin.PngImageFile instance at 0x7f1ee8babdd0 Have you been able to figure out what was wrong in your case? Unfortunately, I cannot add any further details as Review Board only intermittently writes to its log file (the last time on Jan 16th - nothing has been changed since then). Regards, Thilo -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Integration with GIT
git version 1.6.0.4 On Jan 26, 11:39 am, Christian Hammond chip...@chipx86.com wrote: Git, not Review Board. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Jan 26, 2010 at 9:55 AM, Kunjal kunjal.par...@gmail.com wrote: I am using 1.0.5.1 On Jan 25, 3:12 pm, Christian Hammond chip...@chipx86.com wrote: What version of Git are you using? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Jan 25, 2010 at 10:13 AM, Kunjal kunjal.par...@gmail.com wrote: I just try to post the review. my git branch -a shows: git branch -a donut * kunjal postreview.py --parent=origin/donut Failed to execute command: ['git', 'diff', '--no-color', '--full- index', 'master'] fatal: ambiguous argument 'master': unknown revision or path not in the working tree. Use '--' to separate paths from revisions On Jan 25, 9:48 am, Kunjal kunjal.par...@gmail.com wrote: Thanks a lot. One question... In the Add repository dialog, I have provided repository path as git://mobcom-git.sj.broadcom.com/git_repos. Is that correct? We have our all repositories stored at /projects/xxx/xxx/git_repos. Also, on the local workspace, user must do -- git config reviewboard.urlhttp://reviewboard.example.com This could be part of .cshrc file so every user does not have to do it all the time. After I do 2 above steps, am I ready to post-review or some more config is needed? I am using nigthlies as of Jan25. Kunjal On Jan 24, 5:20 pm, Christian Hammond chip...@chipx86.com wrote: Hi, Git support in Review Board 1.1 (soon to be renamed 1.5) is much better than in 1.0.x. Git has no concept of checking out individual files from a remote repository, so in 1.0.x, you need to make sure that you have a repository on a filesystem accessible from the Review Board server and it needs to be constantly up-to-date with a master repository. In 1.5, if you have a web-based repository viewer set up for your Git repository (such as cgit, gitweb, GitHub, etc.) then you can specify a path to a raw file URL that provides a raw checkout of the file based on revision and filename. Review Board will use this to grab the files instead of needing a local checkout. It's much easier to maintain, and we're going to recommend this route going forward. As for post-review, it's had Git support for a long time. I imagine your copy is just out of date. The class should be named GitClient. The nightles are preferred for Git, though, as there's a number of important fixes for determining parent branches. I plan to cut a release soon. To run post-review with Git, you can just type `post-review` and it will generate a diff from the origin to HEAD. If you specify --parent=branchname then it will generate from branchname to HEAD. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Jan 24, 2010 at 5:11 PM, Kunjal kunjal.par...@gmail.com wrote: Last question... Does the GIT support available in RB 1.0.5 or I have to move to RB 1.1 Alpha 2? Sorry for all these questions. On Jan 24, 12:04 pm, Kunjal kunjal.par...@gmail.com wrote: One more thing... The post-review script we have has the class called PerforceClient which gets the repository info. and creates diff. I do not see any class for GITClient. Do I need to create such class on my own? Thanks Kunjal On Jan 23, 11:10 am, Kunjal kunjal.par...@gmail.com wrote: Hello Chris, We do have RB-Perforce integration working perfect! We want RB-GIT integration as well. Here are the steps I can think of. Can you evaluate it? 1. Add new repository for GIT in RB. 2. Install RB tools in Linux machines. We do have our own version of post-review. can we just replace it? 3. what are the commands to be used to post review? For perforce, we are using post-review.exe 234545 For GIT, I have to give latest commit number? post-review 0er545455 ? 4. Any other things I need to take care. Thanks for your help. Kunjal- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/
Re: Access is denied using post-review with ClearCase under Cygwin
After use dynamic view and made changes in ClearCaseClient class in
postreview I stop getting this problem.
On Jan 25, 5:14 pm, Jan Koprowski jan.koprow...@gmail.com wrote:
Hi!
On the beginning I want to say that ReviewBoard is great tool. The
best I have ever seen. Excellent job!
I'am trying to use ReviewBoard in ClearCase under Windows. I was
install whole stuff (ReviewBoard and RBTools) using easy_install under
Windows cmd. I made new snapshot etc... Then I installed cygwin (I
don't know is the order is correct) and run there:
$ post-review index.wsgi --server localhost
Traceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in
module
load_entry_point('RBTools==0.2beta2', 'console_scripts', 'post-
review')()
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 2520, in main
diff, parent_diff = tool.diff(args)
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 951, in diff
return self.do_diff(self.get_extended_namespace(files))
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 912, in get_extended_namespace
os.unlink(tf)
WindowsError: [Error 5] Access is denied: 'c:\\temp\
\62b637b6048cb59c9bf5e3ab0e37aa83'
I know only that c:\temp\62b637b6048cb59c9bf5e3ab0e37aa83 is read-only
and this is a problem but I don't know what fix environ to save this
normally. Any sugestions? After delete this file I get:
$ post-review index.wsgi --server localhost
Failed to execute command: ['cleartool', 'get', '-to', 'c:\\temp\
\81c147b7ee258f26c9cc2854623b769c', 'C:\\Snapshots\\jkoprows_view\
\SCM_tools\\scripts\\ReleaseRobot\\index.wsgi@@\\main\\3\n']
cleartool: Error: C:\Snapshots\jkoprows_view\SCM_tools\scripts
\ReleaseRobot\index.wsgi@@\main\3 does not exist, or is not a
ClearCase version, or is a checked out version which was removed.
C:\\Snapshots\\jkoprows_view\\SCM_tools\\scripts\\ReleaseRobot\
\index.wsgi file is checkedin on 100% so I don't know why this is
wrong.
--
Greetings from Poland
Jan Koprowski
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Post review with combination of binary + txt file does not work
Hello Chris, With RB 1.0.5.1, when someone post the review with 1 binary file + 1 txt file, RB should filter out the binary file but txt file should be able to get reviewed in RB. We are getting below message when the user look at the RB web after posting review. When I test RB, I could post review with few binary files + few text file and it filter out binary files correctly. Why this issue re-surfacing now? Does it depend on type of file? The files we have are called .spr file and they are marked as BINARY in perforce. The patch to 'C:/Builds/Mobcom/sysDev/21331/MMI_2/msp/stack/hedge/sdt/ usimap.spr' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.GAdWou' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.GAdWou/tmp4nYJKO Hunk #1 succeeded at 4297 (offset 187 lines). Hunk #2 succeeded at 4367 (offset 2 lines). Hunk #3 succeeded at 9821 (offset 335 lines). Hunk #4 succeeded at 9538 (offset 2 lines). Hunk #5 succeeded at 16413 (offset 608 lines). Hunk #6 succeeded at 17689 (offset 147 lines). Hunk #7 succeeded at 21659 (offset 760 lines). Hunk #8 succeeded at 24243 (offset 586 lines). Hunk #9 succeeded at 25320 (offset 809 lines). Hunk #10 succeeded at 25777 (offset 625 lines). patch: malformed patch at line 171: ]]][ Traceback (most recent call last): File /projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ views.py, line 153, in view_diff interdiffset, highlighting, True) File /projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 623, in get_diff_files large_data=True) File /projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/Djblets-0.5.6-py2.5.egg/djblets/util/misc.py, line 162, in cache_memoize data = lookup_callable() File /projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 622, in lambda enable_syntax_highlighting), File /projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /projects/mob_reviewboard/xampp/1.6.4-brcm-v2/lib/python2.5/ site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to 'C:/Builds/Mobcom/sysDev/21331/MMI_2/msp/stack/ hedge/sdt/usimap.spr' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.GAdWou' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.GAdWou/tmp4nYJKO Hunk #1 succeeded at 4297 (offset 187 lines). Hunk #2 succeeded at 4367 (offset 2 lines). Hunk #3 succeeded at 9821 (offset 335 lines). Hunk #4 succeeded at 9538 (offset 2 lines). Hunk #5 succeeded at 16413 (offset 608 lines). Hunk #6 succeeded at 17689 (offset 147 lines). Hunk #7 succeeded at 21659 (offset 760 lines). Hunk #8 succeeded at 24243 (offset 586 lines). Hunk #9 succeeded at 25320 (offset 809 lines). Hunk #10 succeeded at 25777 (offset 625 lines). patch: malformed patch at line 171: ]]][ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: About the view diff page of reviewboard
Hi, Christian. I just can't understand how does ReviewBoard get the basic source file with the help of diff file. Yes I have set Repository path on ReviewBoard webUI, and on the Authentication setting, I use my CVS Id and password. But I am an ordinary user on CVS, I can't access other directories on CVS except that cvs administrator give me the authentication. Then how does reviewboard get basic source files on CVS with the path and my CVS account? And I have made a test. When I changed my Authentication account on CVS Repository setting, I still can generate ReviewRequest and make Review successfully. So I think may be the Authentication setting is useless for ReviewBoard. But without any CVS account, how did ReviewBoard get those basic source files from CVS server? Does that means any one without CVS authentication can get source file through ReviewBoard? Best Regards! On Jan 27, 3:53 am, Christian Hammond chip...@chipx86.com wrote: No, there's not. That would be a *lot* of work and isn't planned. It's a fundamental change to the way that Review Board works, and would make things confusing in the future. All the code for talking to repositories is in scmtools/. All the code for handling diffs is in diffviewer/. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Jan 26, 2010 at 1:36 AM, qhlonline qhlonl...@163.com wrote: Hi, Christian. Is there any way to generate Diff Review with only diff file without the basic source file? We don't want reviewers to see the whole content of the basic source file, We want them see only the diff part. I can't find the RB source code that get the basic file from CVS server, Is it defined in Djblets files? Best Regards! 在2010-01-26 15:35:07，Christian Hammond chip...@chipx86.com 写道： This is where the repository information you provide in the administration UI comes into play. Review Board downloads each file from the diff from the repository. It then makes a copy of the file, applies the patch, and generates its own diff (which contains information beyond what a standard diff can provide). The result of that is what gets sent to the user's browser. That code all lives in reviewboard/scmtools/* and reviewboard/diffviewer/*. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com 2010/1/25 qhlonline qhlonl...@163.com Hi, all. I am using Reviewboard 1.0.5.1 and my code repository is CVS. I had previously thought the post-review tool had only passed a unified cvs diff file to Reviewboard server, So on the view diff page, users can only see part of the file (where change take place). And I found now, I can click the *Expand changes* link to see the whole file. But I don't know how did the basic code file was provided to Reviewboard server. I don't think the file was posted by post-review tool, because I can create ReviewRequest through WebUI, And there I can only upload an cvs diff' file. So, can any body told me how did Reviewboard get the basic file of the review reqeust? and where can I read the source code about it? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+ unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at
