Reviewboard with RTC : Possible ?

2010-10-22 Thread gauri.khandekar
Hi,

I have ReviewBoard setup for my team. Our SCM  is Perforce.
Soon we'll be migrating SCM  from Perforce to RTC
Will I be able to use Reviewboard with RTC ?

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Reviewboard with RTC : Possible ?

2010-10-22 Thread Jan Koprowski
As far as I know there is no RTC support for Review Board.
But the good news :) is You can easily add new SCMTool support to
Review Board and this is not very hard.

On Fri, Oct 22, 2010 at 9:03 AM, gauri.khandekar
gauri.khande...@gmail.com wrote:
 Hi,

 I have ReviewBoard setup for my team. Our SCM  is Perforce.
 Soon we'll be migrating SCM  from Perforce to RTC
 Will I be able to use Reviewboard with RTC ?

 --
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en



-- 
 Jan Koprowski

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Error during creation of P4 SCM Repository

2010-10-22 Thread Dolphin
Hi All,

I am getting an error while creating the P4 SCM Repository.

The following error is displayed when I give all the details about
perforce server and save.
The Python module P4 is not installed.You may need to restart the
server after installing it (Highlighting the repository path in the
web UI).

when I check the installed Python modules. I can see P4 to be present.
Am I missing some thing???

Cheers,
Srini

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Error (with rather opaque Python diagnostic output) installing P4 integration

2010-10-22 Thread Thor Simon


On Oct 22, 6:39 am, Christian Hammond chip...@chipx86.com wrote:
 I believe this was a temporary problem. I can no longer reproduce it. Doing
 an easy_install P4PythonInstaller works fine now. Are you still hitting that
 same error?

 Are you by any chance behind a proxy?

Same error this morning.  We're not behind a proxy!

What's it trying to fetch from exactly where, anyway?
Can I fetch it by hand and point P4PythonInstaller at the fetched
file?

r...@reviewboard:/home/tls# easy_install P4PythonInstaller
install_dir /usr/local/lib/python2.6/dist-packages/
Searching for P4PythonInstaller
Reading http://pypi.python.org/simple/P4PythonInstaller/
Reading http://www.review-board.org/
Best match: P4PythonInstaller 0.2
Downloading 
http://reviewboard.googlecode.com/svn/trunk/P4PythonInstaller#egg=P4PythonInstaller-0.2
Doing subversion checkout from 
http://reviewboard.googlecode.com/svn/trunk/P4PythonInstaller
to /tmp/easy_install-rxpgT2/P4PythonInstaller
Processing P4PythonInstaller
Running setup.py -q bdist_egg --dist-dir /tmp/easy_install-rxpgT2/
P4PythonInstaller/egg-dist-tmp-LY5KtW
Downloading p4api.tgz...
Downloading p4python.tgz...
Traceback (most recent call last):
  File /usr/bin/easy_install, line 9, in module
load_entry_point('distribute==0.6.14', 'console_scripts',
'easy_install')()
  File /usr/lib/python2.6/dist-packages/setuptools/command/
easy_install.py, line 1903, in main
with_ei_usage(lambda:
  File /usr/lib/python2.6/dist-packages/setuptools/command/
easy_install.py, line 1884, in with_ei_usage
return f()
  File /usr/lib/python2.6/dist-packages/setuptools/command/
easy_install.py, line 1907, in lambda
distclass=DistributionWithoutHelpCommands, **kw
  File /usr/lib/python2.6/distutils/core.py, line 152, in setup
dist.run_commands()
  File /usr/lib/python2.6/distutils/dist.py, line 975, in
run_commands
self.run_command(cmd)
  File /usr/lib/python2.6/distutils/dist.py, line 995, in
run_command
cmd_obj.run()
  File /usr/lib/python2.6/dist-packages/setuptools/command/
easy_install.py, line 361, in run
self.easy_install(spec, not self.no_deps)
  File /usr/lib/python2.6/dist-packages/setuptools/command/
easy_install.py, line 601, in easy_install
return self.install_item(spec, dist.location, tmpdir, deps)
  File /usr/lib/python2.6/dist-packages/setuptools/command/
easy_install.py, line 631, in install_item
dists = self.install_eggs(spec, download, tmpdir)
  File /usr/lib/python2.6/dist-packages/setuptools/command/
easy_install.py, line 821, in install_eggs
return self.build_and_install(setup_script, setup_base)
  File /usr/lib/python2.6/dist-packages/setuptools/command/
easy_install.py, line 1098, in build_and_install
self.run_setup(setup_script, setup_base, args)
  File /usr/lib/python2.6/dist-packages/setuptools/command/
easy_install.py, line 1087, in run_setup
run_setup(setup_script, args)
  File /usr/lib/python2.6/dist-packages/setuptools/sandbox.py, line
29, in run_setup
lambda: execfile(
  File /usr/lib/python2.6/dist-packages/setuptools/sandbox.py, line
70, in run
return func()
  File /usr/lib/python2.6/dist-packages/setuptools/sandbox.py, line
31, in lambda
{'__file__':setup_script, '__name__':'__main__'}
  File setup.py, line 176, in module

  File setup.py, line 145, in main

  File setup.py, line 34, in download

  File /usr/lib/python2.6/ftplib.py, line 570, in quit
resp = self.voidcmd('QUIT')
  File /usr/lib/python2.6/ftplib.py, line 248, in voidcmd
return self.voidresp()
  File /usr/lib/python2.6/ftplib.py, line 223, in voidresp
resp = self.getresp()
  File /usr/lib/python2.6/ftplib.py, line 209, in getresp
resp = self.getmultiline()
  File /usr/lib/python2.6/ftplib.py, line 195, in getmultiline
line = self.getline()
  File /usr/lib/python2.6/ftplib.py, line 185, in getline
if not line: raise EOFError
EOFError
r...@reviewboard:/home/tls#

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Problem in Adding CVS repository

2010-10-22 Thread Prabhat Chandra
Hi

My cvs repository is in path /home/cvsuser/cvsroot and usage rsh for .
I can see my CVS repository using cvsweb.

And able to checkout using cvs -d :ext:prab...@tn100:/home/cvsuser/
cvsroot co Modole_name and can see using cvsweb with url
http://tn100/cgi-bin/cvsweb. Can anyone tell what would be PATH and
MIRROR PATH to add this repository in Review Board.

I am usingReview Board version  1.5

Thanks in advance

Prabhat

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Problem in Adding CVS repository

2010-10-22 Thread Jan Koprowski
Start from reading this:
http://www.reviewboard.org/docs/manual/1.5/admin/management/repositories/#cvs

Regards,

On Fri, Oct 22, 2010 at 7:03 PM, Prabhat Chandra
prabhat.chand...@gmail.com wrote:
 Hi

 My cvs repository is in path /home/cvsuser/cvsroot and usage rsh for .
 I can see my CVS repository using cvsweb.

 And able to checkout using cvs -d :ext:prab...@tn100:/home/cvsuser/
 cvsroot co Modole_name and can see using cvsweb with url
 http://tn100/cgi-bin/cvsweb. Can anyone tell what would be PATH and
 MIRROR PATH to add this repository in Review Board.

 I am using    Review Board version      1.5

 Thanks in advance

 Prabhat

 --
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en



-- 
 Jan Koprowski

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Error (with rather opaque Python diagnostic output) installing P4 integration

2010-10-22 Thread Christian Hammond
What it tries to fetch varies between setups, as it's dependent on the
operating system and such.

The setup.py for P4PythonInstaller is at
http://reviewboard.googlecode.com/svn/trunk/P4PythonInstaller/. You can kind
of see what it's trying to get by looking at the perforce_hostname,
perforce_path, etc. variables in the setup.py file, the result of
get_p4api_path, and the steps in main(). If you're at all comfortable with
Python, you may want to do some debugging, or just grab the files and
perform the steps that main() performs to try to install this yourself.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Oct 22, 2010 at 5:34 AM, Thor Simon t...@panix.com wrote:



 On Oct 22, 6:39 am, Christian Hammond chip...@chipx86.com wrote:
  I believe this was a temporary problem. I can no longer reproduce it.
 Doing
  an easy_install P4PythonInstaller works fine now. Are you still hitting
 that
  same error?
 
  Are you by any chance behind a proxy?

 Same error this morning.  We're not behind a proxy!

 What's it trying to fetch from exactly where, anyway?
 Can I fetch it by hand and point P4PythonInstaller at the fetched
 file?

 r...@reviewboard:/home/tls# easy_install P4PythonInstaller
 install_dir /usr/local/lib/python2.6/dist-packages/
 Searching for P4PythonInstaller
 Reading http://pypi.python.org/simple/P4PythonInstaller/
 Reading http://www.review-board.org/
 Best match: P4PythonInstaller 0.2
 Downloading
 http://reviewboard.googlecode.com/svn/trunk/P4PythonInstaller#egg=P4PythonInstaller-0.2
 Doing subversion checkout from
 http://reviewboard.googlecode.com/svn/trunk/P4PythonInstaller
 to /tmp/easy_install-rxpgT2/P4PythonInstaller
 Processing P4PythonInstaller
 Running setup.py -q bdist_egg --dist-dir /tmp/easy_install-rxpgT2/
 P4PythonInstaller/egg-dist-tmp-LY5KtW
 Downloading p4api.tgz...
 Downloading p4python.tgz...
 Traceback (most recent call last):
  File /usr/bin/easy_install, line 9, in module
load_entry_point('distribute==0.6.14', 'console_scripts',
 'easy_install')()
  File /usr/lib/python2.6/dist-packages/setuptools/command/
 easy_install.py, line 1903, in main
with_ei_usage(lambda:
  File /usr/lib/python2.6/dist-packages/setuptools/command/
 easy_install.py, line 1884, in with_ei_usage
return f()
  File /usr/lib/python2.6/dist-packages/setuptools/command/
 easy_install.py, line 1907, in lambda
distclass=DistributionWithoutHelpCommands, **kw
  File /usr/lib/python2.6/distutils/core.py, line 152, in setup
dist.run_commands()
  File /usr/lib/python2.6/distutils/dist.py, line 975, in
 run_commands
self.run_command(cmd)
  File /usr/lib/python2.6/distutils/dist.py, line 995, in
 run_command
cmd_obj.run()
  File /usr/lib/python2.6/dist-packages/setuptools/command/
 easy_install.py, line 361, in run
self.easy_install(spec, not self.no_deps)
  File /usr/lib/python2.6/dist-packages/setuptools/command/
 easy_install.py, line 601, in easy_install
return self.install_item(spec, dist.location, tmpdir, deps)
  File /usr/lib/python2.6/dist-packages/setuptools/command/
 easy_install.py, line 631, in install_item
dists = self.install_eggs(spec, download, tmpdir)
  File /usr/lib/python2.6/dist-packages/setuptools/command/
 easy_install.py, line 821, in install_eggs
return self.build_and_install(setup_script, setup_base)
  File /usr/lib/python2.6/dist-packages/setuptools/command/
 easy_install.py, line 1098, in build_and_install
self.run_setup(setup_script, setup_base, args)
  File /usr/lib/python2.6/dist-packages/setuptools/command/
 easy_install.py, line 1087, in run_setup
run_setup(setup_script, args)
  File /usr/lib/python2.6/dist-packages/setuptools/sandbox.py, line
 29, in run_setup
lambda: execfile(
  File /usr/lib/python2.6/dist-packages/setuptools/sandbox.py, line
 70, in run
return func()
  File /usr/lib/python2.6/dist-packages/setuptools/sandbox.py, line
 31, in lambda
{'__file__':setup_script, '__name__':'__main__'}
  File setup.py, line 176, in module

  File setup.py, line 145, in main

  File setup.py, line 34, in download

  File /usr/lib/python2.6/ftplib.py, line 570, in quit
resp = self.voidcmd('QUIT')
  File /usr/lib/python2.6/ftplib.py, line 248, in voidcmd
return self.voidresp()
  File /usr/lib/python2.6/ftplib.py, line 223, in voidresp
resp = self.getresp()
  File /usr/lib/python2.6/ftplib.py, line 209, in getresp
resp = self.getmultiline()
  File /usr/lib/python2.6/ftplib.py, line 195, in getmultiline
line = self.getline()
  File /usr/lib/python2.6/ftplib.py, line 185, in getline
if not line: raise EOFError
 EOFError
 r...@reviewboard:/home/tls#

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 

Re: Issue 1687 in reviewboard: post-review API Error 105

2010-10-22 Thread reviewboard


Comment #7 on issue 1687 by mail4visu: post-review API Error 105
http://code.google.com/p/reviewboard/issues/detail?id=1687

Today I tried running post-review as shown below and I got error as The  
diff file is empty rather than previous The submitted file is empty  
error. How can I resolve this issue?


post-review --diff-filename=attr_fn_acl.c -d --server=http://x.y.z.a:8082

svn info
git rev-parse --git-dir
p4 info
repository info: Path: a.b.c.d:1666, Base path: None, Supports  
changesets: True

Looking for 'x.y.z.a /' cookie in /home/viswesn/.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request on trperforce01:2666 for None
HTTP POSTing to http://x.y.z.a:8082/api/json/reviewrequests/new/:  
{'repository_path': 'a.b.c.d:1666'}

Review request created
Uploading diff, size: 15723
HTTP POSTing to  
http://x.y.z.a:8082/api/json/reviewrequests/8/diff/new/: {}

Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'The diff file is empty']},  
u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors',  
u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}


Error uploading diff

The generated diff file was empty. This usually means no files were
modified in this change.

Try running with --output-diff and --debug for more information.

Your review request still exists, but the diff is not attached.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1860 in reviewboard: AttributeError: 'ReviewRequestDataGrid' object has no attribute 'id_list' accessing reviewboard

2010-10-22 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1860 by RodrigueAlcazar: AttributeError: 'ReviewRequestDataGrid'  
object has no attribute 'id_list' accessing reviewboard

http://code.google.com/p/reviewboard/issues/detail?id=1860

What version are you running?
1.0.9

What's the URL of the page containing the problem?
/dashboard

What steps will reproduce the problem?
1. Log in
2. Access the home page
3.

What is the expected output? What do you see instead?
I want to see the dashboard, instead I got a 500 (nice error message by the  
way)


What operating system are you using? What browser?
Linux, google chrome

Stack trace the admin received:

Traceback (most recent call last):

   
File /subversion/reviewboard/lib/python2.5/site-packages/django/core/handlers/base.py,  
line 100, in get_response

response = callback(request, *callback_args, **callback_kwargs)

   
File /subversion/reviewboard/lib/python2.5/site-packages/djblets/auth/util.py,  
line 46, in _checklogin

return view_func(request, *args, **kwargs)

   
File /subversion/reviewboard/lib/python2.5/site-packages/reviewboard/accounts/decorators.py,  
line 43, in _check_valid_prefs

return view_func(request, *args, **kwargs)

   
File /subversion/reviewboard/lib/python2.5/site-packages/reviewboard/reviews/views.py,  
line 308, in dashboard

return grid.render_to_response(template_name)

   
File /subversion/reviewboard/lib/python2.5/site-packages/djblets/datagrid/grids.py,  
line 700, in render_to_response

self.load_state()

   
File /subversion/reviewboard/lib/python2.5/site-packages/djblets/datagrid/grids.py,  
line 535, in load_state

self.precompute_objects()

   
File /subversion/reviewboard/lib/python2.5/site-packages/djblets/datagrid/grids.py,  
line 611, in precompute_objects

pk__in=self.id_list).order_by())

   
File /subversion/reviewboard/lib/python2.5/site-packages/reviewboard/reviews/datagrids.py,  
line 401, in post_process_queryset

queryset.with_counts(self.request.user))

   
File /subversion/reviewboard/lib/python2.5/site-packages/djblets/datagrid/grids.py,  
line 654, in post_process_queryset

queryset = column.augment_queryset(queryset)

   
File /subversion/reviewboard/lib/python2.5/site-packages/reviewboard/reviews/datagrids.py,  
line 53, in augment_queryset

pk__in=self.datagrid.id_list).values_list('pk', flat=True)

AttributeError: 'ReviewRequestDataGrid' object has no attribute 'id_list'


WSGIRequest
GET:QueryDict: {},
POST:QueryDict: {},
COOKIES:{'collapsediffs': 'True', 'rbsessionid': 
'1e08fcc315438b09dde11813abdffb57'},
META:{'DOCUMENT_ROOT': '/subversion/htdocs',
 'GATEWAY_INTERFACE': 'CGI/1.1',
 'HTTP_ACCEPT': 
'application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5',
 'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.3',
 'HTTP_ACCEPT_ENCODING': 'gzip,deflate,sdch',
 'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.8',
 'HTTP_CACHE_CONTROL': 'max-age=0',
 'HTTP_CONNECTION': 'keep-alive',
 'HTTP_COOKIE': 'rbsessionid=1e08fcc315438b09dde11813abdffb57;  
collapsediffs=True',

 'HTTP_HOST': 'reviewboard.renre.com',
 'HTTP_REFERER': 'http://reviewboard.renre.com/r/2284/',
 'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_4;  
en-US) AppleWebKit/534.7 (KHTML, like Gecko) Chrome/7.0.517.41  
Safari/534.7',

 'PATH': '/usr/bin:/bin',
 'PATH_INFO': u'/dashboard/',
 'PATH_TRANSLATED': 
'/subversion/configuration/dub-source02/reviewboard/reviewboard.wsgi/dashboard/',
 'QUERY_STRING': '',
 'REMOTE_ADDR': '10.114.204.28',
 'REMOTE_PORT': '56287',
 'REQUEST_METHOD': 'GET',
 'REQUEST_URI': '/dashboard/',
 'SCRIPT_FILENAME': 
'/subversion/configuration/dub-source02/reviewboard/reviewboard.wsgi',
 'SCRIPT_NAME': u'',
 'SCRIPT_URI': 'http://reviewboard.renre.com/dashboard/',
 'SCRIPT_URL': '/dashboard/',
 'SERVER_ADDR': '172.17.2.10',
 'SERVER_ADMIN': 'm...@europe.renre.com',
 'SERVER_NAME': 'reviewboard.renre.com',
 'SERVER_PORT': '80',
 'SERVER_PROTOCOL': 'HTTP/1.1',
 'SERVER_SIGNATURE': 'addressApache/2.2.9 (Unix) mod_ssl/2.2.9  
OpenSSL/0.9.8g DAV/2 SVN/1.6.5 mod_wsgi/2.4 Python/2.5.4 Server at  
reviewboard.renre.com Port 80/address\n',
 'SERVER_SOFTWARE': 'Apache/2.2.9 (Unix) mod_ssl/2.2.9 OpenSSL/0.9.8g DAV/2  
SVN/1.6.5 mod_wsgi/2.4 Python/2.5.4',

 'UNIQUE_ID': 'TMGV9H8AAAEAAAX0Zq0E',
 'mod_wsgi.application_group': 'reviewboard.renre.com|',
 'mod_wsgi.callable_object': 'application',
 'mod_wsgi.listener_host': '',
 'mod_wsgi.listener_port': '80',
 'mod_wsgi.process_group': 'reviewboard',
 'mod_wsgi.reload_mechanism': '1',
 'mod_wsgi.script_reloading': '1',
 'mod_wsgi.version': (2, 4),
 'wsgi.errors': mod_wsgi.Log object at 0xb129c90,
 'wsgi.file_wrapper': built-in method file_wrapper of mod_wsgi.Adapter  
object at 0xac01e40,

 'wsgi.input': mod_wsgi.Input object at 0xad52bf0,
 'wsgi.multiprocess': True,
 'wsgi.multithread': True,
 'wsgi.run_once': False,
 'wsgi.url_scheme': 'http',
 'wsgi.version': (1, 0)}


Issue 1861 in reviewboard: Review Request publishes nothing instead of saved text.

2010-10-22 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1861 by chrisnetapp: Review Request publishes nothing instead of  
saved text.

http://code.google.com/p/reviewboard/issues/detail?id=1861

*NOTE: Do not post confidential information in this bug report.*

What version are you running?
1.5 beta 1

What's the URL of the page containing the problem?
r/review#/# -- To request the review
r/review# -- After the request
r/review#/diff/#index_header -- where review is published.

What steps will reproduce the problem?
1. click on a review request
2. Add some text to the review request
3. Click save -- You should see the pending review text on the top of the  
review now

4. Perform some other operation For example View Diff of the review. -- Th
5. Click Publish
6. A blank review will be posted. The text you saved from step 3 is gone

What is the expected output? What do you see instead?
The text that was saved should of been displayed instead of a blank review


What operating system are you using? What browser?
Mac OS X 10.6.
Chrome 7.0.517.41


Please provide any additional information below.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1861 in reviewboard: Review Request publishes nothing instead of saved text.

2010-10-22 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 1861 by chipx86: Review Request publishes nothing  
instead of saved text.

http://code.google.com/p/reviewboard/issues/detail?id=1861

Please upgrade to RB 1.5 and see if it goes away. I believe this is an old  
bug, and haven't seen it in 1.5 final.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1862 in reviewboard: reviewboard running patch against empty files

2010-10-22 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1862 by scottl...@gmail.com: reviewboard running patch against  
empty files

http://code.google.com/p/reviewboard/issues/detail?id=1862

What is the problem?
Reviewboard is running patch against empty file(s) causing forked process  
to sleep waiting for input.


What version are you running?
Stable 1.5

What's the URL of the page containing the problem?
Not sure, most likely review page with diff.

What steps will reproduce the problem?
1. touch /tmp/1-new /tmp/1
2. patch -o /tmp/1-new /tmp/1

What operating system are you using? What browser?
Linux 2.6, RHEL5.4 x86_64

Please provide any additional information below.
$ ps ax | grep [p]atch
12701 ?S  0:00 patch -o /tmp/reviewboard.tTK8b4/tmpd9XDhV-new  
/tmp/reviewboard.tTK8b4/tmpd9XDhV
12702 ?S  0:00 patch -o /tmp/reviewboard.FgJfUi/tmpc03lfo-new  
/tmp/reviewboard.FgJfUi/tmpc03lfo
12703 ?S  0:00 patch -o /tmp/reviewboard.u2QOpe/tmpO6NOTd-new  
/tmp/reviewboard.u2QOpe/tmpO6NOTd
13496 ?S  0:00 patch -o /tmp/reviewboard.g2wQDt/tmpHeiBNY-new  
/tmp/reviewboard.g2wQDt/tmpHeiBNY
13497 ?S  0:00 patch -o /tmp/reviewboard.E_I1If/tmpuB2hxE-new  
/tmp/reviewboard.E_I1If/tmpuB2hxE
15142 ?S  0:00 patch -o /tmp/reviewboard.al3iUL/tmpIUo9GD-new  
/tmp/reviewboard.al3iUL/tmpIUo9GD
15143 ?S  0:00 patch -o /tmp/reviewboard.8vqdLL/tmpZBiuIY-new  
/tmp/reviewboard.8vqdLL/tmpZBiuIY
15144 ?S  0:00 patch -o /tmp/reviewboard._aEgqp/tmp2T2Mq8-new  
/tmp/reviewboard._aEgqp/tmp2T2Mq8
15145 ?S  0:00 patch -o /tmp/reviewboard.CP_FrE/tmpCJNp1z-new  
/tmp/reviewboard.CP_FrE/tmpCJNp1z


$ ls -la /tmp/reviewboard.tTK8b4/tmpd9XDhV-new  
/tmp/reviewboard.tTK8b4/tmpd9XDhV

-rw--- 1 $user $group 0 Oct 22 05:13 /tmp/reviewboard.tTK8b4/tmpd9XDhV
-rw--- 1 $user $group 0 Oct 22 18:44  
/tmp/reviewboard.tTK8b4/tmpd9XDhV-new


$ gdb /usr/bin/patch --pid=12701
...
(gdb) bt
#0  0x0032296c5f00 in __read_nocancel () from /lib64/libc.so.6
#1  0x00322966b853 in _IO_file_xsgetn_internal () from /lib64/libc.so.6
#2  0x003229661c82 in fread () from /lib64/libc.so.6
#3  0x0040baef in ?? ()
#4  0x004062e4 in ?? ()
#5  0x00322961d994 in __libc_start_main () from /lib64/libc.so.6
#6  0x00401c49 in ?? ()
#7  0x7fff7bb4f968 in ?? ()
#8  0x in ?? ()

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.