Re: Problem with uploading consecutive diffs with updates

2012-05-15 Thread Robert Dailey
This happens outside of interdiff too. There is never a reason to say something can't be fixed. It may be difficult, but not impossible. Either review-board or post-review has access to file revisions in Perforce. All you need to do is simply set your base (original) in the diff to be locked to

Re: Problem with uploading consecutive diffs with updates

2012-05-15 Thread Christian Hammond
I think there's a misunderstanding of the problem. If viewing a single diff (not comparing against two) is showing extra stuff in your change, then something is going wrong in your Perforce client, causing it to report improper revisions when building the diff. I can't say what that is, because

Re: post-review throw diff error

2012-05-15 Thread Nilesh Jaiswal
Hi Chris, Could you please provide me a solution to resolve the issue. Regards, Nilesh On Mon, May 14, 2012 at 3:40 PM, Nilesh Jaiswal nileshj...@gmail.comwrote: is this patch version mentioned in the email you are talking about.? Or something else. What do i need to do? On Mon, May 14,

Re: Review Request not published

2012-05-15 Thread Christian Hammond
Hi, It shouldn't be confused under those cases. If you have Chrome or a modern Firefox, it would really help to see the network transfer information on that request. That is, the HTTP request and response headers and payload. Both should offer a tab in their script developer UI for showing

Re: post-review throw diff error

2012-05-15 Thread Christian Hammond
Hi Nilesh, That version seems right, but I don't know why you're hitting that problem. Was that the version of patch running on the server? What happens if you try patching that file locally with the same patch? Christian -- Christian Hammond - chip...@chipx86.com Review Board -

Re: Issue 2585 in reviewboard: Reviewboard's Mercurial Support won't work against Google Code

2012-05-15 Thread reviewboard
Comment #1 on issue 2585 by nate.sku...@gmail.com: Reviewboard's Mercurial Support won't work against Google Code http://code.google.com/p/reviewboard/issues/detail?id=2585 This patch against 1.6.6 fixes it for us. Attachments: reviewboard-googlecode-patch.patch 920 bytes -- You

Re: Issue 2585 in reviewboard: Reviewboard's Mercurial Support won't work against Google Code

2012-05-15 Thread reviewboard
Updates: Status: PendingReview Labels: Milestone-Release1.6.x Component-SCMTools Comment #2 on issue 2585 by chip...@gmail.com: Reviewboard's Mercurial Support won't work against Google Code http://code.google.com/p/reviewboard/issues/detail?id=2585 Can you post this on

Re: Issue 1664 in reviewboard: Chinese characters in code cannot be shown correctly

2012-05-15 Thread reviewboard
Comment #6 on issue 1664 by csfreeb...@gmail.com: Chinese characters in code cannot be shown correctly http://code.google.com/p/reviewboard/issues/detail?id=1664 “after set the repository's encoding as gb2312”,I don't know how to do it. I am using git with review board 1.6.6. -- You