Re: Any release plan ?
Yes. We have a roadmap up on http://www.review-board.org/wiki/Roadmap and are actively pursuing it (I'm working on one of the major pieces at this very moment). Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Mon, Oct 13, 2008 at 2:40 AM, Fabien [EMAIL PROTECTED] wrote: Hello, Now that django has a 1.0 version, do you have any plan to release a 1st stable version ? Quoting http://www.review-board.org/downloads/ : Review Board is still in development, but is approaching an official release. We'll be releasing once Django provides a new official release. Thanks. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
How to add another scmtool support?
If I want to add another scmtool support, is it enough to add a new file in scmtools folder like anotherscmtool.py which will implements several classes and methold? Or any change in other module? And the file will be like the following code: XXXTool get_file: parse_diff_revision: get_fields: get_parser: XXXDiffParser parse_special_header: --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Any release plan ?
Hello, Now that django has a 1.0 version, do you have any plan to release a 1st stable version ? Quoting http://www.review-board.org/downloads/ : Review Board is still in development, but is approaching an official release. We'll be releasing once Django provides a new official release. Thanks. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review error Unable to parse diff header:
I am attempting to upgrade to the latest-and-greatest and am now running into this exact same problem. post-review under cygwin (under DOS). It looks like the p4 where command is returning a DOS style path, and then if you look in a redirected differences output file, all the letters are scrunched together with the '\' characters missing. --- /cygdrive/c/DOCUME~1/APETER~1/LOCALS~1/Temp/Device.cpp 2008-08-12 10:52:53.549697400 -0700 +++ c:companyproductcoresrcwin32desktopDevice.cpp 1969-12-31 16:00:00.0 -0800 ... and of course, the +++ file does not exist. On Oct 9, 5:55 pm, Christian Hammond [EMAIL PROTECTED] wrote: Interesting. It could be that there's assumptions being made that confuse post-review when running inside the cygwin shell instead of a DOS prompt on Windows. The file paths look very inconsistent. One file is UNIX-style (/foo/bar), whereas the other is a mix of Windows (C:\...) and then partly UNIX. It's probably due to where we're getting these paths and how we're concatenating them. Can you run the same command in a DOS box and see what happens? Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Oct 9, 2008 at 5:45 PM, Amit Mokal [EMAIL PROTECTED] wrote: Hi I would like to thank you for developing review board. I am using review board with perforce. When I use the post-review script I get the error Unable to parse diff header: Running the script with debug set to True gives ----- $ python post-review.py 52004 svn info p4 info repository info: Path: milan.engdlp.symantec.com:1666, Base path: None, Supports changesets: True Repository info 'Path: milan.engdlp.symantec.com:1666, Base path: None, Supports changesets: True' Generating diff for changenum 52004 p4 describe -s 52004 Processing edit of //depot/Vontu9/dev/native/src/endpoint/Agent/DetectionCore/ExecutionGraphStatePool.cpp Writing //depot/Vontu9/dev/native/src/endpoint/Agent/DetectionCore/ExecutionGraphStatePool.cpp#2 to /c/DOCUME~1/ADMINI~1/LOCALS~1/Temp/tmpkWJo L p4 print -q //depot/Vontu9/dev/native/src/endpoint/Agent/DetectionCore/ExecutionGraphStatePool.cpp#2 p4 where //depot/Vontu9/dev/native/src/endpoint/Agent/DetectionCore/ExecutionGraphStatePool.cpp diff -urNp /c/DOCUME~1/ADMINI~1/LOCALS~1/Temp/tmpkWJoCL C:/dev/sources\Vontu9\dev\native\src\endpoint\Agent\DetectionCore\ExecutionGraphStatePool cpp +++ C:/dev/sources\Vontu9\dev\native\src\endpoint\Agent\DetectionCore \ExecutionGraphStatePool.cpp Unable to parse diff header: +++ C:/dev/sources\Vontu9\dev\native\src \endpoint\Agent\DetectionCore\ExecutionGraphStatePool.cpp ---- My environment is cygwin. I am using python 2.5.1 diffutils 2.8.7 If I copy paste the diff command to the command line and save the output to a file I actually see a timestamp. However when the script executes the command the time stamp is missing. Thanks Amit- Hide quoted text - - Show quoted text - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: How to add another scmtool support?
On 10/13/2008 8:38 AM, Jay wrote: If I want to add another scmtool support, is it enough to add a new file in scmtools folder like anotherscmtool.py which will implements several classes and methold? Or any change in other module? I can confirm that this is pretty much what you have to do as I'm going through that process myself right now. The best tip I have is to setup another svm (e.v. svn) so you can compare a working scm with your work in progress one. You also need to add the scmtool in the web admin repository page. I did find that with the diff parser I ended up sub classing a few more methods, my scmtool diff output is not unified :-( With any luck you won't have to do much. I have made a hack to the shared code for making raw diffs via a url - I'm not really in a good position to talk about that just yet as it was a quick hack to get it working. I'm hoping to do away with it but I've not spent any time working out how that will be done :-) The reason for this was that I wanted the raw diffs that come out to match the diffs that are uploaded and I needed to put back part of the special header. Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: How to add another scmtool support?
Once it's working, we'll want to add it to the fixtures so people can easily select the repository type. Other than that, all you need to do is implement the SCMTool class. It's also useful to implement the client-side in post-review for most SCMs. Good luck, -David On Mon, Oct 13, 2008 at 12:08 PM, Chris Clark [EMAIL PROTECTED] wrote: On 10/13/2008 8:38 AM, Jay wrote: If I want to add another scmtool support, is it enough to add a new file in scmtools folder like anotherscmtool.py which will implements several classes and methold? Or any change in other module? I can confirm that this is pretty much what you have to do as I'm going through that process myself right now. The best tip I have is to setup another svm (e.v. svn) so you can compare a working scm with your work in progress one. You also need to add the scmtool in the web admin repository page. I did find that with the diff parser I ended up sub classing a few more methods, my scmtool diff output is not unified :-( With any luck you won't have to do much. I have made a hack to the shared code for making raw diffs via a url - I'm not really in a good position to talk about that just yet as it was a quick hack to get it working. I'm hoping to do away with it but I've not spent any time working out how that will be done :-) The reason for this was that I wanted the raw diffs that come out to match the diffs that are uploaded and I needed to put back part of the special header. Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 687 in reviewboard: Can't edit change description
Issue 687: Can't edit change description
http://code.google.com/p/reviewboard/issues/detail?id=687
New issue report by cuviper:
*NOTE: Do not post confidential information in this bug report.*
What's the URL of the page containing the problem?
/r/id/
What steps will reproduce the problem?
1. Publish a review
2. Change a field and hit enter to save it
3. Try to enter a change description
What is the expected output? What do you see instead?
The change description field appears, but it is not editable. There's no
pencil icon, and the field itself is just an empty pre/pre
What operating system are you using? What browser?
Firefox 3 and IE6 behave the same.
Please provide any additional information below.
I noticed this snippet in the templates/reviews/review_detail.html:
264 {% if entry.changedesc %}
265 registerEditor('changedescription', true, true);
266 {% endif %}
If I don't have a changedesc yet, then this field doesn't get registered as
an editor. Later the draft-banner will get shown, but this field is still
just a pre.
I think either the conditional code above needs to be called always, or
else showDraftBanner needs to enable changedescription when it's called.
Issue attributes:
Status: New
Owner:
Labels: Type-Defect Priority-Medium
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 640 in reviewboard: Admin-Settings-General-Site Settings-Server adds an extra slash to the end of the url.
Issue 640: Admin-Settings-General-Site Settings-Server adds an extra slash to the end of the url. http://code.google.com/p/reviewboard/issues/detail?id=640 Comment #3 by chipx86: Fixed in r1531. Issue attribute updates: Status: Fixed Owner: chipx86 Labels: -Priority-Medium Priority-Critical Component-Settings Milestone-Release1.0 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 592 in reviewboard: Clicking: Report bug in reviewboard should open the link in a new window.
Issue 592: Clicking: Report bug in reviewboard should open the link in a new window. http://code.google.com/p/reviewboard/issues/detail?id=592 Comment #3 by chipx86: The new UI rewrite won't let you navigate a page without confirming, if you have an unsaved textbox somewhere. So the worry is now gone. However, I think adding little new window icons next to Report Bug and such would work to address this. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
