Re: Email Settings
well... i figured that one out. The problem is that I'm using post-review from a subversion hook with the --submit-as option. And the dedicated user was not assigned a Name / email and therefore will default to webmas...@localhost. On Fri, Aug 28, 2009 at 3:08 PM, dartarrow dartar...@gmail.com wrote: Hey, how do i set the FROM email address? I have exim4 setup on my localhost which send the email from webmas...@localhost I would like to change that to something like reviewbo...@mycompany.com Thanks --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Email Settings
Hey, how do i set the FROM email address? I have exim4 setup on my localhost which send the email from webmas...@localhost I would like to change that to something like reviewbo...@mycompany.com Thanks --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Email Settings
I already asked about this once before. The e-mails always come from the address of the person who performed the action. I've already opened an enhancement request a while ago to have them come from a single static address. http://code.google.com/p/reviewboard/issues/detail?id=1222 On Aug 28, 2:08 am, dartarrow dartar...@gmail.com wrote: Hey, how do i set the FROM email address? I have exim4 setup on my localhost which send the email from webmas...@localhost I would like to change that to something like reviewbo...@mycompany.com Thanks --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Error 206: Repository path not specified
On Aug 27, 2009, at 5:05 PM, Christian Hammond chip...@chipx86.com wrote: Make sure for Perforce that the Path is an exact match for the server name specified in: p4 info If they differ at all, it will not work. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, Aug 27, 2009 at 1:07 PM, jdt141 justin.d.te...@gmail.com wrote: Hi All - Trying to work out a new kink in our review board setup. IT did some migration work and we've been having trouble ever since. The server is up and running (on Ubuntu 9.04), but my problem is when creating a review request with post-review. I get the following error: Error creating review request: The repository path specified is not in the list of known repositories (code 206). I have found other posts about this error, but the solution is to check the repository path and mirror name. Both of those are set identical (the domain name of our Perforce server). Any other reasons why we'd be getting this error? Thanks. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Error 206: Repository path not specified
not prefixing the path with http://; makes a world of difference... On Aug 27, 6:05 pm, Christian Hammond chip...@chipx86.com wrote: Make sure for Perforce that the Path is an exact match for the server name specified in: p4 info If they differ at all, it will not work. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Thu, Aug 27, 2009 at 1:07 PM, jdt141 justin.d.te...@gmail.com wrote: Hi All - Trying to work out a new kink in our review board setup. IT did some migration work and we've been having trouble ever since. The server is up and running (on Ubuntu 9.04), but my problem is when creating a review request with post-review. I get the following error: Error creating review request: The repository path specified is not in the list of known repositories (code 206). I have found other posts about this error, but the solution is to check the repository path and mirror name. Both of those are set identical (the domain name of our Perforce server). Any other reasons why we'd be getting this error? Thanks. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review board automated with git
More in detail, what we do is: 1. Write some code 2. Do the commit 3. Post a review to a system 4. push 5. Go to 1. and it works! but if we do: 1. Write some code 2. Do the commit 3. Post a review to a system 4. Go to 1 Then posting review for the second time will show sth like file not found in the repository. (both by post-review and via web). On 27 Sie, 12:16, Marek slogt...@gmail.com wrote: We are trying for a while now to introduce Board Review in our company. We are using git. We tried simple flow: 1. git commit 2. post-review but it only works when we do the push after every single commit. Doesn't make a lot of seans to us. (It seem that board review requires one commit back version of your files to apply the diff on) The next step would be to do automated review requests anyway. This first issue makes it impossible to work with simple git pre-commit hooks. Is there any other way? Is there any recommended way to use git with board review, ommiting one-push-per-commit problem. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Feedback on design/implementation for user-configurable signaling
Seems like there's something being built in that direction already: http://github.com/jtauber/django-notification/tree/master Will investigate further. I might be able to port my stuff to theirs. On Thu, Aug 13, 2009 at 8:01 PM, Helder Ribeirohel...@gmail.com wrote: Hi guys, I'm also about to embark into developing something a little big, so I'd like to get some eyeballs on my idea before hammering at it. If you could take a few moments to go over it and give me suggestions, I would greatly appreciate it. I've also posted this on StackOverflow, if you're into that kind of thing :) http://stackoverflow.com/questions/1275077/user-configurable-signalling-mechanism-in-django. Here goes: I need to allow an arbitrary Principal (User, Group, Site Admin) to add Event Sinks (like email addresses, Webhook URLs, etc.) to the system (through the web interface) and, for each one, specify which kinds of Event Source, Event Type should be sent to it. Since I'm doing this for ReviewBoard, I'll give a concrete example with a hypothetical implementation: 1. John creates a new event_sink (a webhook), identified by postbin1; 2. John specifies that postbin1 will receive events of type publish on ReviewRequests (a class-level subscription -- the source_id is unspecified); 3. When a new review_request is created, the Event Manager, lists (through a JOIN with subscriptions) all event_sinks interested in ReviewRequests and creates a (instance-level) subscription binding them as a listener to their particular event_type (the name of a django signal) of interest and to the specific review_request; 4. When that review_request gets published, the Event Manager (who listens to the publish signal) lists all event_sinks interested in that review_request instance and the publish signal and dispatches the signal parameters to their sink method. 5. The Webhook event_sink marshals the data however pleases it and POSTs it to its URL. The schema I thought of is attached. If you can't see it, it's also at: http://bayimg.com/image/aadgoaacd.jpg I'm about to start implementing this myself, but I just want to make sure I'm not reinventing the wheel. Couldn't find anything on Google. Ready-to-use package names, half-way package names that will help me, and/or criticism to my DIY approach are all welcome. Thanks a lot! Helder http://helderribeiro.net --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 77 in reviewboard: Avoid redundant simultaneous reviews
Comment #4 on issue 77 by stefan.b...@gmx.net: Avoid redundant simultaneous reviews http://code.google.com/p/reviewboard/issues/detail?id=77 I support the idea of cybrocop. An important aspect of this enhancement is that all potential reviewers can see that other reviewers are already working on a review on this topic. This helps to avoid two people reviewing the same change needlessly (as grant patterson pointed out in the initial report). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 100 in reviewboard: Allow for reviews based on an existing committed revision in the web UI
Comment #18 on issue 100 by stefan.b...@gmx.net: Allow for reviews based on an existing committed revision in the web UI http://code.google.com/p/reviewboard/issues/detail?id=100 +1 vote for this enhancement. A simple edit field to type in rev numbers should be suffficient. Drop down boxes would be nice to have but should really be useable with big repositories storing thousands of revisions. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Comment on Roadmap in reviewboard
Comment by stefan.b...@gmx.net: Django 1.1 has been released on July 29, 2009 (not 2010). For more information: http://code.google.com/p/reviewboard/wiki/Roadmap --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1294 in reviewboard: the floating You have a pending review bar squanders precious screen space
Comment #1 on issue 1294 by jeff.keller: the floating You have a pending review bar squanders precious screen space http://code.google.com/p/reviewboard/issues/detail?id=1294 Not that it matters, but the actual URL for the version populating ticket is http://code.google.com/p/reviewboard/issues/detail?id=1293 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1295 in reviewboard: Indicate add/delete/edit for each file in the Files Changed: section of the diff page
Comment #1 on issue 1295 by jeff.keller: Indicate add/delete/edit for each file in the Files Changed: section of the diff page http://code.google.com/p/reviewboard/issues/detail?id=1295 This would be particularly helpful when files are when files are being moved and you're trying to get the big picture. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 242 in reviewboard: OpenID authentication support
Updates: Labels: Milestone-Release1.1 Comment #6 on issue 242 by trowbrds: OpenID authentication support http://code.google.com/p/reviewboard/issues/detail?id=242 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Updates: Labels: -Milestone-Release1.5 Milestone-Release1.1 Comment #15 on issue 489 by trowbrds: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
