Re: What is the status of ClearCase integration on Windows?
Hi Sassan,
The latest docs have some instructions on how to use post-review with
Clearcase. In fact, it's the only way to post a review with Clearcase.
http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/
I wrote it using some unix-ish examples, but I actually tested the
instructions under Windows. post-review's Clearcase support is fairly
crude, but it will work for reviewing modified code in a view that has
not been checked in.
Note that you actually need to modify post-review.py to make it work
in your environment, so I recommend pulling it from git and running
setup.py develop. If someone wants to just add these hard-coded values
as options, this won't be necessary anymore.
Dan
On Jan 14, 7:07 pm, Sassan sassan...@verifone.com wrote:
Does anyone know what is and is not currently supported for ClearCase
as an SCM tool on Windows?
For example I see instructions for posting commited code reviews using
post-review.exe under ClearCase section
inhttp://www.reviewboard.org/docs/manual/1.0/users/tools/post-review/
Does the Todo mean it is only on the wish list and not yet
implemented?
I also see a --label=LABEL under ClearCase options for post-
review.exe but I am not clear as to how a single label can designate a
diff of two distinct revisions.
I tried this anyway and I got::
Traceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in
module load_entry_point('RBTools==0.2beta2', 'console_scripts',
'post-review')()
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 2509, in main
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 954, in diff_label
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 947, in diff
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 811, in get_extended_namespace
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 790, in get_previous_version
ValueError: too many values to unpack
Do you know how I get to the postreview.py script inside the rbtools
egg to modify it?
On the other hand it is easy enough for me to generate the diffs
myself out of ClearCase, but is there any way for me post these
directly into the RB server ?
Maybe by passing them to post-review.exe but only to be posted to the
RB server ?
Thanks,
Sassan
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Will post-review generate ReviewRequest for CVS removed files?
The problem is the way that cvs generates the diff for removed files. It is
the same as for a file which has just been added and as such they cannot
checkout the file correctly. I am mulling over trying to fix this bug, by
treating the file as a 'new' file since the diff shows every line removed.
Scott
On Thu, Jan 14, 2010 at 10:58 PM, JohnHenry qhlonl...@163.com wrote:
Hi, all.
I am trying using post-review to generate review request for cvs
removed files. Once a file has been removed with cvs remove file
cvs commit, Then the new version will be the removed version.
Suppose the file version before remove is V1.1 , Then after execution
cvs remove , It will be V1.2; I use the following command:
post-review --target-people=rbroot --submit-as=new rb --
summary=Testing wrong --file-name=new.c --revision-range=1.1:1.2 -
p
But the execution result is:
Error uploading diff: One or more fields had errors (105)
Your review request still exists, but the diff is not attached.
{stat: ok}
Review request draft saved
Uploading diff, size: 223
HTTP POSTing to
http://192.168.3.20:8080/api/json/reviewrequests/204/diff/new/: {}
{fields: {path: [Unable to parse diff revision header 'Fri Jan 15
11:57:39 2010']}, stat: fail, err: {msg: One or more fields had
errors, code: 105}}
Error uploading diff: One or more fields had errors (105)
What is the Unable to parse diff revision header mean?
Best Regards!
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: What is the status of ClearCase integration on Windows?
I would love a patch to move that functionality out into a .reviewboardrc. I
haven't done it myself due to lack of a Clearcase server to test with
(though if anybody wants to donate a license, we can get some automated
tests for stuff going :).
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Fri, Jan 15, 2010 at 7:37 AM, Dan Savilonis d...@n-cube.org wrote:
Hi Sassan,
The latest docs have some instructions on how to use post-review with
Clearcase. In fact, it's the only way to post a review with Clearcase.
http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/
I wrote it using some unix-ish examples, but I actually tested the
instructions under Windows. post-review's Clearcase support is fairly
crude, but it will work for reviewing modified code in a view that has
not been checked in.
Note that you actually need to modify post-review.py to make it work
in your environment, so I recommend pulling it from git and running
setup.py develop. If someone wants to just add these hard-coded values
as options, this won't be necessary anymore.
Dan
On Jan 14, 7:07 pm, Sassan sassan...@verifone.com wrote:
Does anyone know what is and is not currently supported for ClearCase
as an SCM tool on Windows?
For example I see instructions for posting commited code reviews using
post-review.exe under ClearCase section inhttp://
www.reviewboard.org/docs/manual/1.0/users/tools/post-review/
Does the Todo mean it is only on the wish list and not yet
implemented?
I also see a --label=LABEL under ClearCase options for post-
review.exe but I am not clear as to how a single label can designate a
diff of two distinct revisions.
I tried this anyway and I got::
Traceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in
moduleload_entry_point('RBTools==0.2beta2', 'console_scripts',
'post-review')()
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 2509, in main
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 954, in diff_label
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 947, in diff
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 811, in get_extended_namespace
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 790, in get_previous_version
ValueError: too many values to unpack
Do you know how I get to the postreview.py script inside the rbtools
egg to modify it?
On the other hand it is easy enough for me to generate the diffs
myself out of ClearCase, but is there any way for me post these
directly into the RB server ?
Maybe by passing them to post-review.exe but only to be posted to the
RB server ?
Thanks,
Sassan
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: What is the status of ClearCase integration on Windows?
I am happy to try to catch up with python scripting add that
functionality and possibly more to it.
I would like some instructions on how and where to get the source out
of git and any special tools I will need for development.
Thanks,
Sassan
On Jan 15, 3:35 pm, Christian Hammond chip...@chipx86.com wrote:
I would love a patch to move that functionality out into a .reviewboardrc. I
haven't done it myself due to lack of a Clearcase server to test with
(though if anybody wants to donate a license, we can get some automated
tests for stuff going :).
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Fri, Jan 15, 2010 at 7:37 AM, Dan Savilonis d...@n-cube.org wrote:
Hi Sassan,
The latest docs have some instructions on how to use post-review with
Clearcase. In fact, it's the only way to post a review with Clearcase.
http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/
I wrote it using some unix-ish examples, but I actually tested the
instructions under Windows. post-review's Clearcase support is fairly
crude, but it will work for reviewing modified code in a view that has
not been checked in.
Note that you actually need to modify post-review.py to make it work
in your environment, so I recommend pulling it from git and running
setup.py develop. If someone wants to just add these hard-coded values
as options, this won't be necessary anymore.
Dan
On Jan 14, 7:07 pm, Sassan sassan...@verifone.com wrote:
Does anyone know what is and is not currently supported for ClearCase
as an SCM tool on Windows?
For example I see instructions for posting commited code reviews using
post-review.exe under ClearCase section inhttp://
www.reviewboard.org/docs/manual/1.0/users/tools/post-review/
Does the Todo mean it is only on the wish list and not yet
implemented?
I also see a --label=LABEL under ClearCase options for post-
review.exe but I am not clear as to how a single label can designate a
diff of two distinct revisions.
I tried this anyway and I got::
Traceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in
module load_entry_point('RBTools==0.2beta2', 'console_scripts',
'post-review')()
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 2509, in main
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 954, in diff_label
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 947, in diff
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 811, in get_extended_namespace
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 790, in get_previous_version
ValueError: too many values to unpack
Do you know how I get to the postreview.py script inside the rbtools
egg to modify it?
On the other hand it is easy enough for me to generate the diffs
myself out of ClearCase, but is there any way for me post these
directly into the RB server ?
Maybe by passing them to post-review.exe but only to be posted to the
RB server ?
Thanks,
Sassan
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en- Hide quoted text -
- Show quoted text -
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: What is the status of ClearCase integration on Windows?
On Friday 15 January 2010 23:20:32 Sassan wrote: I am also thinking it might be a good idea to add a repository independent base functionality to the post-review script where it is handed the root directory of two source trees, before and after the change and it will then just compare the files and post a review. This way anyone with any source repository can just create the before and after soure trees outside RB and pass the roots of the source trees to the post-review script for posting. This won't work as Review Board needs to be able to access the respective SCM repository from the server-side to apply the posted diff to the base revision. Regards, Thilo -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Install reviewboard on IIS 7
Hi, Yeah, I've heard that IIS can be tricky. I have no experience myself, and Review Board doesn't support it out of the box. If someone did get it to work and was willing to maintain it, we'd be happy to have some instructions in the docs and generate config files from rb-site, but it's not something we're planning to do ourselves any time soon. My recommendation in these cases is usually an Ubuntu-based Linux VM running Apache or lighttpd. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Jan 15, 2010 at 6:05 AM, slav slav@gmail.com wrote: if it'll help anyone, I went Apache route in the end. Python doesn't seem to support FastCGI under IIS. just CGI with Python works, but when trying to launch ReviewBoard using CGI (look for django cgi scripts on the web), I either got browser error, Python error or page would begin to load, but turn into garbage. Either way, it's just too damn hard. Unless something changes, I'd recommend not wasting time, but using Apache (or lighttpd, but it's not as well supported under windows). On Jan 14, 2:42 pm, slav slav@gmail.com wrote: just to follow up. was sleepy. I created directory by hand, and that's what gave the error. rb-site creates directory on it's own. still couldn't get it to run on iis. I tried several approaches, main one looks like: http://code.djangoproject.com/wiki/DjangoOnWindowsWithIISAndSQLServer almost positive it's possible to get it to run on iis 7, but can't quite figure out how. any help would be appreciated. On Jan 13, 10:07 pm, slav slav@gmail.com wrote: hello. I'm wondering if it's possible to install reviewboard under iis 7, and if not, why not? if it is possible, how? I followedhttp:// www.reviewboard.org/docs/manual/dev/admin/installation/windows/ and got all the way to creating a site using rb-site, but it fails with an error, telling me to ensure I'm admin (which I am). I'm on Windows 2008 r2 x64 and Python 2.6 x64 thank you -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Username case sensitivity
I have ReviewBoard authenticating against LDAP. Unfortunately it seems that on our LDAP server (Apple's OpenDirectory) the uid lookup isn't case sensitive but ReviewBoard's user system seems to be. As a result, I end up with duplicate users eg: Bob and bob in the ReviewBoard system. Is there any way to work around this? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
