Re: About “close” of ReviewRequest

2010-03-08 Thread Christian Hammond
I recommend looking at the list archives for posts about policy support. We can't support any code with custom rules like this until we have that code go in (2.0 timeframe). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.v

Re: rb-site script missing after easy_install

2010-03-08 Thread Paul
On Mon, Mar 8, 2010 at 07:20, gruff wrote: > I have followed the installation instructions, but the rb-site script > is nowhere to be seen. > There is a script called rbsite.py in /usr/local/lib/python2.4/site- > packages/ReviewBoard-1.0.5.1-py2.4.egg/reviewboard/cmdline/ , but I > don't think thi

Re: About “close” of ReviewRequest

2010-03-08 Thread David Trowbridge
Close is done through the review_request_close view in webapi/json.py -David On Mon, Mar 8, 2010 at 1:22 AM, JohnHenry wrote: > Hi, >    We had a new requirement of 'close condition'. Only if all target > reviewers had "ship it" this review, The submitter can 'close' this > review request by c

rb-site script missing after easy_install

2010-03-08 Thread gruff
I have followed the installation instructions, but the rb-site script is nowhere to be seen. There is a script called rbsite.py in /usr/local/lib/python2.4/site- packages/ReviewBoard-1.0.5.1-py2.4.egg/reviewboard/cmdline/ , but I don't think this is the one I'm looking for. The OS is CentOS 5.2, w

Re: Folder creation while uploading screenshots

2010-03-08 Thread hschnit
Christian, I had that setting already turned on (and restarted Apache many times since then). The output is what you see in the Logs that I attached previously. Since I had an older version, I tried to disable logging, restart apache, reenable logging, restart apache; Then try to upload a screensho

About “close” of ReviewRequest

2010-03-08 Thread JohnHenry
Hi, We had a new requirement of 'close condition'. Only if all target reviewers had "ship it" this review, The submitter can 'close' this review request by click "submitted". I had noticed that there will be a change in review board about reviewers' "ship it" and submitters' "close" operati