Re: Connection close when uploading diff file
I 发自我的 iPhoneu 在 2010-6-25,上午7:30,jianwei majesty...@hotmail.com 写到: Hi Christian, Thank you for your reply. I am using subversion for my repos. My log looks like this, some settings are not pasted to here. Also, the upload_temp_dir is NONE, is it this causes the problem? But I can upload img file. 2010-06-24 14:50:26,611 - DEBUG - DiffParser.parse: Beginning parse of diff, size = 3670 2010-06-24 14:50:26,612 - DEBUG - DiffParser.parse: Finished parsing diff. 2010-06-24 14:50:30,448 - WARNING - JSONField decode error. Expected dictionary, got string for input '{ u'cache_backend': u'file:///tmp/reviewboard_cache', u'site_upload_temp_dir': None, u'diffviewer_context_num_lines': 5, u'diffviewer_paginate_orphans': 10, u'site_upload_max_memory_size': 2621440, u'cache_expiration_time': 2592000, u'diffviewer_include_space_patterns': [], u'diffviewer_paginate_by': 20, u'diffviewer_syntax_highlighting': True, u'site_media_url': u'/media/', Looking forward to everyone's response. Thank you Jianwei On Jun 24, 5:09 pm, Christian Hammond chip...@chipx86.com wrote: Hi, This may be due to some issue between Review Board and your repository. What type of repository are you using? Can you turn on logging in the administration UI (Admin - Settings - Logging), reproduce the problem, and then see if there's anything in the log files? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Jun 23, 2010 at 9:29 PM, jianwei majesty...@hotmail.com wrote: Hi all, The problem is I got connection closed unexpectedly when I try to upload a diff file. After searching for the solutions to this problems for a few days and I still can not solve this problem except knowing there are some problems of the server site. Can somebody please help me to fix this problem? eg: what can I do on the server side? At the moment, I can use eReviewboard plugin to create a new request from eclipse and I am able to upload image. Version of reviewboard is 1.0.8. Regards Jianwei -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard %2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Git Patchsets (was [Re: Help on viewing diff])
Eduardo's working on this for Summer of code. He can hopefully fill you in on the plans. Right now, there's no public code that I'm aware of. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jun 24, 2010 at 4:14 AM, Stephen Gallagher step...@gallagherhome.com wrote: On 06/24/2010 02:43 AM, Christian Hammond wrote: The way Review Board handles diffs today is that every revision of the diff is meant to be a single change, from the base to the tip of the branch. What I think you're wanting (please correct me if I'm wrong) is more of a patchset concept, with each diff being an iteration of a change. This workflow is not supported yet, but we have a Summer of Code student working on it. Is there a public specification available on how these patchsets are going to be supported? What about a public repository to follow the changes? This is highly relevant to my interests :) -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: remote Mercurial repo support?
On Fri, Jun 25, 2010 at 09:41:02AM -0700, Gordon Morehouse wrote: On Jun 24, 9:12 pm, Dan Buch daniel.b...@gmail.com wrote: IIRC there's some naive logic in the remote Mercurial repo client inside Reviewboard that screws up the number/presence of some '/' chars. I think a recently accepted patch fixed the logic, but you can get it working with older versions of ReviewBoard by doing something like this: for the Path value: http://example.com/hgweb/AwesomeTown for the Mirror path value: http://example.com/hgweb/AwesomeTown/ And yes, it really is the trailing slash. No, this is not 1994. ...Unbelievable. Banging my head for days over a single slash (and no documentation of the issue anywhere). Thank goodness there's a patch in. I've submitted a documentation bug about this: http://code.google.com/p/reviewboard/issues/detail?id=1699 My prior solution had been to mount the repo itself from our repo server via sshfs, but after putting the HTTPS URL back in minus the trailing slash it still worked. Thanks for that, because an automounted sshfs was not exactly the greatest 'solution.' If you haven't already tried, I can warn you that the current public release of RBTools doesn't *actually* support plain ol' Mercurial usage, although it *does* have good support for hgsubversion. Another recently-accepted patch fixes this (for the most part,) and a dist which includes it is available here: http://github.com/meatballhat/rbtools/downloads Thanks! I will investigate that. Any idea if it will be accepted upstream? It has! It *only* took 3 months! ;-) http://reviews.reviewboard.org/r/1464/ I'm not bitter. I swear. When it will actually ship with canonical RBTools? not sure... chipx86 or trowbrds willing to weigh in? :) -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- ~Dan pgp8SHnjWClK9.pgp Description: PGP signature
Re: remote Mercurial repo support?
Not bitter at all! ;) Sadly, this is what happens when $DAYJOB and real life get in the way for a little while. I'll be doing a new RBTools release with those fixes very soon. Christian On Saturday, June 26, 2010, Dan Buch daniel.b...@gmail.com wrote: On Fri, Jun 25, 2010 at 09:41:02AM -0700, Gordon Morehouse wrote: On Jun 24, 9:12 pm, Dan Buch daniel.b...@gmail.com wrote: IIRC there's some naive logic in the remote Mercurial repo client inside Reviewboard that screws up the number/presence of some '/' chars. I think a recently accepted patch fixed the logic, but you can get it working with older versions of ReviewBoard by doing something like this: for the Path value: http://example.com/hgweb/AwesomeTown for the Mirror path value: http://example.com/hgweb/AwesomeTown/ And yes, it really is the trailing slash. No, this is not 1994. ...Unbelievable. Banging my head for days over a single slash (and no documentation of the issue anywhere). Thank goodness there's a patch in. I've submitted a documentation bug about this: http://code.google.com/p/reviewboard/issues/detail?id=1699 My prior solution had been to mount the repo itself from our repo server via sshfs, but after putting the HTTPS URL back in minus the trailing slash it still worked. Thanks for that, because an automounted sshfs was not exactly the greatest 'solution.' If you haven't already tried, I can warn you that the current public release of RBTools doesn't *actually* support plain ol' Mercurial usage, although it *does* have good support for hgsubversion. Another recently-accepted patch fixes this (for the most part,) and a dist which includes it is available here: http://github.com/meatballhat/rbtools/downloads Thanks! I will investigate that. Any idea if it will be accepted upstream? It has! It *only* took 3 months! ;-) http://reviews.reviewboard.org/r/1464/ I'm not bitter. I swear. When it will actually ship with canonical RBTools? not sure... chipx86 or trowbrds willing to weigh in? :) -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- ~Dan -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Comment on Summer_of_Code_Ideas in reviewboard
Comment by leitianbao: I want that files of [Review Board]-[View Diff] are not sorted. If so,the order of files(are showed at [Review Board]-[View Diff]) is the same with the order of file list(new/modify file list of [Structure Design]). For more information: http://code.google.com/p/reviewboard/wiki/Summer_of_Code_Ideas -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.