Re: keeping track of large number of files
So far, what we've done is just show a series of deletes for each line in the file, which isn't really a good this file was deleted indicator. In 1.5 RC1, we have the beginnings of support for marking that a file is indeed deleted. Only CVS supports this right now (we needed it to work around a problem with how CVS diffs represented deleted files). I'm hoping in 1.5.x/1.6 to begin supporting this at least for Subversion, Git, and Perforce. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Aug 30, 2010 at 11:25 AM, Chris Clark chris.cl...@ingres.comwrote: J Arrizza wrote: The caveat, I think, is the collapsed list has to show *all* the files, whether new, deleted, modified, in the current revision or not. That sounds more complicated for implementation but from a user perspective, it's a whole lot of nice-to-have. Does RB have support for files that are deleted in a review? For our private deployment of 1.0.5.1 I ended up faking a diff (in the SCMTool) that has NOTE! reviewer this file has been marked for deletion as the first line. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: mercurial forest extension
You also have to know that the forest extension is being deprecated in favor of the integrated mercurial subrepositories. However, this leaves you in the same situation of finding someone to work on it. Regards. Gilles. On Monday 30 August 2010 12:23:50 am Christian Hammond wrote: Hi, There are no current plans to implement this. So far, Mercurial support has been entirely developed by third parties interested in contributing to Review Board. If someone wants to improve our support to handle Forests, we'll gladly work with them to do so. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Aug 26, 2010 at 8:48 AM, sergius sergey.serg...@googlemail.comwrote: Hi. Is there plans, by any chance, to add support for mercurial forest extension? (See http://mercurial.selenic.com/wiki/ForestExtension) For now we add rb repository for each forest subrepos. So, commit which contains changes in several repositories have to be splitted to several review requests. It would be great to have just one rb-repo corresponding to forest repository. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@google groups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: mercurial-reviewboard - versions?
On Monday 30 August 2010 07:14:39 pm J Arrizza wrote: Christian, He does not respond to emails, so I thought I'd throw it on this list to see if others have had any luck with it. My apologies. Gilles, I got the most recent copy of the extension and it fixed some of the exceptions but not all. The reason I think it's an incompatible versions issue is that there are calls on python objects to methods that don't exist. I'm just guessing there is some combination of mercurial and the extension that work well together... BTW you have a typo in the URL: http://code.google.com/p/mercurial-reviewboard/ John We have been unable to contact the original author either. That's why Colin Caughie started this fork. There might be still some incompatibilities between the latest mercurial and the plugin. I also expect some problems with RB 1.5 that I have not tried yet. Regards. Gilles. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: CVS post-review woes
Chris,
Thank you very much for your feedback.
In the second error, you state that it is attempting to change the
repository name. I have observed this path is derived from CVS/Root.
Even when I change it to a path that matches my current working
directory it still has the same error. The CVS module in this example
is called getting
Is there something wrong with the way I am doing the first 5 steps?
1. cat CVS/Root
:ext:devd...@foo.bar.com/home/cvs
2. cvs -d:ext:devd...@foo.bar.com/home/cvs checkout getting/fee
3. cd ./getting
4. vi fee/random.file
5. post-review fee/random.file
or the repo bit in admin?
repository settings
namefoobarrepo
path :ext:nmil...@gpscvs.cybersource.com/home/cvs
mirror path :ext:devd...@foo.bar.com/home/cvs
name devdude
password devdude
bigoldrock
On Aug 28, 2:39 am, Christian Hammond chip...@chipx86.com wrote:
Hi,
post-review, in the second example, is attempting to change the repository
name to 'foo.bar.com/home/cvs', and expects Review Board to have an entry
for that.
I wasn't sure from your description what values caused the first error
output vs. the second.
The first error is basically a result of Review Board not being able to
authenticate with the CVS server.
What version of Review Board are you running? You need 1.5 RC1 to be able to
authenticate with :ext: hosts (without doing custom work to store
credentials somewhere).
If at all possible, you should use provide a read-only, non-SSH-backed
repository path to give to Review Board. It'll be faster and won't have
authentication issues.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Fri, Aug 27, 2010 at 12:29 PM, bigoldrock noeldamonmil...@gmail.comwrote:
RB,
Please help: I am able to get either
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'Permission denied, please try
again.\r\nPermission denied, please try again.\r\nPermission denied
(publickey,gssapi-with-mic,password).\r\ncvs [checkout aborted]: end of file
from server (consult above messages if any)\n']}, u'stat': u'fail', u'err':
{u'msg': u'One or more fields had errors', u'code': 105}}
or
HTTP POSTing tohttp://localhost/reviews/api/json/reviewrequests/new/:
{'repository_path': 'foo.bar.com/home/cvs', 'submit_as': 'foo'}
Got API Error 206 (HTTP code 200): The repository path specified is not
in the list of known repositories
Error data: {u'repository_path': u'foo.bar.com/home/cvs', u'stat':
u'fail', u'err': {u'msg': u'The repository path specified is not in the list
of known repositories', u'code': 206}}
depending on how I set up the repository.
please provide a functional example for CVS respository settings, post-
review command, and path in which you run it.
given the following:
1. cat CVS/Root
:ext:devd...@foo.bar.com/home/cvs
2. cvs -d:ext:devd...@foo.bar.com/home/cvs checkout getting/fee
3. cd ./getting
4. vi fee/random.file
5. post-review fee/random.file
repository settings
name foobarrepo
path :ext:nmil...@gpscvs.cybersource.com/home/cvs
mirror path :ext:devd...@foo.bar.com/home/cvs
name devdude
password devdude
post-review -p -d --server=http://localhost/reviews/--submit-
as='devdude' --username=devdude --password=devdude --summary='this is
a test reviewboard entry' --description='added a single comment to the
random.file file' fee
what looks wrong or inconsistent?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: CVS post-review woes
You should try setting your Mirror Path to foo.bar.com/home/cvs, and
preferably setting your Path to a non-:ext: CVS Root, if you have one. Using
:ext: is slower and more error-prone, and only works with RB 1.5 RC1 (still
not sure which version you're using).
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, Aug 31, 2010 at 6:45 AM, bigoldrock noeldamonmil...@gmail.comwrote:
Chris,
Thank you very much for your feedback.
In the second error, you state that it is attempting to change the
repository name. I have observed this path is derived from CVS/Root.
Even when I change it to a path that matches my current working
directory it still has the same error. The CVS module in this example
is called getting
Is there something wrong with the way I am doing the first 5 steps?
1. cat CVS/Root
:ext:devd...@foo.bar.com/home/cvs
2. cvs -d:ext:devd...@foo.bar.com/home/cvs checkout getting/fee
3. cd ./getting
4. vi fee/random.file
5. post-review fee/random.file
or the repo bit in admin?
repository settings
namefoobarrepo
path :ext:nmil...@gpscvs.cybersource.com/home/cvs
mirror path :ext:devd...@foo.bar.com/home/cvs
name devdude
password devdude
bigoldrock
On Aug 28, 2:39 am, Christian Hammond chip...@chipx86.com wrote:
Hi,
post-review, in the second example, is attempting to change the
repository
name to 'foo.bar.com/home/cvs', and expects Review Board to have an
entry
for that.
I wasn't sure from your description what values caused the first error
output vs. the second.
The first error is basically a result of Review Board not being able to
authenticate with the CVS server.
What version of Review Board are you running? You need 1.5 RC1 to be able
to
authenticate with :ext: hosts (without doing custom work to store
credentials somewhere).
If at all possible, you should use provide a read-only, non-SSH-backed
repository path to give to Review Board. It'll be faster and won't have
authentication issues.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Fri, Aug 27, 2010 at 12:29 PM, bigoldrock noeldamonmil...@gmail.com
wrote:
RB,
Please help: I am able to get either
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'Permission denied, please try
again.\r\nPermission denied, please try again.\r\nPermission denied
(publickey,gssapi-with-mic,password).\r\ncvs [checkout aborted]: end of
file
from server (consult above messages if any)\n']}, u'stat': u'fail',
u'err':
{u'msg': u'One or more fields had errors', u'code': 105}}
or
HTTP POSTing tohttp://localhost/reviews/api/json/reviewrequests/new/:
{'repository_path': 'foo.bar.com/home/cvs', 'submit_as': 'foo'}
Got API Error 206 (HTTP code 200): The repository path specified is
not
in the list of known repositories
Error data: {u'repository_path': u'foo.bar.com/home/cvs', u'stat':
u'fail', u'err': {u'msg': u'The repository path specified is not in the
list
of known repositories', u'code': 206}}
depending on how I set up the repository.
please provide a functional example for CVS respository settings, post-
review command, and path in which you run it.
given the following:
1. cat CVS/Root
:ext:devd...@foo.bar.com/home/cvs
2. cvs -d:ext:devd...@foo.bar.com/home/cvs checkout getting/fee
3. cd ./getting
4. vi fee/random.file
5. post-review fee/random.file
repository settings
namefoobarrepo
path :ext:nmil...@gpscvs.cybersource.com/home/cvs
mirror path :ext:devd...@foo.bar.com/home/cvs
name devdude
password devdude
post-review -p -d --server=http://localhost/reviews/--submit-
as='devdude' --username=devdude --password=devdude --summary='this is
a test reviewboard entry' --description='added a single comment to the
random.file file' fee
what looks wrong or inconsistent?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us
Re: Issue 1793 in reviewboard: Authentication failure with full gecos
Comment #2 on issue 1793 by alleonik: Authentication failure with full gecos http://code.google.com/p/reviewboard/issues/detail?id=1793 Yes, it`s a page. HTML attached. Attachments: InternalError at _account_login_.html 93.1 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1794 in reviewboard: alert (popup) the user when attempting to leave a page with unpublished changes
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1794 by assafla...@gmail.com: alert (popup) the user when attempting to leave a page with unpublished changes http://code.google.com/p/reviewboard/issues/detail?id=1794 Often I find myself navigating away from a review page without having published my changes. It's nice that there's this draft feature, and in a few cases I do mean to navigate away without submitting (yet). However, my impression is that most of the time I find these drafts hiding all over the place because people just closed the browser or navigated away by accident. The system should have a (configurable) option to alert the user did you forget to publish?. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1737 in reviewboard: Exception is thrown when adding a private GitHub repository
Comment #8 on issue 1737 by kevin.go...@gmail.com: Exception is thrown when
adding a private GitHub repository
http://code.google.com/p/reviewboard/issues/detail?id=1737
Thanks for looking into this, and sorry for this false alert. I have
successfully run Reviewboard without any problems on a dedicated server.
This particular install is on a shared host, where I don't have access to
the apache and python configuration. Hence the installation steps below
(taken from a site that explains how to install a django-based app on
shared hosting) work around the limitations there, and use fastcgi. Are
there any official instructions on how to install Reviewboard in a shared
hosting environment? The database and everything else are a clean install
btw.
### Prepare installing local binaries.
export
PATH=$HOME/opt/bin:$HOME/bin:$HOME/.local/lib/python/site-packages:$PATH
### Install customizable Python.
cd ~/src
wget http://peak.telecommunity.com/dist/virtual-python.py
python ~/src/virtual-python.py
### install python setuptools
cd ~/src
wget http://peak.telecommunity.com/dist/ez_setup.py
python ez_setup.py --install-dir=~/.local/lib/python/site-packages
### install Reviewboard
easy_install --prefix=$HOME/.local -f
http://downloads.reviewboard.org/releases/ReviewBoard/1.5/ -U ReviewBoard
easy_install --prefix=$HOME/.local mysql-python
rb-site install reviewboard
### add this .htaccess file
AddHandler fcgid-script .fcgi
RewriteEngine On
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^(.*)$ reviewboard.fcgi/$1 [QSA,L]
### change reviewboard.fcgi
#!/home3/kevmaste/bin/python
import os, sys
sys.path.insert(0, /home3/kevmaste/reviewboard/conf)
sys.path.insert(0, /home3/kevmaste/reviewboard/htdocs)
sys.path.insert(0, /home3/kevmaste/.local/lib/python/site-packages)
sys.path.insert(0, /home3/kevmaste/.local/lib/python2.4/site-packages)
sys.path.insert(0, /home3/kevmaste/.local/bin)
sys.path.insert(0, /home3/kevmaste/bin)
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/setuptools-0.6c11-py2.4.egg')
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg')
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/python_memcached-1.45-py2.4.egg')
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/pytz-2010h-py2.4.egg')
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/flup-1.0.3.dev_20100525-py2.4.egg')
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/Pygments-1.3.1-py2.4.egg')
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/Djblets-0.6.3-py2.4.egg')
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/django_evolution-0.5-py2.4.egg')
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg')
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/PIL-1.1.7-py2.4-linux-x86_64.egg')
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/paramiko-1.7.6-py2.4.egg')
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/pycrypto-2.1.0-py2.4-linux-x86_64.egg')
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/python_dateutil-1.5-py2.4.egg')
sys.path.insert(0,
'/home3/kevmaste/.local/lib/python2.4/site-packages/recaptcha_client-1.0.5-py2.4.egg')
os.environ[DJANGO_SETTINGS_MODULE] = reviewboard.settings
os.environ[PYTHON_EGG_CACHE]
= /home3/kevmaste/.local/lib/python/site-packages
from django.core.servers.fastcgi import runfastcgi
runfastcgi(method=threaded, daemonize=false)
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 256 in reviewboard: Add/Delete/Edit/integrate information not shown for binary files.
Comment #6 on issue 256 by steve.armstrong: Add/Delete/Edit/integrate information not shown for binary files. http://code.google.com/p/reviewboard/issues/detail?id=256 We're using 1.0.8 with a subversion database, and a post-commit workflow. Uploading a diff with an image delete, image add, and image modify (3 different files) only shows binary file for each one, so the reviewer can't tell which of the three files is the one being deleted. If you could show the before and after images, great, but if not, showing if it's an add/delete/modify would help alot. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
