RE: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or more fields had errors

2011-03-31 Thread Vincent Yee
That's the trick... in /usr/bin/

Thx
Vincent

-Original Message-
From: chip...@gmail.com [mailto:chip...@gmail.com] On Behalf Of Christian 
Hammond
Sent: Wednesday, March 30, 2011 9:51 PM
To: Vincent Yee
Cc: Christian Hammond; reviewboard@googlegroups.com
Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or 
more fields had errors

Hi,

They're both in /usr/local/bin, which is certainly in your user's
path, but is it in Apache's?

You may want to see what happens if you move those to /usr/bin.
Alternatively, you can SetEnv PATH in your web server's config.

Christian


On Wednesday, March 30, 2011, Vincent Yee v...@sendmail.com wrote:














 We do have p4 and patch on the client system:



 $ which p4

 /usr/local/bin/p4

 $ /usr/local/bin/p4 -V

 Perforce - The Fast Software Configuration Management System.

 Copyright 1995-2011 Perforce Software.  All rights reserved.

 Rev. P4/LINUX26X86/2010.2/279478 (2011/01/03).

 [build@vmtemp01 ~]$ ls -al /usr/local/bin/p4

 -rwxr-xr-x 1 root root 777172 Mar 22 14:02 /usr/local/bin/p4



 $ which patch

 /usr/bin/patch

 $ /usr/bin/patch -v

 patch 2.5.4

 Copyright 1984-1988 Larry Wall

 Copyright 1989-1999 Free Software Foundation, Inc.

 $ ls -al /usr/bin/patch

 -rwxr-xr-x 1 root wheel 91476 Aug 11  2008 /usr/bin/patch









 From: chip...@gmail.com
 [mailto:chip...@gmail.com] On Behalf Of Christian Hammond
 Sent: Wednesday, March 30, 2011 5:19 PM
 To: Vincent Yee
 Cc: reviewboard@googlegroups.com
 Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200):
 One or more fields had errors





 Okay, the No such file or
 directory indicates a configuration problem, but is a step in the right
 direction. Some program you need is missing, and Review Board's initial checks
 didn't catch it. Can you make sure that both p4 and patch are both available 
 on
 that system and accessible/executable?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com





 On Wed, Mar 30, 2011 at 4:59 PM, Vincent Yee v...@sendmail.com wrote:





 I tried
 with both in Mirror path:

 perforce.example:1666
 è
 Error data: {u'fields': {u'path': [u'[Errno 2] No such file or
 directory']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
 errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}



 :1666 è
 Error data: {u'fields': {u'path': [u'[P4.connect()] Connect to
 server failed; check $P4PORT.\nTCP connect to :1666 failed.\nconnect: :1666:
 Connection refused\n']}, u'stat': u'fail', u'err': {u'msg': u'One or more
 fields had errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}















 From: chip...@gmail.com [mailto:chip...@gmail.com] On
 Behalf Of Christian Hammond
 Sent: Wednesday, March 30, 2011 4:42 PM






 To: Vincent Yee
 Cc: reviewboard@googlegroups.com
 Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200):
 One or more fields had errors













 The
 error message says you're just using :1666.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com



 On
 Wed, Mar 30, 2011 at 4:38 PM, Vincent Yee v...@sendmail.com wrote:





 Ok now
 it’s a different error with

 Mirror
 path:  perforce.example.com:1666




 HTTP POSTing to 
 http://vmreviews.lab-example.com/reviews/api/json/reviewrequests/20/draft/set/:
 {'summary': 'p4-testing-change'}


 Uploading diff, size: 361








-- 
-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Successful upgrade from Reviewboard 1.0.5.1 to 1.5.5

2011-03-31 Thread Christian Hammond
Awesome :) Thanks for sharing. It's nice to hear on this list when things
actually go smoothly ;)

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, Mar 30, 2011 at 6:29 PM, Chris Clark chris.cl...@ingres.com wrote:

 We had a customized version of 1.0.5.1 and we now have a (less) customized
 version 1.5.5 (custom SCM back end and minor email/template tweaks).

 We're using Ubuntu 8.04.3 LTS (hardy) on x86 (same as the last time we
 upgraded, we've left the OS alone) .

 We had no problems at all with this upgrade! So unlike my previous upgrade
 reports this really is an uninteresting one :-)

 The only minor oddity was that setup tools needed to be upgraded. In our
 haste to upgrade we simply used easy_install for that (it may have been that
 apt-get would have found a new version). When the test upgrades had been
 done, a different OS version was used so this was our only surprise.

 We also went from Django-1.1.1 (we're behind a firewall so this old
 version has been fine for us) to Django-1.3 (other stuff was upgraded too,
 like Djblets-0.5.5 to Djblets-0.6.7, but this is one of the significant
 ones).

 The main reason for the upgrade was that we needed auth support for svn,
 we've wanted the other new features (drag-n-drop images, improved username
 lookup, ) for a while but we *needed* auth.

 Thanks again to everyone for making the upgrade path so easy, with
 great/clear documentation.

 We maybe brave soon and enable the Lucene support.

 Chris

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Installing Review board and connecting to LDAP

2011-03-31 Thread stevenson lee
Hi,

Me and my teammates are trying to use review board for our code
review. I followed the installation guide and got the site up. Now I'm
trying to use our ldap to authenticate.
So far all I did was go to http://localhost/admin/settings/authentication/
(I'm testing on my localhost)
and changed the auth method to ldap and fill up the form.

after filling up the form. I tried logging in using my ldap account
but it failed. I went to the user list and it is still just the admin
user that I have by default.

This is my first time working with ldap can anyone help me? I'm not
sure if I just entered a wrong value in the form or if I need to edit
some other config file.

I'd appreciate any help.

Best regards,

Stevenson Lee

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


post-review perforce changelist -- API Error 105, Error data

2011-03-31 Thread rquit
I submitted two review requests, but only one succeeded.

**
SUCCESSFUL:

[~]$ post-review //path/to/file#8 --debug
 svn info
 p4 info
 repository info: Path: perforce.server.com:1666, Base path: None, Supports 
 changesets: True
 p4 counters
 Writing //path/to/file#8 to /tmp/tmpqGKzlE
 p4 print -o /tmp/tmpqGKzlE -q //path/to/file#8
 diff -urNp /tmp/tmpOVbHra /tmp/tmpqGKzlE
 Looking for 'ip.address /' cookie in /home/user/.post-review-cookies.txt
 Loaded valid cookie -- no login required
 Attempting to create review request on perforce.server.com:1666 for None
 HTTP POSTing to http://ip.address/api/json/reviewrequests/new/: 
 {'repository_path': 'perforce/server.com:1666'}
 Review request created
 Uploading diff, size: 7291
 HTTP POSTing to http://ip.address/api/json/reviewrequests/176/diff/new/: {}
Review request #176 posted.


UNSUCCESSFUL:

[~]$ post-review changelist --debug
 svn info
 p4 info
 repository info: Path: perforce.server.com:1666, Base path: None, Supports 
 changesets: True
 p4 counters
 Generating diff for changenum changelist
 p4 describe -s changelist
 Processing edit of //path/to/file
 Writing //path/to/file#7 to /tmp/tmpePxLve
 p4 print -o /tmp/tmpePxLve -q //path/to/file#7
 Writing //path/to/file#8 to /tmp/tmpNjfomF
 p4 print -o /tmp/tmpNjfomF -q //path/to/file#8
 diff -urNp /tmp/tmpePxLve /tmp/tmpNjfomF
 Looking for 'ip.address /' cookie in /home/user/.post-review-cookies.txt
 Loaded valid cookie -- no login required
 Attempting to create review request on perforce.server.com:1666 for 
 changelist
 HTTP POSTing to http://ip.address/api/json/reviewrequests/new/: 
 {'repository_path': 'perforce.server.com:1666', 'changenum': 'changelist'}
 Review request created
 Uploading diff, size: 1427
 HTTP POSTing to http://ip.address/api/json/reviewrequests/175/diff/new/: {}
 Got API Error 105 (HTTP code 200): One or more fields had errors
 Error data: {'fields': {'path': ['[Errno 2] No such file or directory']}, 
 'stat': 'fail', 'err': {'msg': 'One or more fields had errors', 'code': 
 105}}

Error uploading diff

The generated diff file was empty. This usually means no files were
modified in this change.

Try running with --output-diff and --debug for more information.

Your review request still exists, but the diff is not attached.
**
What could be the issue??

Thanks in advance.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Issue 2055 in reviewboard: Project testing

2011-03-31 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2055 by iqbal...@gmail.com: Project testing
http://code.google.com/p/reviewboard/issues/detail?id=2055

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.


Attachments:
session.JPG  119 KB

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2055 in reviewboard: Project testing

2011-03-31 Thread reviewboard

Updates:
Status: Invalid

Comment #1 on issue 2055 by trowb...@gmail.com: Project testing
http://code.google.com/p/reviewboard/issues/detail?id=2055

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2056 in reviewboard: Use diff viewer to show block changes in Review request changed sections

2011-03-31 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2056 by cord...@gmail.com: Use diff viewer to show block changes  
in Review request changed sections

http://code.google.com/p/reviewboard/issues/detail?id=2056

What version are you running?
1.5

Describe the enhancement and the motivation for it.
When submitting a second or later revision to a review, the description and  
testing done sections typically change.  It displays large from and to  
blocks with no easy way of comparing them to see what has changed or been  
added.  I think it would be a good idea to make use of the diff viewer to  
show the changes to these sections.


What operating system are you using? What browser?
Windows 7, Firefox 3.6.13


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2045 in reviewboard: Show changes to description or testing done fields as a real diff

2011-03-31 Thread reviewboard


Comment #2 on issue 2045 by trowb...@gmail.com: Show changes  
to description or testing done fields as a real diff

http://code.google.com/p/reviewboard/issues/detail?id=2045

Issue 2056 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2056 in reviewboard: Use diff viewer to show block changes in Review request changed sections

2011-03-31 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 2045

Comment #1 on issue 2056 by trowb...@gmail.com: Use diff viewer to show  
block changes in Review request changed sections

http://code.google.com/p/reviewboard/issues/detail?id=2056

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2057 in reviewboard: Auto-detect and make certain

2011-03-31 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2057 by cord...@gmail.com: Auto-detect and make certain
http://code.google.com/p/reviewboard/issues/detail?id=2057

What version are you running?
1.5

Describe the enhancement and the motivation for it.
Frequently I make a reference to another review.  Rather than paste the  
full URL, I would appreciate that if the word review was followed by a  
number, it would automatically be turned into a hyperlink similar to how  
Bugzilla autolinks bug numbers.

See http://www.bugzilla.org/docs/tip/en/html/hintsandtips.html

What operating system are you using? What browser?
Windows 7 and Firefox 3.6.13

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2057 in reviewboard: Detect and auto-link review request IDs

2011-03-31 Thread reviewboard

Updates:
Summary: Detect and auto-link review request IDs

Comment #1 on issue 2057 by trowb...@gmail.com: Detect and auto-link review  
request IDs

http://code.google.com/p/reviewboard/issues/detail?id=2057

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2027 in reviewboard: can't comment to diff

2011-03-31 Thread reviewboard

Updates:
Status: UserError

Comment #2 on issue 2027 by trowb...@gmail.com: can't comment to diff
http://code.google.com/p/reviewboard/issues/detail?id=2027

Assuming that it was not published. If it was and you can provide more  
details, please let us know.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1885 in reviewboard: Permissions to restrict viewing of all commits and closing review requests

2011-03-31 Thread reviewboard

Updates:
Status: Fixed

Comment #3 on issue 1885 by trowb...@gmail.com: Permissions to restrict  
viewing of all commits and closing review requests

http://code.google.com/p/reviewboard/issues/detail?id=1885

These are all possible now with 1.6

- Invite-only groups can handle the cases where you want to limit who's in  
a group, and who sees a review request

- Repositories have group and user-level access lists
- You can keep developers from closing reviews for their own code by using  
--submit-as to post their code under a different username.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1954 in reviewboard: per-user repository hiding

2011-03-31 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 1763

Comment #1 on issue 1954 by trowb...@gmail.com: per-user repository hiding
http://code.google.com/p/reviewboard/issues/detail?id=1954

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1763 in reviewboard: on New Change Request page repository selection can be enhanced

2011-03-31 Thread reviewboard


Comment #2 on issue 1763 by trowb...@gmail.com: on New Change Request  
page repository selection can be enhanced

http://code.google.com/p/reviewboard/issues/detail?id=1763

Issue 1954 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1763 in reviewboard: on New Change Request page repository selection can be enhanced

2011-03-31 Thread reviewboard


Comment #3 on issue 1763 by trowb...@gmail.com: on New Change Request  
page repository selection can be enhanced

http://code.google.com/p/reviewboard/issues/detail?id=1763

1954 suggests adding the ability for users to hide repos that they don't  
care about.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2057 in reviewboard: Detect and auto-link review request IDs

2011-03-31 Thread reviewboard

Updates:
Status: NotABug

Comment #2 on issue 2057 by chip...@gmail.com: Detect and auto-link review  
request IDs

http://code.google.com/p/reviewboard/issues/detail?id=2057

Reference it by /r/123 and it'll do just that. That's our shorthand for  
review request IDs.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.