Re: UnicodeDecodeError with Visual Studio files, RB 1.5.4, RBTools-0.3.2 (Python 2.7.1)

2011-04-05 Thread Chris Clark

Craig A wrote:

This may well be fixed by trying python 2.6 (or even 2.5) as you
suggested.



I tried Python 2.6.6 (could not find an msi installer for 2.5.5) and
voila! It works now, no more problems with BOM characters.

Thanks for your help Chris, I am glad this is working now.
  


Whilst this impacted a Windows user (Windows Python defaults to 7 bit 
US-ASCII encoding) with a utf8 encoded (diff) file. This could easily 
impact any user on any platform where the encoding for the file is not 
valid for the (default) Python site string encoding. For example this is 
likely to impact users of Python 2.7 if:


   * diff contains a single latin1 character (e.g. copyright symbol, an
 e with an accent, etc.) and the site encoding is not latin1.
 This would impact all Unix/Linux platforms where the Python
 installation tends to default to utf8


It looks like the Python 3.x byte/string difference that is in 2.7 will 
need to be looked at. Possibly via an encoding flag to postreview.


I'm snowed under at the moment otherwise I'd look at this myself :-(

I have a number of Windows users (with non ascii diffs) so I'm at risk 
for this problem BUT this isn't an issue for me as I supply them with an 
exe generated with Python 2.4 and py2exe. Craig This may be your best 
option.


Chris

--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Issue 1526 in reviewboard: AttributeError: 'DashboardDataGrid' object has no attribute 'id_list'

2011-04-05 Thread reviewboard


Comment #9 on issue 1526 by chris.cl...@ingres.com:  
AttributeError: 'DashboardDataGrid' object has no attribute 'id_list'

http://code.google.com/p/reviewboard/issues/detail?id=1526

The same user who experience this problem yesterday hit a similar issue.  
The dashboard 500'd for client BUT the trace back is different. I'm not  
sure if this is the same issue, different manifestation or something else.  
Interestingly Djblets is the main thing in the trace back not Reviewboard.


When we upgraded we jumped from Djblets-0.5.5 to Djblets-0.6.7.

Django version jump was Django-1.1.1 to Django-1.3

Traceback (most recent call last):

   
File /usr/lib/python2.5/site-packages/Django-1.3-py2.5.egg/django/core/handlers/base.py,  
line 111, in get_response

response = callback(request, *callback_args, **callback_kwargs)

   
File /usr/lib/python2.5/site-packages/Djblets-0.6.7-py2.5.egg/djblets/auth/util.py,  
line 46, in _checklogin

return view_func(request, *args, **kwargs)

   
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5.5.dev-py2.5.egg/reviewboard/accounts/decorators.py,  
line 46, in _check_valid_prefs

return view_func(request, *args, **kwargs)

   
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5.5.dev-py2.5.egg/reviewboard/reviews/views.py,  
line 330, in dashboard

return grid.render_to_response(template_name)

   
File /usr/lib/python2.5/site-packages/Djblets-0.6.7-py2.5.egg/djblets/datagrid/grids.py,  
line 699, in render_to_response

self.load_state()

   
File /usr/lib/python2.5/site-packages/Djblets-0.6.7-py2.5.egg/djblets/datagrid/grids.py,  
line 534, in load_state

self.precompute_objects()

   
File /usr/lib/python2.5/site-packages/Djblets-0.6.7-py2.5.egg/djblets/datagrid/grids.py,  
line 636, in precompute_objects

for obj in object_list

   
File /usr/lib/python2.5/site-packages/Djblets-0.6.7-py2.5.egg/djblets/datagrid/grids.py,  
line 241, in render_cell

mark_safe(self.datagrid.cell_template_obj.render(ctx))

AttributeError: 'NoneType' object has no attribute 'render'


ModPythonRequest
path:/dashboard/,
GET:QueryDict: {},
POST:QueryDict: {},
COOKIES:{'collapsediffs': 'True', 'rbsessionid': '**SNIP**'},
META:{'AUTH_TYPE': None,
 'CONTENT_LENGTH': 0,
 'CONTENT_TYPE': None,
 'GATEWAY_INTERFACE': 'CGI/1.1',
 'HTTP_ACCEPT': 
'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8',
 'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.7',
 'HTTP_ACCEPT_ENCODING': 'gzip,deflate',
 'HTTP_ACCEPT_LANGUAGE': 'en-us,en;q=0.5',
 'HTTP_CACHE_CONTROL': 'max-age=0',
 'HTTP_CONNECTION': 'keep-alive',
 'HTTP_COOKIE': 'rbsessionid=**SNIP**; collapsediffs=True',
 'HTTP_HOST': '**SNIP**',
 'HTTP_KEEP_ALIVE': '115',
 'HTTP_USER_AGENT': 'Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;  
rv:1.9.2.16) Gecko/20110319 Firefox/3.6.16 ( .NET CLR 3.5.30729)',

 'PATH_INFO': u'/dashboard/',
 'PATH_TRANSLATED': None,
 'QUERY_STRING': None,
 'REMOTE_ADDR': '**SNIP**',
 'REMOTE_HOST': None,
 'REMOTE_IDENT': None,
 'REMOTE_USER': None,
 'REQUEST_METHOD': 'GET',
 'SCRIPT_NAME': '',
 'SERVER_NAME': '**SNIP**',
 'SERVER_PORT': 80,
 'SERVER_PROTOCOL': 'HTTP/1.1',
 'SERVER_SOFTWARE': 'mod_python'}


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.