post-review failing whereas user is an admin

2011-04-06 Thread Pierre Habouzit
I'm evaluating review-board (1.6 beta1) with our corporate git setup,
sadly when I try to use post-review it spits out the following
(repository path anonymized):

$ post-review -d --parent=HEAD~1 HEAD
 RBTools 0.3.2
 Home = /home/madcoder
 svn info
 git rev-parse --git-dir
 git symbolic-ref -q HEAD
 git config --get branch.master.merge
 git config --get branch.master.remote
 git config remote.origin.url
 repository info: Path: X, Base path: , Supports changesets: 
 False
 git config --get reviewboard.url
 HTTP GETting api/
 HTTP GETting http://git.corp/reviews/api/info/
 Using the new web API
 git merge-base origin/master refs/heads/master
 git diff --no-color --full-index --no-ext-diff HEAD~1..
 git diff --no-color --full-index --no-ext-diff 
 c73aa14a712e7d0de93fa1c9cd19e0444f5a6033..HEAD~1
 Attempting to create review request on X for None
 HTTP POSTing to http://git.corp/reviews/api/review-requests/: 
 {'repository': 'X'}
 Got API Error 101 (HTTP code 403): You don't have permission for this
 Error data: {u'stat': u'fail', u'err': {u'msg': uYou don't have permission 
 for this, u'code': 101}}
Error creating review request: You don't have permission for this
(HTTP 403, API Error 101)


I've no clue of how to troubleshoot this issue, my user is superuser
AND member of the staff, so it's highly unlikely that it is a real
permission issue.

Plus, the user is able to create review requests by using the Web UI
on the same repository.

Any clue of what is happening?

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


I want to control review request sight.

2011-04-06 Thread jh5774....@samsung.com
I have some problem about sight issues.

For example,

A user create new Review Request(RQ) and he set this RQ's review group
as A1'

Now, I want that review group A1 only access A's RQ.

My problem is that, anyone who log on my reviewboard can access and
review A's RQ.

I cannot control them And I'm tired to find...

Anyone help me please...

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: I want to control review request sight.

2011-04-06 Thread Christian Hammond
This is not possible in the released version. However, this functionality is
available in the upcoming 1.6 release. There is an alpha out right now,
which I don't recommend for production use yet, but it supports this. We
hopefully will have a final release in a couple of months. For now, you'd
have to segment this using multiple Review Board servers.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, Apr 6, 2011 at 12:05 AM, jh5774@samsung.com 
jh5774@samsung.com wrote:

 I have some problem about sight issues.

 For example,

 A user create new Review Request(RQ) and he set this RQ's review group
 as A1'

 Now, I want that review group A1 only access A's RQ.

 My problem is that, anyone who log on my reviewboard can access and
 review A's RQ.

 I cannot control them And I'm tired to find...

 Anyone help me please...

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: I want to control review request sight.

2011-04-06 Thread jh5774....@samsung.com
Thank you for your help,

Because my company have strict rule about managing source code,

So, we cannot using Reviewboard right now...

Have a good day :)


On 4월6일, 오후5시14분, Christian Hammond chip...@chipx86.com wrote:
 This is not possible in the released version. However, this functionality is
 available in the upcoming 1.6 release. There is an alpha out right now,
 which I don't recommend for production use yet, but it supports this. We
 hopefully will have a final release in a couple of months. For now, you'd
 have to segment this using multiple Review Board servers.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com

 On Wed, Apr 6, 2011 at 12:05 AM, jh5774@samsung.com 







 jh5774@samsung.com wrote:
  I have some problem about sight issues.

  For example,

  A user create new Review Request(RQ) and he set this RQ's review group
  as A1'

  Now, I want that review group A1 only access A's RQ.

  My problem is that, anyone who log on my reviewboard can access and
  review A's RQ.

  I cannot control them And I'm tired to find...

  Anyone help me please...

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


yo What!?!?s shakin!?!?!?!? how's it going!?!?

2011-04-06 Thread Chandra Moye
How have you been? I saw this Acai Berry stuff that is actually
unbelievable! I have been feeling fantastic since i've been taking it.
finally found a way to lose weight that works and is actually healthy
for you! check out this article about it if you want to read more
about it and buy some http://magic-slim.info/!! You can buy from that
site for cheap! I recommended  it to a few friends already and they
were thanking me earlier saying they lost 5lbs in less than a week so
I thought I would fill you in also ;-) The stuff is amazing. A lot of
great info on that site but let me know if you have any questions
about it.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: I want to control review request sight.

2011-04-06 Thread Christian Hammond
Sorry to hear that, but I completely understand. I hope you'll check back
when 1.6 is out the door and see if it meets your needs then :)

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


2011/4/6 jh5774@samsung.com jh5774@samsung.com

 Thank you for your help,

 Because my company have strict rule about managing source code,

 So, we cannot using Reviewboard right now...

 Have a good day :)


 On 4월6일, 오후5시14분, Christian Hammond chip...@chipx86.com wrote:
  This is not possible in the released version. However, this functionality
 is
  available in the upcoming 1.6 release. There is an alpha out right now,
  which I don't recommend for production use yet, but it supports this. We
  hopefully will have a final release in a couple of months. For now, you'd
  have to segment this using multiple Review Board servers.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.reviewboard.org
  VMware, Inc. -http://www.vmware.com
 
  On Wed, Apr 6, 2011 at 12:05 AM, jh5774@samsung.com 
 
 
 
 
 
 
 
  jh5774@samsung.com wrote:
   I have some problem about sight issues.
 
   For example,
 
   A user create new Review Request(RQ) and he set this RQ's review group
   as A1'
 
   Now, I want that review group A1 only access A's RQ.
 
   My problem is that, anyone who log on my reviewboard can access and
   review A's RQ.
 
   I cannot control them And I'm tired to find...
 
   Anyone help me please...
 
   --
   Want to help the Review Board project? Donate today at
  http://www.reviewboard.org/donate/
   Happy user? Let us know athttp://www.reviewboard.org/users/
   -~--~~~~--~~--~--~---
   To unsubscribe from this group, send email to
   reviewboard+unsubscr...@googlegroups.com
   For more options, visit this group at
  http://groups.google.com/group/reviewboard?hl=en

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

I have some problems about Languages.

2011-04-06 Thread jh5774....@samsung.com
Well,

My language, Korean, isn't parsing in Reviewboard.

For example,

I submit Change List(CL) in perforce, and CL's description field is
filled with 'Korean', not English.

And, I go to my Reviewboard server.

In Main menu,

Select New Review Request and select repository (perforce port)

input CL number(with that CL), and click the button 'Create Review
Request'


Then, there's some error in my Review Request.

my description field is empty, and file diff isn't in the RQ.

Below is my reviewboard error messages.

 p4 -p 10.244.106.31:1666 info
 repository info: Path: 10.244.106.31:1666, Base path: None, Supports 
 changesets: True
 Generating diff for changenum 901357
 p4 describe -s 901357
 Processing edit of //this is a branch path. so I delete them example.h
 Writing //this is a branch path. so I delete them example.h#1 to 
 c:\users\admini~1\appdata\local\temp\tmpcezv0o
 p4 print -o c:\users\admini~1\appdata\local\temp\tmpcezv0o -q //this is a 
 branch path. so I delete them example.h#1
 diff -urNp c:\users\admini~1\appdata\local\temp\tmpcezv0o 
 d:\projects\S3350_REL_AE\3p_mm_ct_lib\aac_encoder\lib\export\include\aacplusenc.h
 Looking for '10.244.106.190 /reviewboard_demo/' cookie in 
 C:\Users\Administrator\AppData\Roaming\.post-review-cookies.jh5774.bae.txt
 Loaded valid cookie -- no login required
 HTTP GETting api/
 HTTP GETting http://10.244.106.190/reviewboard_demo/api/info/
 Using the new web API
 Attempting to create review request on 10.244.106.31:1666 for 901357
 HTTP POSTing to 
 http://10.244.106.190/reviewboard_demo/api/review-requests/: {'changenum': 
 '901357', 'repository': '10.244.106.31:1666'}
 Got HTTP error: 500: !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0 
 Transitional//EN
 http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd;

html xmlns=http://www.w3.org/1999/xhtml; xml:lang=en lang=en
 head
  title500 - Internal Server Error | Review Board/title
 /head
 body
  h1Something broke! (Error 500)/h1
  p
   It appears something broke when you tried to go to here. This is
either
   a bug in Review Board or a server configuration error. Please
report
   this to your administrator.
  /p
 /body
/title

Error creating review request: HTTP 500

and, below is my reviewboard server's error log:

  File /usr/lib/python2.6/json/encoder.py, line 317, in
_iterencode for chunk in self._iterencode_default(o, markers):
  File /usr/lib/python2.6/json/encoder.py, line 309, in
_iterencode for chunk in self._iterencode_dict(o, markers):
  File /usr/lib/python2.6/json/encoder.py, line 275, in
_iterencode_dict for chunk in self._iterencode(value, markers):
  File /usr/lib/python2.6/json/encoder.py, line 294, in
_iterencode yield encoder(o)

UnicodeDecodeError: 'utf8' codec can't decode bytes in position 0-1:
invalid data
[Wed Apr 06 17:22:14 2011] [error] [client 10.244.84.108] File does
not exist: /var/www/favicon.ico

/usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/django/db/
backends/mysql/base.py:86:
Warning: Incorrect string value: '\xC1\xDF\xC0\xD4\xB4\xCF...' for
column 'summary' at row 1  return self.cursor.execute(query, args)

/usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/django/db/
backends/mysql/base.py:86: Warning:
Incorrect string value: '\xC1\xDF\xC0\xD4\xB4\xCF...' for column
'description' at row 1  return self.cursor.execute(query, args)

ERROR:django.request:Internal Server Error: /reviewboard_demo/api/
review-requests/


Traceback (most recent call last):
  File /usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/
django/core/handlers/base.py, line 178, in get_response
response = middleware_method(request, response)
  File /usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/
django/middleware/http.py, line 15, in process_response
response['Content-Length'] = str(len(response.content))
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
djblets/webapi/core.py, line 276, in _get_content
content = adapter.encode(self.api_data, request=self.request)
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
djblets/webapi/core.py, line 88, in encode
return super(JSONEncoderAdapter, self).encode(o)
  File /usr/lib/python2.6/json/encoder.py, line 367, in encode
chunks = list(self.iterencode(o))
  File /usr/lib/python2.6/json/encoder.py, line 309, in _iterencode
for chunk in self._iterencode_dict(o, markers):
  File /usr/lib/python2.6/json/encoder.py, line 275, in
_iterencode_dict
for chunk in self._iterencode(value, markers):
  File /usr/lib/python2.6/json/encoder.py, line 317, in _iterencode
for chunk in self._iterencode_default(o, markers):
  File /usr/lib/python2.6/json/encoder.py, line 309, in _iterencode
for chunk in self._iterencode_dict(o, markers):
  File /usr/lib/python2.6/json/encoder.py, line 275, in
_iterencode_dict
for chunk in self._iterencode(value, markers):
  File /usr/lib/python2.6/json/encoder.py, line 294, in _iterencode
yield 

Re: git submodules and reviewboard?

2011-04-06 Thread funeeldy
Does anyone read these??? I would think this is a pretty simple
question to answer.

On Apr 4, 3:14 pm, funeeldy funee...@yahoo.com wrote:
 I am trying to get an answer to this question.  Does reviewboard work
 with git submodules?
 Thanks.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: I have some problems about Languages.

2011-04-06 Thread Min-Woo Lee
maybe you seems to using euc-kr in your perforce
2011. 4. 6. 오후 9:36에 Chris Clark chris.cl...@ingres.com님이 작성:

 This looks VERY similar in behavior (but different manifestation) to the
UnicodeDecode error that another Windows user saw recently with UTF8 encoded
files (check the archive for UnicodeDecode). I.e. this isn't a language
issue but an character set encoding issue

 There are a few options here but I suspect the easiest is for you to
modify the repository info in Reviewboard and declare the encoding. I'm
guessing you are using a multibyte encoding rather than utf8? Can you tell
us the encoding?

 Chris


 jh5774@samsung.com wrote:

 Well,

 My language, Korean, isn't parsing in Reviewboard.

 For example,

 I submit Change List(CL) in perforce, and CL's description field is
 filled with 'Korean', not English.

 And, I go to my Reviewboard server.

 In Main menu,

 Select New Review Request and select repository (perforce port)

 input CL number(with that CL), and click the button 'Create Review
 Request'


 Then, there's some error in my Review Request.

 my description field is empty, and file diff isn't in the RQ.

 Below is my reviewboard error messages.



 p4 -p 10.244.106.31:1666 info
 repository info: Path: 10.244.106.31:1666, Base path: None, Supports
changesets: True
 Generating diff for changenum 901357
 p4 describe -s 901357
 Processing edit of //this is a branch path. so I delete them example.h
 Writing //this is a branch path. so I delete them example.h#1 to
c:\users\admini~1\appdata\local\temp\tmpcezv0o
 p4 print -o c:\users\admini~1\appdata\local\temp\tmpcezv0o -q //this
is a branch path. so I delete them example.h#1
 diff -urNp c:\users\admini~1\appdata\local\temp\tmpcezv0o
d:\projects\S3350_REL_AE\3p_mm_ct_lib\aac_encoder\lib\export\include\aacplusenc.h
 Looking for '10.244.106.190 /reviewboard_demo/' cookie in
C:\Users\Administrator\AppData\Roaming\.post-review-cookies.jh5774.bae.txt
 Loaded valid cookie -- no login required
 HTTP GETting api/
 HTTP GETting http://10.244.106.190/reviewboard_demo/api/info/
 Using the new web API
 Attempting to create review request on 10.244.106.31:1666 for 901357
 HTTP POSTing to
http://10.244.106.190/reviewboard_demo/api/review-requests/: {'changenum':
'901357', 'repository': '10.244.106.31:1666'}
 Got HTTP error: 500: !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0
Transitional//EN


  http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd;

 html xmlns=http://www.w3.org/1999/xhtml; xml:lang=en lang=en
  head
  title500 - Internal Server Error | Review Board/title
  /head
  body
  h1Something broke! (Error 500)/h1
  p
   It appears something broke when you tried to go to here. This is
 either
   a bug in Review Board or a server configuration error. Please
 report
   this to your administrator.
  /p
  /body
 /title

 Error creating review request: HTTP 500

 and, below is my reviewboard server's error log:

  File /usr/lib/python2.6/json/encoder.py, line 317, in
 _iterencode for chunk in self._iterencode_default(o, markers):
  File /usr/lib/python2.6/json/encoder.py, line 309, in
 _iterencode for chunk in self._iterencode_dict(o, markers):
  File /usr/lib/python2.6/json/encoder.py, line 275, in
 _iterencode_dict for chunk in self._iterencode(value, markers):
  File /usr/lib/python2.6/json/encoder.py, line 294, in
 _iterencode yield encoder(o)

 UnicodeDecodeError: 'utf8' codec can't decode bytes in position 0-1:
 invalid data
 [Wed Apr 06 17:22:14 2011] [error] [client 10.244.84.108] File does
 not exist: /var/www/favicon.ico

 /usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/django/db/
 backends/mysql/base.py:86:
 Warning: Incorrect string value: '\xC1\xDF\xC0\xD4\xB4\xCF...' for
 column 'summary' at row 1  return self.cursor.execute(query, args)

 /usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/django/db/
 backends/mysql/base.py:86: Warning:
 Incorrect string value: '\xC1\xDF\xC0\xD4\xB4\xCF...' for column
 'description' at row 1  return self.cursor.execute(query, args)

 ERROR:django.request:Internal Server Error: /reviewboard_demo/api/
 review-requests/


 Traceback (most recent call last):
  File /usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/
 django/core/handlers/base.py, line 178, in get_response
response = middleware_method(request, response)
  File /usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/
 django/middleware/http.py, line 15, in process_response
response['Content-Length'] = str(len(response.content))
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
 djblets/webapi/core.py, line 276, in _get_content
content = adapter.encode(self.api_data, request=self.request)
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
 djblets/webapi/core.py, line 88, in encode
return super(JSONEncoderAdapter, self).encode(o)
  File /usr/lib/python2.6/json/encoder.py, line 367, in encode
chunks = list(self.iterencode(o))
  File 

I can't use the post-review. I get Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD']

2011-04-06 Thread Martin
Hi, everyone.
I had installed ReviewBoard and I created a review uploading the diff patch 
from the web UI. This task worked perfectly, but when I want use post-review 
for the same , I get the following error:

Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD']

I have configured mi git repo in ReviewBoard as a non-bare repository, in 
fact, is a git svn clone of a central SVN.

Does anybody can help me, please?

Thanks in advance.

Martin.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Error with post-review. I get Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD']

2011-04-06 Thread Martin
Hi, everyone.
I had installed ReviewBoard and I created a review uploading the diff
patch from the web UI. This task worked perfectly, but when I want use
post-review for the same , I get the following error:

Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD']

I have configured mi git repo in ReviewBoard as a non-bare repository,
in fact, is a git svn clone of a central SVN.

Does anybody can help me, please?

Thanks in advance.

Martin.


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Error with post-review. I get Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD']

2011-04-06 Thread Chris Clark

Martin wrote:

Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD']
  


What happens when you manually run:

   git symbolic-ref -q HEAD


--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Error with post-review. I get Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD']

2011-04-06 Thread Martin
Nothing happens.
The command is executed but I don't get anything by the standar output.
Any else tip will be useful.

Thanks a lot.

MArtin.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Error with post-review. I get Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD']

2011-04-06 Thread Martin
Before anything...
I configured my non-bare git repository in ReviewBoard. This repository is a 
git svn clone of a central SVN repository.
I'm trying to execute a pre commit review, using the post-review commit with 
the following syntax:

cat file.diff |post-review -d --diff-filename=-
Is this correct?

Thanks.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: git submodules and reviewboard?

2011-04-06 Thread Christian Hammond
Hi,

Sorry, I'm usually faster to respond but I'm on vacation this week and
not checking mail often.

We do not work with git submodules. Review Board associates one review
request per repository and wouldn't know where or how to access the
submodule files.

Christian


On Wednesday, April 6, 2011, funeeldy funee...@yahoo.com wrote:
 Does anyone read these??? I would think this is a pretty simple
 question to answer.

 On Apr 4, 3:14 pm, funeeldy funee...@yahoo.com wrote:
 I am trying to get an answer to this question.  Does reviewboard work
 with git submodules?
 Thanks.

 --
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en

-- 
-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Error with post-review. I get Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD']

2011-04-06 Thread Christian Hammond
Can you paste a full debug log (pass --debug to post-review)?

Also, run that command again and do: echo $?

That will show the error code returned by git. Non-0 is failure.

Christian


On Wednesday, April 6, 2011, Martin martin.villalo...@gmail.com wrote:
 Nothing happens.
 The command is executed but I don't get anything by the standar output.
 Any else tip will be useful.

 Thanks a lot.

 MArtin.


 --
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en

-- 
-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


httplib.BadStatusLine: '' when posting to RB 1.5.5 with RBTools 0.3.2 from SVN client

2011-04-06 Thread Jay
I'm getting an error when using the latest version of postreview to
post an IP from and SVN client:


$ post-review --server=http://reviewboard.ingres.prv --bug=1810 --
summary=X-IP for Mantis 1810 - test
Traceback (most recent call last):
  File /usr/bin/post-review, line 9, in module
load_entry_point('RBTools==0.3.2', 'console_scripts', 'post-
review')()
  File /usr/lib/python2.7/site-packages/RBTools-0.3.2-py2.7.egg/
rbtools/postreview.py, line 3794, in main
submit_as=options.submit_as)
  File /usr/lib/python2.7/site-packages/RBTools-0.3.2-py2.7.egg/
rbtools/postreview.py, line 3403, in tempt_fate
review_request = server.new_review_request(changenum, submit_as)
  File /usr/lib/python2.7/site-packages/RBTools-0.3.2-py2.7.egg/
rbtools/postreview.py, line 555, in new_review_request
if isinstance(self.info.path, list):
  File /usr/lib/python2.7/site-packages/RBTools-0.3.2-py2.7.egg/
rbtools/postreview.py, line 801, in _get_server_info
self._server_info = self._info.find_server_repository_info(self)
  File /usr/lib/python2.7/site-packages/RBTools-0.3.2-py2.7.egg/
rbtools/postreview.py, line 210, in find_server_repository_info
info = self._get_repository_info(server, repository)
  File /usr/lib/python2.7/site-packages/RBTools-0.3.2-py2.7.egg/
rbtools/postreview.py, line 226, in _get_repository_info
return server.get_repository_info(repository['id'])
  File /usr/lib/python2.7/site-packages/RBTools-0.3.2-py2.7.egg/
rbtools/postreview.py, line 720, in get_repository_info
rsp = self.api_get(url)
  File /usr/lib/python2.7/site-packages/RBTools-0.3.2-py2.7.egg/
rbtools/postreview.py, line 876, in api_get
return self.process_json(self.http_get(path))
  File /usr/lib/python2.7/site-packages/RBTools-0.3.2-py2.7.egg/
rbtools/postreview.py, line 846, in http_get
rsp = urllib2.urlopen(url).read()
  File /usr/lib64/python2.7/urllib2.py, line 126, in urlopen
return _opener.open(url, data, timeout)
  File /usr/lib64/python2.7/urllib2.py, line 391, in open
response = self._open(req, data)
  File /usr/lib64/python2.7/urllib2.py, line 409, in _open
'_open', req)
  File /usr/lib64/python2.7/urllib2.py, line 369, in _call_chain
result = func(*args)
  File /usr/lib64/python2.7/urllib2.py, line 1173, in http_open
return self.do_open(httplib.HTTPConnection, req)
  File /usr/lib64/python2.7/urllib2.py, line 1144, in do_open
r = h.getresponse(buffering=True)
  File /usr/lib64/python2.7/httplib.py, line 1025, in getresponse
response.begin()
  File /usr/lib64/python2.7/httplib.py, line 401, in begin
version, status, reason = self._read_status()
  File /usr/lib64/python2.7/httplib.py, line 365, in _read_status
raise BadStatusLine(line)
httplib.BadStatusLine: ''

Bizarrely, if I omit the --bug and --summary parameters, the
review posts without issue. Has anyone else seen this issue?
It works fine with previous version we were using, Postreview v0.8.

Any help, incite would be very much appreciated.

Thanks,

Jay

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Error with post-review. I get Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD']

2011-04-06 Thread Martin
The full debug log below

-bash-4.0$ cat AirStories.diff |post-review --debug --diff-filename=-
 RBTools 0.3.2
 Home = /home/hudsonhome
 svn info
 git rev-parse --git-dir
 git symbolic-ref -q HEAD
Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD']

-bash-4.0$ echo $?
1
-bash-4.0$ 

I feel this is not a good news, don't  you?



-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: I have some problems about Languages.

2011-04-06 Thread jh5774....@samsung.com
Our repository is perforce, their P4CHARATERSET=none.

Our Reviewboard's database support Unicode(utf-8).

And our reviewboard repository setting, Advanced - Encoding box is
empty.

Please check that...

Thank you.


On 4월7일, 오전2시24분, Min-Woo Lee mw44@gmail.com wrote:
 maybe you seems to using euc-kr in your perforce
 2011. 4. 6. 오후 9:36에 Chris Clark chris.cl...@ingres.com님이 작성:

  This looks VERY similar in behavior (but different manifestation) to the

 UnicodeDecode error that another Windows user saw recently with UTF8 encoded
 files (check the archive for UnicodeDecode). I.e. this isn't a language
 issue but an character set encoding issue

  There are a few options here but I suspect the easiest is for you to

 modify the repository info in Reviewboard and declare the encoding. I'm
 guessing you are using a multibyte encoding rather than utf8? Can you tell
 us the encoding?









  Chris

  jh5774@samsung.com wrote:

  Well,

  My language, Korean, isn't parsing in Reviewboard.

  For example,

  I submit Change List(CL) in perforce, and CL's description field is
  filled with 'Korean', not English.

  And, I go to my Reviewboard server.

  In Main menu,

  Select New Review Request and select repository (perforce port)

  input CL number(with that CL), and click the button 'Create Review
  Request'

  Then, there's some error in my Review Request.

  my description field is empty, and file diff isn't in the RQ.

  Below is my reviewboard error messages.

  p4 -p 10.244.106.31:1666 info
  repository info: Path: 10.244.106.31:1666, Base path: None, Supports
 changesets: True
  Generating diff for changenum 901357
  p4 describe -s 901357
  Processing edit of //this is a branch path. so I delete them example.h
  Writing //this is a branch path. so I delete them example.h#1 to

 c:\users\admini~1\appdata\local\temp\tmpcezv0o p4 print -o 
 c:\users\admini~1\appdata\local\temp\tmpcezv0o -q //this

 is a branch path. so I delete them example.h#1 diff -urNp 
 c:\users\admini~1\appdata\local\temp\tmpcezv0o

 d:\projects\S3350_REL_AE\3p_mm_ct_lib\aac_encoder\lib\export\include\aacplu 
 senc.h Looking for '10.244.106.190 /reviewboard_demo/' cookie in

 C:\Users\Administrator\AppData\Roaming\.post-review-cookies.jh5774.bae.txt
  Loaded valid cookie -- no login required
  HTTP GETting api/
  HTTP GETtinghttp://10.244.106.190/reviewboard_demo/api/info/
  Using the new web API
  Attempting to create review request on 10.244.106.31:1666 for 901357
  HTTP POSTing to

 http://10.244.106.190/reviewboard_demo/api/review-requests/:{'changenum':
 '901357', 'repository': '10.244.106.31:1666'}







  Got HTTP error: 500: !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0
 Transitional//EN

   http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd;

  html xmlns=http://www.w3.org/1999/xhtml; xml:lang=en lang=en
   head
   title500 - Internal Server Error | Review Board/title
   /head
   body
   h1Something broke! (Error 500)/h1
   p
It appears something broke when you tried to go to here. This is
  either
a bug in Review Board or a server configuration error. Please
  report
this to your administrator.
   /p
   /body
  /title

  Error creating review request: HTTP 500

  and, below is my reviewboard server's error log:

   File /usr/lib/python2.6/json/encoder.py, line 317, in
  _iterencode for chunk in self._iterencode_default(o, markers):
   File /usr/lib/python2.6/json/encoder.py, line 309, in
  _iterencode for chunk in self._iterencode_dict(o, markers):
   File /usr/lib/python2.6/json/encoder.py, line 275, in
  _iterencode_dict for chunk in self._iterencode(value, markers):
   File /usr/lib/python2.6/json/encoder.py, line 294, in
  _iterencode yield encoder(o)

  UnicodeDecodeError: 'utf8' codec can't decode bytes in position 0-1:
  invalid data
  [Wed Apr 06 17:22:14 2011] [error] [client 10.244.84.108] File does
  not exist: /var/www/favicon.ico

  /usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/django/db/
  backends/mysql/base.py:86:
  Warning: Incorrect string value: '\xC1\xDF\xC0\xD4\xB4\xCF...' for
  column 'summary' at row 1  return self.cursor.execute(query, args)

  /usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/django/db/
  backends/mysql/base.py:86: Warning:
  Incorrect string value: '\xC1\xDF\xC0\xD4\xB4\xCF...' for column
  'description' at row 1  return self.cursor.execute(query, args)

  ERROR:django.request:Internal Server Error: /reviewboard_demo/api/
  review-requests/

  Traceback (most recent call last):
   File /usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/
  django/core/handlers/base.py, line 178, in get_response
 response = middleware_method(request, response)
   File /usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/
  django/middleware/http.py, line 15, in process_response
 response['Content-Length'] = str(len(response.content))
   File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
  

Re: 1.5.4 on Windows, LDAP Authentication issues

2011-04-06 Thread Turbo
I figured it out!

So I had mod-python installed, but that needed openLDAP.
I install openLDAP, but that needed (openSSL or gnuTLS) and Cyrus
SASL.

So basically I installed openSSL and SASL, then re-installed openLDAP
and mod-python.

On Apr 4, 8:16 pm, Turbo ptrc...@gmail.com wrote:
 Hi all,

 I've been attempting to configure LDAP for the past few days and have
 not been able to come up with a solution.

 The three fields I am not clear about are
 Base DN
 User Mask
 Anon User Mask

 I have set up LDAP connections on Apache servers running on UNIX. For
 those settings, I have a field called Bind DN

 What is the difference between Base DN and Bind DN?

 Also, how do I know if RB is even hitting the LDAP server? There are
 times I give it bogus ldap urls and I still get error messages saying
 Incorrect username or password. 

 I have found the 1st post in this thread to resemble my LDAP server
 the 
 closest:http://groups.google.com/group/reviewboard-issues/browse_thread/threa...

 Thank you!

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: I have some problems about Languages.

2011-04-06 Thread jh5774....@samsung.com
Our Perforce server is window 2003 server

server manager said, he didn't set charset anything.

So, maybe perforce server's encoding is euc-kr..

How my ReviewBoard settings change to euc-kr??

Please anyone response to me...

Thank you.



On 4월7일, 오전10시48분, jh5774@samsung.com jh5774@samsung.com
wrote:
 Our repository is perforce, their P4CHARATERSET=none.

 Our Reviewboard's database support Unicode(utf-8).

 And our reviewboard repository setting, Advanced - Encoding box is
 empty.

 Please check that...

 Thank you.

 On 4월7일, 오전2시24분, Min-Woo Lee mw44@gmail.com wrote:







  maybe you seems to using euc-kr in your perforce
  2011. 4. 6. 오후 9:36에 Chris Clark chris.cl...@ingres.com님이 작성:

   This looks VERY similar in behavior (but different manifestation) to the

  UnicodeDecode error that another Windows user saw recently with UTF8 encoded
  files (check the archive for UnicodeDecode). I.e. this isn't a language
  issue but an character set encoding issue

   There are a few options here but I suspect the easiest is for you to

  modify the repository info in Reviewboard and declare the encoding. I'm
  guessing you are using a multibyte encoding rather than utf8? Can you tell
  us the encoding?

   Chris

   jh5774@samsung.com wrote:

   Well,

   My language, Korean, isn't parsing in Reviewboard.

   For example,

   I submit Change List(CL) in perforce, and CL's description field is
   filled with 'Korean', not English.

   And, I go to my Reviewboard server.

   In Main menu,

   Select New Review Request and select repository (perforce port)

   input CL number(with that CL), and click the button 'Create Review
   Request'

   Then, there's some error in my Review Request.

   my description field is empty, and file diff isn't in the RQ.

   Below is my reviewboard error messages.

   p4 -p 10.244.106.31:1666 info
   repository info: Path: 10.244.106.31:1666, Base path: None, Supports
  changesets: True
   Generating diff for changenum 901357
   p4 describe -s 901357
   Processing edit of //this is a branch path. so I delete them example.h
   Writing //this is a branch path. so I delete them example.h#1 to

  c:\users\admini~1\appdata\local\temp\tmpcezv0o p4 print -o 
  c:\users\admini~1\appdata\local\temp\tmpcezv0o -q //this

  is a branch path. so I delete them example.h#1 diff -urNp 
  c:\users\admini~1\appdata\local\temp\tmpcezv0o

  d:\projects\S3350_REL_AE\3p_mm_ct_lib\aac_encoder\lib\export\include\aacplu 
  senc.h Looking for '10.244.106.190 /reviewboard_demo/' cookie in

  C:\Users\Administrator\AppData\Roaming\.post-review-cookies.jh5774.bae.txt 
   Loaded valid cookie -- no login required
   HTTP GETting api/
   HTTP GETtinghttp://10.244.106.190/reviewboard_demo/api/info/
   Using the new web API
   Attempting to create review request on 10.244.106.31:1666 for 901357
   HTTP POSTing to

 http://10.244.106.190/reviewboard_demo/api/review-requests/:{'changenum':
  '901357', 'repository': '10.244.106.31:1666'}

   Got HTTP error: 500: !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0
  Transitional//EN

http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd;

   html xmlns=http://www.w3.org/1999/xhtml; xml:lang=en lang=en
head
title500 - Internal Server Error | Review Board/title
/head
body
h1Something broke! (Error 500)/h1
p
 It appears something broke when you tried to go to here. This is
   either
 a bug in Review Board or a server configuration error. Please
   report
 this to your administrator.
/p
/body
   /title

   Error creating review request: HTTP 500

   and, below is my reviewboard server's error log:

File /usr/lib/python2.6/json/encoder.py, line 317, in
   _iterencode for chunk in self._iterencode_default(o, markers):
File /usr/lib/python2.6/json/encoder.py, line 309, in
   _iterencode for chunk in self._iterencode_dict(o, markers):
File /usr/lib/python2.6/json/encoder.py, line 275, in
   _iterencode_dict for chunk in self._iterencode(value, markers):
File /usr/lib/python2.6/json/encoder.py, line 294, in
   _iterencode yield encoder(o)

   UnicodeDecodeError: 'utf8' codec can't decode bytes in position 0-1:
   invalid data
   [Wed Apr 06 17:22:14 2011] [error] [client 10.244.84.108] File does
   not exist: /var/www/favicon.ico

   /usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/django/db/
   backends/mysql/base.py:86:
   Warning: Incorrect string value: '\xC1\xDF\xC0\xD4\xB4\xCF...' for
   column 'summary' at row 1  return self.cursor.execute(query, args)

   /usr/local/lib/python2.6/dist-packages/Django-1.3-py2.6.egg/django/db/
   backends/mysql/base.py:86: Warning:
   Incorrect string value: '\xC1\xDF\xC0\xD4\xB4\xCF...' for column
   'description' at row 1  return self.cursor.execute(query, args)

   ERROR:django.request:Internal Server Error: /reviewboard_demo/api/
   review-requests/

   Traceback (most recent call last):
File 

Issue 2059 in reviewboard: Enhancement of expanding hidden lines

2011-04-06 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2059 by jianjun@gmail.com: Enhancement of expanding hidden  
lines

http://code.google.com/p/reviewboard/issues/detail?id=2059

*NOTE: If you have a patch, please submit it to
http://reviews.reviewboard.org/


What version are you running?
1.5.4.1

What's the URL of the page this enhancement relates to, if any?


Describe the enhancement and the motivation for it.
The reviewboard will hide a number of lines between the diff lines, from  
several to thousands of lines depending on the code change, users have only  
one option to Expand all the hidden line even if there are thousands of,  
then have to go back to find where they were before. It's could be fine if  
we design a Expand 100 lines for the big hidden blocks, then users will  
find it easy to go back the diff lines and have a better context review.


What operating system are you using? What browser?
Not OS related, Firefox is used.

Please provide any additional information below.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2060 in reviewboard: Not possible to send 2nd revision for a code review

2011-04-06 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2060 by alexande...@gmail.com: Not possible to send 2nd revision  
for a code review

http://code.google.com/p/reviewboard/issues/detail?id=2060

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.0

What's the URL of the page containing the problem?
http://codereview.nimone.com/api/json/reviewrequests/23307/update_from_changenum/.HTTP  
Error  
500: INTERNAL SERVER ERROR



What steps will reproduce the problem?
1. send a changelist for review
2. send the same changelist again

What is the expected output? What do you see instead?
Unable to access  
http://codereview.nimone.com/api/json/reviewrequests/23307/update_from_changenum/.  
The host path may be invalid

HTTP Error 500: INTERNAL SERVER ERROR


What operating system are you using? What browser?
Tried on both Win and Linux.


Please provide any additional information below.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2062 in reviewboard: Clicking on links changes to edit mode instead of opening the link in the browser

2011-04-06 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2062 by the...@gmail.com: Clicking on links changes to edit mode  
instead of opening the link in the browser

http://code.google.com/p/reviewboard/issues/detail?id=2062

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.5.4

What's the URL of the page containing the problem?
rb/r/X

What steps will reproduce the problem?
Putting a url, etc in the summary creates a link.  If you're looking at a  
review that you have permission to edit (either because you're an admin or  
because you created the review), clicking on the link switches the summary  
box to edit mode.


What is the expected output? What do you see instead?
Expect the browser to follow the link, instead of editing the summary.


What operating system are you using? What browser?
See this for both firefox  chromium on linux.  In chromium, middle click  
to open tab ALSO displays this behavior (doesn't open new tab, just moves  
into edit mode).  In both, right click on the link allows to open in new  
tab/window.


Please provide any additional information below.

seems related, but not quite the same as issue 1893

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 342 in reviewboard: Allow incremental expansion of collapsed code blocks

2011-04-06 Thread reviewboard


Comment #12 on issue 342 by trowb...@gmail.com: Allow incremental expansion  
of collapsed code blocks

http://code.google.com/p/reviewboard/issues/detail?id=342

Issue 2059 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1893 in reviewboard: Fields shouldn't become editable when selecting text or clicking hyperlinks

2011-04-06 Thread reviewboard


Comment #9 on issue 1893 by trowb...@gmail.com: Fields shouldn't become  
editable when selecting text or clicking hyperlinks

http://code.google.com/p/reviewboard/issues/detail?id=1893

Issue 2062 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2062 in reviewboard: Clicking on links changes to edit mode instead of opening the link in the browser

2011-04-06 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 1893

Comment #1 on issue 2062 by trowb...@gmail.com: Clicking on links changes  
to edit mode instead of opening the link in the browser

http://code.google.com/p/reviewboard/issues/detail?id=2062

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1893 in reviewboard: Fields shouldn't become editable when selecting text or clicking hyperlinks

2011-04-06 Thread reviewboard

Updates:
	Summary: Fields shouldn't become editable when selecting text or clicking  
hyperlinks


Comment #8 on issue 1893 by trowb...@gmail.com: Fields shouldn't become  
editable when selecting text or clicking hyperlinks

http://code.google.com/p/reviewboard/issues/detail?id=1893

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2061 in reviewboard: can not view diff and post-review

2011-04-06 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 2061 by trowb...@gmail.com: can not view diff and  
post-review

http://code.google.com/p/reviewboard/issues/detail?id=2061

How was this review request created? It sounds like a patch was updated  
that wasn't based off of the code in your github repository.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.