Re: Review Board 1.7 RC 1 is released!

2012-12-05 Thread Christian Hammond
Review Board 1.7 requires Python 2.5 or higher. You'll have to upgrade in order for it to work. What I'd recommend is a newer CentOS install, since some of our dependencies will also need to be updated, and you won't hit as many issues with the upgrade. Your best bet is to upgrade to something

Info per source file

2012-12-05 Thread Laimonas Mockus
Hi, Is it possible to get info (e.g. fetch from database) if a particular source file (or at least diffset) was reviewed? I can see filelists in the table diffviewer_filediff, but I'm unable to find the connection to the status or to the request id (e.g. table reviews_review). I use RB 1.7

Re: Info per source file

2012-12-05 Thread Christian Hammond
Hi, Are you looking to do this through the web API, or are you writing an extension or something? I'm gathering the latter. I'm not at the computer so I don't have the code in front of me, but you can do something like filediff.comments to get the Django relation to the diff comments for the

Issues publishing review with ReviewBoard

2012-12-05 Thread Brian Lewis
Hello All, I've been racking my brain on this for a couple of days and figured I'd post here before I refactor my entire setup. Basically what we are doing is, we have two servers - one is a standard apache web node that acts as a proxy server and terminates SSL, then we have reviewboard being

Re: Issues publishing review with ReviewBoard

2012-12-05 Thread Christian Hammond
Hi Brian, Something to try would be to add: os.environ['HTTPS'] = 'on' to htdocs/reviewboard.wsgi. See if that makes a difference. I noticed this at one point as well. We need to change things to generate this by default if using https, or find a beter way to turn it on by default.

Re: Issues publishing review with ReviewBoard

2012-12-05 Thread Brian Lewis
Hi Christian, Just tried that and there's no change. Additionally, I notice the response from the first request looks like this (notice the http URL's vs https.. almost like it sees the redirect but doesn't want to follow it!) {stat: ok, review_request: {status: pending, last_updated:

Re: Issues publishing review with ReviewBoard

2012-12-05 Thread Christian Hammond
Just to sanity check, did you reload Apache? We put in absolute URLs, and we tell Django to build those for us. Django will insert https if it sees the HTTPS environment variable set to on, and http otherwise. Provided the process is ending up with this environment variable set, and the server is

Re: Issues publishing review with ReviewBoard

2012-12-05 Thread Brian Lewis
Hi Christian, Yes - I just stopped apache and manually restarted it as well just to make sure. Here's a copy of the reviewboard.wsgi file :: import os import sys os.environ['DJANGO_SETTINGS_MODULE'] = reviewboard.settings os.environ['PYTHON_EGG_CACHE'] = /var/www/reviewboard/tmp/egg_cache

API question: list of files in requests, filtered by path and request date

2012-12-05 Thread dado
What would be the best way of getting a list of all reviewed files matching a determined perforce path? I also know I'm after the reviews created after 04/01/12. Should I simply get all the reviews after that date and do any additional filtering client-side? If so, what would be the best way to