Re: Review groups and private repositories
Ah, now it makes sense. Thanks! On Wednesday, 13 November 2013 22:36:21 UTC+2, Christian Hammond wrote: If a user is on group1 but not group2, and a change is posted to group2, then the user will not be allowed to see the change. The reason is that there may be discussions from members on group2 that the user is not privy to. This is an intended design. When dealing with private review requests (due to private repositories or invite-only groups), Review Board becomes very restrictive on who has access. The owner of the review request must be explicit in who they want to bring in for discussion. Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Wed, Nov 13, 2013 at 4:32 AM, SenjorGes gess...@gmail.comjavascript: wrote: Hey, both groups are invite-only groups and review board is on version 1.7.18 - Support ▾ https://sdreview.protacon.com/dashboard/# - [image: Mikko Pulkkinen] Mikko ▾https://sdreview.protacon.com/account/preferences/ On Monday, 11 November 2013 23:15:36 UTC+2, Christian Hammond wrote: Hi, Are either group1 or group2 invite-only groups? Also, what version of Review Board? Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Mon, Nov 11, 2013 at 5:26 AM, SenjorGes gess...@gmail.com wrote: Hey, I have noticed some problems with review groups and private repositories. It seems access control doesn't work properly or is it me? Scenario is this: - I have one SVN repository called repository1 and it's not publicly accessible - Review group named group1 has access to repository1 via admin panel (admin panel - repositories - repository1 - Review groups with access:) - Also group2 has same access to that repository as group1 - User1 belongs to group1 and User2 belongs to group2 So thats the setup, and the problem occuress when: - User1 creates a review request (repository1) and sets group1 as the group for the request - Now if User2 tries to read the review request he/she gets access denied So if you set repository to be private, only the selected group can view the review request, and not all the groups which have access to the repository via admin panel or am I missing something here? And if User2 is a superuser, then he/she can view the request. And this only works if group2 have access to the repository. If I remove group2 from the repository access list and user2 still have superuser rights, review request will not open (Access Denied). --Ges -- Get the Review Board Power Pack at http://www.reviewboard.org/ powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: A repository was not found at the specified path.
Christian, barry@R0150313:~/cvs/repo$ cvs -f -d :pserver:m022927@R0199562:/QREADS5_1_repo checkout -r HEAD -p CVSROOT/modules cvs server: User m022927 cannot read CVSROOT on tag/branch HEAD Looking forward to your comments... Thanks, Barry On Friday, November 8, 2013 11:23:48 AM UTC-6, Barry Novinger wrote: After exploring the existing topics and trying a number of things I decided to post for specific help. Just recently downloaded reviewboard 1.7.16 using mysql, apache mod_wsgi following the best instructions I can find. I can add a local CVS repository to reviewboard but not the teams remote CVSNT repository. I can also access the teams CVSNT repository from the ubuntu shell. using cvs -d :pserver:user@host:/repo login Let me know if you need anything for diagnostics or have anything you recommend me checking or trying Thanks, -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Ways to speed up 1.6.15 to 1.7.18 upgrade
Anyone have ideas on how to speed up the upgrade from 1.6.15 to 1.7.18 or more specifically the evolutions involved? When tested on a snapshot of Review Board database it appeared to take almost 4 hours to process the diffviewer_filediff table and around 90 minutes for the diffview_diffsethistory. Could there be some data in the database which is causing overly long migration times which if removed would improve the situation? We really one to keep the downtime to about an hour in total. Thanks, -amac -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: A repository was not found at the specified path.
In this case, your path isn't correct. It should be your CVSROOT path, which tends to end with :/cvsroot or similar. I don't know if that's it on yours or not, but you'll need to investigate it. What does it say in a local checkout when you cat CVS/Root? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Thu, Nov 14, 2013 at 9:22 AM, Barry Novinger ba...@novinger.net wrote: Christian, barry@R0150313:~/cvs/repo$ cvs -f -d :pserver:m022927@R0199562:/QREADS5_1_repo checkout -r HEAD -p CVSROOT/modules cvs server: User m022927 cannot read CVSROOT on tag/branch HEAD Looking forward to your comments... Thanks, Barry On Friday, November 8, 2013 11:23:48 AM UTC-6, Barry Novinger wrote: After exploring the existing topics and trying a number of things I decided to post for specific help. Just recently downloaded reviewboard 1.7.16 using mysql, apache mod_wsgi following the best instructions I can find. I can add a local CVS repository to reviewboard but not the teams remote CVSNT repository. I can also access the teams CVSNT repository from the ubuntu shell. using cvs -d :pserver:user@host:/repo login Let me know if you need anything for diagnostics or have anything you recommend me checking or trying Thanks, -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: A repository was not found at the specified path.
barry@R0150313:~/cvs/repo/QReadsApp$ cvs -d :pserver:m022927@R0199562:/QREADS5_1_repo checkout QReadsApp cvs server: Updating QReadsApp U QReadsApp/.classpath U QReadsApp/.cvsignore U QReadsApp/.project U QReadsApp/.runtime U QReadsApp/ORBackup.properties . . . U QReadsApp/edu/mayo/qreads/device/WriteToDisk.java cvs server: Updating QReadsApp/eehTmp cvs server: Updating QReadsApp/icons cvs server: Updating QReadsApp/images U QReadsApp/images/wmp.bmp cvs server: Updating QReadsApp/routeLists barry@R0150313:~/cvs/repo/QReadsApp$ ls QReadsApp barry@R0150313:~/cvs/repo/QReadsApp$ cd QReadsApp barry@R0150313:~/cvs/repo/QReadsApp/QReadsApp$ ls build.xml log4j.dtdpicn6220.dll CVSlog4j.xmlpicn6320.dll edumcaRouteList.config picn6520.dll eehTmp mcfRouteList.config qreadsBuild.xml icons mcrRouteList.config QReadsJniKit.dll images META-INF routeLists jmh263enc.dll ORBackup.properties SingleInstanceLaunch.properties jmjpeg.dll PegJniKit.dll jmutil.dll picn20.dll barry@R0150313:~/cvs/repo/QReadsApp/QReadsApp$ cat CVS/Root :pserver:m022927@R0199562:/QREADS5_1_repo On Friday, November 8, 2013 11:23:48 AM UTC-6, Barry Novinger wrote: After exploring the existing topics and trying a number of things I decided to post for specific help. Just recently downloaded reviewboard 1.7.16 using mysql, apache mod_wsgi following the best instructions I can find. I can add a local CVS repository to reviewboard but not the teams remote CVSNT repository. I can also access the teams CVSNT repository from the ubuntu shell. using cvs -d :pserver:user@host:/repo login Let me know if you need anything for diagnostics or have anything you recommend me checking or trying Thanks, -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Change in LDAP authentication behavior in 1.7.14 breaks environments that don't allow anonymous searches
David, Sorry for the massive delay! I've finally posted it at https://reviews.reviewboard.org/r/4953/. On Friday, October 18, 2013 1:51:59 AM UTC-7, David Trowbridge wrote: Daniel, I'd suggest making a quick clone of the reviewboard repository, making your change, and then posting your diff against the reviewboard repository by either creating a diff manually (git diff --full-index) or using rbt post. -David On Tue, Oct 15, 2013 at 4:57 PM, Daniel Kan danie...@gmail.comjavascript: wrote: David, Sure, although I'm not sure how to post a bare diff there without specifying a repository. Is that possible? Thanks! On Thursday, September 26, 2013 2:43:43 PM UTC-7, David Trowbridge wrote: Would you mind submitting your change to http://reviews.reviewboard.org/? Thanks! -David On Tue, Sep 24, 2013 at 7:32 PM, Daniel Kan danie...@gmail.com wrote: I am using RB 1.7.x with an LDAP authentication backend and it's been working fine up through 1.7.13. With 1.7.14, the authentication mechanism no longer works in my environment. After some digging, it appears that there was a change in reviewboard/accounts/backends.py to search anonymously for the user before attempting to bind. The LDAP server in my environment is set up to not return any results to anonymous queries and so the authentication attempt fails. Is there a reason this was changed? Thanks!!! In an attempt to preserve the existing behavior of doing an anonymous search but then attempting a bind as a specific user if the anonymous search returns nothing, I made the following change which works for me: --- reviewboard/accounts/backends.py.orig 2013-09-24 16:18:47.0 -0700 +++ reviewboard/accounts/backends.py2013-09-24 16:20:01.0 -0700 @@ -210,7 +210,10 @@ search = ldapo.search_s(settings.LDAP_BASE_DN, ldap.SCOPE_SUBTREE, uid) -userbinding = search[0][0] + if (len(search) 0): + userbinding = search[0][0] + else: + userbinding=','.join([uid, settings.LDAP_BASE_DN]) ldapo.bind_s(userbinding, password) return self.get_or_create_user(username, None, ldapo) -- Get the Review Board Power Pack at http://www.reviewboard.org/ powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3138 in reviewboard: Implied reviewers don't get review notification email when it is created initially
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3138 by eyuw...@gmail.com: Implied reviewers don't get review notification email when it is created initially http://code.google.com/p/reviewboard/issues/detail?id=3138 What version are you running? 1.7.6 What's the URL of the page containing the problem? No specific URL. See steps for reproduce the problem What steps will reproduce the problem? 1. user A creates a review, put group group_a in the group list 2. user B who subscribes to group_a will not get notification when new review is created 3. user B will receive notification when updates posted to that same review What is the expected output? What do you see instead? User B should receive notification for new review request posted as long as he is member of the group. What operating system are you using? What browser? Centos 6.4. All modern browsers -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3138 in reviewboard: Implied reviewers don't get review notification email when it is created initially
Updates: Status: NeedInfo Comment #1 on issue 3138 by chip...@gmail.com: Implied reviewers don't get review notification email when it is created initially http://code.google.com/p/reviewboard/issues/detail?id=3138 This is strange. Unless there's a bug in 1.7.6 (which I don't recall), this should work. I don't recall any point in time when review request e-mails weren't sent out. Long shot, but is there any custom code in your install that may listen to any signals? Is every user seeing this with every review request? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
